[valgrind] [Bug 359503] Add missing syscalls for aarch64 (arm64)

[Mark Wielaard via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=359503

Mark Wielaard  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|UNCONFIRMED |RESOLVED

--- Comment #12 from Mark Wielaard  ---
Added adjtimex for arm64 and fixed a bug in the syscall wrapper.
valgrind svn r15953.

Please open a new bug for missing syscalls next time instead of reusing this
one.

-- 
You are receiving this mail because:
You are watching all bug changes.

[valgrind] [Bug 359503] Add missing syscalls for aarch64 (arm64)

[Marcin Juszkiewicz via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=359503

Marcin Juszkiewicz  changed:

   What|Removed |Added

 Status|RESOLVED|UNCONFIRMED
 Resolution|FIXED   |---

--- Comment #11 from Marcin Juszkiewicz  ---
tag=adjtimex01_valgrind_memory_leak_check stime=1473840632
cmdline=" valgrind -q --leak-check=full --trace-children=yes adjtimex01"
contacts=""
analysis=exit
<<>>
--7168-- WARNING: unhandled arm64-linux syscall: 171
--7168-- You may be able to write your own handler.
--7168-- Read the file README_MISSING_SYSCALL_OR_IOCTL.
--7168-- Nevertheless we consider this a bug.  Please report
--7168-- it at http://valgrind.org/support/bug_reports.html.
adjtimex011  TBROK  :  adjtimex01.c:107: failed to save current parameters:
errno=ENOSYS(38): Function not implemented
adjtimex012  TBROK  :  adjtimex01.c:107: Remaining cases broken

-- 
You are receiving this mail because:
You are watching all bug changes.

[valgrind] [Bug 359503] Add missing syscalls for aarch64 (arm64)

[Mark Wielaard via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=359503

Mark Wielaard  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |FIXED

--- Comment #10 from Mark Wielaard  ---
valgrind svn r15824 r15825 r15826

This adds most of the syscalls from the original patch. But only those that I
could (very quickly) test. There are still some missing.

It would be nice (not just for arm64) to run something like the LTP Linux Test
Project http://linux-test-project.github.io/ under valgrind. That should be
able to catch most things still missing (and maybe even bad corner cases in the
valgrind syswrappers.

https://archive.fosdem.org/2015/schedule/event/valgrind_easy_hack/attachments/slides/731/export/events/attachments/valgrind_easy_hack/slides/731/valgrind_easy_hacks.html#slide25

-- 
You are receiving this mail because:
You are watching all bug changes.

[valgrind] [Bug 359503] Add missing syscalls for aarch64 (arm64)

[Mark Wielaard via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=359503

--- Comment #9 from Mark Wielaard  ---
Created attachment 97794
  --> https://bugs.kde.org/attachment.cgi?id=97794=edit
Add more missing syscalls

This adds most of the missing syscalls from the original patch for which I
could do a quick test on an arm64 machine. ioprio_set, ioprio_get, preadv,
pwritev, vmsplice, splice, tee, waitid, clock_nanosleep and perf_event_open.

-- 
You are receiving this mail because:
You are watching all bug changes.

[valgrind] [Bug 359503] Add missing syscalls for aarch64 (arm64)

[Mark Wielaard via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=359503

--- Comment #8 from Mark Wielaard  ---
Created attachment 97787
  --> https://bugs.kde.org/attachment.cgi?id=97787=edit
Add arm64 scalar test. Enable tested syscalls.

This adds a new memcheck/tests/arm64-linux/scalar test which is based on the
memcheck/tests/x86-linux/scalar test and contains all syscalls that are also
available on arm64. To make comparison of exp results easier the order of the
tested syscalls is the same as on x86. This enables a couple extra arm64
syscalls.

-- 
You are receiving this mail because:
You are watching all bug changes.

[valgrind] [Bug 359503] Add missing syscalls for aarch64 (arm64)

[Mark Wielaard via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=359503

Mark Wielaard  changed:

   What|Removed |Added

  Attachment #97762|0   |1
is obsolete||

--- Comment #7 from Mark Wielaard  ---
Created attachment 97763
  --> https://bugs.kde.org/attachment.cgi?id=97763=edit
Use correct syscall numbers on arm64 (fix rename, dup2, getpgrp and fork)

Same as the previous patch, but also fixed getpgrp, which doesn't exist on
arm64 and is just getpgid(0).

-- 
You are receiving this mail because:
You are watching all bug changes.

[valgrind] [Bug 359503] Add missing syscalls for aarch64 (arm64)

[Mark Wielaard via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=359503

Mark Wielaard  changed:

   What|Removed |Added

 CC||m...@redhat.com

--- Comment #6 from Mark Wielaard  ---
Created attachment 97762
  --> https://bugs.kde.org/attachment.cgi?id=97762=edit
Use correct syscall numbers on arm64

While testing some of these newly hooked system calls I noticed that valgrind
uses some wrong system call numbers on arm64. This also affects our own dup2
and rename implementations (arm64 only has dup3 and renameat). Which causes
callgrind to sometimes be unable to rename dump files on arm64.

Fixed the syscall numbers using the overview given by Marcin:
https://marcin.juszkiewicz.com.pl/2016/03/05/from-a-diary-of-aarch64-porter-system-calls/

-- 
You are receiving this mail because:
You are watching all bug changes.

[valgrind] [Bug 359503] Add missing syscalls for aarch64 (arm64)

[Marcin Juszkiewicz via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=359503

Marcin Juszkiewicz  changed:

   What|Removed |Added

  Attachment #97263|0   |1
is obsolete||

--- Comment #5 from Marcin Juszkiewicz  ---
Created attachment 97685
  --> https://bugs.kde.org/attachment.cgi?id=97685=edit
add all missing syscalls for aarch64 - rebased to svn HEAD, fixed, build tested

Mark Wielaard pointed that previous patch does not build. Checked, fixed few
syscall names, disabled few.

-- 
You are receiving this mail because:
You are watching all bug changes.

[valgrind] [Bug 359503] Add missing syscalls for aarch64 (arm64)

[Tom Hughes via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=359503

Tom Hughes  changed:

   What|Removed |Added

 CC||t...@compton.nu

--- Comment #3 from Tom Hughes  ---
How many of these have you actually tested though?

The point of leaving them commented out rather than just enabling them all is
to wait until people find something that is actually using them so that we can
get some sort of view of whether they work when we enable them.

-- 
You are receiving this mail because:
You are watching all bug changes.

[valgrind] [Bug 359503] Add missing syscalls for aarch64 (arm64)

[Marcin Juszkiewicz via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=359503

Marcin Juszkiewicz  changed:

   What|Removed |Added

  Attachment #97262|0   |1
is obsolete||

--- Comment #2 from Marcin Juszkiewicz  ---
Created attachment 97263
  --> https://bugs.kde.org/attachment.cgi?id=97263=edit
add all missing syscalls for aarch64 - rebased to svn HEAD

Ops, previous version was done against older valgrind tree...

-- 
You are receiving this mail because:
You are watching all bug changes.

[valgrind] [Bug 359503] Add missing syscalls for aarch64 (arm64)

[Marcin Juszkiewicz via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=359503

--- Comment #1 from Marcin Juszkiewicz  ---
Created attachment 97262
  --> https://bugs.kde.org/attachment.cgi?id=97262=edit
Add all aarch64 syscalls

This patch adds all syscalls. LINX_/LINXY etc was based on commented versions
and on amd64-linux ones.

Not built yet with this code.

-- 
You are receiving this mail because:
You are watching all bug changes.