[valgrind] [Bug 360574] Wrong parameter type for an ashmem ioctl() call on Android and ARM64

[Julian Seward via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=360574

Julian Seward  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|UNCONFIRMED |RESOLVED

-- 
You are receiving this mail because:
You are watching all bug changes.

[valgrind] [Bug 360574] Wrong parameter type for an ashmem ioctl() call on Android and ARM64

[Julian Seward via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=360574

--- Comment #5 from Julian Seward  ---
Fixed, valgrind r15923.  Thanks for the test.

-- 
You are receiving this mail because:
You are watching all bug changes.

[valgrind] [Bug 360574] Wrong parameter type for an ashmem ioctl() call on Android and ARM64

[Anton Kirilov via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=360574

--- Comment #4 from Anton Kirilov  ---
I have tested the patch, and it makes the error message disappear.

-- 
You are receiving this mail because:
You are watching all bug changes.

[valgrind] [Bug 360574] Wrong parameter type for an ashmem ioctl() call on Android and ARM64

[Julian Seward via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=360574

--- Comment #3 from Julian Seward  ---
The problem is that the wrappers for android-specific ioctls on 64-bit ARM
are not enabled, so it handles them using the generic ioctl logic, which
in this case isn't appropriate.  Can you try this patch?


Index: coregrind/m_syswrap/syswrap-linux.c
===
--- coregrind/m_syswrap/syswrap-linux.c(revision 15922)
+++ coregrind/m_syswrap/syswrap-linux.c(working copy)
@@ -7082,7 +7082,8 @@
   break;

 #  if defined(VGPV_arm_linux_android) || defined(VGPV_x86_linux_android) \
-  || defined(VGPV_mips32_linux_android)
+  || defined(VGPV_mips32_linux_android) \
+  || defined(VGPV_arm64_linux_android)
/* ashmem */
case VKI_ASHMEM_GET_SIZE:
case VKI_ASHMEM_SET_SIZE:
@@ -9574,7 +9575,8 @@
   break;

 #  if defined(VGPV_arm_linux_android) || defined(VGPV_x86_linux_android) \
-  || defined(VGPV_mips32_linux_android)
+  || defined(VGPV_mips32_linux_android) \
+  || defined(VGPV_arm64_linux_android)
/* ashmem */
case VKI_ASHMEM_GET_SIZE:
case VKI_ASHMEM_SET_SIZE:
Index: include/vki/vki-linux.h
===
--- include/vki/vki-linux.h(revision 15922)
+++ include/vki/vki-linux.h(working copy)
@@ -3009,7 +3009,8 @@
 //--

 #if defined(VGPV_arm_linux_android) || defined(VGPV_x86_linux_android) \
-|| defined(VGPV_mips32_linux_android)
+|| defined(VGPV_mips32_linux_android) \
+|| defined(VGPV_arm64_linux_android)

 #define VKI_ASHMEM_NAME_LEN 256

-- 
You are receiving this mail because:
You are watching all bug changes.

[valgrind] [Bug 360574] Wrong parameter type for an ashmem ioctl() call on Android and ARM64

[Anton Kirilov via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=360574

--- Comment #2 from Anton Kirilov  ---
Yes, I can.

-- 
You are receiving this mail because:
You are watching all bug changes.

[valgrind] [Bug 360574] Wrong parameter type for an ashmem ioctl() call on Android and ARM64

[Julian Seward via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=360574

--- Comment #1 from Julian Seward  ---
Anton: I don't have an easily available arm64-android device to test on.  But I 
think this is an easy fix.  If I get you a patch, can you test it for me?

-- 
You are receiving this mail because:
You are watching all bug changes.

[valgrind] [Bug 360574] Wrong parameter type for an ashmem ioctl() call on Android and ARM64

[Anton Kirilov via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=360574

Anton Kirilov  changed:

   What|Removed |Added

 CC||jacob.bramley+...@arm.com

-- 
You are receiving this mail because:
You are watching all bug changes.