[valgrind] [Bug 380200] xtree generated callgrind files refer to files without directory name

2017-06-02 Thread Philippe Waroquiers
https://bugs.kde.org/show_bug.cgi?id=380200

--- Comment #5 from Philippe Waroquiers  ---
code change Committed revision 16435.

-- 
You are receiving this mail because:
You are watching all bug changes.

[valgrind] [Bug 380200] xtree generated callgrind files refer to files without directory name

2017-06-02 Thread Philippe Waroquiers
https://bugs.kde.org/show_bug.cgi?id=380200

Philippe Waroquiers  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |FIXED

--- Comment #4 from Philippe Waroquiers  ---
Thanks for the bug report and the patch.
I have applied the (code) patch slightly modified (there was a problem
for the unknown file case).

I have not (yet) added the regtest, no time yet to look at the details, but
I already mark this bug as fixed, as the functionality is now committed.

-- 
You are receiving this mail because:
You are watching all bug changes.

[valgrind] [Bug 380200] xtree generated callgrind files refer to files without directory name

2017-06-02 Thread Matthias Schwarzott
https://bugs.kde.org/show_bug.cgi?id=380200

--- Comment #3 from Matthias Schwarzott  ---
(In reply to Philippe Waroquiers from comment #2)
> (In reply to Matthias Schwarzott from comment #1)
> > Created attachment 105714 [details]
> > valgrind-xtree-add-regtests.patch
> > 
> > This attachment adds two experimental tests for xtree-leak and xtree-memory.
> > xtree-leak uses callgrind_annotate to show the cost values per function and
> > sorts the output afterwards to make it stable.
> Why is the sort needed ? Do you see variations between runs ?
> Or variations between different systems/platforms ?
> 
I run it under amd64. There are variations between runs.
The order of functions differs.
I have not yet checked if the xtree files are stable or not.

-- 
You are receiving this mail because:
You are watching all bug changes.

[valgrind] [Bug 380200] xtree generated callgrind files refer to files without directory name

2017-06-01 Thread Philippe Waroquiers
https://bugs.kde.org/show_bug.cgi?id=380200

Philippe Waroquiers  changed:

   What|Removed |Added

 CC||philippe.waroquiers@skynet.
   ||be

--- Comment #2 from Philippe Waroquiers  ---
(In reply to Matthias Schwarzott from comment #1)
> Created attachment 105714 [details]
> valgrind-xtree-add-regtests.patch
> 
> This attachment adds two experimental tests for xtree-leak and xtree-memory.
> xtree-leak uses callgrind_annotate to show the cost values per function and
> sorts the output afterwards to make it stable.
Why is the sort needed ? Do you see variations between runs ?
Or variations between different systems/platforms ?

> 
> The other for xtree-memory only checks the generated file. I wonder if this
> one is stable enough.

-- 
You are receiving this mail because:
You are watching all bug changes.

[valgrind] [Bug 380200] xtree generated callgrind files refer to files without directory name

2017-05-25 Thread Matthias Schwarzott
https://bugs.kde.org/show_bug.cgi?id=380200

--- Comment #1 from Matthias Schwarzott  ---
Created attachment 105714
  --> https://bugs.kde.org/attachment.cgi?id=105714=edit
valgrind-xtree-add-regtests.patch

This attachment adds two experimental tests for xtree-leak and xtree-memory.
xtree-leak uses callgrind_annotate to show the cost values per function and
sorts the output afterwards to make it stable.

The other for xtree-memory only checks the generated file. I wonder if this one
is stable enough.

-- 
You are receiving this mail because:
You are watching all bug changes.