[valgrind] [Bug 382034] Testcases build fixes for musl

[Paul Floyd]

https://bugs.kde.org/show_bug.cgi?id=382034

Paul Floyd  changed:

   What|Removed |Added

 Status|REOPENED|RESOLVED
 Resolution|--- |FIXED

--- Comment #23 from Paul Floyd  ---
Should build now.

Still around 100 regtest failures.

-- 
You are receiving this mail because:
You are watching all bug changes.

[valgrind] [Bug 382034] Testcases build fixes for musl

[Paul Floyd]

https://bugs.kde.org/show_bug.cgi?id=382034

Paul Floyd  changed:

   What|Removed |Added

 Attachment #158982|Some moe changes for musl   |Some more changes for musl
description|x86 |x86

-- 
You are receiving this mail because:
You are watching all bug changes.

[valgrind] [Bug 382034] Testcases build fixes for musl

[Paul Floyd]

https://bugs.kde.org/show_bug.cgi?id=382034

--- Comment #22 from Paul Floyd  ---
Created attachment 158982
  --> https://bugs.kde.org/attachment.cgi?id=158982=edit
Some moe changes for musl x86

make check succeeds with this patch.

Need to check that there is no impact on other platforms.

-- 
You are receiving this mail because:
You are watching all bug changes.

[valgrind] [Bug 382034] Testcases build fixes for musl

[Sam James]

https://bugs.kde.org/show_bug.cgi?id=382034

Sam James  changed:

   What|Removed |Added

 CC||s...@gentoo.org

-- 
You are receiving this mail because:
You are watching all bug changes.

[valgrind] [Bug 382034] Testcases build fixes for musl

[Paul Floyd]

https://bugs.kde.org/show_bug.cgi?id=382034

--- Comment #21 from Paul Floyd  ---
(In reply to Alexander Kanavin from comment #20)

> I build valgrind using yocto set to use musl and 32bit x86. If you want to
> try that, do it on the most powerful (cpu cores wise) computer you have.

That would be my macbook ;-)

I'll try installing Alpine x86 in VirtualBox.

-- 
You are receiving this mail because:
You are watching all bug changes.

[valgrind] [Bug 382034] Testcases build fixes for musl

[Alexander Kanavin]

https://bugs.kde.org/show_bug.cgi?id=382034

--- Comment #20 from Alexander Kanavin  ---
(In reply to Paul Floyd from comment #19)
> > I'll try to do some musl testing before closing this.
> 
> Did you use an x86 install of Alpine?
> 
> Or is there way to add an x86 subsystem to amd64?

I build valgrind using yocto set to use musl and 32bit x86. If you want to try
that, do it on the most powerful (cpu cores wise) computer you have.

-- 
You are receiving this mail because:
You are watching all bug changes.

[valgrind] [Bug 382034] Testcases build fixes for musl

[Paul Floyd]

https://bugs.kde.org/show_bug.cgi?id=382034

--- Comment #19 from Paul Floyd  ---
> I'll try to do some musl testing before closing this.

Did you use an x86 install of Alpine?

Or is there way to add an x86 subsystem to amd64?

-- 
You are receiving this mail because:
You are watching all bug changes.

[valgrind] [Bug 382034] Testcases build fixes for musl

[Paul Floyd]

https://bugs.kde.org/show_bug.cgi?id=382034

--- Comment #18 from Paul Floyd  ---
commit 306232d40e037274160de417f21fdb957e30fc73 (HEAD -> master, origin/master,
origin/HEAD)
Author: Paul Floyd 
Date:   Tue May 9 22:13:28 2023 +0200

musl: another fix for building testcases

I'll try to do some musl testing before closing this.

-- 
You are receiving this mail because:
You are watching all bug changes.

[valgrind] [Bug 382034] Testcases build fixes for musl

[Alexander Kanavin]

https://bugs.kde.org/show_bug.cgi?id=382034

Alexander Kanavin  changed:

   What|Removed |Added

 Resolution|FIXED   |---
 Status|RESOLVED|REOPENED
 Ever confirmed|0   |1

--- Comment #17 from Alexander Kanavin  ---
There's one more fix needed (add needed includes on musl), I've attached the
patch for it. Hope you don't mind reusing this ticket, which I'll reopen.

-- 
You are receiving this mail because:
You are watching all bug changes.

[valgrind] [Bug 382034] Testcases build fixes for musl

[Alexander Kanavin]

https://bugs.kde.org/show_bug.cgi?id=382034

Alexander Kanavin  changed:

   What|Removed |Added

 CC||alex.kana...@gmail.com

--- Comment #16 from Alexander Kanavin  ---
Created attachment 158792
  --> https://bugs.kde.org/attachment.cgi?id=158792=edit
Add missing includes to avoid 'SYS_modify_ldt is undefined' errors

-- 
You are receiving this mail because:
You are watching all bug changes.

[valgrind] [Bug 382034] Testcases build fixes for musl

[Paul Floyd]

https://bugs.kde.org/show_bug.cgi?id=382034

Paul Floyd  changed:

   What|Removed |Added

 Resolution|WORKSFORME  |FIXED

--- Comment #15 from Paul Floyd  ---
Memory like a sieve. I did apply the __THROW patches and changed the
__modify_ldt patch so that it doesn't affect glibc in any way.

commit f7e4bb4af294575432b629de4869812fdfee6feb
Author: Paul Floyd 
Date:   Fri Jan 27 08:42:06 2023 +0100

Bug 382034 - Testcases build fixes for musl

-- 
You are receiving this mail because:
You are watching all bug changes.

[valgrind] [Bug 382034] Testcases build fixes for musl

[Bug Janitor Service]

https://bugs.kde.org/show_bug.cgi?id=382034

Bug Janitor Service  changed:

   What|Removed |Added

 Resolution|WAITINGFORINFO  |WORKSFORME
 Status|NEEDSINFO   |RESOLVED

--- Comment #14 from Bug Janitor Service  ---
This bug has been in NEEDSINFO status with no change for at least
30 days. The bug is now closed as RESOLVED > WORKSFORME
due to lack of needed information.

For more information about our bug triaging procedures please read the
wiki located here:
https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging

Thank you for helping us make KDE software even better for everyone!

-- 
You are receiving this mail because:
You are watching all bug changes.

[valgrind] [Bug 382034] Testcases build fixes for musl

[Bug Janitor Service]

https://bugs.kde.org/show_bug.cgi?id=382034

--- Comment #13 from Bug Janitor Service  ---
Dear Bug Submitter,

This bug has been in NEEDSINFO status with no change for at least
15 days. Please provide the requested information as soon as
possible and set the bug status as REPORTED. Due to regular bug
tracker maintenance, if the bug is still in NEEDSINFO status with
no change in 30 days the bug will be closed as RESOLVED > WORKSFORME
due to lack of needed information.

For more information about our bug triaging procedures please read the
wiki located here:
https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging

If you have already provided the requested information, please
mark the bug as REPORTED so that the KDE team knows that the bug is
ready to be confirmed.

Thank you for helping us make KDE software even better for everyone!

-- 
You are receiving this mail because:
You are watching all bug changes.

[valgrind] [Bug 382034] Testcases build fixes for musl

[Khem Raj]

https://bugs.kde.org/show_bug.cgi?id=382034

--- Comment #12 from Khem Raj  ---
(In reply to Paul Floyd from comment #11)
> If you don't beat me to it I'll probably go ahead and try this tonight.

OK. I wont get to this till weekend.

-- 
You are receiving this mail because:
You are watching all bug changes.

[valgrind] [Bug 382034] Testcases build fixes for musl

[Paul Floyd]

https://bugs.kde.org/show_bug.cgi?id=382034

--- Comment #11 from Paul Floyd  ---
If you don't beat me to it I'll probably go ahead and try this tonight.

-- 
You are receiving this mail because:
You are watching all bug changes.

[valgrind] [Bug 382034] Testcases build fixes for musl

[Paul Floyd]

https://bugs.kde.org/show_bug.cgi?id=382034

--- Comment #10 from Paul Floyd  ---
In order for there to be no breakage you need all of the following to add no
new problems:
make [builds Valgrind]
make check [builds the testcases]
make regtest [runs the regtest]

regtest uses one ore more expected like [testcase].stderr.exp to capture and
compare the Valgrind output.

Looking again at the diffs I don't think that the expected need updating. I'd
still rather not see any change for glibc in the syscall patch.

Could you update that patch to do something like this

#include "./../../config..h"

#if defined(MUSL_LIBC)
#define MODIFY_LDT(func, ptr, bytecount) syscall(SYS_modify_ldt, (func), (ptr),
(bytecount) );
#else
#define MODIFY_LDT(func, ptr, bytecount) __modify_ldt((func), (ptr),
(bytecount) );
#endif

-- 
You are receiving this mail because:
You are watching all bug changes.

[valgrind] [Bug 382034] Testcases build fixes for musl

[Paul Floyd]

https://bugs.kde.org/show_bug.cgi?id=382034

Paul Floyd  changed:

   What|Removed |Added

 CC||ivan.nikolae...@unikie.com

--- Comment #9 from Paul Floyd  ---
*** Bug 453929 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[valgrind] [Bug 382034] Testcases build fixes for musl

[Khem Raj]

https://bugs.kde.org/show_bug.cgi?id=382034

--- Comment #8 from Khem Raj  ---
(In reply to Paul Floyd from comment #6)
> Could you update the patches with expecteds that won't break glibc Linux?

Paul, I do not understand what 'expecteds' you are refrerring to here. If I
understand it better, I will be able to make the needed change

-- 
You are receiving this mail because:
You are watching all bug changes.

[valgrind] [Bug 382034] Testcases build fixes for musl

[Bug Janitor Service]

https://bugs.kde.org/show_bug.cgi?id=382034

--- Comment #7 from Bug Janitor Service  ---
Dear Bug Submitter,

This bug has been in NEEDSINFO status with no change for at least
15 days. Please provide the requested information as soon as
possible and set the bug status as REPORTED. Due to regular bug
tracker maintenance, if the bug is still in NEEDSINFO status with
no change in 30 days the bug will be closed as RESOLVED > WORKSFORME
due to lack of needed information.

For more information about our bug triaging procedures please read the
wiki located here:
https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging

If you have already provided the requested information, please
mark the bug as REPORTED so that the KDE team knows that the bug is
ready to be confirmed.

Thank you for helping us make KDE software even better for everyone!

-- 
You are receiving this mail because:
You are watching all bug changes.

[valgrind] [Bug 382034] Testcases build fixes for musl

[Paul Floyd]

https://bugs.kde.org/show_bug.cgi?id=382034

Paul Floyd  changed:

   What|Removed |Added

 Status|REPORTED|NEEDSINFO
 Resolution|--- |WAITINGFORINFO

--- Comment #6 from Paul Floyd  ---
Could you update the patches with expecteds that won't break glibc Linux?

-- 
You are receiving this mail because:
You are watching all bug changes.

[valgrind] [Bug 382034] Testcases build fixes for musl

[Paul Floyd]

https://bugs.kde.org/show_bug.cgi?id=382034

--- Comment #5 from Paul Floyd  ---
These might fix building but they will also break the tests themselves. For
instance there is no update to the scalar expected even though the line numbers
will have changed.

-- 
You are receiving this mail because:
You are watching all bug changes.

[valgrind] [Bug 382034] Testcases build fixes for musl

[Paul Floyd]

https://bugs.kde.org/show_bug.cgi?id=382034

Paul Floyd  changed:

   What|Removed |Added

 CC||pjfl...@wanadoo.fr

-- 
You are receiving this mail because:
You are watching all bug changes.

[valgrind] [Bug 382034] Testcases build fixes for musl

[Khem Raj]

https://bugs.kde.org/show_bug.cgi?id=382034

--- Comment #4 from Khem Raj  ---
musl is an alternative system C library implementation for linux, like glibc or
uclibc and others.

see https://www.musl-libc.org/

-- 
You are receiving this mail because:
You are watching all bug changes.

[valgrind] [Bug 382034] Testcases build fixes for musl

[Julian Seward]

https://bugs.kde.org/show_bug.cgi?id=382034

--- Comment #3 from Julian Seward  ---
What is MUSL?

-- 
You are receiving this mail because:
You are watching all bug changes.

[valgrind] [Bug 382034] Testcases build fixes for musl

[Khem Raj]

https://bugs.kde.org/show_bug.cgi?id=382034

Khem Raj  changed:

   What|Removed |Added

 Attachment #106454|application/mbox|text/plain
  mime type||
 Attachment #106454|0   |1
   is patch||

-- 
You are receiving this mail because:
You are watching all bug changes.

[valgrind] [Bug 382034] Testcases build fixes for musl

[Khem Raj]

https://bugs.kde.org/show_bug.cgi?id=382034

--- Comment #2 from Khem Raj  ---
Created attachment 106456
  --> https://bugs.kde.org/attachment.cgi?id=106456=edit
syscall fix

-- 
You are receiving this mail because:
You are watching all bug changes.

[valgrind] [Bug 382034] Testcases build fixes for musl

[Khem Raj]

https://bugs.kde.org/show_bug.cgi?id=382034

--- Comment #1 from Khem Raj  ---
Created attachment 106455
  --> https://bugs.kde.org/attachment.cgi?id=106455=edit
x86 fix

-- 
You are receiving this mail because:
You are watching all bug changes.