https://bugs.kde.org/show_bug.cgi?id=405205
Bug ID: 405205
Summary: tests/filter_libc: remove the line holding the futex
syscall error entirely
Product: valgrind
Version: 3.15 SVN
Platform: Other
OS: Linux
Status: REPORTED
Severity: normal
Priority: NOR
Component: general
Assignee: jsew...@acm.org
Reporter: stefan.maksimo...@rt-rk.com
CC: mips3...@gmail.com
Target Milestone: ---
Created attachment 118641
--> https://bugs.kde.org/attachment.cgi?id=118641&action=edit
Proposed solution
SUMMARY
At the moment the message reported by glibc is removed by the perl substitute
command, leaving an empty line it its place.
This change alters tests/filter_libc so as to remove the line containing the
futex error message completely; effectively we skip printing the line
altogether.
Need for this arose when observing a build process initiated by a buildbot, in
which case the 'make regtest' command was invoked via ssh.
In that case a terminal isn't spawned so the abovementioned message is printed
to stderr which gets filtered by tests/filter_libc (cf. building valgrind
regularly; the message is printed directly to the terminal, not stderr, hence
does not get filtered).
After this change no empty line is printed instead of the message, so there are
no conflicts with the existing stderr.exp files for the
helgrind/tests/{tc18_semabuse,tc20_verifywrap}.
These two tests were the ones where the stderr failure was observed.
I did not observe any regressions for mips32, mips64 or x86 after this change.
STEPS TO REPRODUCE
1. Run either a single test or 'make regtest' via ssh remotely
2. Run the same command locally
3. Observe the difference in the futex syscall error message being printed to
stderr in the first case, whereas it is printed directly to the terminal in the
second case for the two tests mentioned
OBSERVED RESULT
An additional newline appears in the tc18_semabuse and tc20_verifywrap
stderr.out files
EXPECTED RESULT
No empty line generated
--
You are receiving this mail because:
You are watching all bug changes.
