[valgrind] [Bug 429375] PPC ISA 3.1 support is missing, part 9
https://bugs.kde.org/show_bug.cgi?id=429375 Carl Love changed: What|Removed |Added Status|RESOLVED|CLOSED -- You are receiving this mail because: You are watching all bug changes.
[valgrind] [Bug 429375] PPC ISA 3.1 support is missing, part 9
https://bugs.kde.org/show_bug.cgi?id=429375 Carl Love changed: What|Removed |Added Resolution|--- |FIXED Status|REPORTED|RESOLVED --- Comment #6 from Carl Love --- Patches committed 3/30/2021 commit f69bcfc64233a84be4378fed9ec2ddf1d1ec4bcc Author: Carl Love Date: Mon Nov 16 19:09:47 2020 -0600 VSX Permute Control Vector Generate Operation tests. commit 3cc0232c46a5905b4a6c2fbd302b58bf5f90b3d5 Author: Carl Love Date: Mon Jan 11 16:00:57 2021 -0600 PPC64: ISA 3.1 VSX PCV Generate Operations xgenpcvbm VSX Vector Generate PCV from Byte Mask xxgenpcvdmVSX Vector Generate PCV from Doubleword Mask xxgenpcvhmVSX Vector Generate PCV from Halfword Mask xxgenpcvwmVSX Vector Generate PCV from Word Mask Closing bugzilla -- You are receiving this mail because: You are watching all bug changes.
[valgrind] [Bug 429375] PPC ISA 3.1 support is missing, part 9
https://bugs.kde.org/show_bug.cgi?id=429375 --- Comment #5 from Julian Seward --- Looks OK to land now. -- You are receiving this mail because: You are watching all bug changes.
[valgrind] [Bug 429375] PPC ISA 3.1 support is missing, part 9
https://bugs.kde.org/show_bug.cgi?id=429375 Carl Love changed: What|Removed |Added Attachment #134757|0 |1 is obsolete|| --- Comment #4 from Carl Love --- Created attachment 136163 --> https://bugs.kde.org/attachment.cgi?id=136163=edit VSX-PCV Generate Operation functional support Addressed comments from Julian to add static or comment about called from generated code to the various functions. Added vassert(0) instead of prints as requested. Removed redundant return statements. VSX-PCV Generate Operation function support patch has been retested and passed regressing tests. No changes were made to the test cases for VSX-PCV generate operations. -- You are receiving this mail because: You are watching all bug changes.
[valgrind] [Bug 429375] PPC ISA 3.1 support is missing, part 9
https://bugs.kde.org/show_bug.cgi?id=429375
--- Comment #3 from Julian Seward ---
==
https://bugs.kde.org/attachment.cgi?id=133479
test cases for VSX-PCV generate operations
OK to land
==
https://bugs.kde.org/attachment.cgi?id=134757
VSX- PCV Generate Operation functional support
Some concerns here.
/*---*/
/*--- Misc integer helpers. ---*/
/*---*/
+void write_VSX_entry (VexGuestPPC64State* gst, UInt reg_offset,
+ ULong *vsx_entry);
Mark this as static or give it a comment that it is called from generated code
(one or the other)
Also it seems like this function prototype is in a .c file, not a header.
Seems not right.
+/*--*/
+/* VSX Vector Generate PCV from Mask helpers ---*/
+/*--*/
+void write_VSX_entry (VexGuestPPC64State* gst, UInt reg_offset,
+ ULong *vsx_entry)
comment or 'static' pls
+void vector_gen_pvc_byte_mask_dirty_helper( VexGuestPPC64State* gst,
+ULong src_hi, ULong src_lo,
+UInt reg_offset, UInt imm ) {
and here
+ } else {
+ vex_printf("ERROR, vector_gen_pvc_byte_mask_dirty_helper, imm value %u
not supported.\n",
+ imm);
+ }
After printing, do vassert(0); so the system stops, rather than continues
with incorrect data.
+ return;
+}
the return is redundant
+void vector_gen_pvc_hword_mask_dirty_helper( VexGuestPPC64State* gst,
+ ULong src_hi, ULong src_lo,
+ UInt reg_offset, UInt imm ) {
comment or 'static'
+ } else {
+ vex_printf("ERROR, vector_gen_pvc_hword_dirty_mask_helper, imm value %u
not supported.\n",
+ imm);
+ }
and assert, and rm redundant return
+void vector_gen_pvc_word_mask_dirty_helper( VexGuestPPC64State* gst,
+ULong src_hi, ULong src_lo,
+UInt reg_offset, UInt imm ) {
same comments
+void vector_gen_pvc_dword_mask_dirty_helper( VexGuestPPC64State* gst,
+ ULong src_hi, ULong src_lo,
+ UInt reg_offset, UInt imm ) {
same comments
+ IREffect VSX_fx = Ifx_Write;
Inline this at its single use point, since it is never changed.
+ IRExpr** args = mkIRExprVec_5(
+ IRExpr_GSPTR(),
+ mkexpr( src_hi ),
+ mkexpr( src_lo ),
+ mkU32( reg_offset ),
+ mkU64( IMM ) );
+
+
+
No need for three blank lines here.
+ d->nFxState = 1;
+ vex_bzero(>fxState, sizeof(d->fxState));
+ d->fxState[0].fx = VSX_fx;
+ d->fxState[0].size = sizeof(U128);
+ d->fxState[0].offset = reg_offset;
You're sure this declaration of effects is correct, right? The called helpers
really only writes one of the vector registers and doesn't read any?
+ default:
+ vex_printf("dis_vector_generate_pvc_from_mask (opc2)\n");
+ return False;
+ }
Don't print in failure paths; just return False.
==
--
You are receiving this mail because:
You are watching all bug changes.
[valgrind] [Bug 429375] PPC ISA 3.1 support is missing, part 9
https://bugs.kde.org/show_bug.cgi?id=429375 Carl Love changed: What|Removed |Added Attachment #133478|0 |1 is obsolete|| --- Comment #2 from Carl Love --- Created attachment 134757 --> https://bugs.kde.org/attachment.cgi?id=134757=edit VSX- PCV Generate Operation functional support Mainline had a series of fixes added. The patch was updated to apply to the current mainline. -- You are receiving this mail because: You are watching all bug changes.
[valgrind] [Bug 429375] PPC ISA 3.1 support is missing, part 9
https://bugs.kde.org/show_bug.cgi?id=429375 Carl Love changed: What|Removed |Added CC||will_schm...@vnet.ibm.com -- You are receiving this mail because: You are watching all bug changes.
[valgrind] [Bug 429375] PPC ISA 3.1 support is missing, part 9
https://bugs.kde.org/show_bug.cgi?id=429375 --- Comment #1 from Carl Love --- Created attachment 133479 --> https://bugs.kde.org/attachment.cgi?id=133479=edit test cases for VSX-PCV generate operations Add test cases -- You are receiving this mail because: You are watching all bug changes.
