[valgrind] [Bug 433873] openat2 syscall unimplemented on Linux
https://bugs.kde.org/show_bug.cgi?id=433873 Paul Floyd changed: What|Removed |Added Resolution|--- |FIXED Status|REPORTED|RESOLVED --- Comment #8 from Paul Floyd --- Should be fixed with this commit commit 2c93baf53a652fd503c0c21bccb7e85363f43e58 (HEAD -> master, origin/master, origin/HEAD) Author: Paul Floyd Date: Fri Jan 6 21:27:01 2023 +0100 Bug 433873 - openat2 syscall unimplemented on Linux This syscall is not exposed via glibc, so there is only an addition to the scalar test. -- You are receiving this mail because: You are watching all bug changes.
[valgrind] [Bug 433873] openat2 syscall unimplemented on Linux
https://bugs.kde.org/show_bug.cgi?id=433873 --- Comment #7 from Paul Floyd --- Hmm. I should perhaps land this. Need some tests (scalar at least). -- You are receiving this mail because: You are watching all bug changes.
[valgrind] [Bug 433873] openat2 syscall unimplemented on Linux
https://bugs.kde.org/show_bug.cgi?id=433873 Paul Floyd changed: What|Removed |Added Attachment #143183|0 |1 is obsolete|| --- Comment #6 from Paul Floyd --- Created attachment 143184 --> https://bugs.kde.org/attachment.cgi?id=143184=edit patch for openat2 Third time lucky with the flag checks. -- You are receiving this mail because: You are watching all bug changes.
[valgrind] [Bug 433873] openat2 syscall unimplemented on Linux
https://bugs.kde.org/show_bug.cgi?id=433873
--- Comment #5 from Paul Floyd ---
I had a little difficulty compiling the example code, ended up copying/pasting
a few ofd the octal flags from /usr/include/asm-generic/fcntl.h directly into
the file.
I based the mode/flags and resolve checks on this comment in openat.h
* Arguments for how openat2(2) should open the target path. If only @flags and
* @mode are non-zero, then openat2(2) operates very similarly to openat(2).
*
* However, unlike openat(2), unknown or invalid bits in @flags result in
* -EINVAL rather than being silently ignored. @mode must be zero unless one of
* {O_CREAT, O_TMPFILE} are set.
--
You are receiving this mail because:
You are watching all bug changes.
[valgrind] [Bug 433873] openat2 syscall unimplemented on Linux
https://bugs.kde.org/show_bug.cgi?id=433873 Paul Floyd changed: What|Removed |Added Attachment #143181|0 |1 is obsolete|| --- Comment #4 from Paul Floyd --- Created attachment 143183 --> https://bugs.kde.org/attachment.cgi?id=143183=edit patch for openat2 This time - make sure masks are extended to unsigned long long - use resolved field rather than mistakenly mode -- You are receiving this mail because: You are watching all bug changes.
[valgrind] [Bug 433873] openat2 syscall unimplemented on Linux
https://bugs.kde.org/show_bug.cgi?id=433873 --- Comment #3 from Paul Floyd --- Created attachment 143181 --> https://bugs.kde.org/attachment.cgi?id=143181=edit diff for opnenat2 Here is the start of an implementation. Mostly it's just a copy/paste of sys_openat, with the args changed to use struct open_how*, and also to do more thorouhg checking of the args. I'm not sure if the values of VKI_O_DIRECTORY / VKI___O_TMPFILE / VKI_O_TMPFILE are generic across Linux hardware platforms. If they are then they need to be moved to include/vki/vki-linux.h. If not they need to be moved to the platform versions of vki-linux.h -- You are receiving this mail because: You are watching all bug changes.
[valgrind] [Bug 433873] openat2 syscall unimplemented on Linux
https://bugs.kde.org/show_bug.cgi?id=433873 Sam James changed: What|Removed |Added CC||s...@gentoo.org -- You are receiving this mail because: You are watching all bug changes.
[valgrind] [Bug 433873] openat2 syscall unimplemented on Linux
https://bugs.kde.org/show_bug.cgi?id=433873 --- Comment #2 from Drew DeVault --- Created attachment 136343 --> https://bugs.kde.org/attachment.cgi?id=136343=edit Program which demonstrates the use of the openat2 syscall Sure thing. Here's a test program. -- You are receiving this mail because: You are watching all bug changes.
[valgrind] [Bug 433873] openat2 syscall unimplemented on Linux
https://bugs.kde.org/show_bug.cgi?id=433873 Paul Floyd changed: What|Removed |Added CC||pjfl...@wanadoo.fr --- Comment #1 from Paul Floyd --- Do you have a small testcase to reproduce this? -- You are receiving this mail because: You are watching all bug changes.
