[yakuake] [Bug 395012] Skins can't be installed from KNS
https://bugs.kde.org/show_bug.cgi?id=395012 Christoph Feck changed: What|Removed |Added Version Fixed In|19.04.0 | --- Comment #11 from Christoph Feck --- Yakuake is not part of KDE Applications, but released separately. -- You are receiving this mail because: You are watching all bug changes.
[yakuake] [Bug 395012] Skins can't be installed from KNS
https://bugs.kde.org/show_bug.cgi?id=395012 Nate Graham changed: What|Removed |Added Version Fixed In||19.04.0 CC||n...@kde.org -- You are receiving this mail because: You are watching all bug changes.
[yakuake] [Bug 395012] Skins can't be installed from KNS
https://bugs.kde.org/show_bug.cgi?id=395012 Patrick Silva changed: What|Removed |Added CC||l3d8...@gmail.com --- Comment #10 from Patrick Silva --- *** Bug 390155 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
[yakuake] [Bug 395012] Skins can't be installed from KNS
https://bugs.kde.org/show_bug.cgi?id=395012 Eike Hein changed: What|Removed |Added Latest Commit||https://commits.kde.org/yak ||uake/d9537fcba90ba912c8ea50 ||c4733d6189cdb15b01 Resolution|DUPLICATE |FIXED --- Comment #9 from Eike Hein --- Git commit d9537fcba90ba912c8ea50c4733d6189cdb15b01 by Eike Hein, on behalf of Lionel Chauvin. Committed on 10/03/2019 at 07:30. Pushed by hein into branch 'master'. Fix Skin validation when installed from KNS Summary: When a Skin is downloaded from KNS, Yakuake fails to validate the presence of title.skin and tabs.skin files. The skin is then uninstalled even if these files exist. This is due to this optimization of KNS: https://phabricator.kde.org/D6104 Files are not listed anymore by entry.installedFiles(). They are replaced by paths that end with /* In order to fix this bug I changed the validateSkin method so that it checks the presence of files in the filesystem instead of in a list of entries returned by KNS. Test Plan: Download a Skin from KNS: It should not complain about missing files. Install a correct skin from local: it should not complain about missing files; Install a wrong skin from local: it should complain about missing files; Install a correct skin already installed from local: it should ask for overwrite existing skin. Reviewers: hein, apol, #yakuake Reviewed By: hein Subscribers: Zren, hein, apol, chauvin Tags: #yakuake Differential Revision: https://phabricator.kde.org/D13335 M +45 -59 app/config/appearancesettings.cpp M +4-3app/config/appearancesettings.h https://commits.kde.org/yakuake/d9537fcba90ba912c8ea50c4733d6189cdb15b01 -- You are receiving this mail because: You are watching all bug changes.
[yakuake] [Bug 395012] Skins can't be installed from KNS
https://bugs.kde.org/show_bug.cgi?id=395012 --- Comment #8 from Andrei Shevchuk --- Download skin and extract it to ~/.local/share/yakuake/kns_skins/ вт, 5 мар. 2019 г., 6:21 Colin Jaffe : > https://bugs.kde.org/show_bug.cgi?id=395012 > > Colin Jaffe changed: > >What|Removed |Added > > > CC||abbreviated...@posteo.net > > --- Comment #7 from Colin Jaffe --- > How does one manually install a yakuake skin? > > -- > You are receiving this mail because: > You are on the CC list for the bug. -- You are receiving this mail because: You are watching all bug changes.
[yakuake] [Bug 395012] Skins can't be installed from KNS
https://bugs.kde.org/show_bug.cgi?id=395012 Colin Jaffe changed: What|Removed |Added CC||abbreviated...@posteo.net --- Comment #7 from Colin Jaffe --- How does one manually install a yakuake skin? -- You are receiving this mail because: You are watching all bug changes.
[yakuake] [Bug 395012] Skins can't be installed from KNS
https://bugs.kde.org/show_bug.cgi?id=395012 Patrick Silva changed: What|Removed |Added Resolution|--- |DUPLICATE Status|REPORTED|RESOLVED --- Comment #6 from Patrick Silva --- *** This bug has been marked as a duplicate of bug 390155 *** -- You are receiving this mail because: You are watching all bug changes.
[yakuake] [Bug 395012] Skins can't be installed from KNS
https://bugs.kde.org/show_bug.cgi?id=395012 Neousr changed: What|Removed |Added CC||neo...@protonmail.com --- Comment #5 from Neousr --- Can confirm this on Plasma 5.14.5 some time ago i circumvented this by manually installing a skin. -- You are receiving this mail because: You are watching all bug changes.
[yakuake] [Bug 395012] Skins can't be installed from KNS
https://bugs.kde.org/show_bug.cgi?id=395012 Chris Holland changed: What|Removed |Added CC||zrenf...@gmail.com -- You are receiving this mail because: You are watching all bug changes.
[yakuake] [Bug 395012] Skins can't be installed from KNS
https://bugs.kde.org/show_bug.cgi?id=395012 Patrick Silva changed: What|Removed |Added CC||bugsefor...@gmx.com -- You are receiving this mail because: You are watching all bug changes.
[yakuake] [Bug 395012] Skins can't be installed from KNS
https://bugs.kde.org/show_bug.cgi?id=395012 Patrick Silva changed: What|Removed |Added CC||spaceboyr...@yandex.com --- Comment #4 from Patrick Silva --- *** Bug 399887 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
[yakuake] [Bug 395012] Skins can't be installed from KNS
https://bugs.kde.org/show_bug.cgi?id=395012 Andrei Shevchuk changed: What|Removed |Added CC||and...@shevchuk.co --- Comment #3 from Andrei Shevchuk --- Just wanted to confirm the bug, have to install skins manually. -- You are receiving this mail because: You are watching all bug changes.
[yakuake] [Bug 395012] Skins can't be installed from KNS
https://bugs.kde.org/show_bug.cgi?id=395012 --- Comment #2 from Lionel Chauvin --- Hi, Eike Hein Can I add you as a reviewer on https://phabricator.kde.org/D13335 ? -- You are receiving this mail because: You are watching all bug changes.
[yakuake] [Bug 395012] Skins can't be installed from KNS
https://bugs.kde.org/show_bug.cgi?id=395012 --- Comment #1 from Lionel Chauvin --- Hi, Ein Kein Can I add you as a reviewer on https://phabricator.kde.org/D13335 ? -- You are receiving this mail because: You are watching all bug changes.
[yakuake] [Bug 395012] Skins can't be installed from KNS
https://bugs.kde.org/show_bug.cgi?id=395012 Lionel Chauvin changed: What|Removed |Added Attachment #113055|fix |patch description|| -- You are receiving this mail because: You are watching all bug changes.
