Re: RPATH order problem

2007-05-16 Thread David Faure
On Friday 04 May 2007, David Faure wrote:
 It would just be much simpler if -L/usr/lib64 and -L/lib64 were never 
 generated.

I was talking to Simon on IRC and he suggested that -L/usr/lib32 should also 
not be generated.
Can I suggest this patch? (I see that the CMake-2-4 branch is unchanged after 
this discussion,
so this is still TODO)

--- cmLocalGenerator.cxx16 Mar 2007 22:05:42 -  1.132.2.11
+++ cmLocalGenerator.cxx16 May 2007 12:20:30 -
@@ -1467,6 +1467,8 @@ void cmLocalGenerator::OutputLinkLibrari
   // Some search paths should never be emitted
   emitted.insert();
   emitted.insert(/usr/lib);
+  emitted.insert(/usr/lib32);
+  emitted.insert(/usr/lib64);
   std::string libPathFlag =
 this-Makefile-GetRequiredDefinition(CMAKE_LIBRARY_PATH_FLAG);
   std::string libLinkFlag =


-- 
David Faure, [EMAIL PROTECTED], sponsored by Trolltech to work on KDE,
Konqueror (http://www.konqueror.org), and KOffice (http://www.koffice.org).
___
Kde-buildsystem mailing list
Kde-buildsystem@kde.org
https://mail.kde.org/mailman/listinfo/kde-buildsystem


Re: RPATH order problem

2007-05-16 Thread Brad King
David Faure wrote:
 I was talking to Simon on IRC and he suggested that -L/usr/lib32 should also 
 not be generated.
 Can I suggest this patch? (I see that the CMake-2-4 branch is unchanged after 
 this discussion,
 so this is still TODO)
[snip]
emitted.insert(/usr/lib);
 +  emitted.insert(/usr/lib32);
 +  emitted.insert(/usr/lib64);

Yes, this has been on my TODO list since that conversation.  I've
committed it to the main tree but need to wait for a day or two of
nightly tests before I can put it on the branch.

-Brad
___
Kde-buildsystem mailing list
Kde-buildsystem@kde.org
https://mail.kde.org/mailman/listinfo/kde-buildsystem