Re: Fwd: kdelibs/cmake/modules patches

2008-01-29 Thread Dirk Mueller 
On Monday 28 January 2008, Allen Winter wrote:
 --  Forwarded Message  --

 Subject: kdelibs/cmake/modules patches
 Date: Monday 28 January 2008
 From: David Johnson [EMAIL PROTECTED]
 To: [EMAIL PROTECTED]

 At the kde-freebsd team, we have make some simple patches to fix some
 linkage errors, that will sometimes link to KDE3/Qt3 instead of KDE4/Qt4.
 These patches work on FreeBSD, and have been tested on Linux (Arch) as
 well. We would like to get these into the upstream. Can you look these over
 and check their appropriateness? If okay I can check them into 4.0 and
 trunk.

Looks correct to me, please commit. 

Greetings,
Dirk
___
Kde-buildsystem mailing list
Kde-buildsystem@kde.org
https://mail.kde.org/mailman/listinfo/kde-buildsystem

Re: Howto fix KDE4 Buildsystem with CMake CVS

2008-01-29 Thread David Faure 
On Monday 28 January 2008, Andreas Pakulat wrote:
 On 28.01.08 10:32:15, Andreas Pakulat wrote:
  There are a couple of ways to fix this:
  
  a) introduce KDE_XXX_LIBRARY_DIR (or KDE_LIBRARY_DIR) and add
  link_directories calls for kde libdir and qt libdir in all
  CMakeLists.txt all over trunk/.
 
 I must be blind. FindKDE4Internal.cmake already advertises KDE4_LIB_DIR,
 so this is simply a matter of fixing the projects that need to use
 link_directories( ${KDE4_LIB_DIR} ).

Can't we just do that in kde4_add_executable and kde4_add_library etc.?
Or is that too much hidden magic?

-- 
David Faure, [EMAIL PROTECTED], sponsored by Trolltech to work on KDE,
Konqueror (http://www.konqueror.org), and KOffice (http://www.koffice.org).
___
Kde-buildsystem mailing list
Kde-buildsystem@kde.org
https://mail.kde.org/mailman/listinfo/kde-buildsystem