Missing configure checks for #cmakedefine
Hello, it's been pointed out to me that KDE4 runs screensavers at normal priority (thus possibly affecting other sessions on the same machine). The code uses setpriority() call, which is inside #ifdef HAVE_SETPRIORITY. And, while, kdebase/workspace/config-workspace.h.cmake has HAVE_SETPRIORITY, there is nothing to actually do the check[*]. It somehow got lost during KDE4 porting, and there are possibly more places. At least looking at generated kdebase/workspace/config-workspace.h it has a couple of #undef's for things that obviously are present (e.g. unistd.h). Is there some way to avoid this kind of problem? With the way these things are scattered in KDE4 this is rather difficult to check. [*] Already fixed. -- Lubos Lunak KDE developer -- SUSE LINUX, s.r.o. e-mail: l.lu...@suse.cz , l.lu...@kde.org Lihovarska 1060/12 tel: +420 284 028 972 190 00 Prague 9 fax: +420 284 028 951 Czech Republic http://www.suse.cz ___ Kde-buildsystem mailing list Kde-buildsystem@kde.org https://mail.kde.org/mailman/listinfo/kde-buildsystem
Re: Missing configure checks for #cmakedefine
Lubos Lunak wrote: At least looking at generated kdebase/workspace/config-workspace.h it has a couple of #undef's for things that obviously are present (e.g. unistd.h). unistd.h is not present on Windows (it's not a Unix system). But workspace is not meant to compile on Windows anyways... -- Thiago Macieira - thiago (AT) macieira.info - thiago (AT) kde.org PGP/GPG: 0x6EF45358; fingerprint: E067 918B B660 DBD1 105C 966C 33F5 F005 6EF4 5358 signature.asc Description: This is a digitally signed message part. ___ Kde-buildsystem mailing list Kde-buildsystem@kde.org https://mail.kde.org/mailman/listinfo/kde-buildsystem
Re: Missing configure checks for #cmakedefine
Thiago Macieira schrieb: Lubos Lunak wrote: At least looking at generated kdebase/workspace/config-workspace.h it has a couple of #undef's for things that obviously are present (e.g. unistd.h). unistd.h is not present on Windows (it's not a Unix system). But workspace is not meant to compile on Windows anyways... :) Workspace does compile on windows due to the work of Saro and Brandon (afaik plasma.exe also works - at least it starts). Christian ___ Kde-buildsystem mailing list Kde-buildsystem@kde.org https://mail.kde.org/mailman/listinfo/kde-buildsystem
