D19486: Add UDev find module

2019-03-04 Thread Volker Krause 
This revision was automatically updated to reflect the committed changes.
Closed by commit R240:8999b7bd6f6d: Add UDev find module (authored by vkrause).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D19486?vs=53055=53160#toc

REPOSITORY
  R240 Extra CMake Modules

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19486?vs=53055=53160

REVISION DETAIL
  https://phabricator.kde.org/D19486

AFFECTED FILES
  attic/modules/FindUDev.cmake
  docs/find-module/FindUDev.rst
  find-modules/FindUDev.cmake

To: vkrause, cgiboudeaux
Cc: cgiboudeaux, kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns

D19506: ECMGeneratePkgConfigFile: add variables used by pkg_check_modules

2019-03-04 Thread Friedrich W. H. Kossebau 
kossebau added a comment.


  FWIW, this still results in inproper pc files, from what I heard recently. 
The `prefix` variable can be overriden from outside when calling `pkg-config` 
(cmp. `pkg-config --help`) to allow for relocatable installations. Same like 
CMake Config files also allow relocation by having the install prefix not 
hardcoded into directory var values.
  
  So ideally any other paths expressions in the pc file use at least the prefix 
variable.
  
  No more info here myself.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D19506

To: dfaure, apol, fazevedo, cgiboudeaux
Cc: kossebau, cgiboudeaux, fazevedo, kde-buildsystem, kde-frameworks-devel, 
michaelh, ngraham, bruns

D19506: ECMGeneratePkgConfigFile: add variables used by pkg_check_modules

2019-03-04 Thread David Faure 
dfaure closed this revision.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D19506

To: dfaure, apol, fazevedo, cgiboudeaux
Cc: cgiboudeaux, fazevedo, kde-buildsystem, kde-frameworks-devel, michaelh, 
ngraham, bruns

D19506: ECMGeneratePkgConfigFile: add variables used by pkg_check_modules

2019-03-04 Thread Christophe Giboudeaux 
cgiboudeaux accepted this revision.
cgiboudeaux added a comment.
This revision is now accepted and ready to land.


  Thanks.

REPOSITORY
  R240 Extra CMake Modules

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19506

To: dfaure, apol, fazevedo, cgiboudeaux
Cc: cgiboudeaux, fazevedo, kde-buildsystem, kde-frameworks-devel, michaelh, 
ngraham, bruns

D19506: ECMGeneratePkgConfigFile: add variables used by pkg_check_modules

2019-03-04 Thread David Faure 
dfaure updated this revision to Diff 53114.
dfaure added a comment.


  Update unittests, passes now

REPOSITORY
  R240 Extra CMake Modules

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19506?vs=53108=53114

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19506

AFFECTED FILES
  modules/ECMGeneratePkgConfigFile.cmake
  tests/ECMGeneratePkgConfigFile/KF5CoreAddons.pc
  tests/ECMGeneratePkgConfigFile/KF5CoreAddons2.pc
  tests/ECMGeneratePkgConfigFile/KF5CoreAddons3.pc

To: dfaure, apol, fazevedo, cgiboudeaux
Cc: cgiboudeaux, fazevedo, kde-buildsystem, kde-frameworks-devel, michaelh, 
ngraham, bruns

D19506: ECMGeneratePkgConfigFile: add variables used by pkg_check_modules

2019-03-04 Thread Christophe Giboudeaux 
cgiboudeaux added a comment.


  In D19506#424301 , @cgiboudeaux 
wrote:
  
  > The autotest has to be fixed as well
  
  
  Comment edited, the includedir value is correct for this test.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D19506

To: dfaure, apol, fazevedo, cgiboudeaux
Cc: cgiboudeaux, fazevedo, kde-buildsystem, kde-frameworks-devel, michaelh, 
ngraham, bruns

D19506: ECMGeneratePkgConfigFile: add variables used by pkg_check_modules

2019-03-04 Thread Christophe Giboudeaux 
cgiboudeaux requested changes to this revision.
This revision now requires changes to proceed.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D19506

To: dfaure, apol, fazevedo, cgiboudeaux
Cc: cgiboudeaux, fazevedo, kde-buildsystem, kde-frameworks-devel, michaelh, 
ngraham, bruns

D19506: ECMGeneratePkgConfigFile: add variables used by pkg_check_modules

2019-03-04 Thread Christophe Giboudeaux 
cgiboudeaux added a comment.


  The autotest has to be fixed as well
  
  The includedir value looks bogus, the test file contains
  
includedir=/usr/KCoreAddons

REPOSITORY
  R240 Extra CMake Modules

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19506

To: dfaure, apol, fazevedo
Cc: cgiboudeaux, fazevedo, kde-buildsystem, kde-frameworks-devel, michaelh, 
ngraham, bruns

D19506: ECMGeneratePkgConfigFile: add variables used by pkg_check_modules

2019-03-04 Thread Filipe Azevedo 
fazevedo accepted this revision.
fazevedo added a comment.
This revision is now accepted and ready to land.


  Works for me !

REPOSITORY
  R240 Extra CMake Modules

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19506

To: dfaure, apol, fazevedo
Cc: fazevedo, kde-buildsystem, kde-frameworks-devel, michaelh, ngraham, bruns

D19506: ECMGeneratePkgConfigFile: add variables used by pkg_check_modules

2019-03-04 Thread David Faure 
dfaure created this revision.
dfaure added a reviewer: apol.
Herald added projects: Frameworks, Build System.
Herald added a subscriber: kde-frameworks-devel.
dfaure requested review of this revision.

REVISION SUMMARY
  If we ever end up in a situation where the generated .pc file is
  actually used by cmake's pkg_check_modules, then we need the
  includedir and libdir variables; pkg_check_modules ignores the
  Makefile-like Libs and Cflags lines of the .pc file.
  
  Context: craft adds a cmake buildsystem for sqlite3, which is then
  found using pkgconfig in akonadi.

TEST PLAN
  Filipe Azevedo is doing all the testing, I'm just providing patches :)

REPOSITORY
  R240 Extra CMake Modules

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19506

AFFECTED FILES
  modules/ECMGeneratePkgConfigFile.cmake

To: dfaure, apol
Cc: kde-buildsystem, kde-frameworks-devel, michaelh, ngraham, bruns

D18943: Add Fontconfig find modudle

2019-03-04 Thread Volker Krause 
vkrause added a comment.


  In D18943#424041 , @kossebau wrote:
  
  > In D18943#424029 , @vkrause 
wrote:
  >
  > > What I don't understand though is which FindFontconfig this used to find, 
there is non in plasma-desktop...
  >
  >
  > kdelibs4support provides one.
  
  
  ... which is installed into a non-standard location that is added to the 
module search path automatically when doing find_package(KDELibs4Support) it 
seems. Nasty.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D18943

To: vkrause, cgiboudeaux
Cc: matthieugras, kossebau, apol, cgiboudeaux, kde-frameworks-devel, 
kde-buildsystem, michaelh, ngraham, bruns