D23262: disable autouic again - it breaks builds
bcooksley removed a subscriber: fusitter. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D23262 To: sitter, apol, nicolasfella, cullmann Cc: bcooksley, kde-frameworks-devel, kde-buildsystem, LeGast00n, GB_2, bencreasy, michaelh, ngraham, bruns, fusitter
D23262: disable autouic again - it breaks builds
fusitter added a comment. You think sending your minions to insult me and then disabling my account will solve the issue? what will you do next? Disable registration so no one points out your hypocrisy? Which overlord made the decision to disable my account and for what? REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D23262 To: sitter, apol, nicolasfella, cullmann Cc: fusitter, kde-frameworks-devel, kde-buildsystem, LeGast00n, GB_2, bencreasy, michaelh, ngraham, bruns
D22805: set autorcc and autouic by default
fusitter added a comment. You think sending your minions to insult me and then disabling my account will solve the issue? what will you do next? Disable registration so no one points out your hypocrisy? Which overlord made the decision to disable my account and for what? REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D22805 To: sitter, apol, nicolasfella Cc: fusitter, cullmann, nicolasfella, cgiboudeaux, vkrause, kossebau, apol, kde-frameworks-devel, kde-buildsystem, LeGast00n, GB_2, bencreasy, michaelh, ngraham, bruns
D23552: ECM: remove set_package_properties from FindCanberra
fsitter added a comment. You think sending your minions to insult me and then disabling my account will solve the issue? what will you do next? Disable registration so no one points out your hypocrisy? Which overlord made the decision to disable my account and for what? REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D23552 To: dfaure, cgiboudeaux, sitter Cc: fsitter, kossebau, kde-buildsystem, kde-frameworks-devel, apol, aacid, LeGast00n, GB_2, bencreasy, michaelh, ngraham, bruns
D23552: ECM: remove set_package_properties from FindCanberra
dfaure abandoned this revision. dfaure added a comment. Ah, I didn't realize there was no warning if calling set_package_properties with different properties. Good idea. Done in https://commits.kde.org/knotifications/06f5a4a6f8622913cb9cecd89b98cf762a489823 REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D23552 To: dfaure, cgiboudeaux, sitter Cc: kossebau, kde-buildsystem, kde-frameworks-devel, apol, aacid, LeGast00n, GB_2, bencreasy, michaelh, ngraham, bruns
D23552: ECM: remove set_package_properties from FindCanberra
cgiboudeaux added a comment. I'd do the opposite, remove `DESCRIPTION` and `URL` from knotification's CMakeLists.txt and only leave the `PURPOSE` line. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D23552 To: dfaure, cgiboudeaux, sitter Cc: kossebau, kde-buildsystem, kde-frameworks-devel, apol, aacid, LeGast00n, GB_2, bencreasy, michaelh, ngraham, bruns
