Re: Review Request 112451: Adapt the DocBook finders to newer naming conventions
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112451/ --- (Updated Sept. 4, 2013, 12:16 p.m.) Review request for Build System, KDE Frameworks and Luigi Toscano. Changes --- Change casing as Alexander suggested Summary (updated) - Adapt the DocBook finders to newer naming conventions Description (updated) --- When trying to properly split KDocTools I saw that FindDocBookXML.cmake and FindDocBookXSL.cmake were at an attic directory that was not being processed. This patch changes them to have them usable for KF5. Diffs (updated) - attic/modules/FindDocBookXML.cmake 26053bf attic/modules/FindDocBookXSL.cmake ab93c9e find-modules/FindDocBookXML.cmake PRE-CREATION find-modules/FindDocBookXSL.cmake PRE-CREATION Diff: http://git.reviewboard.kde.org/r/112451/diff/ Testing --- Installs and seems to work. Thanks, Aleix Pol Gonzalez ___ Kde-buildsystem mailing list Kde-buildsystem@kde.org https://mail.kde.org/mailman/listinfo/kde-buildsystem
Re: Review Request 112451: Adapt the DocBook finders to newer naming conventions
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112451/ --- (Updated Sept. 4, 2013, 1:55 p.m.) Review request for Build System, KDE Frameworks and Luigi Toscano. Changes --- remove commented code Description --- When trying to properly split KDocTools I saw that FindDocBookXML.cmake and FindDocBookXSL.cmake were at an attic directory that was not being processed. This patch changes them to have them usable for KF5. Diffs (updated) - attic/modules/FindDocBookXML.cmake 26053bf attic/modules/FindDocBookXSL.cmake ab93c9e Diff: http://git.reviewboard.kde.org/r/112451/diff/ Testing --- Installs and seems to work. Thanks, Aleix Pol Gonzalez ___ Kde-buildsystem mailing list Kde-buildsystem@kde.org https://mail.kde.org/mailman/listinfo/kde-buildsystem
Re: Review Request 112451: Adapt the DocBook finders to newer naming conventions
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112451/#review39357 --- Ship it! Ship It! - Luigi Toscano On Sept. 4, 2013, 1:55 p.m., Aleix Pol Gonzalez wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112451/ --- (Updated Sept. 4, 2013, 1:55 p.m.) Review request for Build System, KDE Frameworks and Luigi Toscano. Description --- When trying to properly split KDocTools I saw that FindDocBookXML.cmake and FindDocBookXSL.cmake were at an attic directory that was not being processed. This patch changes them to have them usable for KF5. Diffs - attic/modules/FindDocBookXML.cmake 26053bf attic/modules/FindDocBookXSL.cmake ab93c9e Diff: http://git.reviewboard.kde.org/r/112451/diff/ Testing --- Installs and seems to work. Thanks, Aleix Pol Gonzalez ___ Kde-buildsystem mailing list Kde-buildsystem@kde.org https://mail.kde.org/mailman/listinfo/kde-buildsystem
Re: Review Request 112451: Adapt the DocBook finders to newer naming conventions
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112451/ --- (Updated Sept. 4, 2013, 2:46 p.m.) Review request for Build System, KDE Frameworks and Luigi Toscano. Changes --- rebase after changes in ecm Description --- When trying to properly split KDocTools I saw that FindDocBookXML.cmake and FindDocBookXSL.cmake were at an attic directory that was not being processed. This patch changes them to have them usable for KF5. Diffs (updated) - attic/modules/FindDocBookXML.cmake attic/modules/FindDocBookXSL.cmake Diff: http://git.reviewboard.kde.org/r/112451/diff/ Testing --- Installs and seems to work. Thanks, Aleix Pol Gonzalez ___ Kde-buildsystem mailing list Kde-buildsystem@kde.org https://mail.kde.org/mailman/listinfo/kde-buildsystem
Re: Review Request 112451: Adapt the DocBook finders to newer naming conventions
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112451/#review39359 --- Ship it! Ship It! - Stephen Kelly On Sept. 4, 2013, 2:46 p.m., Aleix Pol Gonzalez wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112451/ --- (Updated Sept. 4, 2013, 2:46 p.m.) Review request for Build System, KDE Frameworks and Luigi Toscano. Description --- When trying to properly split KDocTools I saw that FindDocBookXML.cmake and FindDocBookXSL.cmake were at an attic directory that was not being processed. This patch changes them to have them usable for KF5. Diffs - attic/modules/FindDocBookXML.cmake attic/modules/FindDocBookXSL.cmake Diff: http://git.reviewboard.kde.org/r/112451/diff/ Testing --- Installs and seems to work. Thanks, Aleix Pol Gonzalez ___ Kde-buildsystem mailing list Kde-buildsystem@kde.org https://mail.kde.org/mailman/listinfo/kde-buildsystem
Re: Review Request 112451: Adapt the DocBook finders to newer naming conventions
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112451/ --- (Updated Sept. 4, 2013, 2:50 p.m.) Status -- This change has been marked as submitted. Review request for Build System, KDE Frameworks and Luigi Toscano. Description --- When trying to properly split KDocTools I saw that FindDocBookXML.cmake and FindDocBookXSL.cmake were at an attic directory that was not being processed. This patch changes them to have them usable for KF5. Diffs - attic/modules/FindDocBookXML.cmake attic/modules/FindDocBookXSL.cmake Diff: http://git.reviewboard.kde.org/r/112451/diff/ Testing --- Installs and seems to work. Thanks, Aleix Pol Gonzalez ___ Kde-buildsystem mailing list Kde-buildsystem@kde.org https://mail.kde.org/mailman/listinfo/kde-buildsystem
Re: Review Request 112451: Adapt the DocBook finders to newer naming conventions
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112451/#review39371 --- Did you verify that these files work as expected ? AFAIK, find_package_handle_standard_args() sets by default the UPPERCASE_FOUND variable, not the CamelCase_FOUND variable. To have it set CamelCase_FOUND, i.e. DocBookXML_FOUND (instead of DOCBOOKXML_FOUND), use the new signature: find_package_handle_standard_args(FOUND_VAR DocBookXML_FOUND REQUIRED_VARS DocBookXSL_DIR ) After that you can set the old UPPERCASE variables for compatibility if you want to. - Alexander Neundorf On Sept. 4, 2013, 2:50 p.m., Aleix Pol Gonzalez wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112451/ --- (Updated Sept. 4, 2013, 2:50 p.m.) Review request for Build System, KDE Frameworks and Luigi Toscano. Description --- When trying to properly split KDocTools I saw that FindDocBookXML.cmake and FindDocBookXSL.cmake were at an attic directory that was not being processed. This patch changes them to have them usable for KF5. Diffs - attic/modules/FindDocBookXML.cmake attic/modules/FindDocBookXSL.cmake Diff: http://git.reviewboard.kde.org/r/112451/diff/ Testing --- Installs and seems to work. Thanks, Aleix Pol Gonzalez ___ Kde-buildsystem mailing list Kde-buildsystem@kde.org https://mail.kde.org/mailman/listinfo/kde-buildsystem
Re: Review Request 112451: Adapt the DocBook finders to newer naming conventions
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112451/#review39360 --- This review has been submitted with commit d42d5889d25ac4c900a294f283dd802eccf96010 by Aleix Pol to branch master. - Commit Hook On Sept. 4, 2013, 2:46 p.m., Aleix Pol Gonzalez wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112451/ --- (Updated Sept. 4, 2013, 2:46 p.m.) Review request for Build System, KDE Frameworks and Luigi Toscano. Description --- When trying to properly split KDocTools I saw that FindDocBookXML.cmake and FindDocBookXSL.cmake were at an attic directory that was not being processed. This patch changes them to have them usable for KF5. Diffs - attic/modules/FindDocBookXML.cmake attic/modules/FindDocBookXSL.cmake Diff: http://git.reviewboard.kde.org/r/112451/diff/ Testing --- Installs and seems to work. Thanks, Aleix Pol Gonzalez ___ Kde-buildsystem mailing list Kde-buildsystem@kde.org https://mail.kde.org/mailman/listinfo/kde-buildsystem
Re: Review Request 112451: Adapt the DocBook finders to newer naming conventions
On Sept. 4, 2013, 6:08 p.m., Alexander Neundorf wrote: Did you verify that these files work as expected ? AFAIK, find_package_handle_standard_args() sets by default the UPPERCASE_FOUND variable, not the CamelCase_FOUND variable. To have it set CamelCase_FOUND, i.e. DocBookXML_FOUND (instead of DOCBOOKXML_FOUND), use the new signature: find_package_handle_standard_args(FOUND_VAR DocBookXML_FOUND REQUIRED_VARS DocBookXSL_DIR ) After that you can set the old UPPERCASE variables for compatibility if you want to. I've just fixed this, thanks for the suggestion! - Aleix --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112451/#review39371 --- On Sept. 4, 2013, 2:50 p.m., Aleix Pol Gonzalez wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112451/ --- (Updated Sept. 4, 2013, 2:50 p.m.) Review request for Build System, KDE Frameworks and Luigi Toscano. Description --- When trying to properly split KDocTools I saw that FindDocBookXML.cmake and FindDocBookXSL.cmake were at an attic directory that was not being processed. This patch changes them to have them usable for KF5. Diffs - attic/modules/FindDocBookXML.cmake attic/modules/FindDocBookXSL.cmake Diff: http://git.reviewboard.kde.org/r/112451/diff/ Testing --- Installs and seems to work. Thanks, Aleix Pol Gonzalez ___ Kde-buildsystem mailing list Kde-buildsystem@kde.org https://mail.kde.org/mailman/listinfo/kde-buildsystem
