Re: using phonon from kde-qt repo

2009-08-06 Thread Fathi Boudra
This patch is still not commited.
Does anything prevent his inclusion in 4.3 branch and trunk ?
___
Kde-buildsystem mailing list
Kde-buildsystem@kde.org
https://mail.kde.org/mailman/listinfo/kde-buildsystem


Re: using phonon from kde-qt repo

2009-07-28 Thread Thiago Macieira
Pavel Volkovitskiy wrote:
Hello!

i'm trying to build latest kdebase-runtime module from 4.3 branch with
phonon from qt (kde-qt repo) instead of kdesupport

cmake finds headers/libraries but then build stops with:

phonon/kded-module/phononserver.h:26:36: error:
 Phonon/ObjectDescription: No such file or directory

i tried to fix that and found that FindQt4.cmake (from kdelibs) doesn't
 set QT_PHONON_INCLUDE_DIR right (ie it doesn't finds headers)

this patch fixes that:
===
--- FindQt4.cmake.orig  2009-07-27 21:59:42.670907643 +0400
+++ FindQt4.cmake   2009-07-27 22:14:37.585907753 +0400
@@ -739,9 +739,10 @@
 )

   # Set QT_PHONON_INCLUDE_DIR
-  FIND_PATH(QT_PHONON_INCLUDE_DIR phonon
+  FIND_PATH(QT_PHONON_INCLUDE_DIR Phonon
 PATHS
 ${QT_INCLUDE_DIR}/phonon
+${QT_HEADERS_DIR}/phonon
 NO_DEFAULT_PATH
 )
===

i added QT_HEADERS_DIR just to match others QT_.*_INCLUDE_DIR

real issue is that it's looked for phonon but only Phonon exists
 there

Your patch makes sense. With 4.5.3, the Phonon directory is a subdir of 
$QTDIR/include/phonon.

-- 
  Thiago Macieira  -  thiago (AT) macieira.info - thiago (AT) kde.org
PGP/GPG: 0x6EF45358; fingerprint:
E067 918B B660 DBD1 105C  966C 33F5 F005 6EF4 5358


signature.asc
Description: This is a digitally signed message part.
___
Kde-buildsystem mailing list
Kde-buildsystem@kde.org
https://mail.kde.org/mailman/listinfo/kde-buildsystem