Re: Review Request: Adding net usershare suport for KSambaShare
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/4320/ --- (Updated 2010-11-30 00:40:10.025557) Review request for kdelibs, Raphael Kubo da Costa, Jonathan Thomas, Aurélien Gâteau, Jonathan Riddell, Adenilson Cavalcanti, loureiro, and Daniel Nicoletti. Changes --- Added docstrings and now using kuser to check if the share name matches a system user name. Summary --- KDE needs to support modern samba tools. With the net usershare command line tool the users can manage their shares. The attached patch intends to add support for this tool. Diffs (updated) - /trunk/KDE/kdelibs/includes/CMakeLists.txt 1180108 /trunk/KDE/kdelibs/kio/CMakeLists.txt 1180108 /trunk/KDE/kdelibs/kio/kio/ksambashare.h 1180108 /trunk/KDE/kdelibs/kio/kio/ksambashare.cpp 1180108 /trunk/KDE/kdelibs/kio/kio/ksambashare_p.h PRE-CREATION /trunk/KDE/kdelibs/kio/kio/ksambasharedata.h PRE-CREATION /trunk/KDE/kdelibs/kio/kio/ksambasharedata.cpp PRE-CREATION /trunk/KDE/kdelibs/kio/kio/ksambasharedata_p.h PRE-CREATION Diff: http://svn.reviewboard.kde.org/r/4320/diff Testing --- Thanks, Rodrigo
Re: Review Request: KDateEdit moving into kdelibs
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/6014/#review9054 --- The code is based on an old version of KDateEdit - the feature in the libkdepim version to set a minimum and/or maximum date is missing. This needs to be added, or it will break things. /trunk/KDE/kdelibs/kdeui/widgets/kdateedit.h http://svn.reviewboard.kde.org/r/6014/#comment9847 Please update my email to djar...@kde.org (here and in other places) - David On 2010-11-29 22:11:34, Kevin Ottens wrote: --- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/6014/ --- (Updated 2010-11-29 22:11:34) Review request for kdelibs and KDE PIM. Summary --- For a very long time now there's been a KDateEdit widget cooking up in kdepim. It's in fact a popular one, and I'm aware of around half a dozen (sometimes modified) copies of that widget. One of the most advanced fork is in Skrooge ATM. During the latest KDE Hacking Session in Toulouse, I sat down with the Skrooge maintainer and produced a refactored version of KDateEdit which also cover their needs. This patch is about introducing this widget in kdeui. It basically comes with three new classes: - KDateEdit itself; - KDatePickerPopup used by KDateEdit to popup a calendar picker; - KDateValidator used by KDateEdit to validate the input, it's made public as some of the fixup behavior can be tuned. Note that KDateTable already exposed a class named KDateValidator (much less advanced), so I took care of copying the extra method the former KDateValidator was exposing for BC reasons. I'm aiming for inclusion in 4.6, so a prompt review would be welcome. Thanks in advance. ;-) Diffs - /trunk/KDE/kdelibs/includes/CMakeLists.txt 1201925 /trunk/KDE/kdelibs/includes/KDateEdit PRE-CREATION /trunk/KDE/kdelibs/includes/KDatePickerPopup PRE-CREATION /trunk/KDE/kdelibs/includes/KDateValidator 1201925 /trunk/KDE/kdelibs/kdeui/CMakeLists.txt 1201925 /trunk/KDE/kdelibs/kdeui/widgets/kdateedit.h PRE-CREATION /trunk/KDE/kdelibs/kdeui/widgets/kdateedit.cpp PRE-CREATION /trunk/KDE/kdelibs/kdeui/widgets/kdatepickerpopup.h PRE-CREATION /trunk/KDE/kdelibs/kdeui/widgets/kdatepickerpopup.cpp PRE-CREATION /trunk/KDE/kdelibs/kdeui/widgets/kdatetable.h 1201925 /trunk/KDE/kdelibs/kdeui/widgets/kdatetable.cpp 1201925 /trunk/KDE/kdelibs/kdeui/widgets/kdatevalidator.h PRE-CREATION /trunk/KDE/kdelibs/kdeui/widgets/kdatevalidator.cpp PRE-CREATION /trunk/KDE/kdelibs/kdeui/widgets/kdatevalidator_p.h PRE-CREATION Diff: http://svn.reviewboard.kde.org/r/6014/diff Testing --- Thanks, Kevin
Re: Helping libraries load their own translation catalogs
A Diumenge, 28 de novembre de 2010, Albert Astals Cid va escriure: A Diumenge, 28 de novembre de 2010, Ivan Cukic va escriure: On Monday, 22. November 2010. 19.05.45 Albert Astals Cid wrote: A Dilluns, 22 de novembre de 2010, David Faure va escriure: On Sunday 21 November 2010, Oswald Buddenhagen wrote: On Sun, Nov 21, 2010 at 12:46:53AM +, Albert Astals Cid wrote: It achieves that by creating a static that instructs KGlobal to load a given translation catalog on global locale creation. Just to note that this fails for catalogs that have a dash in their name Wops, that's too bad. Unless someone with more knowledge than me is able to fix my macro i'm suggesting the attached patch. It breaks current users of K_CATALOG_LOADER, but according lxr.kde.org there is none at the moment so it's not a big deal i guess :D Comments? I've commited my change. Albert Albert Cheerio
Re: Review Request: Adds method to KBookmarkManager disable showing dialogs on errors.
On 2010-11-29 00:08:22, Albert Astals Cid wrote: Why did you change the if/else logic? Also you added another kError when there was an existing one already. Also as commented on IRC maybe it would make sense to emit a signal to warn whoever might be interested that an error happened Matthias Fuchs wrote: I changed that to always have a useful debug output. The second one is there to make it easier if there are bug reports, as it is hard to work with translated messages, especially if they are quite important. So not the whole message is translated, probably I should us an error code there, as file.errorString() is translated. Btw. on the signal. Should it just be an void error() signal or a void error(translatedErrorMessage) one? - Matthias --- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/6004/#review9034 --- On 2010-11-28 21:00:30, Matthias Fuchs wrote: --- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/6004/ --- (Updated 2010-11-28 21:00:30) Review request for kdelibs and David Faure. Summary --- Adds method to KBookmarkManager disable showing dialogs on errors. This way it is possible to deactivate those messages if KBoomarkManager is not run in the gui thread. BUG:207592 Diffs - /trunk/KDE/kdelibs/kio/bookmarks/kbookmarkmanager.h 1201809 /trunk/KDE/kdelibs/kio/bookmarks/kbookmarkmanager.cc 1201809 Diff: http://svn.reviewboard.kde.org/r/6004/diff Testing --- Thanks, Matthias
Re: Review Request: Adds method to KBookmarkManager disable showing dialogs on errors.
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/6004/ --- (Updated 2010-11-30 20:57:03.986026) Review request for kdelibs and David Faure. Changes --- Messed up the last diff, this one is correct now. Summary --- Adds method to KBookmarkManager disable showing dialogs on errors. This way it is possible to deactivate those messages if KBoomarkManager is not run in the gui thread. BUG:207592 This addresses bug 207592. https://bugs.kde.org/show_bug.cgi?id=207592 Diffs (updated) - /trunk/KDE/kdelibs/kio/bookmarks/kbookmarkmanager.h 1202414 /trunk/KDE/kdelibs/kio/bookmarks/kbookmarkmanager.cc 1202414 Diff: http://svn.reviewboard.kde.org/r/6004/diff Testing --- Thanks, Matthias
Re: Review Request: Adding net usershare suport for KSambaShare
On 2010-11-19 02:36:54, Raphael Kubo da Costa wrote: I think we're finally getting there :) dfaure might know better about the KDirWatch stuff; apart from that, the appropriate @since tags need to be added, as well as the missing method apidox. After that it's probably r+ from me. \o/ - Rodrigo --- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/4320/#review8836 --- On 2010-12-01 01:56:04, Rodrigo Belem wrote: --- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/4320/ --- (Updated 2010-12-01 01:56:04) Review request for kdelibs, Raphael Kubo da Costa, Jonathan Thomas, Aurélien Gâteau, Jonathan Riddell, Adenilson Cavalcanti, loureiro, and Daniel Nicoletti. Summary --- KDE needs to support modern samba tools. With the net usershare command line tool the users can manage their shares. The attached patch intends to add support for this tool. Diffs - /trunk/KDE/kdelibs/includes/CMakeLists.txt 1202449 /trunk/KDE/kdelibs/includes/KSambaShareData PRE-CREATION /trunk/KDE/kdelibs/kio/CMakeLists.txt 1202449 /trunk/KDE/kdelibs/kio/kio/ksambashare.h 1202449 /trunk/KDE/kdelibs/kio/kio/ksambashare.cpp 1202449 /trunk/KDE/kdelibs/kio/kio/ksambashare_p.h PRE-CREATION /trunk/KDE/kdelibs/kio/kio/ksambasharedata.h PRE-CREATION /trunk/KDE/kdelibs/kio/kio/ksambasharedata.cpp PRE-CREATION /trunk/KDE/kdelibs/kio/kio/ksambasharedata_p.h PRE-CREATION Diff: http://svn.reviewboard.kde.org/r/4320/diff Testing --- Thanks, Rodrigo
