Re: Review Request: KActivities requires Soprano 2.7 to compile
On Nov. 7, 2011, 3:56 p.m., Ralf Jung wrote: Any comment on this? The patch looks trivial, but I am still new to all this so I'd prefer if someone could confirm that KActivites can and should actually require Soprano 2.7. it builds here with 2.6.51. so 2.7 is not required, but perhaps some patch level version of 2.6. in any case, this CMakeLists.txt file should not be requiring 2.7 as it isn't actually required. - Aaron J. --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102893/#review7993 --- On Oct. 16, 2011, 10:29 a.m., Ralf Jung wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102893/ --- (Updated Oct. 16, 2011, 10:29 a.m.) Review request for kdelibs. Description --- I tried compiling KActivities with Soprano 2.6 installed, which resulted in compile errors. After upgrading to Soprano 2.7, these were fixed. I assume this means that KActivities actually requires Soprano 2.7? If that's the case, IMHO attached patch should be applied to detect that at cmake-time. (I also hope this is the right list, there is no kactivities group in reviewboard) Diffs - service/CMakeLists.txt 5489b6b Diff: http://git.reviewboard.kde.org/r/102893/diff/diff Testing --- compile-tested Thanks, Ralf Jung
Re: New Feature for kdelibs (Was: The case for a kdelibs 4.8)
On Monday, November 7, 2011 19:32:15 Dawit A wrote: Well this is over a month too late, but I have a enhancement change for kcookiejar that needs to go into kdelibs/kioslave for KDE 4.8. The patch has actually been pending for a merge since KDE 4.6. See https://bugs.kde.org/show_bug.cgi?id=54300. ... Right. The patch simply moves the idea of session cookies from being a global configuration option to a site specific option. That is it gets rid of the all or nothing approach currently employed. That gives the user a lot more control of how they deal with cookies. can you explain why it must go into 4.8? it's been waiting since 4.6, and i didn't find a description of what requires it in 4.8 ... as far as i can see, it's a feature enhancement that isn't strictly required by anything (though it is very nice to have indeed), so it should go into the frameworks branch. -- Aaron J. Seigo humru othro a kohnu se GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA EE75 D6B7 2EB1 A7F1 DB43 KDE core developer sponsored by Qt Development Frameworks signature.asc Description: This is a digitally signed message part.
Re: Review request for KSecretsService components
Hello Again, The freeze will come in less thant two days now and I'd like to know if anyone reviewed these components. Thanks, On 10/31/2011 11:48 PM, Valentin Rusu wrote: Hello, Please be advised three repostories need review before integration into the next release: 1. /kdereview/ksecretservice 2. kdelibs branch ksecretsservice 3. /kdereview/ksecrets *1. /kdereview/ksecretservice* The first one has several subdirectories. The only relevant one is the daemon subdirectory. Other directories contents was already moved to other repositories (see below). This daemon directory contains the sources of the future kde-runtime/ksecretsserviced It needs testing but it's quite usable. *2. kdelibs branch ksecretsservice* kdelibs/kdeui/ksecretsservice This is the API KDE applications will be supposed to use instead of KWallet class. Tools listed below already use this API. kdelibs/kdeui/util/kwallet.cpp Contains code depending on a configuration flag that directs calls to ksecretsserviced instead of kwalletd, via the new API. *3. /kdereview/ksecrets* Contains several tools in a less or more mature state: a. kwl2kss - tool to import kwallet files to ksecretsservice, b. ksecrets - tool to list the contents of a ksecretsservice collection (e.g. wallet), c. kio - KIO slave in a just started state, intended to show collections in konqueror or dolphin, d. secretsync - this was the tool I initially wanted to do for KWallet, but drought me into ksecretsservice :-) It's half way implemented. The mandatory components for next release would be 1, 2, 3 (a, b), the others may wait, but releasing them may cause no harm if communication is done right (I'll take care of that). Thanks for your comments (any comments), -- Valentin Rusu (IRC valir, KDE vrusu) KSecretsService (former KSecretService, KWallet replacement)
Review Request: Fix crash when zombie taskbar buttons are left
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103085/ --- Review request for KDE Runtime and Craig Drummond. Description --- This fixes a crash I had in the following scenario: - Launched Thunderbird, the opened it's address book, creating a second taskbar icon for it, after the main Thunderbird one, - Close the address book - the taskbar button stayed there, despite corresponding window has gone, - Launch another application - crash Thread 1 (Thread 0x7f2c87270760 (LWP 1206)): [KCrash Handler] #6 0x7f2c8383d965 in raise () from /lib/libc.so.6 #7 0x7f2c8383eddb in abort () from /lib/libc.so.6 #8 0x7f2c8587aff3 in qt_message_output (msgType=QtFatalMsg, buf=0x31b7478 ASSERT: \pid != 0\ in file /home/kde/src/kde-workspace/libs/ksysguard/processcore/processes_linux_p.cpp, line 188) at global/qglobal.cpp:2255 #9 0x7f2c8587b166 in qt_message(QtMsgType, const char *, typedef __va_list_tag __va_list_tag *) (msgType=QtFatalMsg, msg=0x7f2c85a3c728 ASSERT: \%s\ in file %s, line %d, ap=0x7fff0c2c2178) at global/qglobal.cpp:2301 #10 0x7f2c8587b8f6 in qFatal (msg=0x7f2c85a3c728 ASSERT: \%s\ in file %s, line %d) at global/qglobal.cpp:2484 #11 0x7f2c8587abb8 in qt_assert (assertion=0x7f2c670817e5 pid != 0, file=0x7f2c67081798 /home/kde/src/kde-workspace/libs/ksysguard/processcore/processes_linux_p.cpp, line=188) at global/qglobal.cpp:1999 #12 0x7f2c670767cc in KSysGuard::ProcessesLocal::getParentPid (this=0x31b7610, pid=0) at /home/kde/src/kde-workspace/libs/ksysguard/processcore/processes_linux_p.cpp:188 #13 0x7f2c67070fad in KSysGuard::Processes::updateOrAddProcess (this=0x7fff0c2c2370, pid=0) at /home/kde/src/kde-workspace/libs/ksysguard/processcore/processes.cpp:291 #14 0x7f2c672e1481 in TaskManager::getServicesViaPid (pid=0) at /home/kde/src/kde-workspace/libs/taskmanager/taskitem.cpp:433 #15 0x7f2c672e32ca in TaskManager::TaskItem::launcherUrl (this=0x38c1c80) at /home/kde/src/kde-workspace/libs/taskmanager/taskitem.cpp:612 #16 0x7f2c672e07b2 in TaskManager::TaskItem::taskName (this=0x38c1c80) at /home/kde/src/kde-workspace/libs/taskmanager/taskitem.cpp:196 #17 0x7f2c672c9bc9 in TaskManager::AlphaSortingStrategy::sortItems (this=0x28b9ac0, items=...) at /home/kde/src/kde-workspace/libs/taskmanager/strategies/alphasortingstrategy.cpp:89 #18 0x7f2c672b7c1a in TaskManager::AbstractSortingStrategy::check (this=0x28b9ac0, itemToCheck=0x38c1c80) at /home/kde/src/kde-workspace/libs/taskmanager/abstractsortingstrategy.cpp:145 #19 0x7f2c672b7a54 in TaskManager::AbstractSortingStrategy::handleItem (this=0x28b9ac0, item=0x38c1c80) at /home/kde/src/kde-workspace/libs/taskmanager/abstractsortingstrategy.cpp:115 #20 0x7f2c672b7efb in TaskManager::AbstractSortingStrategy::qt_static_metacall (_o=0x28b9ac0, _c=QMetaObject::InvokeMetaMethod, _id=0, _a=0x7fff0c2c30d0) at /home/kde/src/superbuild/kdebase/build/Build/kde-workspace/libs/taskmanager/abstractsortingstrategy.moc:55 #21 0x7f2c859d75fa in QMetaObject::activate (sender=0x28bd590, m=0x7f2c67517280, local_signal_index=1, argv=0x7fff0c2c30d0) at kernel/qobject.cpp:3546 #22 0x7f2c672df1ef in TaskManager::TaskGroup::itemAdded (this=0x28bd590, _t1=0x38c1c80) at /home/kde/src/superbuild/kdebase/build/Build/kde-workspace/libs/taskmanager/taskgroup.moc:187 #23 0x7f2c672dc8a0 in TaskManager::TaskGroup::add (this=0x28bd590, item=0x38c1c80, insertIndex=-1) at /home/kde/src/kde-workspace/libs/taskmanager/taskgroup.cpp:250 #24 0x7f2c672ce28e in TaskManager::ManualGroupingStrategy::handleItem (this=0x28b98d0, item=0x38c1c80) at /home/kde/src/kde-workspace/libs/taskmanager/strategies/manualgroupingstrategy.cpp:125 #25 0x7f2c672b93cc in TaskManager::GroupManagerPrivate::addTask (this=0x28aab40, task=...) at /home/kde/src/kde-workspace/libs/taskmanager/groupmanager.cpp:349 #26 0x7f2c672beb77 in TaskManager::GroupManager::qt_static_metacall (_o=0x28aa9b0, _c=QMetaObject::InvokeMetaMethod, _id=10, _a=0x7fff0c2c34e0) at /home/kde/src/superbuild/kdebase/build/Build/kde-workspace/libs/taskmanager/groupmanager.moc:90 #27 0x7f2c859d75fa in QMetaObject::activate (sender=0x28aa6f0, m=0x7f2c67517640, local_signal_index=0, argv=0x7fff0c2c34e0) at kernel/qobject.cpp:3546 #28 0x7f2c672e7649 in TaskManager::TaskManager::taskAdded (this=0x28aa6f0, _t1=...) at /home/kde/src/superbuild/kdebase/build/Build/kde-workspace/libs/taskmanager/taskmanager.moc:188 #29 0x7f2c672e613d in TaskManager::TaskManager::windowAdded (this=0x28aa6f0, w=96469055) at /home/kde/src/kde-workspace/libs/taskmanager/taskmanager.cpp:292 #30 0x7f2c672e7273 in TaskManager::TaskManager::qt_static_metacall (_o=0x28aa6f0, _c=QMetaObject::InvokeMetaMethod, _id=7, _a=0x7fff0c2c37a0) at
Re: Review Request: Fix crash when zombie taskbar buttons are left
On Nov. 8, 2011, 9:01 p.m., Craig Drummond wrote: Ship It! Really KSysGuard::ProcessesLocal::getParentPid should be fixed to not crash when passed pid of 0. Also, a similar fix will be needed in getServiceLauncherUrl - Craig --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103085/#review8032 --- On Nov. 8, 2011, 8:57 p.m., Valentin Rusu wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103085/ --- (Updated Nov. 8, 2011, 8:57 p.m.) Review request for KDE Runtime and Craig Drummond. Description --- This fixes a crash I had in the following scenario: - Launched Thunderbird, the opened it's address book, creating a second taskbar icon for it, after the main Thunderbird one, - Close the address book - the taskbar button stayed there, despite corresponding window has gone, - Launch another application - crash Thread 1 (Thread 0x7f2c87270760 (LWP 1206)): [KCrash Handler] #6 0x7f2c8383d965 in raise () from /lib/libc.so.6 #7 0x7f2c8383eddb in abort () from /lib/libc.so.6 #8 0x7f2c8587aff3 in qt_message_output (msgType=QtFatalMsg, buf=0x31b7478 ASSERT: \pid != 0\ in file /home/kde/src/kde-workspace/libs/ksysguard/processcore/processes_linux_p.cpp, line 188) at global/qglobal.cpp:2255 #9 0x7f2c8587b166 in qt_message(QtMsgType, const char *, typedef __va_list_tag __va_list_tag *) (msgType=QtFatalMsg, msg=0x7f2c85a3c728 ASSERT: \%s\ in file %s, line %d, ap=0x7fff0c2c2178) at global/qglobal.cpp:2301 #10 0x7f2c8587b8f6 in qFatal (msg=0x7f2c85a3c728 ASSERT: \%s\ in file %s, line %d) at global/qglobal.cpp:2484 #11 0x7f2c8587abb8 in qt_assert (assertion=0x7f2c670817e5 pid != 0, file=0x7f2c67081798 /home/kde/src/kde-workspace/libs/ksysguard/processcore/processes_linux_p.cpp, line=188) at global/qglobal.cpp:1999 #12 0x7f2c670767cc in KSysGuard::ProcessesLocal::getParentPid (this=0x31b7610, pid=0) at /home/kde/src/kde-workspace/libs/ksysguard/processcore/processes_linux_p.cpp:188 #13 0x7f2c67070fad in KSysGuard::Processes::updateOrAddProcess (this=0x7fff0c2c2370, pid=0) at /home/kde/src/kde-workspace/libs/ksysguard/processcore/processes.cpp:291 #14 0x7f2c672e1481 in TaskManager::getServicesViaPid (pid=0) at /home/kde/src/kde-workspace/libs/taskmanager/taskitem.cpp:433 #15 0x7f2c672e32ca in TaskManager::TaskItem::launcherUrl (this=0x38c1c80) at /home/kde/src/kde-workspace/libs/taskmanager/taskitem.cpp:612 #16 0x7f2c672e07b2 in TaskManager::TaskItem::taskName (this=0x38c1c80) at /home/kde/src/kde-workspace/libs/taskmanager/taskitem.cpp:196 #17 0x7f2c672c9bc9 in TaskManager::AlphaSortingStrategy::sortItems (this=0x28b9ac0, items=...) at /home/kde/src/kde-workspace/libs/taskmanager/strategies/alphasortingstrategy.cpp:89 #18 0x7f2c672b7c1a in TaskManager::AbstractSortingStrategy::check (this=0x28b9ac0, itemToCheck=0x38c1c80) at /home/kde/src/kde-workspace/libs/taskmanager/abstractsortingstrategy.cpp:145 #19 0x7f2c672b7a54 in TaskManager::AbstractSortingStrategy::handleItem (this=0x28b9ac0, item=0x38c1c80) at /home/kde/src/kde-workspace/libs/taskmanager/abstractsortingstrategy.cpp:115 #20 0x7f2c672b7efb in TaskManager::AbstractSortingStrategy::qt_static_metacall (_o=0x28b9ac0, _c=QMetaObject::InvokeMetaMethod, _id=0, _a=0x7fff0c2c30d0) at /home/kde/src/superbuild/kdebase/build/Build/kde-workspace/libs/taskmanager/abstractsortingstrategy.moc:55 #21 0x7f2c859d75fa in QMetaObject::activate (sender=0x28bd590, m=0x7f2c67517280, local_signal_index=1, argv=0x7fff0c2c30d0) at kernel/qobject.cpp:3546 #22 0x7f2c672df1ef in TaskManager::TaskGroup::itemAdded (this=0x28bd590, _t1=0x38c1c80) at /home/kde/src/superbuild/kdebase/build/Build/kde-workspace/libs/taskmanager/taskgroup.moc:187 #23 0x7f2c672dc8a0 in TaskManager::TaskGroup::add (this=0x28bd590, item=0x38c1c80, insertIndex=-1) at /home/kde/src/kde-workspace/libs/taskmanager/taskgroup.cpp:250 #24 0x7f2c672ce28e in TaskManager::ManualGroupingStrategy::handleItem (this=0x28b98d0, item=0x38c1c80) at /home/kde/src/kde-workspace/libs/taskmanager/strategies/manualgroupingstrategy.cpp:125 #25 0x7f2c672b93cc in TaskManager::GroupManagerPrivate::addTask (this=0x28aab40, task=...) at /home/kde/src/kde-workspace/libs/taskmanager/groupmanager.cpp:349 #26 0x7f2c672beb77 in TaskManager::GroupManager::qt_static_metacall (_o=0x28aa9b0, _c=QMetaObject::InvokeMetaMethod, _id=10, _a=0x7fff0c2c34e0) at /home/kde/src/superbuild/kdebase/build/Build/kde-workspace/libs/taskmanager/groupmanager.moc:90 #27 0x7f2c859d75fa in QMetaObject::activate
Re: Review Request: Fix crash when zombie taskbar buttons are left
On Nov. 8, 2011, 9:01 p.m., Craig Drummond wrote: Ship It! Craig Drummond wrote: Really KSysGuard::ProcessesLocal::getParentPid should be fixed to not crash when passed pid of 0. Also, a similar fix will be needed in getServiceLauncherUrl Ok, I also fixed getServiceLauncherUrl - Valentin --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103085/#review8032 --- On Nov. 8, 2011, 8:57 p.m., Valentin Rusu wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103085/ --- (Updated Nov. 8, 2011, 8:57 p.m.) Review request for KDE Runtime and Craig Drummond. Description --- This fixes a crash I had in the following scenario: - Launched Thunderbird, the opened it's address book, creating a second taskbar icon for it, after the main Thunderbird one, - Close the address book - the taskbar button stayed there, despite corresponding window has gone, - Launch another application - crash Thread 1 (Thread 0x7f2c87270760 (LWP 1206)): [KCrash Handler] #6 0x7f2c8383d965 in raise () from /lib/libc.so.6 #7 0x7f2c8383eddb in abort () from /lib/libc.so.6 #8 0x7f2c8587aff3 in qt_message_output (msgType=QtFatalMsg, buf=0x31b7478 ASSERT: \pid != 0\ in file /home/kde/src/kde-workspace/libs/ksysguard/processcore/processes_linux_p.cpp, line 188) at global/qglobal.cpp:2255 #9 0x7f2c8587b166 in qt_message(QtMsgType, const char *, typedef __va_list_tag __va_list_tag *) (msgType=QtFatalMsg, msg=0x7f2c85a3c728 ASSERT: \%s\ in file %s, line %d, ap=0x7fff0c2c2178) at global/qglobal.cpp:2301 #10 0x7f2c8587b8f6 in qFatal (msg=0x7f2c85a3c728 ASSERT: \%s\ in file %s, line %d) at global/qglobal.cpp:2484 #11 0x7f2c8587abb8 in qt_assert (assertion=0x7f2c670817e5 pid != 0, file=0x7f2c67081798 /home/kde/src/kde-workspace/libs/ksysguard/processcore/processes_linux_p.cpp, line=188) at global/qglobal.cpp:1999 #12 0x7f2c670767cc in KSysGuard::ProcessesLocal::getParentPid (this=0x31b7610, pid=0) at /home/kde/src/kde-workspace/libs/ksysguard/processcore/processes_linux_p.cpp:188 #13 0x7f2c67070fad in KSysGuard::Processes::updateOrAddProcess (this=0x7fff0c2c2370, pid=0) at /home/kde/src/kde-workspace/libs/ksysguard/processcore/processes.cpp:291 #14 0x7f2c672e1481 in TaskManager::getServicesViaPid (pid=0) at /home/kde/src/kde-workspace/libs/taskmanager/taskitem.cpp:433 #15 0x7f2c672e32ca in TaskManager::TaskItem::launcherUrl (this=0x38c1c80) at /home/kde/src/kde-workspace/libs/taskmanager/taskitem.cpp:612 #16 0x7f2c672e07b2 in TaskManager::TaskItem::taskName (this=0x38c1c80) at /home/kde/src/kde-workspace/libs/taskmanager/taskitem.cpp:196 #17 0x7f2c672c9bc9 in TaskManager::AlphaSortingStrategy::sortItems (this=0x28b9ac0, items=...) at /home/kde/src/kde-workspace/libs/taskmanager/strategies/alphasortingstrategy.cpp:89 #18 0x7f2c672b7c1a in TaskManager::AbstractSortingStrategy::check (this=0x28b9ac0, itemToCheck=0x38c1c80) at /home/kde/src/kde-workspace/libs/taskmanager/abstractsortingstrategy.cpp:145 #19 0x7f2c672b7a54 in TaskManager::AbstractSortingStrategy::handleItem (this=0x28b9ac0, item=0x38c1c80) at /home/kde/src/kde-workspace/libs/taskmanager/abstractsortingstrategy.cpp:115 #20 0x7f2c672b7efb in TaskManager::AbstractSortingStrategy::qt_static_metacall (_o=0x28b9ac0, _c=QMetaObject::InvokeMetaMethod, _id=0, _a=0x7fff0c2c30d0) at /home/kde/src/superbuild/kdebase/build/Build/kde-workspace/libs/taskmanager/abstractsortingstrategy.moc:55 #21 0x7f2c859d75fa in QMetaObject::activate (sender=0x28bd590, m=0x7f2c67517280, local_signal_index=1, argv=0x7fff0c2c30d0) at kernel/qobject.cpp:3546 #22 0x7f2c672df1ef in TaskManager::TaskGroup::itemAdded (this=0x28bd590, _t1=0x38c1c80) at /home/kde/src/superbuild/kdebase/build/Build/kde-workspace/libs/taskmanager/taskgroup.moc:187 #23 0x7f2c672dc8a0 in TaskManager::TaskGroup::add (this=0x28bd590, item=0x38c1c80, insertIndex=-1) at /home/kde/src/kde-workspace/libs/taskmanager/taskgroup.cpp:250 #24 0x7f2c672ce28e in TaskManager::ManualGroupingStrategy::handleItem (this=0x28b98d0, item=0x38c1c80) at /home/kde/src/kde-workspace/libs/taskmanager/strategies/manualgroupingstrategy.cpp:125 #25 0x7f2c672b93cc in TaskManager::GroupManagerPrivate::addTask (this=0x28aab40, task=...) at /home/kde/src/kde-workspace/libs/taskmanager/groupmanager.cpp:349 #26 0x7f2c672beb77 in TaskManager::GroupManager::qt_static_metacall (_o=0x28aa9b0, _c=QMetaObject::InvokeMetaMethod, _id=10, _a=0x7fff0c2c34e0) at
