Re: Review Request: udev PortableMediaPlayer: read protocols from media-player-info; docs
On Nov. 20, 2011, 3:37 a.m., Alex Fiestas wrote:
solid/solid/CMakeLists.txt, line 82
http://git.reviewboard.kde.org/r/103028/diff/1/?file=40291#file40291line82
I can understand the copy/paste of this file, but do we need all of it?
I'd rather keep only what we need and document that we copy/pasted it from
kdelibs etc
It's actually already trimmed down (I think to the minimum needed). There
should probably be a comment saying where it was from, though (akonadi; the
libs directory).
- Alex
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103028/#review8329
---
On Nov. 5, 2011, 4:47 p.m., Matěj Laitl wrote:
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103028/
---
(Updated Nov. 5, 2011, 4:47 p.m.)
Review request for kdelibs.
Description
---
This is a second attempt at implementing PortableMediaPlayer for udev
back-end using media-player-info [3], the first attempt was [2] by
Alex Merry and this patch is heavily based on it. This patch relates to
a discussion at [1] and is just a first step, the second would
be to forward PMP interface from udev backed to udisks backed somehow
(udisks...Device interface provides NativePath attribute that links to
sysfs path that can help - on Linux)
[1] http://mail.kde.org/pipermail/kde-hardware-devel/2011-October/001481.html
[2] https://svn.reviewboard.kde.org/r/5853/
[3] http://www.freedesktop.org/wiki/Software/media-player-info
Care is taken not to change existing behaviour - e.g. when udev env
ID_MEDIA_PLAYER equals 1, behaviour is unchanged.
TODO: announce runtime-only media-player-info dependency for solid and
add it to build instructions. libmtp = 1.0.4 is also needed at
runtime for detection of MTP devices to work. usbmuxd (dependency
of libimobiledevice) is needed at runtime for detection of Apple
iOS devices.
TODO: what about windows support?
The patch is against kdelibs KDE/4.7 branch, please forward-port.
CCBUG: 253671 # does not solve it yet, but is a first step
CCBUG: 269447
CCBUG: 269451
REVIEW: 103028
DIGEST: groundwork for better media device player detection
CCMAIL: amarok-de...@kde.org
Diffs
-
solid/solid/CMakeLists.txt 1a4adfa
solid/solid/backends/udev/udevdevice.cpp d6c7fb4
solid/solid/backends/udev/udevmanager.cpp 55e655b
solid/solid/backends/udev/udevportablemediaplayer.h e0348aa
solid/solid/backends/udev/udevportablemediaplayer.cpp 32a1893
solid/solid/ifaces/portablemediaplayer.h a73120a
solid/solid/xdgbasedirs.cpp PRE-CREATION
solid/solid/xdgbasedirs_p.h PRE-CREATION
Diff: http://git.reviewboard.kde.org/r/103028/diff/diff
Testing
---
1. connect iPod
2. works:
$ solid-hardware details
/org/kde/solid/udev/sys/devices/pci:00/:00:1d.0/usb2/2-1/2-1.2/2-1.2:1.0/host6/target6:0:0/6:0:0:0/block/sdc
udi =
'/org/kde/solid/udev/sys/devices/pci:00/:00:1d.0/usb2/2-1/2-1.2/2-1.2:1.0/host6/target6:0:0/6:0:0:0/block/sdc'
parent = '/org/kde/solid/udev' (string)
vendor = 'Apple' (string)
product = 'iPod' (string)
description = 'Portable Media Player' (string)
Block.major = 8 (0x8) (int)
Block.minor = 32 (0x20) (int)
Block.device = '/dev/sdc' (string)
PortableMediaPlayer.supportedProtocols = {'storage', 'ipod'} (string list)
PortableMediaPlayer.supportedDrivers = {'usb'} (string list)
3. not yet:
$ solid-hardware details /org/freedesktop/UDisks/devices/sdc1
udi = '/org/freedesktop/UDisks/devices/sdc1'
parent = '/org/freedesktop/UDisks/devices/sdc' (string)
vendor = 'Apple' (string)
product = 'MATOUSUV IP' (string)
description = 'MATOUSUV IP' (string)
Block.major = 8 (0x8) (int)
Block.minor = 33 (0x21) (int)
Block.device = '/dev/sdc1' (string)
StorageAccess.accessible = true (bool)
StorageAccess.filePath = '/media/MATOUSUV IP' (string)
StorageAccess.ignored = false (bool)
StorageVolume.ignored = false (bool)
StorageVolume.usage = 'FileSystem' (0x2) (enum)
StorageVolume.fsType = 'vfat' (string)
StorageVolume.label = 'MATOUSUV IP' (string)
StorageVolume.uuid = '3141-5926' (string)
StorageVolume.size = 7888957440 (0x1d637f000) (qulonglong)
Thanks,
Matěj Laitl
Re: Date for IRC meeting about
Am Sonntag 20 November 2011, 20.08:11 schrieb Alexander Neundorf: Morning First: I'm subscribed to both lists so no need to CC: me. According to our Doodle [1] we found a date which works for everybody, great! It's Sunday, the 4th of December at 20:00 (UTC). Just to make sure: that's 21:00 CET (german) time, right ? Yes that's right. For other time zones here is a link to a tz converter: http://www.timeanddate.com/worldclock/converter.html Which channel, actually ? Sorry, forgot this: #kde-devel Do we have/need something like an agenda ? I think there will be an more precise agenda but this is not done by me (who is just a helper) but by some frameworks developers. thx Mario
Re: Review Request: Provide extra options for date keyword display in KDateComboBox
On Nov. 20, 2011, 10:07 p.m., Albert Astals Cid wrote: This patch modifies the behaviour, maybe it is better if you change KDateComboBox::NoneKeyword to KDateComboBox::NoNoneKeyword And adapt the if accordingly? This way there is no behaviour change at all and makes old users still work. This class was rushed in at the last moment for KDE 4.7, and I doubt whether this particular behaviour is really right, or that many applications will want it. So although it is a minor change in behaviour, I would see it as rectifying a mistake. The function to select a blank date is already there via the clear button in the edit field anyway, so the change only removes the duplication of a feature. - David --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103103/#review8351 --- On Nov. 10, 2011, 12:36 a.m., David Jarvie wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103103/ --- (Updated Nov. 10, 2011, 12:36 a.m.) Review request for kdelibs and John Layt. Description --- KDateComboBox provides the option to display a list of date keywords with the date picker popup. These keywords currently show dates in the past, present and future, together with a no date item. The no date item is a particular problem since not only is it redundant - since there is already a button in the line edit to clear the date value - but I suspect that many applications will not accept a blank date as valid input. This patch adds two new enum values to allow applications to select which of these date keywords are displayed: one enum value shows the no date item which is now not shown by default, and another enum value hides dates in the past. Currently in KAlarm, which I maintain, the display of date keywords is disabled because dates in the past and blank dates are not valid values to enter, and it would be confusing to users to offer them as options. This patch will make it possible to display only present and future date keywords, which will enable it to make use of date keywords. Diffs - kdeui/widgets/kdatecombobox.h 63bf52f kdeui/widgets/kdatecombobox.cpp fc239bc Diff: http://git.reviewboard.kde.org/r/103103/diff/diff Testing --- Tested in KAlarm. Thanks, David Jarvie
Right location for test config files?
In regards to defect below, what's the right location for some xml files I use in keyboard daemon tests? Currently the files I have is to test the code for parsing /usr/share/X11/xkb/rules/evdev.xml but some others could be added later... I tried to find other tests in kde-workspace but none of them seem to use non-program files. Thanks, Andriy Original Message Subject: [Bug 287212] kcontrol installs keyboard test files in wrong location Date: Tue, 22 Nov 2011 00:31:12 + From: Christoph Feck christ...@maxiom.de Reply-To: bug-cont...@bugs.kde.org To: ary...@gmail.com https://bugs.kde.org/show_bug.cgi?id=287212 Christoph Feckchrist...@maxiom.de changed: What|Removed |Added Component|general |kcm_keyboard AssignedTo|sourtooth+ssb...@gmail.com |ary...@gmail.com -- Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug.
Requesting freeze exception for JtG
Hi, Last weekend we had the KDE eV Sprint at Berlin. For various reasons, financial mainly, it was clear we need to raise visibility of the Join the Game campaign in order to get more users to sign up. One of the decisions taken was to add a bit of the Join the Game text to KDE applications. Screenshots available here: http://www.elpauer.org/help-jtg/ To avoid confusion with the Join the Game program, there are slight changes in About KDE: Join KDE and Support KDE have been relabeled to Get involved and Donate respectively. Why is it important that we get this in now? - Because 4.8 is probably the last release before 5.0 - Given our history with 4.0, I wouldn't be surprised if users and distributions avoid 5.0 as the default, or even altogether - This means either the Join the Game propaganda goes in for 4.8, or it will not arrive to our users before 18-24 months (~12 months till 5.0 + 6 months for 5.1 + distributions delay + ...). No matter how optimistic we are about releasing 5.0 soon, history shows there are always delays. - We cannot wait 18 months There are no API changes involved. This is not exactly a feature either. Code is available in the origin-KDE/4.7 branch here: g...@git.kde.org:/clones/kdelibs/pgquiles/kdelibs-jointhegame.git If you'd rather see it in web: http://quickgit.kde.org/?p=clones%2Fkdelibs%2Fpgquiles%2Fkdelibs-jointhegame.gita=shortlogh=refs/heads/origin-KDE/4.7 Given that we are already feature frozen, I am hereby requesting a freeze exception for the following: - Adding a new menu subheader (Support KDE: Join the Game) - Adding new dialog with three tabs (KJoinTheGame). The text of these tabs is essentially the same as the first three columns in http://jointhegame.kde.org/ This will require a message freeze exception, which I have already requested. http://lists.kde.org/?l=kde-i18n-docm=132192199114831w=2 -- Pau Garcia i Quiles http://www.elpauer.org (Due to my workload, I may need 10 days to answer)
Review Request: Ensure Plasma Desktop does not crash on exit with Qt 4.8
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103202/ --- Review request for kdelibs and Plasma. Description --- Qt 4.8 contains changes which break qDeleteAll() in certain scenarios. This patch fixes one of those scenarios to ensure that Plasma Desktop does not crash on quit or logout. Diffs - plasma/private/containment_p.h 4025bf4 Diff: http://git.reviewboard.kde.org/r/103202/diff/diff Testing --- Compiled, Plasma Desktop no longer crashes on exit. Thanks, Ben Cooksley
