Review Request: Crash guard for KSelectionProxyModelPrivate::removeRangeFromProxy()
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103421/ --- Review request for kdelibs and Stephen Kelly. Description --- Crash guard for KSelectionProxyModelPrivate::removeRangeFromProxy() occassionally I am encountering asserts or crashes in this method, so this little crash guard avoids those situations Diffs - kdeui/itemviews/kselectionproxymodel.cpp eca2d78 Diff: http://git.reviewboard.kde.org/r/103421/diff/diff Testing --- used locally for about a week and haven't seen crashes in KSelectionProxyModel Thanks, Allen Winter
Review Request: Fix KStatusNotifierItem not updating its icon when set by pixmap
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103425/ --- Review request for kdelibs and Marco Martin. Description --- Set the icon for KStatusNotifierItem by setIconByPixmap(), then by setIconByName(). If setIconByPixmap() is called to set the first icon again, the icon doesn't change. The same bug seems likely to happen with other pairs of icon setting methods. This patch fixes this bug. Diffs - kdeui/notifications/kstatusnotifieritem.cpp aecb81c Diff: http://git.reviewboard.kde.org/r/103425/diff/diff Testing --- Tested switching setIconByPixmap()/setIconByName() in KAlarm. Thanks, David Jarvie
Review Request: Don't set an RPATH when installed into multiarch dir
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103422/ --- Review request for kdelibs. Description --- Don't set an RPATH when installed into a multiarch dir (e.g. /usr/lib/x86_64-linux-gnu). On Debian and Ubuntu /usr/lib/arch are system lib dirs. On a Kubuntu 11.10 system CMAKE_PLATFORM_IMPLICIT_LINK_DIRECTORIES contains /lib /usr/lib /usr/lib32 /usr/lib64 and CMAKE_CXX_IMPLICIT_LINK_DIRECTORIES contains /usr/lib/gcc/x86_64-linux-gnu/4.6.1 /usr/lib/x86_64-linux-gnu /usr/lib /lib/x86_64-linux-gnu /lib Diffs - cmake/modules/FindKDE4Internal.cmake 6d65e61 Diff: http://git.reviewboard.kde.org/r/103422/diff/diff Testing --- Thanks, Felix Geyer
Review Request: Add 20px margin when to info pages generated by kio_info
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103426/ --- Review request for KDE Runtime. Description --- The patch adds a 20 px margin to info pages generated by kio_info to make them easier to read. This addresses bug 230959. http://bugs.kde.org/show_bug.cgi?id=230959 Diffs - kioslave/info/kde-info2html 03ace75 Diff: http://git.reviewboard.kde.org/r/103426/diff/diff Testing --- Tested by displaying info:/make/Goals. Thanks, Dawit Alemayehu
