Re: Review Request: Port shutdown dialog to QML
> On Feb. 6, 2012, 9:38 p.m., Alexander Neundorf wrote: > > Good from my POV (cmake stuff). UI-wise looks also fine. Was there anything else we needed to do? If not, merge to master. Thanks, you rock! - Christoph --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103621/#review10379 --- On Feb. 4, 2012, 2:04 p.m., Lamarque Vieira Souza wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/103621/ > --- > > (Updated Feb. 4, 2012, 2:04 p.m.) > > > Review request for KDE Base Apps and KDE Runtime. > > > Description > --- > > Port shutdown dialog to QML. Two QML themes are included: default, which > mimics the current shutdown dialog look & feel, and contour, which is used in > Plasma Active. > > > This addresses bugs 216853 and 216853. > http://bugs.kde.org/show_bug.cgi?id=216853 > http://bugs.kde.org/show_bug.cgi?id=216853 > > > Diffs > - > > ksmserver/CMakeLists.txt 295b96e > ksmserver/Copyright.txt PRE-CREATION > ksmserver/FindKDeclarative.cmake PRE-CREATION > ksmserver/Messages.sh 0aa8bab > ksmserver/shutdown.cpp 7fd1e11 > ksmserver/shutdowndlg.h e5f0942 > ksmserver/shutdowndlg.cpp a09a1a7 > ksmserver/themes/contour/ContourButton.qml PRE-CREATION > ksmserver/themes/contour/main.qml PRE-CREATION > ksmserver/themes/contour/metadata.desktop PRE-CREATION > ksmserver/themes/contour/screenshot.png PRE-CREATION > ksmserver/themes/default/ContextMenu.qml PRE-CREATION > ksmserver/themes/default/KSMButton.qml PRE-CREATION > ksmserver/themes/default/MenuItem.qml PRE-CREATION > ksmserver/themes/default/helper.js PRE-CREATION > ksmserver/themes/default/main.qml PRE-CREATION > ksmserver/themes/default/metadata.desktop PRE-CREATION > ksmserver/themes/default/screenshot.png PRE-CREATION > > Diff: http://git.reviewboard.kde.org/r/103621/diff/diff > > > Testing > --- > > Works in Plasma Active Two using MeeGo image and KDE SC 4.8. It does not work > in 4.7.x because the default theme requires kde-runtime 4.8's declarative > imports. > > TODO: > > . test right to left language support. > > > Screenshots > --- > > > http://git.reviewboard.kde.org/r/103621/s/400/ > New version with label accelerator working > http://git.reviewboard.kde.org/r/103621/s/407/ > > > Thanks, > > Lamarque Vieira Souza > >
Re: Review Request: Port shutdown dialog to QML
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103621/#review10379 --- Ship it! Good from my POV (cmake stuff). - Alexander Neundorf On Feb. 4, 2012, 2:04 p.m., Lamarque Vieira Souza wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/103621/ > --- > > (Updated Feb. 4, 2012, 2:04 p.m.) > > > Review request for KDE Base Apps and KDE Runtime. > > > Description > --- > > Port shutdown dialog to QML. Two QML themes are included: default, which > mimics the current shutdown dialog look & feel, and contour, which is used in > Plasma Active. > > > This addresses bugs 216853 and 216853. > http://bugs.kde.org/show_bug.cgi?id=216853 > http://bugs.kde.org/show_bug.cgi?id=216853 > > > Diffs > - > > ksmserver/CMakeLists.txt 295b96e > ksmserver/Copyright.txt PRE-CREATION > ksmserver/FindKDeclarative.cmake PRE-CREATION > ksmserver/Messages.sh 0aa8bab > ksmserver/shutdown.cpp 7fd1e11 > ksmserver/shutdowndlg.h e5f0942 > ksmserver/shutdowndlg.cpp a09a1a7 > ksmserver/themes/contour/ContourButton.qml PRE-CREATION > ksmserver/themes/contour/main.qml PRE-CREATION > ksmserver/themes/contour/metadata.desktop PRE-CREATION > ksmserver/themes/contour/screenshot.png PRE-CREATION > ksmserver/themes/default/ContextMenu.qml PRE-CREATION > ksmserver/themes/default/KSMButton.qml PRE-CREATION > ksmserver/themes/default/MenuItem.qml PRE-CREATION > ksmserver/themes/default/helper.js PRE-CREATION > ksmserver/themes/default/main.qml PRE-CREATION > ksmserver/themes/default/metadata.desktop PRE-CREATION > ksmserver/themes/default/screenshot.png PRE-CREATION > > Diff: http://git.reviewboard.kde.org/r/103621/diff/diff > > > Testing > --- > > Works in Plasma Active Two using MeeGo image and KDE SC 4.8. It does not work > in 4.7.x because the default theme requires kde-runtime 4.8's declarative > imports. > > TODO: > > . test right to left language support. > > > Screenshots > --- > > > http://git.reviewboard.kde.org/r/103621/s/400/ > New version with label accelerator working > http://git.reviewboard.kde.org/r/103621/s/407/ > > > Thanks, > > Lamarque Vieira Souza > >
Re: Review Request: Prompt for the folder name when creating one in the sidebar bookmark module
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103845/#review10374 --- This review has been submitted with commit ab4dfb4a5619dd36edb0fc3dd3ec71bb06f2da56 by Dawit Alemayehu to branch master. - Commit Hook On Feb. 2, 2012, 6:20 p.m., Dawit Alemayehu wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/103845/ > --- > > (Updated Feb. 2, 2012, 6:20 p.m.) > > > Review request for KDE Base Apps and David Faure. > > > Description > --- > > The attached patch implemets the TODO about prompting the user for a name > when creating a new bookmark folder in Konqueror's sidebar bookmark widget. > > > This addresses bug 247049. > http://bugs.kde.org/show_bug.cgi?id=247049 > > > Diffs > - > > konqueror/sidebar/trees/bookmark_module/bookmark_module.cpp 23b8e05 > > Diff: http://git.reviewboard.kde.org/r/103845/diff/diff > > > Testing > --- > > Follow the steps outlined in the bug report before and after the patch. > > > Thanks, > > Dawit Alemayehu > >
Re: Review Request: Fix a VLC crash by delaying object deletion to avoid invalid access by QtDBus
On Wednesday 01 February 2012 19:25:13 Dawit A wrote: > On Mon, Jan 30, 2012 at 4:48 AM, Thiago Macieira wrote: > > On Monday, 30 de January de 2012 08.05.50, Cristian Oneț wrote: > >> > Diffs > >> > - > >> > > >> > kio/bookmarks/kbookmarkmanager.cc d8a9cb7 > >> > kio/kio/fileundomanager.cpp f580c29 > >> > kio/kio/scheduler.cpp 6b36d9d > >> > > >> > Diff: http://git.reviewboard.kde.org/r/100577/diff/diff > > > > Do you have a valgrind trace of the problem? > > > > I cannot confirm that the fix is correct or not because I don't know why > > the crash happens. > > I can generate one, but I do not have a debug build of Qt and it takes > way too long to build that on my 6 year old home PC. Wow. We need to resurrect adopt-a-geek (1) and get you a new PC *now* !!! (1): http://devel-home.kde.org/~wheeler/adopt-a-geek/ -- David Faure, fa...@kde.org, http://www.davidfaure.fr Sponsored by Nokia to work on KDE, incl. KDE Frameworks 5
Re: Re: [Kde-pim] Contact Aggregation [was: KDE Telepathy on its way to Extragear]
On Sunday, January 08, 2012 09:46:37 Daniele E. Domenichelli wrote: Heya, Ladies and gents - the reminder I promised to send: this weekend there will be a KDE PIM sprint in Osnabruck. Lets have a Telepath there to finish the contact aggregation discussion... BTW fun meeting some of you at FOSDEM! Good luck with the recovery ;-) Hugs /Jos signature.asc Description: This is a digitally signed message part.
