Review Request: Allow protocol-specialized ThumbCreators to be used for folder previews
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103882/ --- Review request for kdelibs. Description --- The problem is fairly simple: I needed to create previews for directory items in a custom KIO slave. Writing the ThumbCreator was simple. But it got never called. The reason is that the thumbnail kio slave always uses its own directory thumbnailing method for folders if the plugin name is not specified in the metadata. The PreviewJob on the other hand does only specify the plugin metadata field for local ThumbCreators; remote ThumbCreators are only checked for existance. This patch fixes that by first checking for a specialized ThumbCreator plugin by protocol and then falling back to the old way of detection my mime-type. Diffs - kio/kio/previewjob.cpp 5635875 Diff: http://git.reviewboard.kde.org/r/103882/diff/diff Testing --- Tested on my custom KIO slave: perfect thumbnails. Thumbnails for everything else still working fine. Thanks, Sebastian Trueg
Re: [Kde-pim] Contact Aggregation [was: KDE Telepathy on its way to Extragear]
On 07/02/12 10:45, Martin Klapetek wrote: Ladies and gents - the reminder I promised to send: this weekend there will be a KDE PIM sprint in Osnabruck. Lets have a Telepath there to finish the contact aggregation discussion... Unfortunately I can't be there as well... Cheers, Daniele
Re: Re: [Kde-pim] Contact Aggregation [was: KDE Telepathy on its way to Extragear]
On Mon, Feb 6, 2012 at 08:12, Jos Poortvliet j...@opensuse.org wrote: On Sunday, January 08, 2012 09:46:37 Daniele E. Domenichelli wrote: snip stuff from aeons ago Heya, Ladies and gents - the reminder I promised to send: this weekend there will be a KDE PIM sprint in Osnabruck. Lets have a Telepath there to finish the contact aggregation discussion... Unfortunately I'm unable to attend this meeting, though I would absolutely wish I could (as I was the one working on this the most). Time for real-life stuff for a while now. If anyone will be there for KTp team, I can probably give all the needed knowledge in this and I can possibly be an irc-support too. BTW fun meeting some of you at FOSDEM! Good luck with the recovery ;-) Good times. Hugs /Jos -- Martin Klapetek | KDE Developer
Re: Re: [Kde-pim] Contact Aggregation [was: KDE Telepathy on its way to Extragear]
2012/2/7 Martin Klapetek martin.klape...@gmail.com: On Mon, Feb 6, 2012 at 08:12, Jos Poortvliet j...@opensuse.org wrote: On Sunday, January 08, 2012 09:46:37 Daniele E. Domenichelli wrote: snip stuff from aeons ago Heya, Ladies and gents - the reminder I promised to send: this weekend there will be a KDE PIM sprint in Osnabruck. Lets have a Telepath there to finish the contact aggregation discussion... I also cannot make it, I need to be back in England for the Monday and can't risk being late, especially given the current weather conditions. I can, however, be online during most of the weekend for consulting on this topic. You can find me (and probably Martin) in #kde-telepathy or me on XMPP at this address. Unfortunately I'm unable to attend this meeting, though I would absolutely wish I could (as I was the one working on this the most). Time for real-life stuff for a while now. If anyone will be there for KTp team, I can probably give all the needed knowledge in this and I can possibly be an irc-support too. BTW fun meeting some of you at FOSDEM! Good luck with the recovery ;-) Good times. Hugs /Jos -- Martin Klapetek | KDE Developer ___ KDE-Telepathy mailing list kde-telepa...@kde.org https://mail.kde.org/mailman/listinfo/kde-telepathy
Re: [Kde-pim] Contact Aggregation [was: KDE Telepathy on its way to Extragear]
On Tue, Feb 7, 2012 at 11:34, Daniele E. Domenichelli daniele.domeniche...@gmail.com wrote: On 07/02/12 10:45, Martin Klapetek wrote: Ladies and gents - the reminder I promised to send: this weekend there will be a KDE PIM sprint in Osnabruck. Lets have a Telepath there to finish the contact aggregation discussion... Unfortunately I can't be there as well... I would suggest to set up a conference call using Skype, Google+ hangout or something similar (soon hopefully kde-telepathy :P). Me and David can 100% be part of that, others are very welcome to join. Does that sound feasible? -- Martin Klapetek | KDE Developer Cheers, Daniele
Re: Review Request: Port shutdown dialog to QML
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103621/#review10408 --- This review has been submitted with commit 49e65509f9bada70382d2768670a31b568f28ce4 by Lamarque V. Souza to branch master. - Commit Hook On Feb. 4, 2012, 2:04 p.m., Lamarque Vieira Souza wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103621/ --- (Updated Feb. 4, 2012, 2:04 p.m.) Review request for KDE Base Apps and KDE Runtime. Description --- Port shutdown dialog to QML. Two QML themes are included: default, which mimics the current shutdown dialog look feel, and contour, which is used in Plasma Active. This addresses bugs 216853 and 216853. http://bugs.kde.org/show_bug.cgi?id=216853 http://bugs.kde.org/show_bug.cgi?id=216853 Diffs - ksmserver/CMakeLists.txt 295b96e ksmserver/Copyright.txt PRE-CREATION ksmserver/FindKDeclarative.cmake PRE-CREATION ksmserver/Messages.sh 0aa8bab ksmserver/shutdown.cpp 7fd1e11 ksmserver/shutdowndlg.h e5f0942 ksmserver/shutdowndlg.cpp a09a1a7 ksmserver/themes/contour/ContourButton.qml PRE-CREATION ksmserver/themes/contour/main.qml PRE-CREATION ksmserver/themes/contour/metadata.desktop PRE-CREATION ksmserver/themes/contour/screenshot.png PRE-CREATION ksmserver/themes/default/ContextMenu.qml PRE-CREATION ksmserver/themes/default/KSMButton.qml PRE-CREATION ksmserver/themes/default/MenuItem.qml PRE-CREATION ksmserver/themes/default/helper.js PRE-CREATION ksmserver/themes/default/main.qml PRE-CREATION ksmserver/themes/default/metadata.desktop PRE-CREATION ksmserver/themes/default/screenshot.png PRE-CREATION Diff: http://git.reviewboard.kde.org/r/103621/diff/diff Testing --- Works in Plasma Active Two using MeeGo image and KDE SC 4.8. It does not work in 4.7.x because the default theme requires kde-runtime 4.8's declarative imports. TODO: . test right to left language support. Screenshots --- http://git.reviewboard.kde.org/r/103621/s/400/ New version with label accelerator working http://git.reviewboard.kde.org/r/103621/s/407/ Thanks, Lamarque Vieira Souza
