Re: Review Request: Add warning for searching the complete file system

2012-05-04 Thread Andre Heinecke


 On May 3, 2012, 7:35 p.m., Mark Gaiser wrote:
  Let me first say that i have absolutely nothing to say about this. I do 
  have an opinion about this though.
  I would not like this. If i'm searching i just want to search and certainly 
  don't get a dialog just to confirm my search.
  
  Others might think differently though... Perhaps as an option but disabled 
  by default.
 
 Kai Uwe Broulik wrote:
 I guess you should introduce them to Nepomuk and explain them how to 
 efficiently tag their files and find them by their contents instead :P

Thanks for your feedback. I've argued about this with my admins, their 
argumentation was The users that know what they are doing just use find
Their argumentation was: If i use an open razor blade i don't expect a warning 
before I cut my throat. But if i use an electrical shaver i don't expect it to 
cut my throat.


But I'll discard this patch, the warning is just annoying and would not solve 
much. An option to include network file systems (disabled by default) would be 
a better approach to this problem.

Regards


- Andre


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104826/#review13382
---


On May 2, 2012, 7:50 p.m., Andre Heinecke wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 http://git.reviewboard.kde.org/r/104826/
 ---
 
 (Updated May 2, 2012, 7:50 p.m.)
 
 
 Review request for KDE Base Apps.
 
 
 Description
 ---
 
 In my company it regularly happens that some non technical person, e.g. a 
 secretary or a marketing guy tries to find a file he or she has no idea where 
 it is placed.
 When they use kfind to search the complete file system without using locate 
 this pretty much means a DOS attack on our company network with loads of NFS 
 shares etc.
 
 Searching the complete filesystem is nearly always wrong but as users are 
 used to it from Search my Computer or other indexed search options they 
 might not realize it.
 
 This Patch adds a confirmation dialog if you want to search / or file:/// 
 recursively without using locate warning you that this might take a very long 
 time and is a resource intensive operation
 
 
 Diffs
 -
 
   kfind/kfinddlg.cpp 12b3b7e 
   kfind/kquery.h 39609f3 
 
 Diff: http://git.reviewboard.kde.org/r/104826/diff/
 
 
 Testing
 ---
 
 Compiled, tested with regular paths, as well as / and file:///
 
 
 Thanks,
 
 Andre Heinecke
 




Re: Review Request: Add warning for searching the complete file system

2012-05-04 Thread Andre Heinecke


 On May 3, 2012, 7:35 p.m., Mark Gaiser wrote:
  Let me first say that i have absolutely nothing to say about this. I do 
  have an opinion about this though.
  I would not like this. If i'm searching i just want to search and certainly 
  don't get a dialog just to confirm my search.
  
  Others might think differently though... Perhaps as an option but disabled 
  by default.
 
 Kai Uwe Broulik wrote:
 I guess you should introduce them to Nepomuk and explain them how to 
 efficiently tag their files and find them by their contents instead :P
 
 Andre Heinecke wrote:
 Thanks for your feedback. I've argued about this with my admins, their 
 argumentation was The users that know what they are doing just use find
 Their argumentation was: If i use an open razor blade i don't expect a 
 warning before I cut my throat. But if i use an electrical shaver i don't 
 expect it to cut my throat.
 
 
 But I'll discard this patch, the warning is just annoying and would not 
 solve much. An option to include network file systems (disabled by default) 
 would be a better approach to this problem.
 
 Regards

Btw. nepomuk based file search is not going to be an option for company 
networks for a long time or ever. Imagine the Upgrade, every user indexes 
everything for themself,.. Afaik The semantic desktop as it is currently 
designed is for desktops and not for distributed environments.


- Andre


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104826/#review13382
---


On May 2, 2012, 7:50 p.m., Andre Heinecke wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 http://git.reviewboard.kde.org/r/104826/
 ---
 
 (Updated May 2, 2012, 7:50 p.m.)
 
 
 Review request for KDE Base Apps.
 
 
 Description
 ---
 
 In my company it regularly happens that some non technical person, e.g. a 
 secretary or a marketing guy tries to find a file he or she has no idea where 
 it is placed.
 When they use kfind to search the complete file system without using locate 
 this pretty much means a DOS attack on our company network with loads of NFS 
 shares etc.
 
 Searching the complete filesystem is nearly always wrong but as users are 
 used to it from Search my Computer or other indexed search options they 
 might not realize it.
 
 This Patch adds a confirmation dialog if you want to search / or file:/// 
 recursively without using locate warning you that this might take a very long 
 time and is a resource intensive operation
 
 
 Diffs
 -
 
   kfind/kfinddlg.cpp 12b3b7e 
   kfind/kquery.h 39609f3 
 
 Diff: http://git.reviewboard.kde.org/r/104826/diff/
 
 
 Testing
 ---
 
 Compiled, tested with regular paths, as well as / and file:///
 
 
 Thanks,
 
 Andre Heinecke
 




Replacement of identity.kde.org

2012-05-04 Thread Tom Albers
Hi, 

We are currently preparing the replacement of the current software used for 
identity.kde.org (GOSA). We will replace it with brand new software, developed 
by Ben Cooksley himself, it's called Solena. The idea is still the same: one 
place to create a username/password and use that service on several other sites 
we roll out within KDE. The most important advantage with the new software is 
that we get a sane user experience, identity.kde.org has a bad user interface, 
resulting in several problems.

We will convert all existing accounts automatically. Why this mail? To announce 
the new software and to announce that this weekend we will do the conversion to 
new system and make that active.

That means that identity.kde.org will not be 100% up this weekend, and it might 
be that at some points we are making some minor adjustments to the sites which 
rely on the authentication done by identity.kde.org, resulting that you can not 
login into such a site for short periods of time.

Any questions (or beta-testers!) are still welcome in #kde-sysadmin.

Best,

Tom Albers
KDE Sysadmin


Re: Review Request: Add warning for searching the complete file system

2012-05-04 Thread Sebastian Kügler
On Thursday, May 03, 2012 19:52:55 Andre Heinecke wrote:
 Btw. nepomuk based file search is not going to be an option for company
 networks for a long time or ever. Imagine the Upgrade, every user indexes
 everything for themself,.. Afaik The semantic desktop as it is currently
 designed is for desktops and not for distributed environments.

You're not supposed to index the whole filesystem anyway, just the 
*interesting* information (e.g. documents in your home directory).

That aside, though ... :)
-- 
sebas

http://www.kde.org | http://vizZzion.org | GPG Key ID: 9119 0EF9


Re: Review Request: kjs: Implement Array.isArray

2012-05-04 Thread Commit Hook

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104676/#review13424
---


This review has been submitted with commit 
f6a64b352c9ec4cc6eb970a855e848d841b79ffe by Bernd Buschinski to branch KDE/4.8.

- Commit Hook


On April 26, 2012, 5:19 p.m., Bernd Buschinski wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 http://git.reviewboard.kde.org/r/104676/
 ---
 
 (Updated April 26, 2012, 5:19 p.m.)
 
 
 Review request for kdelibs.
 
 
 Description
 ---
 
 kjs: Implement Array.isArray
 
 strictly to ECMA Edition 5.1 r6 - 15.4.3.2
 
 
 Diffs
 -
 
   kjs/array_object.cpp 7538ba1 
 
 Diff: http://git.reviewboard.kde.org/r/104676/diff/
 
 
 Testing
 ---
 
 ecmascript 15.4.3.2 tests
 
 
 Thanks,
 
 Bernd Buschinski
 




Re: Review Request: KJS: Implement Object.prototypeOf, Object.keys, Object.getOwnPropertyNames

2012-05-04 Thread Commit Hook

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104511/#review13422
---


This review has been submitted with commit 
654fa56348058ab8155a1ff87002771d87d63768 by Bernd Buschinski to branch KDE/4.8.

- Commit Hook


On April 30, 2012, 6:59 p.m., Bernd Buschinski wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 http://git.reviewboard.kde.org/r/104511/
 ---
 
 (Updated April 30, 2012, 6:59 p.m.)
 
 
 Review request for kdelibs.
 
 
 Description
 ---
 
 KJS: Implement Object.prototypeOf, Object.keys, Object.getOwnPropertyNames
 
 NOTE: Array was left out on purpose, as currentl imeplementation does not 
 save attributes (next patch will fix this)
 
 keysGetOwnPropertyNames requieres to change the 
 JSObject::getOwnPropertyNames implementation,
 for future use a enum is better than than a bool, maybe there will be more 
 ways to include/exclude properties.
 
 All changes for khtml/ecma/ are to silense the -Woverloaded-virtual warnings
 
 
 Diffs
 -
 
   khtml/ecma/debugger/localvariabledock.cpp 289c910 
   khtml/ecma/kjs_css.h aba44b8 
   khtml/ecma/kjs_css.cpp e3e7417 
   khtml/ecma/kjs_data.cpp df6fa85 
   khtml/ecma/kjs_dom.h d0433c3 
   khtml/ecma/kjs_dom.cpp 5fff7e3 
   khtml/ecma/kjs_html.h 0f3f544c 
   khtml/ecma/kjs_html.cpp e3da95c 
   khtml/ecma/kjs_scriptable.h af5343c 
   khtml/ecma/kjs_scriptable.cpp 5d4ea68 
   kjs/JSVariableObject.h a8f01eb 
   kjs/JSVariableObject.cpp b00ef76 
   kjs/array_instance.h 3f2b630 
   kjs/array_instance.cpp fe9b8b4 
   kjs/function.h 3757fe8 
   kjs/function.cpp 5f39ae6 
   kjs/object.h 047c242 
   kjs/object.cpp c19122f 
   kjs/object_object.cpp 986f03f 
   kjs/property_map.h 6b127ff 
   kjs/property_map.cpp b2ff08e 
   kjs/string_object.h e890d52 
   kjs/string_object.cpp 170e2f7 
 
 Diff: http://git.reviewboard.kde.org/r/104511/diff/
 
 
 Testing
 ---
 
 ecma script  daily surfing
 
 
 Thanks,
 
 Bernd Buschinski
 




Re: Review Request: kjs: All prototype constructor should be [[Writable]]: true, [[Enumerable]]: false, [[Configurable]]: true

2012-05-04 Thread Commit Hook

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104680/#review13425
---


This review has been submitted with commit 
4d326a3f143e7a270003704a2d2d85d27faaa564 by Bernd Buschinski to branch KDE/4.8.

- Commit Hook


On April 19, 2012, 7:41 p.m., Bernd Buschinski wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 http://git.reviewboard.kde.org/r/104680/
 ---
 
 (Updated April 19, 2012, 7:41 p.m.)
 
 
 Review request for kdelibs.
 
 
 Description
 ---
 
 kjs: All prototype constructor should be [[Writable]]: true, [[Enumerable]]: 
 false, [[Configurable]]: true
 
 
 As said in ECMA Edition 5.1r6 - 15.1:
 
 Unless otherwise specified, the standard built-in properties of the global 
 object have attributes {[[Writable]]: true, [[Enumerable]]: false, 
 [[Configurable]]: true}.
 
 And it is not otherwise specified.
 
 
 Diffs
 -
 
   kjs/interpreter.cpp cf1acf1 
 
 Diff: http://git.reviewboard.kde.org/r/104680/diff/
 
 
 Testing
 ---
 
 Confirmed by ecmascript tests checking the attributes of 
 *.prototype.constrictor with Object.getOwnPropertyDescriptor
 like
 Object.getOwnPropertyDescriptor(Date.prototype, constructor);
 
 
 Thanks,
 
 Bernd Buschinski
 




What about DATAKIOSLAVE?

2012-05-04 Thread Rolf Eike Beer
In kio/kio/dataprotocol.h you will find this documentation of that #define:

// DATAKIOSLAVE: define if you want to compile this into a stand-alone
//  kioslave

And in this header and the implementation a bunch of #ifdef's depending on
it. But I can't see it being set or used anywhere. Would anyone object on
just killing it altogether?

Eike


Review Request: kjs: Unify/de-duplicate Space checking

2012-05-04 Thread Bernd Buschinski

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104855/
---

Review request for kdelibs.


Description
---

kjs: Unify/de-duplicate Space checking

function.cpp isStrWhiteSpace was missing 0xFEFF:  // ZERO WIDTH NO-BREAK SPACE


Diffs
-

  kjs/commonunicode.h PRE-CREATION 
  kjs/function.cpp 5f39ae6 
  kjs/lexer.cpp e89de5f 

Diff: http://git.reviewboard.kde.org/r/104855/diff/


Testing
---


Thanks,

Bernd Buschinski



Review Request: kjs: Fix parseFloat not cutting-off leading unicode spaces

2012-05-04 Thread Bernd Buschinski

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104858/
---

Review request for kdelibs.


Description
---

kjs: Fix parseFloat not cutting-off leading unicode spaces

parseInt cuts away the leading spaces, like it should, but we don't to it for 
parseFloat, like we should.
UString::toDouble does remove leading spaces, but only ascii spaces, no 
unicodespaces.

ECMA 15.1.2.3 Step 2 confirms that leading spaces should be cut

depends on https://git.reviewboard.kde.org/r/104855/


Diffs
-

  kjs/function.cpp 5f39ae6 

Diff: http://git.reviewboard.kde.org/r/104858/diff/


Testing
---

Fixes a couple of ecma parseFloat tests


Thanks,

Bernd Buschinski



Use Icon Tasks as out default taskmanager for KDE 4.9?

2012-05-04 Thread Mark
Hi,

I was witnessing a range of very annoying task manager bugs.

1. I was still witnessing ghosting even with Qt 4.8.1. I haven't re-opened
https://bugs.kde.org/show_bug.cgi?id=275469 yet since i think the ghosting
doesn't occur in icon tasks.
2. I was witnessing something new in KDE 4.8 (hidden feature ^_-) called
overlapping. It's very efficient use of space and perhaps usable for
tablets but i rather dislike it. hehehe, anyway, there is a bug report for
that as well:  https://bugs.kde.org/show_bug.cgi?id=275469
3. Task Manager sometimes seems to forget which applications are pinned
which are then back when the user logs out and back in again. (restarting
plasma-desktop is probably also an option)
4. Minimize effect could go all ways with taskmanager. Sometime even to the
middle of the screen.

Icon Tasks has none of the above mentioned issues. And all of those issues
are really very noticeable and disruptive. It just gives a bad impression.

Icon Tasks is probably not made with the intention to replace the current
taskbar plasmoid, but it has strangely gotten a lot better then what we
feed our users by default. It only misses a few things.
1. Switch to disable peek
2. Switch to show the icons as bars just like task manager does.
3. Switch to sort open and closed tasks. Meaning you have all the closed
tasks as icons in the left of your taskbar and all the open ones as bars
next to the closed ones.

Now one might argue that we should fix taskmanager. I'd agree if there was
no alternative. Icon tasks is already shipped with KDE since version 4.8
(or 4.7?). The things that have to be added to it to make it a full
taskmanager replacement is fairly minor so why not?

So all things considered, why don't we pull the plug for taskmanager and
start using icon tasks by default?
And would this still be on time for KDE 4.9?

Kind regards,
Mark


Re: Use Icon Tasks as out default taskmanager for KDE 4.9?

2012-05-04 Thread Mark
out = our.. sorry for that title typo.

On Fri, May 4, 2012 at 10:36 PM, Mark mark...@gmail.com wrote:

 Hi,

 I was witnessing a range of very annoying task manager bugs.

 1. I was still witnessing ghosting even with Qt 4.8.1. I haven't re-opened
 https://bugs.kde.org/show_bug.cgi?id=275469 yet since i think the
 ghosting doesn't occur in icon tasks.
 2. I was witnessing something new in KDE 4.8 (hidden feature ^_-) called
 overlapping. It's very efficient use of space and perhaps usable for
 tablets but i rather dislike it. hehehe, anyway, there is a bug report for
 that as well:  https://bugs.kde.org/show_bug.cgi?id=275469
 3. Task Manager sometimes seems to forget which applications are pinned
 which are then back when the user logs out and back in again. (restarting
 plasma-desktop is probably also an option)
 4. Minimize effect could go all ways with taskmanager. Sometime even to
 the middle of the screen.

 Icon Tasks has none of the above mentioned issues. And all of those issues
 are really very noticeable and disruptive. It just gives a bad impression.

 Icon Tasks is probably not made with the intention to replace the current
 taskbar plasmoid, but it has strangely gotten a lot better then what we
 feed our users by default. It only misses a few things.
 1. Switch to disable peek
 2. Switch to show the icons as bars just like task manager does.
 3. Switch to sort open and closed tasks. Meaning you have all the closed
 tasks as icons in the left of your taskbar and all the open ones as bars
 next to the closed ones.

 Now one might argue that we should fix taskmanager. I'd agree if there was
 no alternative. Icon tasks is already shipped with KDE since version 4.8
 (or 4.7?). The things that have to be added to it to make it a full
 taskmanager replacement is fairly minor so why not?

 So all things considered, why don't we pull the plug for taskmanager and
 start using icon tasks by default?
 And would this still be on time for KDE 4.9?

 Kind regards,
 Mark



Re: What about DATAKIOSLAVE?

2012-05-04 Thread David Faure
On Friday 04 May 2012 18:53:40 Rolf Eike Beer wrote:
 In kio/kio/dataprotocol.h you will find this documentation of that #define:
 
 // DATAKIOSLAVE: define if you want to compile this into a stand-alone
 //kioslave
 
 And in this header and the implementation a bunch of #ifdef's depending on
 it. But I can't see it being set or used anywhere. Would anyone object on
 just killing it altogether?

Ask Leo Savernik directly, not sure he's reading this list regularly.

-- 
David Faure, fa...@kde.org, http://www.davidfaure.fr
Sponsored by Nokia to work on KDE, incl. KDE Frameworks 5



Re: Review Request: Added option for disabling the offer to save website passwords in Konqueror

2012-05-04 Thread David Faure


 On April 26, 2012, 5:09 p.m., Albert Astals Cid wrote:
  If i understand you correctly you are suggesting to create a bug (option 
  that does nothing)?
  
  Doesn't make much sense.
 
 Dawit Alemayehu wrote:
 Huh ? I do not follow. By option that does nothing you mean this change 
 by itself does nothing that is correct. But that is true of every option in 
 that dialog as well. Moreover, it is a well known fact that you cannot post a 
 patch for different components in reviewboard. Anyhow, the option will most 
 definitely be used by kwebkitpart. Whether or not some body implements 
 support for it in khtml is a question I cannot answer. That is what I meant.

Do you have the kwebkitpart patch ready?
I suppose it'll be easy to apply to khtml as well.


- David


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104631/#review12934
---


On April 26, 2012, 3:48 a.m., Dawit Alemayehu wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 http://git.reviewboard.kde.org/r/104631/
 ---
 
 (Updated April 26, 2012, 3:48 a.m.)
 
 
 Review request for KDE Base Apps, kdelibs and David Faure.
 
 
 Description
 ---
 
 A patch to make that provides an option to disable the offer to save website 
 passwords. Note that for this patch to take effect this option will have to 
 be used at at the browser engine level. Those patches are separate to this 
 one. This is just the GUI configuration.
 
 
 Diffs
 -
 
   konqueror/settings/konqhtml/htmlopts.h 69f36d8 
   konqueror/settings/konqhtml/htmlopts.cpp e5d6deb 
 
 Diff: http://git.reviewboard.kde.org/r/104631/diff/
 
 
 Testing
 ---
 
 
 Screenshots
 ---
 
 Option for disabling KWallet integration
   http://git.reviewboard.kde.org/r/104631/s/544/
 
 
 Thanks,
 
 Dawit Alemayehu
 




Re: Review Request: Added option for disabling the offer to save website passwords in Konqueror

2012-05-04 Thread Albert Astals Cid


 On April 26, 2012, 5:09 p.m., Albert Astals Cid wrote:
  If i understand you correctly you are suggesting to create a bug (option 
  that does nothing)?
  
  Doesn't make much sense.
 
 Dawit Alemayehu wrote:
 Huh ? I do not follow. By option that does nothing you mean this change 
 by itself does nothing that is correct. But that is true of every option in 
 that dialog as well. Moreover, it is a well known fact that you cannot post a 
 patch for different components in reviewboard. Anyhow, the option will most 
 definitely be used by kwebkitpart. Whether or not some body implements 
 support for it in khtml is a question I cannot answer. That is what I meant.
 
 David Faure wrote:
 Do you have the kwebkitpart patch ready?
 I suppose it'll be easy to apply to khtml as well.

You are suggesting to add an option that does nothing in our default html 
rendering engine. That is adding a bug. The fact that you know it and don't 
care about it makes me sad.


- Albert


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104631/#review12934
---


On April 26, 2012, 3:48 a.m., Dawit Alemayehu wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 http://git.reviewboard.kde.org/r/104631/
 ---
 
 (Updated April 26, 2012, 3:48 a.m.)
 
 
 Review request for KDE Base Apps, kdelibs and David Faure.
 
 
 Description
 ---
 
 A patch to make that provides an option to disable the offer to save website 
 passwords. Note that for this patch to take effect this option will have to 
 be used at at the browser engine level. Those patches are separate to this 
 one. This is just the GUI configuration.
 
 
 Diffs
 -
 
   konqueror/settings/konqhtml/htmlopts.h 69f36d8 
   konqueror/settings/konqhtml/htmlopts.cpp e5d6deb 
 
 Diff: http://git.reviewboard.kde.org/r/104631/diff/
 
 
 Testing
 ---
 
 
 Screenshots
 ---
 
 Option for disabling KWallet integration
   http://git.reviewboard.kde.org/r/104631/s/544/
 
 
 Thanks,
 
 Dawit Alemayehu
 




Re: Review Request: Avoid using QDialog::exec in kpasswdserver to address long standing issue

2012-05-04 Thread David Faure

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104817/#review13442
---


Very nice, thanks for this! Including the unittests I had marked as TODO... 
great ;-)

Just some minor issues.


kpasswdserver/kpasswdserver.cpp
http://git.reviewboard.kde.org/r/104817/#comment10577

Is this unfinished porting, or old code that can be removed?
I think the code above is doing it, so I guess the latter.



kpasswdserver/kpasswdserver.cpp
http://git.reviewboard.kde.org/r/104817/#comment10578

Why the qpointer? If there no nested event loop, it can't ibly get deleted 
before the end of the method.
No need to make the code more complex.



kpasswdserver/kpasswdserver.cpp
http://git.reviewboard.kde.org/r/104817/#comment10579

Same here. Can't be NULL, can't get deleted during the method - simple 
pointer should do.



kpasswdserver/kpasswdserver.cpp
http://git.reviewboard.kde.org/r/104817/#comment10580

Why delete value with QScopedPointer and delete key with delete? IMHO 
simple delete is more readable.



kpasswdserver/tests/kpasswdservertest.cpp
http://git.reviewboard.kde.org/r/104817/#comment10581

Copy/paste error, there's no username in the URL 2 lines below.


- David Faure


On May 1, 2012, 10:36 p.m., Dawit Alemayehu wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 http://git.reviewboard.kde.org/r/104817/
 ---
 
 (Updated May 1, 2012, 10:36 p.m.)
 
 
 Review request for KDE Runtime and David Faure.
 
 
 Description
 ---
 
 The attached patch does the following:
 
 - Use QDialog::open instead of QDialog::exec to prevent one password dialog 
 from blocking other password dialogs. This fixes the changes committed with 
 https://git.reviewboard.kde.org/r/103245/ which allowed dialog boxes from 
 different applications to be shown so long as they are not for the same site.
 
 - Update the key under which the password is cached if the request url 
 contains a username, but the user change it in the password dialog. IOW, do 
 now allow a password to be stored under different username than the one used 
 to access the site.
 
 - Added the unit test listed in the TODOs along with several more that 
 exercise all of the above changes.
 
 
 Diffs
 -
 
   kpasswdserver/tests/kpasswdservertest.cpp 38a579b 
   kpasswdserver/DESIGN 6a128f9 
   kpasswdserver/kpasswdserver.h 66f1f57 
   kpasswdserver/kpasswdserver.cpp b2abbd4 
 
 Diff: http://git.reviewboard.kde.org/r/104817/diff/
 
 
 Testing
 ---
 
 Added several additional unit tests to exercise all the changes. See patch.
 
 
 Thanks,
 
 Dawit Alemayehu
 




Re: Review Request: Avoid using QDialog::exec in kpasswdserver to address long standing issue

2012-05-04 Thread Dawit Alemayehu


 On May 4, 2012, 10:20 p.m., David Faure wrote:
  kpasswdserver/kpasswdserver.cpp, line 1108
  http://git.reviewboard.kde.org/r/104817/diff/1/?file=61958#file61958line1108
 
  Is this unfinished porting, or old code that can be removed?
  I think the code above is doing it, so I guess the latter.

Ooops. That should be removed. It is me testing something that actually is not 
necessary.


 On May 4, 2012, 10:20 p.m., David Faure wrote:
  kpasswdserver/kpasswdserver.cpp, line 1150
  http://git.reviewboard.kde.org/r/104817/diff/1/?file=61958#file61958line1150
 
  Why the qpointer? If there no nested event loop, it can't ibly get 
  deleted before the end of the method.
  No need to make the code more complex.

True. I just did not change the previous approach. I simply changed is from 
QScopedPointer to QPointer.


- Dawit


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104817/#review13442
---


On May 1, 2012, 10:36 p.m., Dawit Alemayehu wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 http://git.reviewboard.kde.org/r/104817/
 ---
 
 (Updated May 1, 2012, 10:36 p.m.)
 
 
 Review request for KDE Runtime and David Faure.
 
 
 Description
 ---
 
 The attached patch does the following:
 
 - Use QDialog::open instead of QDialog::exec to prevent one password dialog 
 from blocking other password dialogs. This fixes the changes committed with 
 https://git.reviewboard.kde.org/r/103245/ which allowed dialog boxes from 
 different applications to be shown so long as they are not for the same site.
 
 - Update the key under which the password is cached if the request url 
 contains a username, but the user change it in the password dialog. IOW, do 
 now allow a password to be stored under different username than the one used 
 to access the site.
 
 - Added the unit test listed in the TODOs along with several more that 
 exercise all of the above changes.
 
 
 Diffs
 -
 
   kpasswdserver/tests/kpasswdservertest.cpp 38a579b 
   kpasswdserver/DESIGN 6a128f9 
   kpasswdserver/kpasswdserver.h 66f1f57 
   kpasswdserver/kpasswdserver.cpp b2abbd4 
 
 Diff: http://git.reviewboard.kde.org/r/104817/diff/
 
 
 Testing
 ---
 
 Added several additional unit tests to exercise all the changes. See patch.
 
 
 Thanks,
 
 Dawit Alemayehu
 




Re: Review Request: Avoid using QDialog::exec in kpasswdserver to address long standing issue

2012-05-04 Thread Dawit Alemayehu

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104817/
---

(Updated May 4, 2012, 11:01 p.m.)


Review request for KDE Runtime and David Faure.


Changes
---

Fixed the issues raised by David.


Description
---

The attached patch does the following:

- Use QDialog::open instead of QDialog::exec to prevent one password dialog 
from blocking other password dialogs. This fixes the changes committed with 
https://git.reviewboard.kde.org/r/103245/ which allowed dialog boxes from 
different applications to be shown so long as they are not for the same site.

- Update the key under which the password is cached if the request url contains 
a username, but the user change it in the password dialog. IOW, do now allow a 
password to be stored under different username than the one used to access the 
site.

- Added the unit test listed in the TODOs along with several more that exercise 
all of the above changes.


Diffs (updated)
-

  kpasswdserver/DESIGN 6a128f9 
  kpasswdserver/kpasswdserver.h 66f1f57 
  kpasswdserver/kpasswdserver.cpp b2abbd4 
  kpasswdserver/tests/kpasswdservertest.cpp 38a579b 

Diff: http://git.reviewboard.kde.org/r/104817/diff/


Testing
---

Added several additional unit tests to exercise all the changes. See patch.


Thanks,

Dawit Alemayehu



Re: [Kde-pim] [ANNOUNCE] Google and Kolab New Soft Dependencies for kdepim-runtime 4.9

2012-05-04 Thread Michael Jansen

Since i had problems to find that xsd thing here the link for others.

http://www.codesynthesis.com/projects/xsd/

Mike

On Friday, May 04, 2012 10:45:42 AM Allen Winter wrote:
 Howdy,
 
 Coming in kdepim-runtime 4.9, we will now be providing a Google resource as
 well as an overhauled Kolab resource that adds support for Kolab v3.
 
 Both of these new resources are dependent on 3rdparty libraries, optionally.
 So you must have all the necessary dependencies available at build time if
 you want these resources for your kdepim applications. Which of course you
 do :)
 
 For Kolab you will need:
 =
 xerces-c development
 xsd
 swig
 libkolabxml-0.4.0 and libkolab-0.2.0 (source-only available at this time
 from http://git.kolab.org)
 
 For Google you will need:
 ===
 libkgoogle-0.3.0
 
 
 From what I can tell, the major distributions already have most of these
 dependencies available as packages.  The Kolab libraries are currently only
 available as source since they are very new.
 
 Please report questions or concerns to the kde-...@kde.org mailing list.
 
 -Allen
 
 
 ___
 KDE PIM mailing list kde-...@kde.org
 https://mail.kde.org/mailman/listinfo/kde-pim
 KDE PIM home page at http://pim.kde.org/
-- 
Michael Jansen
http://michael-jansen.biz