Workflow plasmoid [Re: Hello...]
Hi Michael,
Lets move this to plasma-devel since it is about plasma. (replying to k-c-d as
well just for easier tracking what happened to the thread)
1) I am using the following code to remove an activity:
void ActivityManager::remove(QString id) {
ActivityManager::stop(id);
Since this plasmoid is meant to manage the activities, not to be merely a
consumer, I'd suggest you to use the libkactivities directly. IMO, the data
engine shouldn't even have the remove service.
Cheerio,
Ivan
--
So remember when you're feeling very small and insecure
How amazingly unlikely is your birth
And pray that there's intelligent life somewhere up in space
Because there's bugger all down here on earth.
-- Monty Python
Re: Review Request: Rename Samba Shares to Windows Shares (SMB)
On June 21, 2012, 10:05 p.m., Mark Gaiser wrote: I don't really know if we should do this.. I do understand why you want to rename it. From a user point of view the user probably wants to either access windows shares or make shares accessible for windows. Either way, it's done through Samba which implements the SMB protocol: http://en.wikipedia.org/wiki/Server_Message_Block so it are actually SMB Shares ;) Changing it is not really useful i think. I for example make Samba shares between Linux machines as well since that is just easy and why should those be called Windows Shares all of a sudden? I think Samba Shares is just fine. Perhaps SMB Shares describes it even better. I'm not against the change, but also not in favor. Someone else should decide whether this is OK or not. Lamarque Vieira Souza wrote: I am also against this change, also because Windows is a trademark, so we have better avoid using it in KDE. OBS: samba also implements the cifs protocol, the sucessor of SMB and the current default protocol used in Win7. So SMB Shares is also not a good name. On Windows a \\ path is translated into a smb:// URL for KDE apps, so no Samba is used at all but the bookmark is still called Samba Shares - Andrius da Costa --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105318/#review14969 --- On June 21, 2012, 3:40 p.m., Maarten De Meyer wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105318/ --- (Updated June 21, 2012, 3:40 p.m.) Review request for KDE Runtime and David Edmundson. Description --- Fix for bug 141257. Renamed 'Samba Shares' to 'Windows Shares (SMB)' I posted this on the usability mailing list a while a go and David Edmundson CC'd the original author but for now there has been no response. http://lists.kde.org/?l=kde-usabilitym=133173657001169w=2 Since we are past string freeze this is probably for 4.10 I can not commit this myself, thanks This addresses bug 141257. http://bugs.kde.org/show_bug.cgi?id=141257 Diffs - kioslave/smb/smb-network.desktop a121a31 Diff: http://git.reviewboard.kde.org/r/105318/diff/ Testing --- Thanks, Maarten De Meyer
Re: Review Request: Rename Samba Shares to Windows Shares (SMB)
On June 21, 2012, 10:05 p.m., Mark Gaiser wrote: I don't really know if we should do this.. I do understand why you want to rename it. From a user point of view the user probably wants to either access windows shares or make shares accessible for windows. Either way, it's done through Samba which implements the SMB protocol: http://en.wikipedia.org/wiki/Server_Message_Block so it are actually SMB Shares ;) Changing it is not really useful i think. I for example make Samba shares between Linux machines as well since that is just easy and why should those be called Windows Shares all of a sudden? I think Samba Shares is just fine. Perhaps SMB Shares describes it even better. I'm not against the change, but also not in favor. Someone else should decide whether this is OK or not. Lamarque Vieira Souza wrote: I am also against this change, also because Windows is a trademark, so we have better avoid using it in KDE. OBS: samba also implements the cifs protocol, the sucessor of SMB and the current default protocol used in Win7. So SMB Shares is also not a good name. Andrius da Costa Ribas wrote: On Windows a \\ path is translated into a smb:// URL for KDE apps, so no Samba is used at all but the bookmark is still called Samba Shares I know it uses the SMB protocol, thats why I added it in brackets. We know samba. My mother however thinks about a certain latin dance when I tell her to 'use the samba share'. I don't know what it is called in other linux DE's and it doesn't matter, we should chose the best fitting string. There are different interpretations of best. For me that means it hides implementation details and is easy to understand for everybody. Other people might want to call it what it is. SMB would be even worse compared to samba imo, this change is to make it easier for new users, not harder. Not sure about the trademark, I doubt it would be a problem but am obviously no lawyer. This is not really an important change, if this is considered bad I'll just close this review and the bug. It was more a personal attempt to get used to bug fixing workflow. - Maarten --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105318/#review14969 --- On June 21, 2012, 3:40 p.m., Maarten De Meyer wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105318/ --- (Updated June 21, 2012, 3:40 p.m.) Review request for KDE Runtime and David Edmundson. Description --- Fix for bug 141257. Renamed 'Samba Shares' to 'Windows Shares (SMB)' I posted this on the usability mailing list a while a go and David Edmundson CC'd the original author but for now there has been no response. http://lists.kde.org/?l=kde-usabilitym=133173657001169w=2 Since we are past string freeze this is probably for 4.10 I can not commit this myself, thanks This addresses bug 141257. http://bugs.kde.org/show_bug.cgi?id=141257 Diffs - kioslave/smb/smb-network.desktop a121a31 Diff: http://git.reviewboard.kde.org/r/105318/diff/ Testing --- Thanks, Maarten De Meyer
Re: Review Request: Rename Samba Shares to Windows Shares (SMB)
Hi, On Friday 22 June 2012 03:24:47 Maarten De Meyer wrote: ... My mother however thinks about a certain latin dance when I tell her to 'use the samba share'. My mother however thinks about certain holes in the walls of her home when I tell her to 'use the windows share'. SCNR. -- Regards Thomas Baumgart GPG-FP: E55E D592 F45F 116B 8429 4F99 9C59 DB40 B75D D3BA - Computers are like air conditioners: they stop working properly if you open WINDOWS (anonymous source) - signature.asc Description: This is a digitally signed message part.
Re: Workflow plasmoid [Re: Hello...]
Hi Ivan,
yes of course, I have just subscribe to plasma-devel, do I have to
resend the first mail?
for the activitymanager I will try to use directly the libkactivities, I
think you must have
the same opinion for the tasks also? to use lilbtaskmanager instead of
the tasks engine...
Michail
Στις 22/06/2012 10:06 πμ, ο/η Ivan Cukic έγραψε:
Hi Michael,
Lets move this to plasma-devel since it is about plasma. (replying to k-c-d as
well just for easier tracking what happened to the thread)
1) I am using the following code to remove an activity:
void ActivityManager::remove(QString id) {
ActivityManager::stop(id);
Since this plasmoid is meant to manage the activities, not to be merely a
consumer, I'd suggest you to use the libkactivities directly. IMO, the data
engine shouldn't even have the remove service.
Cheerio,
Ivan
Re: Review Request: Rename Samba Shares to Windows Shares (SMB)
My mother however thinks about a certain latin dance when I tell her to 'use the samba share'. My mother however thinks about certain holes in the walls of her home when I tell her to 'use the windows share'. Windows itself refers to this by network share, I think. However, what I was wondering is: if a user does not understand those terms, would that user use these shares? Or would that user just use the link or shortcut he got from the system administrator? Because I am not sure if my mother would understand the whole concept of sharing anyway -- ok, I am telling a lie here, my mother is an IT professional, but that is not the point. ;)
Re: Review Request: Rename Samba Shares to Windows Shares (SMB)
Just let me add my 2 cents to the discussion saying that whatever name you are going to choose here, it should be non technical at all from the user POV. So, please let samba, smb or similar out of it. Windows is borderline. My mother knows that it is referred to something computer related. :) 2012/6/22 Stas Verberkt lego...@legolasweb.nl My mother however thinks about a certain latin dance when I tell her to 'use the samba share'. My mother however thinks about certain holes in the walls of her home when I tell her to 'use the windows share'. Windows itself refers to this by network share, I think. However, what I was wondering is: if a user does not understand those terms, would that user use these shares? Or would that user just use the link or shortcut he got from the system administrator? Because I am not sure if my mother would understand the whole concept of sharing anyway -- ok, I am telling a lie here, my mother is an IT professional, but that is not the point. ;) -- Andrea Diamantini WEB: http://www.adjam.org rekonq project WEB: http://rekonq.kde.org IRC: rekonq@freenode
Re: Review Request: Rename Samba Shares to Windows Shares (SMB)
On June 21, 2012, 10:05 p.m., Mark Gaiser wrote: I don't really know if we should do this.. I do understand why you want to rename it. From a user point of view the user probably wants to either access windows shares or make shares accessible for windows. Either way, it's done through Samba which implements the SMB protocol: http://en.wikipedia.org/wiki/Server_Message_Block so it are actually SMB Shares ;) Changing it is not really useful i think. I for example make Samba shares between Linux machines as well since that is just easy and why should those be called Windows Shares all of a sudden? I think Samba Shares is just fine. Perhaps SMB Shares describes it even better. I'm not against the change, but also not in favor. Someone else should decide whether this is OK or not. Lamarque Vieira Souza wrote: I am also against this change, also because Windows is a trademark, so we have better avoid using it in KDE. OBS: samba also implements the cifs protocol, the sucessor of SMB and the current default protocol used in Win7. So SMB Shares is also not a good name. Andrius da Costa Ribas wrote: On Windows a \\ path is translated into a smb:// URL for KDE apps, so no Samba is used at all but the bookmark is still called Samba Shares Maarten De Meyer wrote: I know it uses the SMB protocol, thats why I added it in brackets. We know samba. My mother however thinks about a certain latin dance when I tell her to 'use the samba share'. I don't know what it is called in other linux DE's and it doesn't matter, we should chose the best fitting string. There are different interpretations of best. For me that means it hides implementation details and is easy to understand for everybody. Other people might want to call it what it is. SMB would be even worse compared to samba imo, this change is to make it easier for new users, not harder. Not sure about the trademark, I doubt it would be a problem but am obviously no lawyer. This is not really an important change, if this is considered bad I'll just close this review and the bug. It was more a personal attempt to get used to bug fixing workflow. Perhaps it should be called Network Shares because that is what they are and makes it more understandable for the non techical people as well. Regardless of SMB, CIFS or whatever protocol is being used. - Mark --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105318/#review14969 --- On June 21, 2012, 3:40 p.m., Maarten De Meyer wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105318/ --- (Updated June 21, 2012, 3:40 p.m.) Review request for KDE Runtime and David Edmundson. Description --- Fix for bug 141257. Renamed 'Samba Shares' to 'Windows Shares (SMB)' I posted this on the usability mailing list a while a go and David Edmundson CC'd the original author but for now there has been no response. http://lists.kde.org/?l=kde-usabilitym=133173657001169w=2 Since we are past string freeze this is probably for 4.10 I can not commit this myself, thanks This addresses bug 141257. http://bugs.kde.org/show_bug.cgi?id=141257 Diffs - kioslave/smb/smb-network.desktop a121a31 Diff: http://git.reviewboard.kde.org/r/105318/diff/ Testing --- Thanks, Maarten De Meyer
Re: Review Request: Rename Samba Shares to Windows Shares (SMB)
On June 21, 2012, 10:05 p.m., Mark Gaiser wrote: I don't really know if we should do this.. I do understand why you want to rename it. From a user point of view the user probably wants to either access windows shares or make shares accessible for windows. Either way, it's done through Samba which implements the SMB protocol: http://en.wikipedia.org/wiki/Server_Message_Block so it are actually SMB Shares ;) Changing it is not really useful i think. I for example make Samba shares between Linux machines as well since that is just easy and why should those be called Windows Shares all of a sudden? I think Samba Shares is just fine. Perhaps SMB Shares describes it even better. I'm not against the change, but also not in favor. Someone else should decide whether this is OK or not. Lamarque Vieira Souza wrote: I am also against this change, also because Windows is a trademark, so we have better avoid using it in KDE. OBS: samba also implements the cifs protocol, the sucessor of SMB and the current default protocol used in Win7. So SMB Shares is also not a good name. Andrius da Costa Ribas wrote: On Windows a \\ path is translated into a smb:// URL for KDE apps, so no Samba is used at all but the bookmark is still called Samba Shares Maarten De Meyer wrote: I know it uses the SMB protocol, thats why I added it in brackets. We know samba. My mother however thinks about a certain latin dance when I tell her to 'use the samba share'. I don't know what it is called in other linux DE's and it doesn't matter, we should chose the best fitting string. There are different interpretations of best. For me that means it hides implementation details and is easy to understand for everybody. Other people might want to call it what it is. SMB would be even worse compared to samba imo, this change is to make it easier for new users, not harder. Not sure about the trademark, I doubt it would be a problem but am obviously no lawyer. This is not really an important change, if this is considered bad I'll just close this review and the bug. It was more a personal attempt to get used to bug fixing workflow. Mark Gaiser wrote: Perhaps it should be called Network Shares because that is what they are and makes it more understandable for the non techical people as well. Regardless of SMB, CIFS or whatever protocol is being used. The kcm uses Windows Shares as caption and says ...configure which windows (smb) filesystems you can... which is imo really the worst variant because it's in the context of systemsettings not really clear that it's talking about MS Windows (tm) since windows otherwise refer to, well, the windows on your desktop and the exact meaning is not really stressed by using the lowercase variant. However, i don't like talking about even MS Windows (tm) shares because it's rather misleading, given many *nix servers and esp. NAS provide SMB/CIFS Since the entire concept is rather uniquely done through samba / smb:// i'd rather completely avoid the particular words samba, windows or shares (it's too generic, ppl. might think of NYSE) and just talk about Network folders as, similar to what Mark said, that's what they are - and let me add unfortunately :-P Also there's much blank space in kcm and tooltip available for an explanation that this is SMB/CIFS provided on POSIX systems through Samba (add a link?) and predominantly used by MS Windows to export local paths to the network. - Thomas --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105318/#review14969 --- On June 21, 2012, 3:40 p.m., Maarten De Meyer wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105318/ --- (Updated June 21, 2012, 3:40 p.m.) Review request for KDE Runtime and David Edmundson. Description --- Fix for bug 141257. Renamed 'Samba Shares' to 'Windows Shares (SMB)' I posted this on the usability mailing list a while a go and David Edmundson CC'd the original author but for now there has been no response. http://lists.kde.org/?l=kde-usabilitym=133173657001169w=2 Since we are past string freeze this is probably for 4.10 I can not commit this myself, thanks This addresses bug 141257. http://bugs.kde.org/show_bug.cgi?id=141257 Diffs - kioslave/smb/smb-network.desktop a121a31 Diff: http://git.reviewboard.kde.org/r/105318/diff/ Testing --- Thanks, Maarten De Meyer
Re: Review Request: Rename Samba Shares to Windows Shares (SMB)
On June 21, 2012, 10:05 p.m., Mark Gaiser wrote: I don't really know if we should do this.. I do understand why you want to rename it. From a user point of view the user probably wants to either access windows shares or make shares accessible for windows. Either way, it's done through Samba which implements the SMB protocol: http://en.wikipedia.org/wiki/Server_Message_Block so it are actually SMB Shares ;) Changing it is not really useful i think. I for example make Samba shares between Linux machines as well since that is just easy and why should those be called Windows Shares all of a sudden? I think Samba Shares is just fine. Perhaps SMB Shares describes it even better. I'm not against the change, but also not in favor. Someone else should decide whether this is OK or not. Lamarque Vieira Souza wrote: I am also against this change, also because Windows is a trademark, so we have better avoid using it in KDE. OBS: samba also implements the cifs protocol, the sucessor of SMB and the current default protocol used in Win7. So SMB Shares is also not a good name. Andrius da Costa Ribas wrote: On Windows a \\ path is translated into a smb:// URL for KDE apps, so no Samba is used at all but the bookmark is still called Samba Shares Maarten De Meyer wrote: I know it uses the SMB protocol, thats why I added it in brackets. We know samba. My mother however thinks about a certain latin dance when I tell her to 'use the samba share'. I don't know what it is called in other linux DE's and it doesn't matter, we should chose the best fitting string. There are different interpretations of best. For me that means it hides implementation details and is easy to understand for everybody. Other people might want to call it what it is. SMB would be even worse compared to samba imo, this change is to make it easier for new users, not harder. Not sure about the trademark, I doubt it would be a problem but am obviously no lawyer. This is not really an important change, if this is considered bad I'll just close this review and the bug. It was more a personal attempt to get used to bug fixing workflow. Mark Gaiser wrote: Perhaps it should be called Network Shares because that is what they are and makes it more understandable for the non techical people as well. Regardless of SMB, CIFS or whatever protocol is being used. Thomas Lübking wrote: The kcm uses Windows Shares as caption and says ...configure which windows (smb) filesystems you can... which is imo really the worst variant because it's in the context of systemsettings not really clear that it's talking about MS Windows (tm) since windows otherwise refer to, well, the windows on your desktop and the exact meaning is not really stressed by using the lowercase variant. However, i don't like talking about even MS Windows (tm) shares because it's rather misleading, given many *nix servers and esp. NAS provide SMB/CIFS Since the entire concept is rather uniquely done through samba / smb:// i'd rather completely avoid the particular words samba, windows or shares (it's too generic, ppl. might think of NYSE) and just talk about Network folders as, similar to what Mark said, that's what they are - and let me add unfortunately :-P Also there's much blank space in kcm and tooltip available for an explanation that this is SMB/CIFS provided on POSIX systems through Samba (add a link?) and predominantly used by MS Windows to export local paths to the network. After the last comment I have to put my 2 cents here, tho I like Network Folders, my plans for the smb:// kio will make this a not very Folder... Windows export their printers using the SMB protocol, which right now is ignored on the kio code, since I'm about to release a new print-manager I'll patch that to show the printers so you can easily add them (the term Folder won't apply then anymore). So Network Places might sound better, but the truth is: we have 3 ways of accessing network stuff, we need network transparency not a new name. smb://, network:// and zeroconf:// we need a common denominator which isn't easy to implement. Then we can rename it and just call Network. Right now I think we should make it clear what the entry is thus Samba shares IMO still the best choice. - Daniel --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105318/#review14969 --- On June 21, 2012, 3:40 p.m., Maarten De Meyer wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105318/ --- (Updated June 21, 2012,
Patch to add kdoctools/customization/xsl/hu.xml
Hello, the attached patch adds the kdoctools/customization/xsl/hu.xml to kdelibs. Please commit it to KDE/4.8 and to master. Kristóf Kiszel 0027-Add-Hungarian-translation.patch Description: Binary data
Re: Patch to add kdoctools/customization/xsl/hu.xml
Hi, Usually, we use reviewboard for patches. For instance, I cannot unfortunately open up this attachment on my phone (N9) for reviewing. I can do that in few hours. Perhaps, you also meant against the frameworks branch (saying this without even seeing the patch). BR, Laszlo On 6/22/12, Kristóf Kiszel ulys...@kubuntu.org wrote: Hello, the attached patch adds the kdoctools/customization/xsl/hu.xml to kdelibs. Please commit it to KDE/4.8 and to master. Kristóf Kiszel
