Re: KF5 Update Meeting Minutes 2013-w47

2013-11-19 Thread Mark Gaiser
On Tue, Nov 19, 2013 at 4:53 PM, Kevin Ottens  wrote:
> Hello everyone,
>
> This is the minutes of the Week 47 KF5 meeting. As usual it has been held on
> #kde-devel at 4pm Paris time.
>
> Were present: afiestas, agateau, apol, jpwhiting, mgraesslin, randomguy3,
> sebas, teo and myself.
>
> Announcement:
>  * We're not yet ready for the splitting so it's postponed by a week;
>  * Please get open tasks done;
>
>  * agateau fixed kauth-policy-gen which was breaking kde-workspace;
>  * he's working on fixing kio standalone build (reviews posted);
>  * he's blocked on desktoptojson, he got an ugly suggestion on cmake-user but
> kde-buildsystem didn't get back to him;
>  * he consider merging his superbuild changes which are still pending;
>
>  * dfaure has been chasing a bug in Qt which affects KIO;
i think i know which one ^_-
>
>  * jpwhiting moved kspeech to staging and will look into finding its final
> place;
>
>  * mgraesslin merged kcolorschememanager;
>  * he also included the netwm port to xcb;
>  * he would need a prompt review on http://pastebin.kde.org/pjyjpm9on ;
>  * he also waits on a crasher fix https://git.reviewboard.kde.org/r/113877/ ;
>
>  * randomguy3 got kmediaplayer ready (it is in staging, soon tier3);
>  * he's also working on KDBusService;
>
>  * Riddell is done for the coinstallability;
>  * he completed the list for the new runtime organization;
>  * he needs feedback on all that;
>
>  * sebas is working on plasma applets in the panel (calendar, clock, systray);
>  * he's also trying to get his build back on track;
>
>  * teo is still working on ksmserver, it starts and run kwin successfully now;
>  * he's also fixing the commandline parsing;
>
>  * afiestas is working on powerdevil to restore its functionalities;
>  * he also plans to look in kded bugs;
>
>  * apol has been looking into making porting away from kde4support easier;
>  * he also worked a bit on the standalone builds effort;
>  * he almost removed all plasma-framework dependencies on kde4support;
>
>  * ervin reviewed a bit, mostly got busy with the pim sprint.
>
> If you got questions, feel free to ask.

Sorry for not attending. I was traveling back home when the meeting was up.
Out of curiosity, any update on a frameworks sprint in Toulouse yet?

And to add my point to it.
I've started working on adding more detailed signals for
QFileSystemWatcher in an effort to:
1. Make that more usable
2. Deprecate KDirWatch

I've added the "created" signal as we know it in KDirWatch and now
have to go through the Qt review route which is a first timer for me.
I have working code + testcase :)
This obviously won't be done for Qt 5.2 since it's frozen already. I
hope it might get into 5.3 along with a few more signals.


Review Request 113954: Remove dead code related to kompare support

2013-11-19 Thread Kevin Funk

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113954/
---

Review request for kdelibs.


Repository: kdevplatform


Description
---

Remove dead code related to kompare support

Never used.

Minor: Code cleanup


ApplyChangesWidget: Get rid off kompare support

Never used, and never enabled since 2009.

ApplyChangesWidget: Remove useless changes view

Just clutters the view, doesn't really provide information

Minor: Cleanup code


Diffs
-

  CMakeLists.txt ee6ee330078ceae283823c112f50afb6b295cc25 
  config-kdevplatform.h.cmake ff1db70ab10ff558f0881a31ff63b26d02f5d859 
  language/CMakeLists.txt 2f777e4ffab3f8b7dca814d09d9a9492861814e6 
  language/codegen/applychangeswidget.h 
d316d826d14b6118b4c40996ef0726cf788bb867 
  language/codegen/applychangeswidget.cpp 
c5c0a5c3ea4eee72b888b47d9eab84d04cb9341c 
  language/codegen/komparesupport.h 001144ad162a3913430bc46c6d90337fc14a3327 
  language/codegen/komparesupport.cpp c5c04ed092e8723613a5e97ca5777cd0f2ac479f 
  shell/CMakeLists.txt 57c5b72c3eef30e37c3a9c58016c6eb247f53e23 
  shell/documentcontroller.cpp 21916b359bc88ed87d2353ffccb408cf243dcf89 
  shell/patchdocument.h fe0d7de2d0a32c211a567a4d312de461a59d0c98 
  shell/patchdocument.cpp 724ce2af92882cbe336bd389e2e99b38a0c820e9 
  vcs/vcspluginhelper.cpp 0456aee4c1395a90d3c51009cfc1cd662afbf2c3 

Diff: http://git.reviewboard.kde.org/r/113954/diff/


Testing
---


Thanks,

Kevin Funk



Re: Review Request 113857: Get rid off ifdefs for windows driver kit

2013-11-19 Thread Kevin Funk

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113857/
---

(Updated Nov. 19, 2013, 6:18 p.m.)


Status
--

This change has been marked as submitted.


Review request for kdelibs, Patrick Spendrin and Patrick von Reth.


Repository: kdelibs


Description
---

Get rid off ifdefs for windows driver kit

Headers are now part of kdewin

As discussed with Patrick von Reth on IRC.


Diffs
-

  solid/solid/backends/win/winblock.cpp 
1f4d378a9614775b4f8abe186d147189a550858c 
  solid/solid/backends/win/windevicemanager.h 
b2d3c40779a60f24be498ba6e435a0c9cba1f2f8 
  solid/solid/backends/win/winopticaldisc.cpp 
c20ee43e33e20f795e814f13d7507756df394c1e 
  solid/solid/backends/win/winopticaldrive.h 
ce6c2c45338edbe470ba8f040dd3a3e829073d9c 
  solid/solid/backends/win/winopticaldrive.cpp 
fd87eb982a75ff2cff48f9f5ab5e13ac400d9a5e 

Diff: http://git.reviewboard.kde.org/r/113857/diff/


Testing
---


Thanks,

Kevin Funk



Re: Review Request 113857: Get rid off ifdefs for windows driver kit

2013-11-19 Thread Commit Hook

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113857/#review43980
---


This review has been submitted with commit 
9f538a25935461e7f773c350991fab343b165d60 by Kevin Funk to branch master.

- Commit Hook


On Nov. 14, 2013, 1:08 p.m., Kevin Funk wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113857/
> ---
> 
> (Updated Nov. 14, 2013, 1:08 p.m.)
> 
> 
> Review request for kdelibs, Patrick Spendrin and Patrick von Reth.
> 
> 
> Repository: kdelibs
> 
> 
> Description
> ---
> 
> Get rid off ifdefs for windows driver kit
> 
> Headers are now part of kdewin
> 
> As discussed with Patrick von Reth on IRC.
> 
> 
> Diffs
> -
> 
>   solid/solid/backends/win/winblock.cpp 
> 1f4d378a9614775b4f8abe186d147189a550858c 
>   solid/solid/backends/win/windevicemanager.h 
> b2d3c40779a60f24be498ba6e435a0c9cba1f2f8 
>   solid/solid/backends/win/winopticaldisc.cpp 
> c20ee43e33e20f795e814f13d7507756df394c1e 
>   solid/solid/backends/win/winopticaldrive.h 
> ce6c2c45338edbe470ba8f040dd3a3e829073d9c 
>   solid/solid/backends/win/winopticaldrive.cpp 
> fd87eb982a75ff2cff48f9f5ab5e13ac400d9a5e 
> 
> Diff: http://git.reviewboard.kde.org/r/113857/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Kevin Funk
> 
>



Re: KF5 Update Meeting Minutes 2013-w47

2013-11-19 Thread John Layt
On 19 November 2013 16:53, Kevin Ottens  wrote:

> Announcement:
>  * We're not yet ready for the splitting so it's postponed by a week;
>  * Please get open tasks done;

At the PIM Sprint Alex passed the byte formatting TODO on to me which
I've started coding, I'll try push a review in a couple of days:

* New class KFormat will be added to KCoreAddons
* Will use tr() rather than i18n(), which is proving the hard part
* Will ignore any user settings, only formats as requested via api
* Will have static methods for formatByteSize(),
formatDecimalDuration(), formatSpelloutDuration() and
formatRelativeDate()

I'm still figuring out the tr() part and loading of catalogues and the
rest, especially for static methods.

As this doesn't involve moving any code (the old methods stay in
KLocale in kde4support), and nothing else in Frameworks calls these
methods, then in theory this shouldn't block the split from happening,
but I'll try get it in before then.

Cheers!

John.


Re: Review Request 113857: Get rid off ifdefs for windows driver kit

2013-11-19 Thread Patrick von Reth

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113857/#review43950
---

Ship it!


Ship It!

- Patrick von Reth


On Nov. 14, 2013, 1:08 p.m., Kevin Funk wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113857/
> ---
> 
> (Updated Nov. 14, 2013, 1:08 p.m.)
> 
> 
> Review request for kdelibs, Patrick Spendrin and Patrick von Reth.
> 
> 
> Repository: kdelibs
> 
> 
> Description
> ---
> 
> Get rid off ifdefs for windows driver kit
> 
> Headers are now part of kdewin
> 
> As discussed with Patrick von Reth on IRC.
> 
> 
> Diffs
> -
> 
>   solid/solid/backends/win/winblock.cpp 
> 1f4d378a9614775b4f8abe186d147189a550858c 
>   solid/solid/backends/win/windevicemanager.h 
> b2d3c40779a60f24be498ba6e435a0c9cba1f2f8 
>   solid/solid/backends/win/winopticaldisc.cpp 
> c20ee43e33e20f795e814f13d7507756df394c1e 
>   solid/solid/backends/win/winopticaldrive.h 
> ce6c2c45338edbe470ba8f040dd3a3e829073d9c 
>   solid/solid/backends/win/winopticaldrive.cpp 
> fd87eb982a75ff2cff48f9f5ab5e13ac400d9a5e 
> 
> Diff: http://git.reviewboard.kde.org/r/113857/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Kevin Funk
> 
>



KF5 Update Meeting Minutes 2013-w47

2013-11-19 Thread Kevin Ottens
Hello everyone,

This is the minutes of the Week 47 KF5 meeting. As usual it has been held on
#kde-devel at 4pm Paris time.

Were present: afiestas, agateau, apol, jpwhiting, mgraesslin, randomguy3,
sebas, teo and myself.

Announcement:
 * We're not yet ready for the splitting so it's postponed by a week;
 * Please get open tasks done;

 * agateau fixed kauth-policy-gen which was breaking kde-workspace;
 * he's working on fixing kio standalone build (reviews posted);
 * he's blocked on desktoptojson, he got an ugly suggestion on cmake-user but
kde-buildsystem didn't get back to him;
 * he consider merging his superbuild changes which are still pending;

 * dfaure has been chasing a bug in Qt which affects KIO;

 * jpwhiting moved kspeech to staging and will look into finding its final
place;

 * mgraesslin merged kcolorschememanager;
 * he also included the netwm port to xcb;
 * he would need a prompt review on http://pastebin.kde.org/pjyjpm9on ;
 * he also waits on a crasher fix https://git.reviewboard.kde.org/r/113877/ ;

 * randomguy3 got kmediaplayer ready (it is in staging, soon tier3);
 * he's also working on KDBusService;

 * Riddell is done for the coinstallability;
 * he completed the list for the new runtime organization;
 * he needs feedback on all that;

 * sebas is working on plasma applets in the panel (calendar, clock, systray);
 * he's also trying to get his build back on track;

 * teo is still working on ksmserver, it starts and run kwin successfully now;
 * he's also fixing the commandline parsing;

 * afiestas is working on powerdevil to restore its functionalities;
 * he also plans to look in kded bugs;

 * apol has been looking into making porting away from kde4support easier;
 * he also worked a bit on the standalone builds effort;
 * he almost removed all plasma-framework dependencies on kde4support;

 * ervin reviewed a bit, mostly got busy with the pim sprint.

If you got questions, feel free to ask.

Regards.
--
Kévin Ottens, http://ervin.ipsquad.net

KDAB - proud supporter of KDE, http://www.kdab.com



signature.asc
Description: This is a digitally signed message part.