Re: Review Request 114737: KInfocenter/OpenGL: reimplement the ReadPipe() function with QProcess
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114737/#review48287 --- I made another change because I noticed a QProcess: Destroyed while process is still running. message in the terminal. I now call QProcess::waitForFinished() instead of QProcess::waitForReadyRead(). This works as well, and gets rid of that warning. - Wolfgang Bauer On Jan. 4, 2014, 5:54 p.m., Wolfgang Bauer wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114737/ --- (Updated Jan. 4, 2014, 5:54 p.m.) Review request for kde-workspace and David Stephen Hubner. Repository: kde-workspace Description --- This patch reimplements the ReadPipe() function by using QProcess instead of popen(). This should make it more portable. As a positive side-effect, this also removes those sh: lspci: command not found. messages when run in Konsole and lspci is not in the user's path. This was suggested on the kde-core-devel mailinglist in November: http://lists.kde.org/?l=kde-core-develm=138407113011843w=2 http://lists.kde.org/?l=kde-core-develm=138409755820003w=2 Diffs - kinfocenter/Modules/opengl/opengl.cpp 8901957 Diff: https://git.reviewboard.kde.org/r/114737/diff/ Testing --- Ran KInfocenter with lspci in /usr/bin/ (i.e. in the user's path) and /sbin/ (not in the user's path). The OpenGL module showed the 3D accelerator info correctly in both cases. With lspci removed completely it showed unknown as expected. Thanks, Wolfgang Bauer
Re: Review Request 114737: KInfocenter/OpenGL: reimplement the ReadPipe() function with QProcess
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114737/ --- (Updated Jan. 26, 2014, 10:43 a.m.) Review request for kde-workspace and David Stephen Hubner. Changes --- - changed the type of the FileName parameter to const QString - call QProcess::waitForFinished() instead of QProcess::waitForReadyRead() to get rid of a runtime warning (QProcess: Destroyed while process is still running.) Repository: kde-workspace Description --- This patch reimplements the ReadPipe() function by using QProcess instead of popen(). This should make it more portable. As a positive side-effect, this also removes those sh: lspci: command not found. messages when run in Konsole and lspci is not in the user's path. This was suggested on the kde-core-devel mailinglist in November: http://lists.kde.org/?l=kde-core-develm=138407113011843w=2 http://lists.kde.org/?l=kde-core-develm=138409755820003w=2 Diffs (updated) - kinfocenter/Modules/opengl/opengl.cpp 8901957 Diff: https://git.reviewboard.kde.org/r/114737/diff/ Testing --- Ran KInfocenter with lspci in /usr/bin/ (i.e. in the user's path) and /sbin/ (not in the user's path). The OpenGL module showed the 3D accelerator info correctly in both cases. With lspci removed completely it showed unknown as expected. Thanks, Wolfgang Bauer
Re: Review Request 113413: Improved Keyboard Layout Preview
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/113413/#review48292 --- Ship it! Ship It! - shivam makkar On Nov. 15, 2013, 9:37 a.m., shivam makkar wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/113413/ --- (Updated Nov. 15, 2013, 9:37 a.m.) Review request for KDE Runtime, kde-workspace and Andriy Rysin. Repository: kde-workspace Description --- Improved keyboard layout preview added geometry feature, multi-level keys (4) and parsed geometry file using Boost c++ libraries and tool tip showing symbol names. my GSoC-13 project ! Diffs - kcontrol/keyboard/preview/kbpreviewframe.cpp 2d7a11e Diff: https://git.reviewboard.kde.org/r/113413/diff/ Testing --- File Attachments English layout default geometry https://git.reviewboard.kde.org/media/uploaded/files/2013/11/05/57ce3e15-26a9-46e2-ad5d-6073e04a5489__snapshot16.jpg ukranian layout fixed 3/4 levels https://git.reviewboard.kde.org/media/uploaded/files/2013/11/15/527ada38-46b1-4b96-9d03-4a429d8275a5__snapshot19.jpg belgian fixed 3/4 level https://git.reviewboard.kde.org/media/uploaded/files/2013/11/15/1ec53ee9-f2ac-4a63-bc4f-6180160c20dd__snapshot20.jpg microsoft natural https://git.reviewboard.kde.org/media/uploaded/files/2013/11/15/aea0136b-c4f2-412e-9de7-534b64d70af0__snapshot18.jpg Thanks, shivam makkar
Re: Review Request 114715: Attempt to fix KZoneAllocator issue
On Jan. 24, 2014, 4:32 p.m., David Faure wrote: Urgh - a static object in a library? How did we not notice before... Needs to be fixed indeed. I would have used Q_GLOBAL_STATIC (which has methods like isDestroyed()), but I guess that's equivalent to your sharedpointer + strong ref idea, so why not. Where do you want me to commit this? Both to kdelibs master + kcompletion framework? - Kevin --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114715/#review48232 --- On Jan. 3, 2014, 5:52 p.m., Kevin Funk wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114715/ --- (Updated Jan. 3, 2014, 5:52 p.m.) Review request for kdelibs and Frank Reininghaus. Bugs: 327599 http://bugs.kde.org/show_bug.cgi?id=327599 Repository: kdelibs Description --- Attempt to fix KZoneAllocator issue kcompletion.p_h: Make the static KZoneAllocator member of KCompTreeNode a shared pointer so external users can hold a reference to it. kcompletion.cpp: Hold a reference to KCompTreeNode's KZoneAllocator instance so we avoid deleting the KZoneAllocator too early. See attached bug report for possible causes. (Hint: It crashes on Windows because ~KZoneAllocator is called to early.) kallocator.cpp: Use printf instead of qDebug(), because this code path code might be called very late during destruction and qDebug() will crash deep inside Qt. Also see discussion: http://lists.kde.org/?l=kde-develm=138583383708455w=1 BUG: 327599 CCBUG: 243375 Diffs - kdecore/util/kallocator.cpp 8b21120c62c513ea41686fe8185ec2808fe5d83a kdeui/util/kcompletion.cpp 340aa92b900d670e2ad73f70a63d5221d0feed1d kdeui/util/kcompletion_p.h 1cf31db3f16fe3421415cd54265eee20bb998710 Diff: https://git.reviewboard.kde.org/r/114715/diff/ Testing --- Thanks, Kevin Funk
Re: KDE Review - Moving Artikulate to KDE Edu
El Dimarts, 14 de gener de 2014, a les 19:52:57, Albert Astals Cid va escriure: El Dimarts, 14 de gener de 2014, a les 09:18:10, Andreas Cord-Landwehr va escriure: Hi, I think you should work on getting kqmlgraphplugin released first, depending on something unreleased scares me a bit. Just talked to Sebastian (maintainer of the plugin) and he will do a technical preview release of the plugin soon. BTW this code already exists in KTouch for quite some time and now is only split into a self-contained plugin. After compiling and installing kqmlgraphplugin and artikulate i got artikulate(10361) LearnerProfile::Storage::database: Database path: /home/kdeunstable/.kde/share/apps/artikulate/learnerdata.db artikulate(10361) LearnerProfile::ProfileManagerPrivate::ProfileManagerPrivate: No last active profile found, falling back to first found profile artikulate(10361): There is no subdirectory skeletons in directory . cannot load skeletons. artikulate(10361): There is no subdirectory courses in directory . cannot load courses. When running it and no window at all. As discussed on IRC, the program starts now (was access problem to the sound card making Phonon to wait infinitely.) Are the course downloads working now or do you still have a problem with the KNS dialog? (if not, we should move that discussion to a bug report probably) Yeah my system is a bit broken, i'll try to test it again today or tomorrow and will come back with more info. So I did have a look at Artikulate yesterday and just found some minor nagging user flow issues that I told Andreas and he says he would be fixing. Other than that, looks good to me to move to kdeedu *but* we need to decide what to do with kqmlgraphplugin first, since we can't have a kdeedu app depending on a playground lib. Cheers, Albert Sorry for the noise! Cheers, Albert Greetings, Andreas
Re: KDE Review - Moving Artikulate to KDE Edu
On Sunday 26 January 2014 16:39:08 Albert Astals Cid wrote: So I did have a look at Artikulate yesterday and just found some minor nagging user flow issues that I told Andreas and he says he would be fixing. Other than that, looks good to me to move to kdeedu *but* we need to decide what to do with kqmlgraphplugin first, since we can't have a kdeedu app depending on a playground lib. Are there technical reasons why we cannot? Christoph Feck (kdepepo)
Re: KDE Review - Moving Artikulate to KDE Edu
El Diumenge, 26 de gener de 2014, a les 17:01:39, Christoph Feck va escriure: On Sunday 26 January 2014 16:39:08 Albert Astals Cid wrote: So I did have a look at Artikulate yesterday and just found some minor nagging user flow issues that I told Andreas and he says he would be fixing. Other than that, looks good to me to move to kdeedu *but* we need to decide what to do with kqmlgraphplugin first, since we can't have a kdeedu app depending on a playground lib. Are there technical reasons why we cannot? You can't compile something against something that is unreleased. Cheers, Albert Christoph Feck (kdepepo)
