Re: Review Request 118270: [doc] explicitly load external entities (after CVE-2014-0191)
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118270/ --- (Updated June 3, 2014, 3:50 p.m.) Review request for Documentation, KDE Frameworks, kdelibs, Rohan Garg, Jonathan Riddell, Luc Menut, and Rex Dieter. Changes --- Add Luc, who could have missed the last update Bugs: 335001 http://bugs.kde.org/show_bug.cgi?id=335001 Repository: kdelibs Description --- Use the more modern API function for XML loading and enable the flags which load the external entities, so that meinproc4 can work again after the security changes implemented for CVE-2014-0191. Without this change meinproc4 complains (see the referenced bug) The fix (half of the patch, the other half is on code which was removed) applies to KF5 too, hence the group. My tests shows that the documentation cache is properly generated as before, and the patch should work even on the old Packagers (Ubuntu packagers in CC, as Ubuntu is one of the few distributions where libxml2 has been already patched) could you please test it with a fixed libxml and without, and if possible with KF5 as well? Diffs - kdoctools/meinproc.cpp 0894d63 kdoctools/xslt.cpp a7265ca Diff: https://git.reviewboard.kde.org/r/118270/diff/ Testing --- meinproc4 works again Thanks, Luigi Toscano
Review Request 118504: Fix libssh timeout type
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118504/ --- Review request for KDE Runtime. Repository: kde-runtime Description --- While preparing the connection to a SFTP server kio_sftp puts the timeouts to libssh's ssh_options_set as pointers to int while libssh expects the them to be given as pointers to long. See: http://git.libssh.org/projects/libssh.git/tree/src/options.c#n587 http://git.libssh.org/projects/libssh.git/tree/src/options.c#n601 I could fix several unpredictable connection problems by kio_sftp with this patch. Diffs - kioslave/sftp/kio_sftp.cpp 21cffac0e5892944ca6c5b74537ebc4b7fb4738e Diff: https://git.reviewboard.kde.org/r/118504/diff/ Testing --- Thanks, Lutz Heermann
kdecore-ktimezonestest broken
Hi, David, this commit to kdelibs http://build.kde.org/view/KDE%20SC%20stable/job/kdelibs_stable/1089/changes broke the ktimezonetests http://build.kde.org/view/KDE%20SC%20stable/job/kdelibs_stable/1089/ Can you please fix them urgently before Thursday. Otherwise we'll either have to delay the release or revert your fix. Thanks, Albert
Re: kdecore-ktimezonestest broken
El Dimecres, 4 de juny de 2014, a les 00:27:45, Albert Astals Cid va escriure: Hi, David, this commit to kdelibs http://build.kde.org/view/KDE%20SC%20stable/job/kdelibs_stable/1089/changes broke the ktimezonetests http://build.kde.org/view/KDE%20SC%20stable/job/kdelibs_stable/1089/ Can you please fix them urgently before Thursday. Otherwise we'll either have to delay the release or revert your fix. I'm pretty sure that commit is also the culprit for this failure in testicaltimezones in kdepimlibs http://build.kde.org/view/KDE%20SC%20stable/job/kdepimlibs_stable/888/testReport/ Cheers, Albert Thanks, Albert
