Re: Review Request 118750: Prevent use after free
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118750/ --- (Updated June 15, 2014, 8:18 a.m.) Review request for kde-workspace and Andriy Rysin. Changes --- Use Thomas' suggestion – nicer way to fix the issue. Repository: kde-workspace Description --- Prior to this patch, the memory str was pointing to was freed once the ; was reached. By storing the result of opton.toAscii(), the memory is kept alive. Diffs (updated) - plasma-desktop/kcms/keyboard/preview/keysymhelper.cpp 67beb80 Diff: https://git.reviewboard.kde.org/r/118750/diff/ Testing --- Only recompiled the application so far. Thanks, Fabian Kosmale
Re: Review Request 118750: Prevent use after free
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118750/#review60124 --- Ship it! Please NOTICE that i've no mandate in the code section. You've certainly my vote, since the present code is clearly wrong and this patch implies no behavioral change, but please wait whether somebody has to raise a veto (next few workdays) before pushing (though i doubt so) - Thomas Lübking On June 15, 2014, 8:18 a.m., Fabian Kosmale wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118750/ --- (Updated June 15, 2014, 8:18 a.m.) Review request for kde-workspace and Andriy Rysin. Repository: kde-workspace Description --- Prior to this patch, the memory str was pointing to was freed once the ; was reached. By storing the result of opton.toAscii(), the memory is kept alive. Diffs - plasma-desktop/kcms/keyboard/preview/keysymhelper.cpp 67beb80 Diff: https://git.reviewboard.kde.org/r/118750/diff/ Testing --- Only recompiled the application so far. Thanks, Fabian Kosmale
Review Request 118763: Remove find_package(XCB) call as it is handled already by the top-level cmake file
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118763/
---
Review request for kde-workspace.
Repository: oxygen
Description
---
No idea if kde-workspace is still the right group, if not, please change.
find_package(XCB) is called without specifying the required components. This
leads to linking to unused dependencies in case they are installed.
Since XCB is searched for in the top level cmake file in the repository, there
is no need to search for it again. The component required there (only base XCB)
is sufficient.
Although, this should be sufficient to fix the deps problem, it makes sense to
link to XCB::XCB instead of ${XCB_LIBRARIES}, since the former is what is
actually needed.
Diffs
-
kstyle/CMakeLists.txt 165b62a
liboxygen/CMakeLists.txt 0d1dd94
Diff: https://git.reviewboard.kde.org/r/118763/diff/
Testing
---
Thanks,
Bernd Steinhauser
Re: Review Request 118749: Prevent crashes caused by invalid access of Konqueror's URL edit widget
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118749/#review60147 --- Ship it! Looks good, except for one error konqueror/src/konqmainwindow.cpp https://git.reviewboard.kde.org/r/118749/#comment41903 no, this should be mainWindow-comboEdit() - David Faure On June 14, 2014, 11:01 p.m., Dawit Alemayehu wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118749/ --- (Updated June 14, 2014, 11:01 p.m.) Review request for KDE Base Apps and David Faure. Bugs: 320500 http://bugs.kde.org/show_bug.cgi?id=320500 Repository: kde-baseapps Description --- The attached patch is intended to prevent all crashes that are caused by invalid access of the QLineEdit in Konqueror's URL combobox. Diffs - konqueror/src/konqmainwindow.h 4ad4c4f konqueror/src/konqmainwindow.cpp da8c82e Diff: https://git.reviewboard.kde.org/r/118749/diff/ Testing --- Thanks, Dawit Alemayehu
Re: Review Request 118749: Prevent crashes caused by invalid access of Konqueror's URL edit widget
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118749/ --- (Updated June 16, 2014, 3:48 a.m.) Review request for KDE Base Apps and David Faure. Changes --- Updated patch based on review. Bugs: 320500 http://bugs.kde.org/show_bug.cgi?id=320500 Repository: kde-baseapps Description --- The attached patch is intended to prevent all crashes that are caused by invalid access of the QLineEdit in Konqueror's URL combobox. Diffs (updated) - konqueror/src/konqmainwindow.h 4ad4c4f konqueror/src/konqmainwindow.cpp da8c82e Diff: https://git.reviewboard.kde.org/r/118749/diff/ Testing --- Thanks, Dawit Alemayehu
Re: Review Request 118749: Prevent crashes caused by invalid access of Konqueror's URL edit widget
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118749/#review60159 --- This review has been submitted with commit 1e171b4230886c7c3287d8de7df7f75444b1356c by Dawit Alemayehu to branch KDE/4.13. - Commit Hook On June 16, 2014, 3:48 a.m., Dawit Alemayehu wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118749/ --- (Updated June 16, 2014, 3:48 a.m.) Review request for KDE Base Apps and David Faure. Bugs: 320500 http://bugs.kde.org/show_bug.cgi?id=320500 Repository: kde-baseapps Description --- The attached patch is intended to prevent all crashes that are caused by invalid access of the QLineEdit in Konqueror's URL combobox. Diffs - konqueror/src/konqmainwindow.h 4ad4c4f konqueror/src/konqmainwindow.cpp da8c82e Diff: https://git.reviewboard.kde.org/r/118749/diff/ Testing --- Thanks, Dawit Alemayehu
Re: Review Request 118749: Prevent crashes caused by invalid access of Konqueror's URL edit widget
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118749/ --- (Updated June 16, 2014, 3:50 a.m.) Status -- This change has been marked as submitted. Review request for KDE Base Apps and David Faure. Bugs: 320500 http://bugs.kde.org/show_bug.cgi?id=320500 Repository: kde-baseapps Description --- The attached patch is intended to prevent all crashes that are caused by invalid access of the QLineEdit in Konqueror's URL combobox. Diffs - konqueror/src/konqmainwindow.h 4ad4c4f konqueror/src/konqmainwindow.cpp da8c82e Diff: https://git.reviewboard.kde.org/r/118749/diff/ Testing --- Thanks, Dawit Alemayehu
