Re: Holes in KDE (fork of Changes in Git Infra thread)
Ian Wadham wrote: Hello Ian, for reference, I'm one of the KDE Community Forum adminstrators (aka the green guys). So what CAN I do? This needs major re-phrasing --- hopefully as positives rather than negatives. This comes from the upstream software we use - phpBB. I admit it's written in a not-so-friendly way, but there's little we can do at this point: mainly because we try (reasonably) to avoid modifying the upstream software too much, because that has a maintenance cost (and we already are short on skilled people and we already have some modifications to the forum software wrt upstream). I have one. Otherwise, I would have to register a new KDE Identity in order to reply, for example, to a maintainer wanted post(?) Yes, the forum requires a valid KDE Identity login. more. Another possible turnoff. Speaking for myself, I almost invariably click away from sites that want you to register, unless I am really, really interested. Unfortunately, this is unavoidable as forums as large as KDE's attract a whole load of bots, spammers, and other ad-spewers. Even with registration enabled (and checks to external services to prevent obvious spammers) we have to kill several spam posts per day. Also IMO registration is to keep a minimal barrier of entry to prevent flames and other unwanted behavior (granted, the forums behave exceptionally well - few times we've had to poke people to behave). Hopefully this clears things up. -- Luca Beltrame - KDE Forums team KDE Science supporter GPG key ID: 6E1A4E79
Re: Adding experimental parts to a KF5 library
The C++ committee uses (for example) std::experimental::something I was thinking about something along these lines as well. say it's a technology preview Both would be ok I guess, the only problem I see with TP is that is one does not read the README, it might be missed. I'd propose to go for: - experimental namespace to force the user to see that something is not stable - 0 soversion to show that the library has no stable ABI. Cheerio, Ivan On 10 January 2015 at 10:23, Ivan Čukić ivan.cu...@gmail.com wrote: The C++ committee uses (for example) std::experimental::something I was thinking about something along these lines as well. say it's a technology preview Both would be ok I guess, the only problem I see with TP is that is one does not read the README, it might be missed. I'd propose to go for: - experimental namespace to force the user to see that something is not stable - 0 soversion to show that the library has no stable ABI. Cheerio, Ivan On 9 January 2015 at 20:54, Mark Gaiser mark...@gmail.com wrote: On Fri, Jan 9, 2015 at 5:34 PM, Ivan Čukić ivan.cu...@kde.org wrote: Hi, Because of the short release cycle for the frameworks, it is hard to have bigger new features included into one of them. Slowly evolving APIs while developing stuff leaves a lot of crud and deprecated methods later. What is our policy about having experimental (unstable API/ABI) parts in a framework (obviously, in a separate binary, so that the main library remains BC)? Cheerio, Ivan The C++ committee uses (for example) std::experimental::something. Why don't we adapt the same in frameworks. There it would probably be: framework::experimental::something. Or Qt as another example, they simply say it's a technology preview :) I don't think they put it under a special namespace. -- KDE, ivan.cu...@kde.org, http://ivan.fomentgroup.org/ gpg key id: 850B6F76 -- Cheerio, Ivan -- While you were hanging yourself on someone else's words Dying to believe in what you heard I was staring straight into the shining sun
Re: Review Request 121717: libksysguard/processtable: Add new column Relative Start Time
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121717/#review73675 --- processui/ProcessModel.cpp https://git.reviewboard.kde.org/r/121717/#comment51278 You don't need this, since - as I understand - all functions in the class can be static. processui/ProcessModel.cpp https://git.reviewboard.kde.org/r/121717/#comment51274 What do you mean by the comment 'first iteration'? processui/timeutil.h https://git.reviewboard.kde.org/r/121717/#comment51277 This can be static, too, right? processui/timeutil.h https://git.reviewboard.kde.org/r/121717/#comment51275 No sure, but maybe in some language we need a proper singular / plural handling here, too? Same for the other two i18nc calls. - Dominik Haumann On Jan. 9, 2015, 10:25 a.m., Gregor Mi wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121717/ --- (Updated Jan. 9, 2015, 10:25 a.m.) Review request for KDE Base Apps and John Tapsell. Repository: libksysguard Description --- This will add a new column Relative Start Time which shows how much time has elapsed since the process was started. Some details: - add new heading with default location between Shared Memory and Command and not visible by default - define What's this - define Tooltip - define sorting - add class TimeUtil with methods: - systemUptimeSeconds - systemUptimeAbsolute - secondsToHumanElapsedString (for this one a unit test was added, see chronotest.cpp) This code reformatting goes in separate commits: - ProcessModel.cpp: reformat code: consistent number of linebreaks between method definitions (1 blank line) - ProcessModel.h: reformat code: split long enum line into separte lines for better diffing Side note on sorting: I was wondering if the sorting of the PID column is exactly the same as with the new Relative Start Time column. When testing on my computer it was. But according to this post one cannot generally assume that sorting by PID will reflect the relative start order of the processes: http://stackoverflow.com/questions/822797/about-the-pid-of-the-process Diffs - processcore/process.h 85a3a13388c44f768040dbc6602ab3211edd5b21 processui/ksysguardprocesslist.cpp 894e9a4d42112e01e742f1b0a2bcd6be7a844258 processui/timeutil.h PRE-CREATION tests/CMakeLists.txt 0fb3ab620564abf09f82d1609fc464d5597b2bd3 tests/chronotest.h PRE-CREATION tests/chronotest.cpp PRE-CREATION processcore/process.cpp 190f4902fa6f3bae2d8b60dbf1a43be71beb1820 processcore/processes_linux_p.cpp 0cff0e8b407a087dc29f755b12ea3d784ba34e6a processui/ProcessModel.h a338536023f9d003a44bcb8420b9288f8673ea92 processui/ProcessModel.cpp 3acf52b92f4a8ca054d88aad1ec6b31f4a31f297 Diff: https://git.reviewboard.kde.org/r/121717/diff/ Testing --- Run ksysguard, show new column, sort in both directions. Minor issue: as the seconds pass the values in the new column will not be updated automatically unless there is some user interaction (like mouse hovering/moving or sorting). New unit test passes. Thanks, Gregor Mi
Re: Holes in KDE (fork of Changes in Git Infra thread)
On 10/01/2015, at 8:49 PM, Luca Beltrame wrote: For reference, I'm one of the KDE Community Forum adminstrators (aka the green guys). In reply to what Ian Wadham wrote: So what CAN I do? This needs major re-phrasing --- hopefully as positives rather than negatives. This comes from the upstream software we use - phpBB. I admit it's written in a not-so-friendly way, but there's little we can do at this point: mainly because we try (reasonably) to avoid modifying the upstream software too much, because that has a maintenance cost (and we already are short on skilled people and we already have some modifications to the forum software wrt upstream). I have one. Otherwise, I would have to register a new KDE Identity in order to reply, for example, to a maintainer wanted post(?) Yes, the forum requires a valid KDE Identity login. more. Another possible turnoff. Speaking for myself, I almost invariably click away from sites that want you to register, unless I am really, really interested. Unfortunately, this is unavoidable as forums as large as KDE's attract a whole load of bots, spammers, and other ad-spewers. Even with registration enabled (and checks to external services to prevent obvious spammers) we have to kill several spam posts per day. Also IMO registration is to keep a minimal barrier of entry to prevent flames and other unwanted behavior (granted, the forums behave exceptionally well - few times we've had to poke people to behave). Hopefully this clears things up. Yes, it does. I understand. I guess I could add a rider paragraph to anything I post, to reassure newbies to persevere with the way the site does things and to say that they will not sign their life away or receive endless emails and ads by getting a KDE Identity. KDE really does need new recruits --- badly. Cheers, Ian W.
Re: Holes in KDE (fork of Changes in Git Infra thread)
El Dissabte, 10 de gener de 2015, a les 23:10:47, Ian Wadham va escriure: On 10/01/2015, at 8:49 PM, Luca Beltrame wrote: For reference, I'm one of the KDE Community Forum adminstrators (aka the green guys). In reply to what Ian Wadham wrote: So what CAN I do? This needs major re-phrasing --- hopefully as positives rather than negatives. This comes from the upstream software we use - phpBB. I admit it's written in a not-so-friendly way, but there's little we can do at this point: mainly because we try (reasonably) to avoid modifying the upstream software too much, because that has a maintenance cost (and we already are short on skilled people and we already have some modifications to the forum software wrt upstream). I have one. Otherwise, I would have to register a new KDE Identity in order to reply, for example, to a maintainer wanted post(?) Yes, the forum requires a valid KDE Identity login. more. Another possible turnoff. Speaking for myself, I almost invariably click away from sites that want you to register, unless I am really, really interested. Unfortunately, this is unavoidable as forums as large as KDE's attract a whole load of bots, spammers, and other ad-spewers. Even with registration enabled (and checks to external services to prevent obvious spammers) we have to kill several spam posts per day. Also IMO registration is to keep a minimal barrier of entry to prevent flames and other unwanted behavior (granted, the forums behave exceptionally well - few times we've had to poke people to behave). Hopefully this clears things up. Yes, it does. I understand. I guess I could add a rider paragraph to anything I post, to reassure newbies to persevere with the way the site does things and to say that they will not sign their life away or receive endless emails and ads by getting a KDE Identity. KDE really does need new recruits --- badly. Ian, I'd appreciate if you could write your emails not as if the world was going to end. Every of your emails seems as if things were very bad, they are not, they can be improved, yes, but reading your emails, if i were a newbie, i'd ran away from what you paint as a dying project. Cheers, Albert Cheers, Ian W.
Re: Review Request 121717: libksysguard/processtable: Add new column Relative Start Time
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121717/#review73714 --- processcore/process.cpp https://git.reviewboard.kde.org/r/121717/#comment51308 initialize to 0 in the constructor? - Albert Astals Cid On gen. 9, 2015, 10:25 a.m., Gregor Mi wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121717/ --- (Updated gen. 9, 2015, 10:25 a.m.) Review request for KDE Base Apps and John Tapsell. Repository: libksysguard Description --- This will add a new column Relative Start Time which shows how much time has elapsed since the process was started. Some details: - add new heading with default location between Shared Memory and Command and not visible by default - define What's this - define Tooltip - define sorting - add class TimeUtil with methods: - systemUptimeSeconds - systemUptimeAbsolute - secondsToHumanElapsedString (for this one a unit test was added, see chronotest.cpp) This code reformatting goes in separate commits: - ProcessModel.cpp: reformat code: consistent number of linebreaks between method definitions (1 blank line) - ProcessModel.h: reformat code: split long enum line into separte lines for better diffing Side note on sorting: I was wondering if the sorting of the PID column is exactly the same as with the new Relative Start Time column. When testing on my computer it was. But according to this post one cannot generally assume that sorting by PID will reflect the relative start order of the processes: http://stackoverflow.com/questions/822797/about-the-pid-of-the-process Diffs - processcore/process.h 85a3a13388c44f768040dbc6602ab3211edd5b21 processui/ksysguardprocesslist.cpp 894e9a4d42112e01e742f1b0a2bcd6be7a844258 processui/timeutil.h PRE-CREATION tests/CMakeLists.txt 0fb3ab620564abf09f82d1609fc464d5597b2bd3 tests/chronotest.h PRE-CREATION tests/chronotest.cpp PRE-CREATION processcore/process.cpp 190f4902fa6f3bae2d8b60dbf1a43be71beb1820 processcore/processes_linux_p.cpp 0cff0e8b407a087dc29f755b12ea3d784ba34e6a processui/ProcessModel.h a338536023f9d003a44bcb8420b9288f8673ea92 processui/ProcessModel.cpp 3acf52b92f4a8ca054d88aad1ec6b31f4a31f297 Diff: https://git.reviewboard.kde.org/r/121717/diff/ Testing --- Run ksysguard, show new column, sort in both directions. Minor issue: as the seconds pass the values in the new column will not be updated automatically unless there is some user interaction (like mouse hovering/moving or sorting). New unit test passes. Thanks, Gregor Mi
Re: Review Request 120573: [OS X] make KDE's trash use the OS X trash
On gen. 9, 2015, 12:27 a.m., David Faure wrote: Sorry, this one got drowned in the ML noise and I missed it After renaming idForDevice to idForMountPoint, please push to kde-runtime once the Applications 14.12 freeze is over. Then you'll have to forward-port this commit to the kio repository, where the kio_trash code has moved (and port your code to Qt5/KF5, although hopefully it's not a lot of work). René J.V. Bertin wrote: When will that freeze be over? Also, think I introduced a (minor?) regression when I heeded a number of comments on Oct. 17th, and wrote _Trash infrastructure is now created only when really needed (please check if I forgot any cases), which does NOT include scanning the trash nor doing something with a trashed file (knowing a trashed file by name should mean the infrastruct. exists)._ The regression being that when you empty the OS X trash and then navigate to the wastebin in Dolphin, any KDE content that was in the trash is still shown; even the properties are still available. I haven't checked exactly why this is yet; should I, or could I use it as a check to see if anyone actually uses the feature enough to be bothered? ;) The packages for 14.12.1 have been created, you can commit now. About the regression, is it MacOS only or for everyone? - Albert --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120573/#review73542 --- On nov. 27, 2014, 11:04 p.m., René J.V. Bertin wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120573/ --- (Updated nov. 27, 2014, 11:04 p.m.) Review request for KDE Software on Mac OS X, KDE Runtime and David Faure. Repository: kde-runtime Description --- KDE on OS X does not handle the desktop session (no Plasma) nor can it rely on XDG to obtain the proper paths to use for something like the trash. As a result, all applications that propose to move things they manage to the wastebin (Dolphin, but also digiKam) will store those items in a place that has no particular meaning on OS X, and that will thus tend to fill up. OS X stores trash in one of several locations. Files trashed from the boot volume (and/or the volume containing $HOME, I don't actually know that) end up in `~/.Trash`. Files deleted from other volumes end up in `/Volumes/volName/.Trashes/uid`, where volName is the volume name (regardless whether it's an external or a remote drive; only mounted NFS shares are handled differently) and uid the numerical user id. Permissions on `.Trashes` are the same as those expected by KDE. The kio_trash kioslave appears to support several actual trash directory locations, just like OS X. `TrashImpl::init()` creates a standard trash in `~/.local/share/Trash` (at least under OS X) but also `TrashImpl::trashForMountPoint()` that is used in cases I have not yet encountered. On OS X, my modified `TrashImpl::init()` sets the standard trash directory to `~/.Trash/KDE.trash` and will create the `files` and `info` subdirectories as required, because they will of course be deleted when the user empties the OS X trash. `TrashImpl::fileRemoved()` has been modified to call a new function, `deleteEmptyTrashInfraStructure` to delete the KDE trash's internal infrastructure when the wastebin is empty so that OS X also sees the trash as emptied. (Since implementing `deleteEmptyTrashInfraStructure` this feature actually works, as expected as far as I can tell). Remains to be done: - determine in what cases `trashForMountPoint()` is used, and finish the modifications for it to use `/.Trashes/uid/KDE.trash` Diffs - kioslave/trash/trashimpl.cpp fe2e152 kioslave/trash/trashimpl.h bc68723 kioslave/trash/tests/CMakeLists.txt 9161fdf kioslave/trash/kcmtrash.cpp f4811fd kioslave/trash/CMakeLists.txt 3604089 Diff: https://git.reviewboard.kde.org/r/120573/diff/ Testing --- On OS X 10.6.8 with kdelibs and kde-runtime git/4.14, using Dolphin. Tested actions are - move items to wastebin from $HOME and a directory on a different volume - restore items to both places - empty wastebin through Dolphin - empty OS X trashcan Thanks, René J.V. Bertin
Re: Review Request 121717: libksysguard/processtable: Add new column Relative Start Time
On Јан. 10, 2015, 5:29 по п., Dominik Haumann wrote: processui/timeutil.h, line 67 https://git.reviewboard.kde.org/r/121717/diff/2/?file=337999#file337999line67 No sure, but maybe in some language we need a proper singular / plural handling here, too? Same for the other two i18nc calls. I would leave it as it is, and wait for a translator to complain. Although the amount is integer, it is represented with a unit, as if it were real-valued. It would also be ugly to convert the other two to plural, as it would take splitting them into multiple submessages. - Chusslove --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121717/#review73675 --- On Јан. 9, 2015, 11:25 пре п., Gregor Mi wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121717/ --- (Updated Јан. 9, 2015, 11:25 пре п.) Review request for KDE Base Apps and John Tapsell. Repository: libksysguard Description --- This will add a new column Relative Start Time which shows how much time has elapsed since the process was started. Some details: - add new heading with default location between Shared Memory and Command and not visible by default - define What's this - define Tooltip - define sorting - add class TimeUtil with methods: - systemUptimeSeconds - systemUptimeAbsolute - secondsToHumanElapsedString (for this one a unit test was added, see chronotest.cpp) This code reformatting goes in separate commits: - ProcessModel.cpp: reformat code: consistent number of linebreaks between method definitions (1 blank line) - ProcessModel.h: reformat code: split long enum line into separte lines for better diffing Side note on sorting: I was wondering if the sorting of the PID column is exactly the same as with the new Relative Start Time column. When testing on my computer it was. But according to this post one cannot generally assume that sorting by PID will reflect the relative start order of the processes: http://stackoverflow.com/questions/822797/about-the-pid-of-the-process Diffs - processcore/process.h 85a3a13388c44f768040dbc6602ab3211edd5b21 processui/ksysguardprocesslist.cpp 894e9a4d42112e01e742f1b0a2bcd6be7a844258 processui/timeutil.h PRE-CREATION tests/CMakeLists.txt 0fb3ab620564abf09f82d1609fc464d5597b2bd3 tests/chronotest.h PRE-CREATION tests/chronotest.cpp PRE-CREATION processcore/process.cpp 190f4902fa6f3bae2d8b60dbf1a43be71beb1820 processcore/processes_linux_p.cpp 0cff0e8b407a087dc29f755b12ea3d784ba34e6a processui/ProcessModel.h a338536023f9d003a44bcb8420b9288f8673ea92 processui/ProcessModel.cpp 3acf52b92f4a8ca054d88aad1ec6b31f4a31f297 Diff: https://git.reviewboard.kde.org/r/121717/diff/ Testing --- Run ksysguard, show new column, sort in both directions. Minor issue: as the seconds pass the values in the new column will not be updated automatically unless there is some user interaction (like mouse hovering/moving or sorting). New unit test passes. Thanks, Gregor Mi
Re: Review Request 120573: [OS X] make KDE's trash use the OS X trash
On Jan. 9, 2015, 1:27 a.m., David Faure wrote: Sorry, this one got drowned in the ML noise and I missed it After renaming idForDevice to idForMountPoint, please push to kde-runtime once the Applications 14.12 freeze is over. Then you'll have to forward-port this commit to the kio repository, where the kio_trash code has moved (and port your code to Qt5/KF5, although hopefully it's not a lot of work). René J.V. Bertin wrote: When will that freeze be over? Also, think I introduced a (minor?) regression when I heeded a number of comments on Oct. 17th, and wrote _Trash infrastructure is now created only when really needed (please check if I forgot any cases), which does NOT include scanning the trash nor doing something with a trashed file (knowing a trashed file by name should mean the infrastruct. exists)._ The regression being that when you empty the OS X trash and then navigate to the wastebin in Dolphin, any KDE content that was in the trash is still shown; even the properties are still available. I haven't checked exactly why this is yet; should I, or could I use it as a check to see if anyone actually uses the feature enough to be bothered? ;) Albert Astals Cid wrote: The packages for 14.12.1 have been created, you can commit now. About the regression, is it MacOS only or for everyone? How could it be for everyone? It's only on OS X that the KDE wastebin is hosted in the Finder trash ;) - René J.V. --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120573/#review73542 --- On Nov. 28, 2014, 12:04 a.m., René J.V. Bertin wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120573/ --- (Updated Nov. 28, 2014, 12:04 a.m.) Review request for KDE Software on Mac OS X, KDE Runtime and David Faure. Repository: kde-runtime Description --- KDE on OS X does not handle the desktop session (no Plasma) nor can it rely on XDG to obtain the proper paths to use for something like the trash. As a result, all applications that propose to move things they manage to the wastebin (Dolphin, but also digiKam) will store those items in a place that has no particular meaning on OS X, and that will thus tend to fill up. OS X stores trash in one of several locations. Files trashed from the boot volume (and/or the volume containing $HOME, I don't actually know that) end up in `~/.Trash`. Files deleted from other volumes end up in `/Volumes/volName/.Trashes/uid`, where volName is the volume name (regardless whether it's an external or a remote drive; only mounted NFS shares are handled differently) and uid the numerical user id. Permissions on `.Trashes` are the same as those expected by KDE. The kio_trash kioslave appears to support several actual trash directory locations, just like OS X. `TrashImpl::init()` creates a standard trash in `~/.local/share/Trash` (at least under OS X) but also `TrashImpl::trashForMountPoint()` that is used in cases I have not yet encountered. On OS X, my modified `TrashImpl::init()` sets the standard trash directory to `~/.Trash/KDE.trash` and will create the `files` and `info` subdirectories as required, because they will of course be deleted when the user empties the OS X trash. `TrashImpl::fileRemoved()` has been modified to call a new function, `deleteEmptyTrashInfraStructure` to delete the KDE trash's internal infrastructure when the wastebin is empty so that OS X also sees the trash as emptied. (Since implementing `deleteEmptyTrashInfraStructure` this feature actually works, as expected as far as I can tell). Remains to be done: - determine in what cases `trashForMountPoint()` is used, and finish the modifications for it to use `/.Trashes/uid/KDE.trash` Diffs - kioslave/trash/trashimpl.cpp fe2e152 kioslave/trash/trashimpl.h bc68723 kioslave/trash/tests/CMakeLists.txt 9161fdf kioslave/trash/kcmtrash.cpp f4811fd kioslave/trash/CMakeLists.txt 3604089 Diff: https://git.reviewboard.kde.org/r/120573/diff/ Testing --- On OS X 10.6.8 with kdelibs and kde-runtime git/4.14, using Dolphin. Tested actions are - move items to wastebin from $HOME and a directory on a different volume - restore items to both places - empty wastebin through Dolphin - empty OS X trashcan Thanks, René J.V. Bertin
