Re: Help solving this month's Bug of the Month
On Wed, Feb 04, 2015 at 04:45:26PM +0100, Christoph Feck wrote: According to recent comments, this is bug is still reproducible for some users, but not for others. It is unclear if the actual issue is in KDE software, Qt libraries, xorg libraries, or the keyboard layout definition files. From reading the latest comments on that bug, and the linked Qt bug report, it seems pretty clear-cut to be a Qt bug that's fixed in Qt5, but not in Qt4? So maybe it should just be marked as an upstream bug? -- Martin Sandsmark
Re: Moving KDE Telepathy to kdenetwork
On Wednesday 04 February 2015 01:51:49 Albert Astals Cid wrote: El Dimarts, 3 de febrer de 2015, a les 00:49:17, Martin Klapetek va escriure: Hi, so we decided with KDE Telepathy to join the big guys and become part of KDE Applications 15.04. So I'd like to request a move of KDE Telepathy repos[1] to kdenetwork/. This is also a mail to Urs Wolfer asking for approval as per the policies. KTP is all KF5 based at the moment, right? Not being a IM user myself, how does KTP compare to kopete feature wise? Kopete mailing list: is there any work happening in kopete? Are you even thinking on a port to KF5? I do not have time right now to port Kopete to KF5. I'm still using Kopete and if I catch some crash/bug I will try to fix it. But in last months I did not have time to work on any new feature due to finishing my university study... Anyway, if there are some students interested in Kopete and KDE will be in next Google Summer of Code and could help mentor some Kopete project... -- Pali Rohár pali.ro...@gmail.com signature.asc Description: This is a digitally signed message part.
Re: Review Request 122320: use xcb-screen count instead of qguiapplication.screens
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122320/#review75358 --- startkde/kcminit/CMakeLists.txt https://git.reviewboard.kde.org/r/122320/#comment52123 you forgot to git add the config-xcb.h.cmake - Martin Gräßlin On Feb. 4, 2015, 1:31 a.m., Nick Shaforostoff wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122320/ --- (Updated Feb. 4, 2015, 1:31 a.m.) Review request for kde-workspace, Martin Gräßlin and Thomas Lübking. Repository: plasma-workspace Description --- this patch makes kcminit behave like in kde4: it uses proper xcb screen count which may be different from QGuiApplication::screens().count(). for example when i connext external monitor via vga to my laptop, xcb screen count is still '1', while QGuiApplication::screens().count() returns '2'. switching from QGuiApplication to QCoreApplication still wasn't possible because modules like 'mouse' need gui initialized and would crash if kcminit uses QCoreApplication. Diffs - startkde/kcminit/CMakeLists.txt b17951f startkde/kcminit/main.cpp 1008966 Diff: https://git.reviewboard.kde.org/r/122320/diff/ Testing --- i have built kcminit on ubuntu vivid alpha 32-bit, replaced binaries and libraries in the system and successfuly could run kcminit_startup and reboot also went fine. Thanks, Nick Shaforostoff
Re: Review Request 122320: use xcb-screen count instead of qguiapplication.screens
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122320/#review75433 --- Can you explain why the count is different and why XCB's count is the correct one? In the commit message. - Thiago Macieira On Fev. 4, 2015, 12:31 a.m., Nick Shaforostoff wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122320/ --- (Updated Fev. 4, 2015, 12:31 a.m.) Review request for kde-workspace, Martin Gräßlin and Thomas Lübking. Repository: plasma-workspace Description --- this patch makes kcminit behave like in kde4: it uses proper xcb screen count which may be different from QGuiApplication::screens().count(). for example when i connext external monitor via vga to my laptop, xcb screen count is still '1', while QGuiApplication::screens().count() returns '2'. switching from QGuiApplication to QCoreApplication still wasn't possible because modules like 'mouse' need gui initialized and would crash if kcminit uses QCoreApplication. Diffs - startkde/kcminit/CMakeLists.txt b17951f startkde/kcminit/main.cpp 1008966 Diff: https://git.reviewboard.kde.org/r/122320/diff/ Testing --- i have built kcminit on ubuntu vivid alpha 32-bit, replaced binaries and libraries in the system and successfuly could run kcminit_startup and reboot also went fine. Thanks, Nick Shaforostoff
Re: make uninstall
On Monday 02 February 2015 21:49:22 Albert Astals Cid wrote: El Divendres, 30 de gener de 2015, a les 10:47:22, Alex Merry va escriure: On Friday 30 January 2015 10:44:23 Alex Merry wrote: Over on kde-frameworks-devel, there have been several requests to bring back `make uninstall` for KF5 and KF5-based projects. KDELibs4 used to define this for any dependent projects (it's essentially `xargs rm install_manifest.txt` under the hood), and we could easily add it to KDECMakeSettings (with an option to disable it). We could also easily make it opt-in, either by making a separate module to define an uninstall target or by requiring projects or users to set a variable/option. If we know there's people that want it, i guess it's better to make it opt- out, probably we'll get more homogeinity that way. This is now done (https://git.reviewboard.kde.org/r/122359/). Alex
Re: make uninstall
On Wednesday 04 February 2015 18:33:42 Alex Merry wrote: On Monday 02 February 2015 21:49:22 Albert Astals Cid wrote: El Divendres, 30 de gener de 2015, a les 10:47:22, Alex Merry va escriure: On Friday 30 January 2015 10:44:23 Alex Merry wrote: Over on kde-frameworks-devel, there have been several requests to bring back `make uninstall` for KF5 and KF5-based projects. KDELibs4 used to define this for any dependent projects (it's essentially `xargs rm install_manifest.txt` under the hood), and we could easily add it to KDECMakeSettings (with an option to disable it). We could also easily make it opt-in, either by making a separate module to define an uninstall target or by requiring projects or users to set a variable/option. If we know there's people that want it, i guess it's better to make it opt- out, probably we'll get more homogeinity that way. This is now done (https://git.reviewboard.kde.org/r/122359/). Thank you Alex, much appreciated! -- Milian Wolff m...@milianw.de http://milianw.de
Re: LibRingClient has moved to extragear/network
Elv1313 . ha scritto: Hi, After going through kdereview for the last few weeks, libringclient (formerly the sflphone-kde client logic library) is now moving to KDE extragear. I am currently starting to remove the legacy Qt4 support still required by the KDE4 client (and porting it to kf5) so the translation issue should be solved in the coming week. For now, the translations are still based on kde4 l10n way of handling pure Qt libraries. If it's still kdelibs4-based, can you please fix the translation branches on projects.kde.org so that trunk_kf5 is empty for now? I'm moving the translations. Ciao -- Luigi
Re: Help solving this month's Bug of the Month
El Dimecres, 4 de febrer de 2015, a les 18:06:23, Martin Sandsmark va escriure: On Wed, Feb 04, 2015 at 04:45:26PM +0100, Christoph Feck wrote: According to recent comments, this is bug is still reproducible for some users, but not for others. It is unclear if the actual issue is in KDE software, Qt libraries, xorg libraries, or the keyboard layout definition files. From reading the latest comments on that bug, and the linked Qt bug report, it seems pretty clear-cut to be a Qt bug that's fixed in Qt5, but not in Qt4? So maybe it should just be marked as an upstream bug? Even if it's an upstream bug, in my opinion the BugOfTheMonth+GardeningEffort is showing the users that we care, and if they are affected by a severe bug we're going to try to make as much as we can to fix it, not just toss it over the fence and say it's not us. Cheers, Albert
Re: Review Request 122320: use xcb-screen count instead of qguiapplication.screens
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122320/ --- (Updated Feb. 4, 2015, 8:59 p.m.) Status -- This change has been marked as submitted. Review request for kde-workspace, Martin Gräßlin and Thomas Lübking. Repository: plasma-workspace Description --- this patch makes kcminit behave like in kde4: it uses proper xcb screen count which may be different from QGuiApplication::screens().count(). for example when i connext external monitor via vga to my laptop, xcb screen count is still '1', while QGuiApplication::screens().count() returns '2'. switching from QGuiApplication to QCoreApplication still wasn't possible because modules like 'mouse' need gui initialized and would crash if kcminit uses QCoreApplication. Diffs - startkde/kcminit/CMakeLists.txt b17951f startkde/kcminit/main.cpp 1008966 Diff: https://git.reviewboard.kde.org/r/122320/diff/ Testing --- i have built kcminit on ubuntu vivid alpha 32-bit, replaced binaries and libraries in the system and successfuly could run kcminit_startup and reboot also went fine. Thanks, Nick Shaforostoff
Re: Help solving this month's Bug of the Month
On Wednesday 04 February 2015 21:51:53 Albert Astals Cid wrote: El Dimecres, 4 de febrer de 2015, a les 18:06:23, Martin Sandsmark va escriure: On Wed, Feb 04, 2015 at 04:45:26PM +0100, Christoph Feck wrote: According to recent comments, this is bug is still reproducible for some users, but not for others. It is unclear if the actual issue is in KDE software, Qt libraries, xorg libraries, or the keyboard layout definition files. From reading the latest comments on that bug, and the linked Qt bug report, it seems pretty clear-cut to be a Qt bug that's fixed in Qt5, but not in Qt4? So maybe it should just be marked as an upstream bug? Even if it's an upstream bug, in my opinion the BugOfTheMonth+GardeningEffort is showing the users that we care, and if they are affected by a severe bug we're going to try to make as much as we can to fix it, not just toss it over the fence and say it's not us. Cheers, Albert Exactly. Looking at current Plasma 5+Qt 5 bugs, we still need to support KDE 4 users for some time. And as explained at https://community.kde.org/Gardening/BugOfTheMonth we actually want to find developers who are able to investigate all levels of the software stack, because otherwise there will simply be no progress. Christoph Feck (kdepepo)
Re: Review Request 121361: DeviceAutomounter Settings ui texts are misleading, if not plain wrong.
On Dec. 8, 2014, 2:15 p.m., Sebastian Kügler wrote: solid-device-automounter/kcm/DeviceAutomounterKCM.ui, line 45 https://git.reviewboard.kde.org/r/121361/diff/1/?file=331961#file331961line45 Well, with this change, the whatsthis and I suppose the function of this checkbox does the exact opposite of its name. automountUnknownDevices now means only automount know devices. Thomas Lübking wrote: automountUnknownDevices is now labeled Automatically mount unknown devices and hinted all attached devices will be automatically mounted[, otherwise only remembered devices will be] Sounds correct to me, but the automount GUI sucks. You've to enable automounting to get a list of four items: - known only - all (does that invoke the known only rule?) on login - on plugin - an override list What you indeed have is on plugin and on login, multiplied by the seen only rule. And then there's an override list, with a lot of unchecked devices what seems to suggest the above rules doesn't actually apply to most things. What there should be are two checkboxes: [ ] Automount removable media when attached [ ] Automount removable media when logging in each of them activating a Device override group which allows to controlthe override list as well as a third checkbox [ ] Do not automount media that has not been mounted before And the following override list probably needs to be some sort of tristate - defaulting to no override, what could be done by a leading checkbox column which activates the override for this device itfp. Frank, are you able to propose an updated patch with the above comments addressed? - Christoph --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121361/#review71555 --- On Dec. 5, 2014, 7:06 p.m., Frank Schütte wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121361/ --- (Updated Dec. 5, 2014, 7:06 p.m.) Review request for kdelibs, Solid, Christoph Feck, and Helio Castro. Bugs: 243046 and 261376 http://bugs.kde.org/show_bug.cgi?id=243046 http://bugs.kde.org/show_bug.cgi?id=261376 Repository: kde-runtime Description --- automounterrc has four settings: [General] AutomountEnabled=true AutomountOnLogin=false AutomountOnPlugin=false AutomountUnknownDevices=true The ui text for AutomountUnknownDevices says the opposite of its functionality. This is repaired by the patch. Login/Plugin enable/disable overrides. I tried to clarify this a little bit. Diffs - solid-device-automounter/kcm/DeviceAutomounterKCM.ui 3827e95 Diff: https://git.reviewboard.kde.org/r/121361/diff/ Testing --- Thanks, Frank Schütte
Re: Help solving this month's Bug of the Month
On Wed, Feb 04, 2015 at 09:51:53PM +0100, Albert Astals Cid wrote: Even if it's an upstream bug, in my opinion the BugOfTheMonth+GardeningEffort is showing the users that we care, and if they are affected by a severe bug we're going to try to make as much as we can to fix it, not just toss it over the fence and say it's not us. I agree, with figuring out how it was fixed in Qt5, and backporting it to Qt4. :-) If you believe that keeping the bug in our tracker open will help on the impression to users / tracking it from our side, I agree we should keep it open. :-) -- Martin Sandsmark
Re: Review Request 122320: use xcb-screen count instead of qguiapplication.screens
On Фев. 4, 2015, 9:16 д.п., Martin Gräßlin wrote: startkde/kcminit/CMakeLists.txt, line 6 https://git.reviewboard.kde.org/r/122320/diff/4/?file=346734#file346734line6 you forgot to git add the config-xcb.h.cmake i know. its contents is the following: /* Define if you have XCB at all */ #cmakedefine XCB_FOUND are there any other issues apart this one? - Nick --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122320/#review75358 --- On Фев. 4, 2015, 12:31 д.п., Nick Shaforostoff wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122320/ --- (Updated Фев. 4, 2015, 12:31 д.п.) Review request for kde-workspace, Martin Gräßlin and Thomas Lübking. Repository: plasma-workspace Description --- this patch makes kcminit behave like in kde4: it uses proper xcb screen count which may be different from QGuiApplication::screens().count(). for example when i connext external monitor via vga to my laptop, xcb screen count is still '1', while QGuiApplication::screens().count() returns '2'. switching from QGuiApplication to QCoreApplication still wasn't possible because modules like 'mouse' need gui initialized and would crash if kcminit uses QCoreApplication. Diffs - startkde/kcminit/CMakeLists.txt b17951f startkde/kcminit/main.cpp 1008966 Diff: https://git.reviewboard.kde.org/r/122320/diff/ Testing --- i have built kcminit on ubuntu vivid alpha 32-bit, replaced binaries and libraries in the system and successfuly could run kcminit_startup and reboot also went fine. Thanks, Nick Shaforostoff
Re: Moving KDE Telepathy to kdenetwork
On Wed, Feb 4, 2015 at 1:51 AM, Albert Astals Cid aa...@kde.org wrote: El Dimarts, 3 de febrer de 2015, a les 00:49:17, Martin Klapetek va escriure: Hi, so we decided with KDE Telepathy to join the big guys and become part of KDE Applications 15.04. So I'd like to request a move of KDE Telepathy repos[1] to kdenetwork/. This is also a mail to Urs Wolfer asking for approval as per the policies. KTP is all KF5 based at the moment, right? Correct. Not being a IM user myself, how does KTP compare to kopete feature wise? I'm not sure to be honest as I don't know what Kopete can all do. KTp does not try to be a swiss army knife of IM, that's for sure, the main objectives are ease of use, simple UIs with powerful features underneath and providing good integration in Plasma. The main advantage is the architecture and backends - it's all DBus activated (and stateless) components, super easy to extend with new protocols support using Qt, GLib or Python. Plus the Telepathy project is widely adopted in the world - Unity, Ubuntu Phone, Gnome, Jolla, N9 and maybe in other places, making it proven by usage. Small downside is that it is developed mostly by Gnome folks and can suffer from being bent to their needs only. Kopete mailing list: is there any work happening in kopete? Are you even thinking on a port to KF5? KDE Telepathy has been through kdereview once and we've kept the culture of everything goes through review pretty high up, but I guess that move from extragear to main module also must go through kdereview? The app lifecycle page[2] does not mention this case. I'd say that given it had review already and we deemed it was good enough, we can just skip the code review and focus on more administrative stuff :D Worksforme :) Another part that KDE Telepathy needs is KAccounts and we'd like to move that one too, probably to kde-runtime but there seems to be some disagreements of the purpose of kde-runtime. KAccounts is basically a KCM, a kded module and a library for writing custom plugins for various KAccounts functionality. So please advise where to move that. Also note that this was in kdereview just a month ago so I'd like to just skip kdereview for this as it didn't have many changes. Was thinking, why not kdenetwork? I mean what kind of non network related account would you add to KAccounts? Well I don't have a strong opinion either way. If you think it suits better in kdenetwork, then ok. And yes at this point all accounts are network related. Cheers -- Martin Klapetek | KDE Developer
Re: Review Request 122320: use xcb-screen count instead of qguiapplication.screens
On Feb. 4, 2015, 10:16 a.m., Martin Gräßlin wrote: startkde/kcminit/CMakeLists.txt, line 6 https://git.reviewboard.kde.org/r/122320/diff/4/?file=346734#file346734line6 you forgot to git add the config-xcb.h.cmake Nick Shaforostoff wrote: i know. its contents is the following: /* Define if you have XCB at all */ #cmakedefine XCB_FOUND are there any other issues apart this one? no with that it's fine. - Martin --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122320/#review75358 --- On Feb. 4, 2015, 1:31 a.m., Nick Shaforostoff wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122320/ --- (Updated Feb. 4, 2015, 1:31 a.m.) Review request for kde-workspace, Martin Gräßlin and Thomas Lübking. Repository: plasma-workspace Description --- this patch makes kcminit behave like in kde4: it uses proper xcb screen count which may be different from QGuiApplication::screens().count(). for example when i connext external monitor via vga to my laptop, xcb screen count is still '1', while QGuiApplication::screens().count() returns '2'. switching from QGuiApplication to QCoreApplication still wasn't possible because modules like 'mouse' need gui initialized and would crash if kcminit uses QCoreApplication. Diffs - startkde/kcminit/CMakeLists.txt b17951f startkde/kcminit/main.cpp 1008966 Diff: https://git.reviewboard.kde.org/r/122320/diff/ Testing --- i have built kcminit on ubuntu vivid alpha 32-bit, replaced binaries and libraries in the system and successfuly could run kcminit_startup and reboot also went fine. Thanks, Nick Shaforostoff
Help solving this month's Bug of the Month
Hi developers! The KDE Gardening Team nominates one particular annoying bug as “The Bug of the Month”, see https://community.kde.org/Gardening This time, we need someone who can investigate a problem with keyboard shortcuts when a certain order of keyboard layouts is used: https://bugs.kde.org/show_bug.cgi?id=309193 According to recent comments, this is bug is still reproducible for some users, but not for others. It is unclear if the actual issue is in KDE software, Qt libraries, xorg libraries, or the keyboard layout definition files. Please help solving it, by adding ideas or patches to the relevant pages, review requests, or bugzilla pages. Anyone is invited to participate and our users will appreciate this bug getting solved. Suggestions for next month's bug to the kde-gardening mailing list. Thanks in advance! -- Christoph Feck http://kdepepo.wordpress.com/ KDE Quality Team
