Re: Review Request 123437: FinKexiv2: Use FindPkgConfig instead of UsePkgConfig
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123437/ --- (Updated July 19, 2015, 10:40 a.m.) Status -- This change has been marked as submitted. Review request for Build System and kdelibs. Changes --- Submitted with commit 35f85f102d6bd097f2fa45c92339f93570dd31ba by Heiko Becker to branch KDE/4.14. Repository: kdelibs Description --- The latter is deprecated and doesn't respect the PKG_CONFIG environment variable which makes it easy to deal with differently named pkg-config executables, e.g. arch-prefixed ones. Diffs - cmake/modules/FindKexiv2.cmake ad9969ab9c1e7f3848922ce6160a5725cb6641bb Diff: https://git.reviewboard.kde.org/r/123437/diff/ Testing --- I built okular and checked that it finds and links against libkexiv2. Thanks, Heiko Becker
Re: KDE Applications Versioning
Since this hasn't been finalized I didn't include it in my email to kde-cvs- announce about the creation of the 15.08 branches for the KDE Applications modules. Cheers, Albert El Dimarts, 14 de juliol de 2015, a les 07:08:57, Andreas Cord-Landwehr va escriure: On Monday 13 July 2015 23:14:17 Albert Astals Cid wrote: I did a few tweaks, i still feel it seems this is the official way other than an optional way of defining the version but maybe that's just me. Hi, I have the same feeling as Albert that the current text is not clear enough that both variants (increase version by hand and using the scripted approach) are fine. What about adding an introduction paragraph like the following: - snip - Every application has an application version number that regular has to be increased to distinguish different versions of the application (e.g., features, bugfixes). When an application does not have its own release schedule but is released alongside with KDE Applications, there is also the version number of the KDE Applications release. It is the maintainer's duty to take care on increasing the version number regularly and there are specifically two possible ways: 1. increase the version number by hand for each new release 2. use the same version number as KDE Applications and let the release script update the version number In the following, we explain how to use the scripted version numbers. - snap - If it is OK this way, I can add it later today to the wiki page. Cheers, Andreas
3 UDSEntry optimizations
Hi, I just pushed 3 UDSEntry changes to gerrit for your reviewing pleasure: 1: https://gerrit.vesnicky.cesnet.cz/r/#/c/473/ 2: https://gerrit.vesnicky.cesnet.cz/r/#/c/474/ 3: https://gerrit.vesnicky.cesnet.cz/r/#/c/475/ The end result is a faster UDSEntry in every way. The benchmark results (which are from udsentrybenchmark) can be found here: http://kdeblog.mageprojects.com/?p=394preview=1_ppp=c936cdced4 So.. what did i do this time? Initially i wanted to get rid of the extra bookkeeping without loss of speed or increasing memory usage. This was basically an experiment to see if i could get that working. I was guessing that a linear lookup (using std::find_if) would be equally fast as QVector::contains(). That turned out to be that case as you can see in the benchmarks. Next up i wanted to use more advanced C++11 that QVector simply doesn't allow: emplace_back: http://en.cppreference.com/w/cpp/container/vector/emplace_back My guess was that it would allow for quite some speedups in inserting because objects would be created in place instead of created and copied (or moved). Looks like i was right since the benchmarks for creating entries have been improved quite a bit. While at it, also implemented move semantics :) In terms of memory consumption these patches don't change much. Browsing a massive folder (500.000 files) in dolphin without this patch series took ~710MB, with it the figure was about 705MB. A saving, but nothing much compared tot the total usage. I would like to know what you folks think of these improvements. I really wonder how much more performance i can squeeze out of UDSEntry. Regarding gerrit. How can i make patch 2 and 3 dependent on 1? And why is gerrit failing? Best regards, Mark
