Re: Review Request 125056: Fix build on OS X

[Samuel Gaist]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125056/
---

(Updated Sept. 5, 2015, 8:02 p.m.)


Review request for kde-workspace and Jonathan Riddell.


Repository: kwallet-pam


Description (updated)
---

Added implementation of pam_syslog and pam_vsyslog for OS X

Added include dir setup to FindLibGcrypt

add reviewboardrc


Diffs
-

  .reviewboardrc PRE-CREATION 
  CMakeLists.txt bfdcfda71ef5ba3b5e4247afe02af1c23d064783 
  cmake/modules/FindLibGcrypt.cmake 27de0b46a82e92a24734476ea32401bef01a8ca8 
  pam_darwin.h PRE-CREATION 
  pam_darwin.c PRE-CREATION 
  pam_kwallet.c a84585ef1fc3f4aeac728e707d52479ec85b5300 

Diff: https://git.reviewboard.kde.org/r/125056/diff/


Testing
---

Build on OS X 10.8


Thanks,

Samuel Gaist

Re: Review Request 125056: Fix build on OS X

[Martin Klapetek]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125056/#review84880
---


Looks good to me


CMakeLists.txt (line 45)


This change is already preceeded with 
https://git.reviewboard.kde.org/r/124962/


- Martin Klapetek


On Sept. 5, 2015, 1:47 a.m., Samuel Gaist wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125056/
> ---
> 
> (Updated Sept. 5, 2015, 1:47 a.m.)
> 
> 
> Review request for kde-workspace and Jonathan Riddell.
> 
> 
> Repository: kwallet-pam
> 
> 
> Description
> ---
> 
> Add include dir setup to gcrypt find cmake module
> 
> Added implementation of pam_syslog and pam_vsyslog for OS X
> 
> 
> add reviewboardrc
> 
> 
> Diffs
> -
> 
>   .reviewboardrc PRE-CREATION 
>   CMakeLists.txt f60ac4121c793d62a7471074c1d4ea687360557c 
>   cmake/modules/FindLibGcrypt.cmake 27de0b46a82e92a24734476ea32401bef01a8ca8 
>   pam_darwin.h PRE-CREATION 
>   pam_darwin.c PRE-CREATION 
>   pam_kwallet.c a84585ef1fc3f4aeac728e707d52479ec85b5300 
> 
> Diff: https://git.reviewboard.kde.org/r/125056/diff/
> 
> 
> Testing
> ---
> 
> Build on OS X 10.8
> 
> 
> Thanks,
> 
> Samuel Gaist
> 
>

Re: Review Request 125056: Fix build on OS X

[Samuel Gaist]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125056/
---

(Updated Sept. 5, 2015, 7:47 p.m.)


Review request for kde-workspace and Jonathan Riddell.


Repository: kwallet-pam


Description (updated)
---

Added implementation of pam_syslog and pam_vsyslog for OS X


add reviewboardrc


Diffs (updated)
-

  .reviewboardrc PRE-CREATION 
  CMakeLists.txt bfdcfda71ef5ba3b5e4247afe02af1c23d064783 
  pam_darwin.h PRE-CREATION 
  pam_darwin.c PRE-CREATION 
  pam_kwallet.c a84585ef1fc3f4aeac728e707d52479ec85b5300 

Diff: https://git.reviewboard.kde.org/r/125056/diff/


Testing
---

Build on OS X 10.8


Thanks,

Samuel Gaist

Re: Review Request 125056: Fix build on OS X

[Samuel Gaist]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125056/
---

(Updated Sept. 5, 2015, 8:01 p.m.)


Review request for kde-workspace and Jonathan Riddell.


Repository: kwallet-pam


Description
---

Added implementation of pam_syslog and pam_vsyslog for OS X


add reviewboardrc


Diffs (updated)
-

  .reviewboardrc PRE-CREATION 
  CMakeLists.txt bfdcfda71ef5ba3b5e4247afe02af1c23d064783 
  cmake/modules/FindLibGcrypt.cmake 27de0b46a82e92a24734476ea32401bef01a8ca8 
  pam_darwin.h PRE-CREATION 
  pam_darwin.c PRE-CREATION 
  pam_kwallet.c a84585ef1fc3f4aeac728e707d52479ec85b5300 

Diff: https://git.reviewboard.kde.org/r/125056/diff/


Testing
---

Build on OS X 10.8


Thanks,

Samuel Gaist

Review Request 125068: Make Format Painter work in KRichTextWidget

[Allen Winter]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125068/
---

Review request for kdelibs.


Bugs: 221947
http://bugs.kde.org/show_bug.cgi?id=221947


Repository: kdelibs


Description
---

This patch, originally from Anders Lund back in 2010, fixes the problem with 
the Format Painter changes not taking effect.


Diffs
-

  kdeui/widgets/krichtextwidget.cpp 36ca232 

Diff: https://git.reviewboard.kde.org/r/125068/diff/


Testing
---

Tried it.  Format Painter function in KJots works now, so fixes bug 221947


Thanks,

Allen Winter

Re: Porting to frameworks 2: libkcompactdisc

[Boudhayan Gupta]

Hi,

On 4 September 2015 at 04:58, Alexander Potashev  wrote:
> I think the new fancy library naming scheme is
> "libKF5Xxx.so.SOVERSION", regardless of it being part of KF5 or not.
> Thus libKF5CompactDisc.so.5.

As of now, the code in the frameworks branch builds libKF5CompactDisc.so.5.

I've set it this way for a few reasons:

1) From the perspective of a library user who's playing with and
getting to grips with how to use KDE libraries (and is not a seasoned
KDE dev), all he has to do is add "CompactDisc" to the
find_packages(KF5) line. Purely from the point of a library user, this
is much easier to do.

2) libKF5Screen does it this way and adding it to a project is a
breeze (see point 1).

3) This way, the library is co-installable with the KDE4 version.

The main plus point is number 1 - instead of thinking from the POV of
a KDE Multimedia developer, from the point of a guy who's just playing
with code this way is more intuitive, and we don't give up much in
order to keep it this way - all we need to ensure is that the version
number of this library stays equal to or greater than the minimum
required Frameworks version.

My two pennies.

-- Boudhayan