Re: KTabWidget vs QTabWidget

2015-09-19 Thread Gilles Caulier 
Into digiKam, i do exactly a pure Qt5 port of KTabWidget to QTabWidget,
especially about D

Look my commit :

https://quickgit.kde.org/?p=digikam.git=commit=11b5e18d24d80a1bf34fdcc78064a7cb8a26fabc

Best

Gilles Caulier

2015-09-19 9:19 GMT+02:00 Thomas Lübking :

> Disclaimer: I've no knowledge about the made decision process/intentions.
>
> On Samstag, 19. September 2015 02:46:24 CEST, Jeremy Whiting wrote:
>
>> KTabWidget documentation on api.kde.org it still says that KTabWidget is
>> preferred over QTabWidget [1].
>>
>
> Wild guess: the class was moved, but nobody took a close look at the
> comments, so the API docu remained the same and on Qt4 level.
>
> In reading Qt documentation about drag and drop [2] it seems that you
>> need to subclass widgets in order to specify any additional mime types
>> that should be handled by a drop event
>>
>
> No, you can also install an eventfilter (on QTabBar/QTabWidget, the
> feature code was/is mostly in KTabBar, KTabWidget largely only forwards it)
>
> (which we have in KTabWidget... so why not just use it...)
>>
>
> Probably because it contains much additional code and dropping mime is too
> rare - and usually only required from one location.
> The effort to bind the signals isn't much different from providing an
> eventfilter, QTabBar has ::tabAt(), so you already have the index for the
> event position.
>
> Am I missing something? If not I suggest we reconsider and maybe
>> move/copy?
>>
>
> "move". Having the same symbol in KWidgetAddons and kde4libssupport is
> gonna break things - badly.
>
> or maybe users of KTabWidget should just keep using KDELibs4Support?
>>
>
> I assume this is why the support lib exists - you can keep the widget
> until you ported away :-P
>
> Cheers,
> Thomas
>

Jenkins-kde-ci: kdelibs KDE-4.14 stable-qt4 » Linux,gcc - Build # 22 - Still Unstable!

2015-09-19 Thread no-reply 

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/kdelibs%20KDE-4.14%20stable-qt4/PLATFORM=Linux,compiler=gcc/22/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Sat, 19 Sep 2015 07:45:46 +
Build duration: 32 min

CHANGE SET
Revision 8d15e35f78c670e2598058d21b6fe24f1957261b by scripty: (SVN_SILENT made 
messages (.desktop file))
  change: edit kdecore/network/kssld/kssld.desktop
  change: edit kio/misc/kpac/proxyscout.notifyrc
  change: edit kioslave/http/kcookiejar/kcookiejar.desktop
  change: edit kio/misc/kpac/proxyscout.desktop
  change: edit 
plasma/tests/testcontainmentactionsplugin/plasma-containmentactions-test.desktop
  change: edit kio/kio/kfileitemactionplugin.desktop


JUNIT RESULTS

Name: (root) Failed: 2 test(s), Passed: 162 test(s), Skipped: 0 test(s), Total: 
164 test(s)Failed: TestSuite.kdecore-kmimetype_nomimetypesFailed: 
TestSuite.kfile-kfileplacesmodeltest

COBERTURA RESULTS

Cobertura Coverage Report
  

By packages

Re: Adding further modules to api.kde.org

2015-09-19 Thread Allen Winter 
Step 1:  make sure your projects have a Mainpage.dox at the top-source-level
this file can be 0 bytes if you want, but ideally has useful content.
see Mainpage.dox in other projects for examples.

(Frameworks projects don't need Mainpage.dox, as I recall, but Alex can correct 
me.)

Then at least the apidox will be generated.

Step 2: I need to muck with the EBN scripts so the apidox are written
to someplace other than the default kde4 location.


On Tuesday, September 15, 2015 09:23:08 AM Martin Graesslin wrote:
> Hi Allen,
> 
> is there anything I can do to help get the documentation updated? I want to 
> include KWayland in inqlude (patch is prepared) and I find a little bit 
> embarrassing for KDE to have the api docs to point to 
> http://kde.martin-graesslin.com/kwayland/index.html
> 
> Cheers
> Martin
> 
> On Thursday, September 10, 2015 4:06:31 PM CEST Allen Winter wrote:
> > On Thursday, September 10, 2015 01:55:21 PM Jeremy Whiting wrote:
> > > Allen,
> > > 
> > > Those are both KDE4 versions of workspace stuff. I don't see any place
> > > where kf5 versions are.
> > 
> > oh. sorry I misunderstood the problem.
> > 
> > > On Thu, Sep 10, 2015 at 1:50 PM, Allen Winter  wrote:
> > > > On Thursday, September 10, 2015 10:57:10 AM Martin Graesslin wrote:
> > > >> Hi all,
> > > >> 
> > > >> back in KDE4 days the workspace libraries were listed on api.kde.org
> > > >> [1]. But for the current version we don't have any API docs available.
> > > >> The section "Other KDE Software" [2] lists KDE Support, KDE Extragear
> > > >> and Playground but apparently nothing from what used to be KDE SC.
> > > >> 
> > > >> Does anybody know how I can get our KDE Workspaces listed there again?
> > > >> I'm in particular interested in getting KWayland API documentation
> > > >> published.
> > > >> 
> > > >> If nobody knows: does anyone know who needs to be poked.
> > > > 
> > > > http://api.kde.org/4.x-api/workspace-apidocs/ exists
> > > > The KDE SC stuff is shown under "KDE4 Versions"
> > > > http://api.kde.org/history4.php
> > > > 
> > > > I do notice that under the various KDE 4.foo tables we don't have a
> > > > workspace entry we have kde-workspace, but not workspace.  seems like
> > > > kde-workspace and workspace are similar.
> > > > 
> > > > I'm not sure there's anything to fix.
> > > > 
> > > > -Allen

Re: KTabWidget vs QTabWidget

2015-09-19 Thread David Faure 
On Friday 18 September 2015 18:46:24 Jeremy Whiting wrote:
> Hey all,
> 
> In looking into fixing the remaining issues in Okular's frameworks
> branch I realized that in part of the effort to port it away from
> KDELibs4Support it got some functionality removed. It was ported from
> KTabWidget to QTabWidget but QTabWidget doesn't seem to support drag
> and drop the way KTabWidget did. In looking at the KTabWidget
> documentation on api.kde.org it still says that KTabWidget is
> preferred over QTabWidget [1]. If that's the case why did it end up in
> KDELibs4Support?

Nobody took the time to update the documentation of all the classes
that were moved to kdelibs4support.
So as always: trust the code more than the documentation.

> In reading Qt documentation about drag and drop [2] it seems that you
> need to subclass widgets in order to specify any additional mime types
> that should be handled by a drop event (which okular made use of so
> you could drop documents on it's tab bar to open them). Without
> KTabWidget we lose that feature completely unless we subclass
> QTabWidget (which we have in KTabWidget... so why not just use it...).
> Am I missing something? If not I suggest we reconsider and maybe
> move/copy? KTabWidget into KF5::WidgetsAddons as it still provides
> functionality we want/need in some cases. I'm not sure what would be
> BC or SC in this case tbh (or maybe users of KTabWidget should just
> keep using KDELibs4Support?)

To be clear: QTabWidget supports dnd-to-reorder tabs, but that's not
what you're after, you want DnD of URLs, right?

It takes about 10 lines of code in a QTabWidget subclass, but of course
I have no objection to this being provided by KF5 for convenience.
However, *not* as a QTabWidget subclass then. We moved away from that design
because it creates confusion (when to use QTabWidget and when to use KTabWidget)
and makes things less flexible. Instead, I suggest that you want a decorator,
much like KDragWidgetDecorator in kwidgetaddons, but for drops of URLs.
The decorator would install event filters for DragEnter and Drop, check for 
URLs,
decode on drop, emit a signal. The only problem is: how would we tell the 
decorator
that we only want drops "in the empty area next to the tabbar" and not 
everywhere
on the tabwidget... (I assume this is what you want, right?).

(I'm keeping the CC to kde-core-devel so its readers can see this has been
answered, but I suggest we now followup on kde-frameworks-devel only).

-- 
David Faure, fa...@kde.org, http://www.davidfaure.fr
Working on KDE Frameworks 5

Re: Adding further modules to api.kde.org

2015-09-19 Thread Martin Graesslin 
On Saturday, September 19, 2015 11:09:51 AM CEST Allen Winter wrote:
> Step 1:  make sure your projects have a Mainpage.dox at the top-source-level
> this file can be 0 bytes if you want, but ideally has useful content. see
> Mainpage.dox in other projects for examples.
> 
> (Frameworks projects don't need Mainpage.dox, as I recall, but Alex can
> correct me.)

awesome, thanks. Just pushed a Mainpage.dox. Didn't expect that was needed as 
I mostly compared with frameworks. (Suggestion: maybe also check for README.md 
availability - though with the prospect of phabrictor that's probably a bad 
idea).

Cheers
Martin

> 
> Then at least the apidox will be generated.
> 
> Step 2: I need to muck with the EBN scripts so the apidox are written
> to someplace other than the default kde4 location.
> 
> On Tuesday, September 15, 2015 09:23:08 AM Martin Graesslin wrote:
> > Hi Allen,
> > 
> > is there anything I can do to help get the documentation updated? I want
> > to
> > include KWayland in inqlude (patch is prepared) and I find a little bit
> > embarrassing for KDE to have the api docs to point to
> > http://kde.martin-graesslin.com/kwayland/index.html
> > 
> > Cheers
> > Martin
> > 
> > On Thursday, September 10, 2015 4:06:31 PM CEST Allen Winter wrote:
> > > On Thursday, September 10, 2015 01:55:21 PM Jeremy Whiting wrote:
> > > > Allen,
> > > > 
> > > > Those are both KDE4 versions of workspace stuff. I don't see any place
> > > > where kf5 versions are.
> > > 
> > > oh. sorry I misunderstood the problem.
> > > 
> > > > On Thu, Sep 10, 2015 at 1:50 PM, Allen Winter  wrote:
> > > > > On Thursday, September 10, 2015 10:57:10 AM Martin Graesslin wrote:
> > > > >> Hi all,
> > > > >> 
> > > > >> back in KDE4 days the workspace libraries were listed on
> > > > >> api.kde.org
> > > > >> [1]. But for the current version we don't have any API docs
> > > > >> available.
> > > > >> The section "Other KDE Software" [2] lists KDE Support, KDE
> > > > >> Extragear
> > > > >> and Playground but apparently nothing from what used to be KDE SC.
> > > > >> 
> > > > >> Does anybody know how I can get our KDE Workspaces listed there
> > > > >> again?
> > > > >> I'm in particular interested in getting KWayland API documentation
> > > > >> published.
> > > > >> 
> > > > >> If nobody knows: does anyone know who needs to be poked.
> > > > > 
> > > > > http://api.kde.org/4.x-api/workspace-apidocs/ exists
> > > > > The KDE SC stuff is shown under "KDE4 Versions"
> > > > > http://api.kde.org/history4.php
> > > > > 
> > > > > I do notice that under the various KDE 4.foo tables we don't have a
> > > > > workspace entry we have kde-workspace, but not workspace.  seems
> > > > > like
> > > > > kde-workspace and workspace are similar.
> > > > > 
> > > > > I'm not sure there's anything to fix.
> > > > > 
> > > > > -Allen


signature.asc
Description: This is a digitally signed message part.

Re: Adding further modules to api.kde.org

2015-09-19 Thread Allen Winter 
http://api.kde.org/4.x-api/workspace-apidocs/kwayland/html/index.html
look ok?

what would be a better url for this?
perhaps http://api.kde.org/plasma-apidocs/kwayland/html/index.html ??



On Friday, September 11, 2015 08:10:37 AM Martin Gräßlin wrote:
> Am 2015-09-10 21:50, schrieb Allen Winter:
> > On Thursday, September 10, 2015 10:57:10 AM Martin Graesslin wrote:
> >> Hi all,
> >> 
> >> back in KDE4 days the workspace libraries were listed on api.kde.org 
> >> [1]. But
> >> for the current version we don't have any API docs available. The 
> >> section
> >> "Other KDE Software" [2] lists KDE Support, KDE Extragear and 
> >> Playground but
> >> apparently nothing from what used to be KDE SC.
> >> 
> >> Does anybody know how I can get our KDE Workspaces listed there again? 
> >> I'm in
> >> particular interested in getting KWayland API documentation published.
> >> 
> >> If nobody knows: does anyone know who needs to be poked.
> >> 
> > 
> > http://api.kde.org/4.x-api/workspace-apidocs/ exists
> > The KDE SC stuff is shown under "KDE4 Versions" 
> > http://api.kde.org/history4.php
> > 
> > I do notice that under the various KDE 4.foo tables we don't have a
> > workspace entry
> > we have kde-workspace, but not workspace.  seems like kde-workspace
> > and workspace are similar.
> > 
> > I'm not sure there's anything to fix.
> 
> Well it's KDE4, it's old and outdated. It doesn't list new modules like 
> the new KDecoration library or KWayland.
> 
> Looking at the documentation it seems like at least KWin's documentation 
> is from latest master - this is rather unexpected to be found under 
> "KDE4".
> 
> So yes I think there is lots to fix and I'm willing to look into it. 
> Just I need to be told how.
> 
> If I as the maintainer are not able to find the documentation of my own 
> software, nobody else is. Just that should show that there is quite 
> something to fix ;-)
> 
> Cheers
> Martin

Re: Adding further modules to api.kde.org

2015-09-19 Thread Allen Winter 
On Saturday, September 19, 2015 07:03:40 PM Martin Graesslin wrote:
> On Saturday, September 19, 2015 12:54:57 PM CEST you wrote:
> > http://api.kde.org/4.x-api/workspace-apidocs/kwayland/html/index.html
> > look ok?
> 
> hmm that doesn't use the wonderful README.md. Compare to 
> http://kde.martin-graesslin.com/kwayland/index.html (requires IPV6)
> 
> Interestingly whenever I locally generated with kgenapidox it included the 
> README.md and I did verify after adding the .dox file that it doesn't change. 
> What's used on ebn to generate the docs?
> 
Ancient scripts that predate kgenapidox by at least a decade.
I wonder if symlinking Mainpage.dox to README.md would work for now.
I'll try that

> > 
> > what would be a better url for this?
> > perhaps http://api.kde.org/plasma-apidocs/kwayland/html/index.html ??
> 
> My opinion would be workspace is better as that's what our module is still 
> called on projects.kde.org. If others think it should be plasma I won't 
> oppose 
> ;-)
> 
http://api.kde.org/workspace-apidocs/kwayland/html/index.html ??

> Anyway: thanks for putting it up. Much appreciated!
> 
> Cheers
> Martin
> 
> > 
> > On Friday, September 11, 2015 08:10:37 AM Martin Gräßlin wrote:
> > > Am 2015-09-10 21:50, schrieb Allen Winter:
> > > > On Thursday, September 10, 2015 10:57:10 AM Martin Graesslin wrote:
> > > >> Hi all,
> > > >> 
> > > >> back in KDE4 days the workspace libraries were listed on api.kde.org
> > > >> [1]. But
> > > >> for the current version we don't have any API docs available. The
> > > >> section
> > > >> "Other KDE Software" [2] lists KDE Support, KDE Extragear and
> > > >> Playground but
> > > >> apparently nothing from what used to be KDE SC.
> > > >> 
> > > >> Does anybody know how I can get our KDE Workspaces listed there again?
> > > >> I'm in
> > > >> particular interested in getting KWayland API documentation published.
> > > >> 
> > > >> If nobody knows: does anyone know who needs to be poked.
> > > > 
> > > > http://api.kde.org/4.x-api/workspace-apidocs/ exists
> > > > The KDE SC stuff is shown under "KDE4 Versions"
> > > > http://api.kde.org/history4.php
> > > > 
> > > > I do notice that under the various KDE 4.foo tables we don't have a
> > > > workspace entry
> > > > we have kde-workspace, but not workspace.  seems like kde-workspace
> > > > and workspace are similar.
> > > > 
> > > > I'm not sure there's anything to fix.
> > > 
> > > Well it's KDE4, it's old and outdated. It doesn't list new modules like
> > > the new KDecoration library or KWayland.
> > > 
> > > Looking at the documentation it seems like at least KWin's documentation
> > > is from latest master - this is rather unexpected to be found under
> > > "KDE4".
> > > 
> > > So yes I think there is lots to fix and I'm willing to look into it.
> > > Just I need to be told how.
> > > 
> > > If I as the maintainer are not able to find the documentation of my own
> > > software, nobody else is. Just that should show that there is quite
> > > something to fix ;-)
> > > 
> > > Cheers
> > > Martin

Re: Adding further modules to api.kde.org

2015-09-19 Thread Martin Graesslin 
On Saturday, September 19, 2015 12:54:57 PM CEST you wrote:
> http://api.kde.org/4.x-api/workspace-apidocs/kwayland/html/index.html
> look ok?

hmm that doesn't use the wonderful README.md. Compare to 
http://kde.martin-graesslin.com/kwayland/index.html (requires IPV6)

Interestingly whenever I locally generated with kgenapidox it included the 
README.md and I did verify after adding the .dox file that it doesn't change. 
What's used on ebn to generate the docs?

> 
> what would be a better url for this?
> perhaps http://api.kde.org/plasma-apidocs/kwayland/html/index.html ??

My opinion would be workspace is better as that's what our module is still 
called on projects.kde.org. If others think it should be plasma I won't oppose 
;-)

Anyway: thanks for putting it up. Much appreciated!

Cheers
Martin

> 
> On Friday, September 11, 2015 08:10:37 AM Martin Gräßlin wrote:
> > Am 2015-09-10 21:50, schrieb Allen Winter:
> > > On Thursday, September 10, 2015 10:57:10 AM Martin Graesslin wrote:
> > >> Hi all,
> > >> 
> > >> back in KDE4 days the workspace libraries were listed on api.kde.org
> > >> [1]. But
> > >> for the current version we don't have any API docs available. The
> > >> section
> > >> "Other KDE Software" [2] lists KDE Support, KDE Extragear and
> > >> Playground but
> > >> apparently nothing from what used to be KDE SC.
> > >> 
> > >> Does anybody know how I can get our KDE Workspaces listed there again?
> > >> I'm in
> > >> particular interested in getting KWayland API documentation published.
> > >> 
> > >> If nobody knows: does anyone know who needs to be poked.
> > > 
> > > http://api.kde.org/4.x-api/workspace-apidocs/ exists
> > > The KDE SC stuff is shown under "KDE4 Versions"
> > > http://api.kde.org/history4.php
> > > 
> > > I do notice that under the various KDE 4.foo tables we don't have a
> > > workspace entry
> > > we have kde-workspace, but not workspace.  seems like kde-workspace
> > > and workspace are similar.
> > > 
> > > I'm not sure there's anything to fix.
> > 
> > Well it's KDE4, it's old and outdated. It doesn't list new modules like
> > the new KDecoration library or KWayland.
> > 
> > Looking at the documentation it seems like at least KWin's documentation
> > is from latest master - this is rather unexpected to be found under
> > "KDE4".
> > 
> > So yes I think there is lots to fix and I'm willing to look into it.
> > Just I need to be told how.
> > 
> > If I as the maintainer are not able to find the documentation of my own
> > software, nobody else is. Just that should show that there is quite
> > something to fix ;-)
> > 
> > Cheers
> > Martin


signature.asc
Description: This is a digitally signed message part.