Re: Review Request 125539: [kio-mtp] Add file system freespace retrieval to mtp kioslave

[Emmanuel Pescosta]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125539/#review86908
---


ping?

- Emmanuel Pescosta


On Oct. 6, 2015, 9:15 a.m., Emmanuel Pescosta wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125539/
> ---
> 
> (Updated Oct. 6, 2015, 9:15 a.m.)
> 
> 
> Review request for kde-workspace and Philipp Schmidt.
> 
> 
> Repository: kio-extras
> 
> 
> Description
> ---
> 
> Provides total and available space of mtp devices
> 
> 
> Diffs
> -
> 
>   mtp/kio_mtp.h 65ef734 
>   mtp/kio_mtp.cpp 466e4b3 
> 
> Diff: https://git.reviewboard.kde.org/r/125539/diff/
> 
> 
> Testing
> ---
> 
> Works fine
> 
> 
> Thanks,
> 
> Emmanuel Pescosta
> 
>

Re: Cervisia?

[Jeremy Whiting]

Awesome! Keep it up. Porting to Qt5/KF5 can happen on a branch and be
done a small bit at a time if you like. There are also some scripts in
kdesdk/kde-dev-scripts/kf5 that can help with the trivial changes.
Most are executed like find -iname *.cpp | xargs scriptname, but if
not they will say in a comment at the top of the script how to execute
them.

On Thu, Oct 15, 2015 at 8:02 PM, Martin Koller  wrote:
> On Thursday 15 October 2015 15:49:32 Jeremy Whiting wrote:
>> Michael, Martin,
>>
>> Any progress on the cervisia front? Is there anything I can do to help?
>
> yes, a lot of progress!
> We have already ported away from Qt3/KDE3 support classes.
> This is already in master and I'm testing it by using it on a daily basis.
>
> The next step would now be to start the port to KF5 - this has not been 
> started yet.
>
> --
> Best regards/Schöne Grüße
>
> Martin
> A: Because it breaks the logical sequence of discussion
> Q: Why is top posting bad?
>
> ()  ascii ribbon campaign - against html e-mail
> /\- against proprietary attachments
>
> Geschenkideen, Accessoires, Seifen, Kulinarisches: www.lillehus.at

Re: Review Request 125539: [kio-mtp] Add file system freespace retrieval to mtp kioslave

[Martin Klapetek]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125539/#review86931
---

Ship it!



mtp/kio_mtp.cpp (line 926)


This doesn't seem useful?


- Martin Klapetek


On Oct. 6, 2015, 9:15 a.m., Emmanuel Pescosta wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125539/
> ---
> 
> (Updated Oct. 6, 2015, 9:15 a.m.)
> 
> 
> Review request for kde-workspace and Philipp Schmidt.
> 
> 
> Repository: kio-extras
> 
> 
> Description
> ---
> 
> Provides total and available space of mtp devices
> 
> 
> Diffs
> -
> 
>   mtp/kio_mtp.h 65ef734 
>   mtp/kio_mtp.cpp 466e4b3 
> 
> Diff: https://git.reviewboard.kde.org/r/125539/diff/
> 
> 
> Testing
> ---
> 
> Works fine
> 
> 
> Thanks,
> 
> Emmanuel Pescosta
> 
>