Re: Review Request 127629: Fix KDateTime::isValid() for ClockTime values
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127629/ --- (Updated May 5, 2016, 10:17 p.m.) Status -- This change has been marked as submitted. Review request for kdelibs. Changes --- Submitted with commit af320ed5599cb0737c0601e26126c39e64780de0 by David Jarvie to branch master. Bugs: 336738 https://bugs.kde.org/show_bug.cgi?id=336738 Repository: kdelibs4support Description --- KDateTime::isValid() wrongly returns invalid for an instance which is specified in ClockTime, if the date/time is invalid in the local time zone. This is due to the internal QDateTime value being set to Qt::LocalTime, and unlike in Qt4, QDateTime in Qt5 uses the local time zone to validate the date/time. For ClockTime, there is no associated time zone (and choosing the local time zone to perform validation is purely arbitrary), so it should ignore the local time zone when validating. Diffs - autotests/kdatetimetest.cpp a8e7749 src/kdecore/kdatetime.cpp c530db1 Diff: https://git.reviewboard.kde.org/r/127629/diff/ Testing --- Test added to kdatetimetest, all tests pass. Thanks, David Jarvie
Jenkins-kde-ci: kdelibs KDE-4.14 latest-qt4 » Linux,gcc - Build # 15 - Still Unstable!
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kdelibs%20KDE-4.14%20latest-qt4/PLATFORM=Linux,compiler=gcc/15/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 05 May 2016 21:51:29 + Build duration: 21 min CHANGE SET Revision d9ee2e2752480479ca96135c120cf8bf56e79893 by Albert Astals Cid: (Prepare for 4.14.20) change: edit cmake/modules/KDE4Defaults.cmake change: edit README change: edit CMakeLists.txt JUNIT RESULTS Name: (root) Failed: 3 test(s), Passed: 160 test(s), Skipped: 0 test(s), Total: 163 test(s)Failed: TestSuite.kdeui-kiconloader_unittestFailed: TestSuite.kdeui-ktimezonewidget_unittestFailed: TestSuite.kdeui-ktoolbar_unittest COBERTURA RESULTS Cobertura Coverage Report By packages
Jenkins-kde-ci: kdelibs KDE-4.14 stable-qt4 » Linux,gcc - Build # 15 - Still Unstable!
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kdelibs%20KDE-4.14%20stable-qt4/PLATFORM=Linux,compiler=gcc/15/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 05 May 2016 21:51:29 + Build duration: 13 min CHANGE SET Revision d9ee2e2752480479ca96135c120cf8bf56e79893 by Albert Astals Cid: (Prepare for 4.14.20) change: edit CMakeLists.txt change: edit README change: edit cmake/modules/KDE4Defaults.cmake JUNIT RESULTS Name: (root) Failed: 3 test(s), Passed: 160 test(s), Skipped: 0 test(s), Total: 163 test(s)Failed: TestSuite.kdeui-kiconloader_unittestFailed: TestSuite.kdeui-ktimezonewidget_unittestFailed: TestSuite.kdeui-ktoolbar_unittest COBERTURA RESULTS Cobertura Coverage Report By packages
Re: KRandom regression + fix
Albert Astals Cid wrote: > From my "i know nothing about random numbers", i guess it's hard to write > a unit test for a sequente of random numbers, you can get ten "3" in a row > and it's still a valid random sequence. https://xkcd.com/221/ ;-) Kevin Kofler
