Re: Zanshin is in kdereview

2017-06-10 Thread Kevin Ottens 
Hello,

On Thursday, 8 June 2017 22:12:10 CEST Albert Astals Cid wrote:
> Sincerely i'd just suggest to kill the 3rdparty folder altogether, if you're
> concerned about people not being able to compile your thing you're better
> server just providing an appimage/snap/flatpack.

It's more that:
 1) two of them are generally not packaged, only for the tests and don't seem 
to care much about API compatibility assuming they're in the source tree 
(cucumber-cpp and mockitopp) so I just deal with it as they seem to expect;
 2) the third one (libkdepim) I'm forbidden to link against since it's private 
API to kdepim (turned into a dumping ground apparently...).
 
Obviously, as soon as libkdepim is cleaned up (which I regularly hear it's 
supposed to happen) and features are moved in proper frameworks I'll drop it 
from the 3rdparty folder. Didn't happen yet...

Hope that clarifies.

Regards.
-- 
Kévin Ottens, http://ervin.ipsquad.net

KDAB - proud supporter of KDE, http://www.kdab.com



signature.asc
Description: This is a digitally signed message part.

Re: Zanshin is in kdereview

2017-06-10 Thread Kevin Ottens 
Hello,

On Thursday, 8 June 2017 19:24:54 CEST Albert Astals Cid wrote:
> El dijous, 8 de juny de 2017, a les 9:36:51 CEST, Kevin Ottens va escriure:
> > OK, this time it's the right one. :-)
> > 
> > Zanshin is now in kdereview and aiming for extragear/pim. Please review
> > away!
> 
> Oh, you use kparts, but use a tr() based system instead of a i18n one.
> 
> Can I ask why?

Because it got started while KF5 was on the radar and couldn't tell what would 
happen of i18n. Also I don't use any of the i18n features and I want to keep 
the dependencies as minimal as possible to make a move on a mobile target 
easier if need be.

> This current setup makes the strings of the *.rc files untranslatable since
> extractrc creates mock i18n() calls.
> 
> If you really really really want to keep the tr() based system

I'd like to.

> I guess you could have a new .po catalog for the messages contained in the
> .rc files and also load that one.

I'm a bit clueless there, I think I need some hand holding. Could you be a bit 
more specific on how this is done?

Cheers.
-- 
Kévin Ottens, http://ervin.ipsquad.net

KDAB - proud supporter of KDE, http://www.kdab.com



signature.asc
Description: This is a digitally signed message part.

Re: Zanshin is in kdereview

2017-06-10 Thread Kevin Ottens 
Hello,

On Thursday, 8 June 2017 13:03:35 CEST Jonathan Riddell wrote:
> There's some GPL 2 only files in 3rdparty/kdepim, if they are used it
> means the applications can only be copied as GPL 2, consider
> contacting the copyright holders to fix this as it doesn't match the
> rest of the source.  (And fix it in kdepim if the same files are there
> with the same licence.)

Some of the people involved are listed in the relicense check script, I sent 
an email to the other ones in order to complete our database. Let's wait and 
see now...
 
> You have a release script in scripts/release.sh, consider using
> kde:releaseme as extracting translations can be quite faffy and
> releaseme does all that for you.

I tried that recently but didn't manage to get it to work at all. Failed with 
a backtrace leading to some obscure Ruby dependency and got stuck. Any 
guidance is welcome there, I'm especially interested because of the 
translation extraction bits which I do a bad job at since the beginning...

> There's no documentation.  I'm unsure how strong a requirement this is
> these days.

I honestly don't have the bandwidth to maintain such documentation at the 
moment.

> Is Todo a word? I think it should be but the dictionaries I checked
> haven't caught up with it. Maybe KDE can be at the forefront of
> English linguistic development here.

Addressed by: https://phabricator.kde.org/D6170

> Use title case on actions (menu items and buttons), "Next page" should
> be "Next Page" etc

Addressed by: https://phabricator.kde.org/D6171

> Single key shortcut for Move item is unusual, check with usability
> designer types if that's ok.

I'm very much attached to this. It's in fact mimicking what KMail does.

> If I stop Akonadi it silently stops working, an error message might be
> informative.

I'll see what can be done, I'll need to investigate on how best to address it. 
Is it a blocker for getting out of kdereview? If not please open a bug report 
about it.

> On my KDE neon User Edition install if I run Kontact it appears fine
> but on closing Kontact it crashes, this doesn't happen if I don't have
> Zanshin installed.

Do you have more information about that?

I got to admit I don't use this plugin and I'm regularly thinking about just 
dropping it, opinions welcome.

Regards.
-- 
Kévin Ottens, http://ervin.ipsquad.net

KDAB - proud supporter of KDE, http://www.kdab.com



signature.asc
Description: This is a digitally signed message part.

KDE Frameworks 5.35.0 released

2017-06-10 Thread David Faure 
10th June 2017. KDE today announces the release of KDE Frameworks 5.35.0.

KDE Frameworks are 70 addon libraries to Qt which provide a wide variety of·
commonly needed functionality in mature, peer reviewed and well tested·
libraries with friendly licensing terms. For an introduction see the·
Frameworks 5.0 release announcement.

Attica

  Improve error notification

BluezQt

  Pass an explicit list of arguments. This prevents QProcess from trying to 
handle our space containing path through a shell
  Fix property changes being missed immediately after an obejct is added (bug 
377405)

Breeze Icons

  update awk mime as it's a script language (bug 376211)

Extra CMake Modules

  restore hidden-visibility testing with Xcode 6.2
  ecm_qt_declare_logging_category(): more unique include guard for header
  Add or improve "Generated. Don't edit" messages and make consistent
  Add a new FindGperf module
  Change default pkgconfig install path for FreeBSD

KActivitiesStats

  Fix kactivities-stats into tier3

KDE Doxygen Tools

  Do not consider keyword Q_REQUIRED_RESULT

KAuth

  Verify that whoever is calling us is actually who he says he is

KCodecs

  Generate gperf output at build time

KCoreAddons

  Ensure proper per thread seeding in KRandom
  Do not watch QRC's paths (bug 374075)

KDBusAddons

  Don't include the pid in the dbus path when on flatpak

KDeclarative

  Consistently emit MouseEventListener::pressed signal
  Don't leak MimeData object (bug 380270)

KDELibs 4 Support

  Handle having spaces in the path to CMAKE_SOURCE_DIR

KEmoticons

  Fix: Qt5::DBus is only privately used

KFileMetaData

  use /usr/bin/env to locate python2

KHTML

  Generate kentities gperf output at build time
  Generate doctypes gperf output at build time

KI18n

  Extend Programmer's Guide with notes about influence of setlocale()

KIO

  Addressed an issue where certain elements in applications (e.g. Dolphin's 
file view) would become inaccessible in high-dpi multi-screen setup (bug 363548)
  [RenameDialog] Enforce plain text format
  Identify PIE binaries (application/x-sharedlib) as executable files (bug 
350018)
  core: expose GETMNTINFO_USES_STATVFS in config header
  PreviewJob: skip remote directories. Too expensive to preview (bug 208625)
  PreviewJob: clean up empty temp file when get() fails (bug 208625)
  Speed up detail treeview display by avoiding too many column resizes

KNewStuff

  Use a single QNAM (and a disk cache) for HTTP jobs
  Internal cache for provider data on initialisation

KNotification

  Fix KSNIs being unable to register service under flatpak
  Use application name instead of pid when creating SNI dbus service

KPeople

  Do not export symbols from private libraries
  Fix symbol exporting for KF5PeopleWidgets and KF5PeopleBackend
  limit #warning to GCC

KWallet Framework

  Replace kwalletd4 after migration has finished
  Signal completion of migration agent
  Only start timer for migration agent if necessary
  Check for unique application instance as early as possible

KWayland

  Add requestToggleKeepAbove/below
  Keep QIcon::fromTheme in main thread
  Remove pid changedSignal in Client::PlasmaWindow
  Add pid to plasma window management protocol

KWidgetsAddons

  KViewStateSerializer: Fix crash when view is destroyed before state 
serializer (bug 353380)

KWindowSystem

  Better fix for NetRootInfoTestWM in path with spaces

KXMLGUI

  Set main window as parent of stand-alone popup menus
  When building menu hierarchies, parent menus to their containers

Plasma Framework

  Add VLC tray icon
  Plasmoid templates: use the image which is part of the package (again)
  Add template for Plasma QML Applet with QML extension
  Recreate plasmashellsurf on exposed, destroy on hidden

Syntax Highlighting

  Haskell: highlight "julius" quasiquoter using Normal##Javascript rules
  Haskell: enable hamlet highlighting for "shamlet" quasiquoter too

Security information

The released code has been GPG-signed using the following key:
pub rsa2048/58D0EE648A48B3BB 2016-09-05 David Faure 
Primary key fingerprint: 53E6 B47B 45CE A3E0 D5B7  4577 58D0 EE64 8A48 B3BB

http://kde.org/announcements/kde-frameworks-5.35.0.php

-- 
David Faure, fa...@kde.org, http://www.davidfaure.fr
Working on KDE Frameworks 5

Re: Application usage statistics and targeted user surveys

2017-06-10 Thread Volker Krause 
On Tuesday, 6 June 2017 15:01:57 CEST Aleix Pol wrote:
> On Thu, May 25, 2017 at 4:42 PM, Volker Krause  wrote:
> > On Wednesday, 24 May 2017 17:38:22 CEST Aleix Pol wrote:
> >> On Tue, May 23, 2017 at 6:31 PM, Aleix Pol  wrote:
> >> Hey Volker, I figured out this one. Never mind.
> >> 
> >> I've done a proof of concept integrating it in Discover, here's 2
> >> patches:
> >> https://phabricator.kde.org/D5960
> >> https://phabricator.kde.org/D5961
> > 
> > There's still two aspects missing in the integration:
> > - configure Provider to actually submit (see productIdentifier,
> > feedbackServer and submissionInterval properties)
> > - probably add some data sources (in the current form you only get an
> > indication on how many users you have, and untargeted surveys, nothing
> > more)
> > 
> > The second point will need some more QML wrapper API. I'll look into
> > adding a QML plugin to KUserFeedback directly for this.
> > 
> >> Now to proceed I'd like to give a try to whole system including the
> >> server. Do you have documented how to set it up anywhere? Would make
> >> it easier.
> > 
> > INSTALL contains the deployment documentation, both for the full setup
> > with
> > authentication on an Apache server, and locally for unsecured testing
> > using
> > the built-in PHP server.
> > 
> > I've also got a playground server on my own infrastructure now that I can
> > provide accounts for. And Jan has published his ongoing work on creating a
> > Docker image for the server here:
> > https://github.com/KDAB/kuserfeedbackdocker
> > 
> > Regards,
> > Volker
> 
> Hi Volker,
> More noob feedback:
> I set up a local system I could tinkle with using your colleague's
> docker. Worked quite well. But, I was getting an issue, possibly fixed
> by this patch:
> https://phabricator.kde.org/D6117

This looks good, I'll try to get that path unit-tested to make sure this works 
with sqlite too. However, you should not actually hit this path in the first 
place, which is probably also why you are not seeing any data.

> Now I get to see things being sent on the UserFeedbackConsole
> application, but I only see timestamps. I added debug information to
> see what is being sent and (after updating the discover patch above)
> and I see all sort of data, being delivered. Is it being lost in the
> internets? Or am I not looking into it correctly? If I export the
> product using UserFeedbackConsole I also only get timestamps :(.

Do you see the empty columns for the other data in UserFeedbackConsole, or do 
you only see the Timestamp column? In the former case the data is either not 
transmitted, or rejected by the server for some reason, we'd need to look at 
the JSON payload sent to the server in that case. In the other case, you 
probably need to set up a product schema first with UserFeedbackConsole 
(easiest via Schema -> Source Templates in the Schema view).

I'll also try your Discover patches here to see if I can reproduce this, the 
QML bindings haven't gotten any real use yet, quite possible some stuff 
doesn't work there correctly yet.

Regards,
Volker

signature.asc
Description: This is a digitally signed message part.

Re: Application usage statistics and targeted user surveys

2017-06-10 Thread Volker Krause 
On Thursday, 8 June 2017 01:36:44 CEST Aleix Pol wrote:
> On Thu, Jun 8, 2017 at 12:27 AM, Albert Astals Cid  wrote:
> > El dissabte, 3 de juny de 2017, a les 11:49:00 CEST, Volker Krause va
> > 
> > escriure:
> >> On Thursday, 25 May 2017 12:33:49 CEST Volker Krause wrote:
> >> > On Tuesday, 23 May 2017 18:31:35 CEST Aleix Pol wrote:
> >> > > I would have looked into fixing it, but I'm not sure I understand why
> >> > > there's all the RPATH logic in place, so I'd prefer to hear from you
> >> > > first.
> >> > 
> >> > I have removed the remains of the pre-ECM rpath handling. This also
> >> > changed
> >> > binary output directories on Linux to follow KDE standards, so you
> >> > might
> >> > want to do a clean build to avoid issues with outdated binaries in the
> >> > build dir.
> >> > 
> >> > > A good next step would also be to get it running on build.kde.org, so
> >> > > we can identify these issues.
> >> > 
> >> > Indeed, I've requested CI coverage now.
> >> 
> >> Looks like in order to get CI coverage we need to move to kdereview
> >> (which
> >> is fine, I think it's ready for that), but that requires to know where
> >> this
> >> should end up afterwards.
> >> 
> >> I guess the candidates are extragear/libs or frameworks? frameworks seems
> >> conceptually like the right place, but putting something there that is
> >> still fairly new and has seen little field testing seems sub-optimal.
> >> Opinions?> 
> > To me it seems a few releases from extragear would make sense before
> > moving to frameworks and promise full API/ABI compatibility.

Sounds sensible to me, let's do that.

> > OTOH when moving from extreagear to frameworks we may have to rename
> > library (to have the KF5 suffix) which would break also API (at least at
> > the cmake level).
> > 
> > How do people feel having libs in extreager having the KF5 "cmake naming"
> > in the understanding that we're stabilizing them to be part of frameworks
> > eventually?
> 
> IMO it's a bit weird and unsettling. But then, we're already doing it
> for many pim libraries (not in extragear but in applications, still
> not part of KF5).

But isn't the rename the least of our problems if we start in extragear/libs 
exactly to be able to still do ABI, API and behavior changes until we are 
happy with things for frameworks?

I'll try to get all currently pending API changes in ASAP, and then get it 
moved to kdereview within this month.

Regards,
Volker


signature.asc
Description: This is a digitally signed message part.