plasma-nano and plasma-phone-components are now in kdereview
Hello! plasma-nano: https://invent.kde.org/kde/plasma-nano plasma-phone-components: https://invent.kde.org/kde/plasma-phone-components Two repos have been moved to kdereview, with final intended destinition being kde/workspace. plasma-nano is a minimal shell package which other shell package can extend, while plasma-phone-components is a shell package, look and feel and several other components which makes Plasma Mobile. Thanks -- Bhushan Shah http://blog.bshah.in IRC Nick : bshah on Freenode GPG key fingerprint : 0AAC 775B B643 7A8D 9AF7 A3AC FE07 8411 7FBC E11D signature.asc Description: PGP signature
Re: KTrip in kdereview
El dimecres, 30 d’octubre de 2019, a les 14:52:29 CET, Nicolas Fella va escriure: > On Dienstag, 29. Oktober 2019 23:25:44 CET Albert Astals Cid wrote: > > El diumenge, 27 d’octubre de 2019, a les 15:29:10 CET, Nicolas Fella va > escriure: > > You're not calling > > KLocalizedString::setApplicationDomain > > as far as i can see so translations won't work. > Fixed. > > > It would be good for it to use feature_summary so instead of a hard to read > > error http://paste.debian.net/810/ one would get the nice summary with > > "you're missing this required package, find it here" > I'm using feature_summary. What should I do differently? As discussed at QtWS you need something like http://paste.debian.net/1115148/ Cheers, Albert
Re: KIOFuse in kdereview
El dimarts, 5 de novembre de 2019, a les 18:56:25 CET, David Edmundson va escriure: > As a note for reviewers, there are some /very significant/ patches > that are in the merge requests section of that repo. One should review > kio-fuse assuming those are applied. Then get these landed and ask for review again once they have landed, don't ask us to spend our time looking at things that aren't ready. Cheers, Albert > > -- > > The current bugzilla product says: > "kiofuse: A bridge between KIO and FUSE [Unmaintained]" > > It only has one open bug which contains nothing useful. Should I > rename the bugzilla entry? > > -- > > I don't see where we would use KIO fuse mounts on windows or OS X. > A kf5 based app would be using KIO methods directly. If it's > not...then kde code isn't involved anyway. Lets not make life complex > for the sake > of purely hypothetical cases. >
Re: KIOFuse in kdereview
On Thu, 7 Nov 2019 at 16:34, Jonathan Riddell wrote: > This compiles for me but there's no install rule so nothing gets > installed,my ioslaves are unfused > > Jonathan > > Yes, there is no install rule. This doesn't inhibit from using KIOFuse as described in the README. Also note that https://invent.kde.org/kde/kio-fuse/merge_requests/4 does do an install, but also changes the way to communicate to the kio-fuse process.
Re: KIOFuse in kdereview
This compiles for me but there's no install rule so nothing gets installed,my ioslaves are unfused Jonathan
Re: Quick Charts in KDE Review
Am Montag, 21. Oktober 2019, 15:22:23 CET schrieb Arjen Hiemstra: > Hi, > > Quick Charts has been moved to KDE review. The intent is to make it a > Tier 1 framework. Any chance the official name can be "KQuickCharts"? "Quick Charts" is a generic name which only asks for being misunderstood, is hard to google etc.. > Quick Charts is a QML module that implements a set of high-performance, > GPU accelerated > charts. Currently the main user of it is a new KSysGuard UI I have been > working on, but > once it is part of Frameworks I also hope to convert several bits of > Plasma to using it. If there is only one user currently, might it perhaps be a better idea to do some independent releases for a while to get more feedback on the API, before settling to the API freeze by being part of KDE Frameworks? It will be at least a year until KF6 is there to properly fix up any potential API inconveniences which users might find. I would at least recommend to first get some API shaping by real-world exposure. Sorry otherwise for not reviewing myself, not into QML the recent months. Cheers Friedrich
Re: Quick Charts in KDE Review
Approved in general, but we will cover that and any ported applets effectively ported from KDeclarative::Plotter in relevant separate review processes. David
Re: Quick Charts in KDE Review
чт, 7 нояб. 2019 г. в 13:53, Arjen Hiemstra : > > On 21-10-2019 15:22, Arjen Hiemstra wrote: > > Hi, > > > > Quick Charts has been moved to KDE review. The intent is to make it a > > Tier 1 framework. > > > > Quick Charts is a QML module that implements a set of > > high-performance, GPU accelerated > > charts. Currently the main user of it is a new KSysGuard UI I have > > been working on, but > > once it is part of Frameworks I also hope to convert several bits of > > Plasma to using it. > > It has now been a little over two weeks. If there are no objections, I > will move this to frameworks later today. Hi Arjen, Did anyone from the Plasma team approve the new KSysGuard UI? -- Alexander Potashev
