Re: Introducing KDE Activity Filter

2020-07-20 Thread Ingo Klöcker
On Sonntag, 19. Juli 2020 10:20:56 CEST Adriaan de Groot wrote:
> On Tuesday, 14 July 2020 10:57:41 CEST Ingo Klöcker wrote:
> > On Dienstag, 14. Juli 2020 10:20:33 CEST Kåre Särs wrote:
> > > Is there a way to verify that the yaml file is syntactically correct
> > > before
> > > pushing the change?
> > 
> > There are loads of YAML linters/validators, online and offline. In fact,
> > this would be an opportunity to test-drive the awesome GitLab CI/CD. I
> > volunteer to implement this, if sysadmin is okay with this.
> 
> There's a bunch of different tools for YAML validation indeed.

It has already been implemented and merged. I'm using the Python package 
yamllint.

> > Or do you mean "semantically correct", i.e. also checking for valid
> > projects?
> 
> (From a JSON-schema perspective) You might periodically generate a schema
> type that checks the repository-re, for the simple case of |-separated full
> repository names. Personally I'd be more inclined to follow Albert's
> original question, and change the tool not to eat a RE but a YAML
> list-of-repo-names.

I didn't implement any semantic validation. I agree that using a list would be 
more YAML-like.

Regards,
Ingo


signature.asc
Description: This is a digitally signed message part.


Re: Introducing KDE Activity Filter

2020-07-20 Thread Luiz Fernando Ranghetti
Hi Ben,

How to specify svn addresses?

Back in time I have pt_BR translations filtered in the old commit filter.
Then I could see the commits on phabricator, watching pages like this:
https://phabricator.kde.org/source/svn/history/branches/stable/l10n-kf5/pt_BR/
(and its trunk counterpart). I didn't find something similar to this on
invent.k.o

Now I'm left with this:
https://websvn.kde.org/branches/stable/l10n-kf5/pt_BR/messages/?sortby=date#dirlist
(in
this case scripty run will mask someone contribution)

Regards,

Luiz





Em dom., 12 de jul. de 2020 às 14:57, Ben Cooksley 
escreveu:

> On Mon, Jul 13, 2020 at 4:46 AM Albert Astals Cid  wrote:
> >
> > El diumenge, 12 de juliol de 2020, a les 8:08:11 CEST, Ben Cooksley va
> escriure:
> > > Hi all,
> > >
> > > A few years back Sysadmin had to turn off the old Commit Filter
> > > service due to a number of security issues, with no replacement
> > > available.
> > >
> > > I'm now happy to announce that a replacement service is now available,
> >
> > Very much appreciated! Now i can stop using ifttt :)
> >
> > > with the added functionality of also being able to cover activity on
> > > Bugzilla and Gitlab (for Tasks and Merge Requests). It is intended
> > > that Activity Filter will be used to provide Gitlab notifications for
> > > merge requests and tasks to mailing lists, along with CI notifications
> > > if desired (once that is moved to Gitlab)
> > >
> > > The new service is configured through YAML format files in the
> > > sysadmin/activityfilter repository
> > > (https://invent.kde.org/sysadmin/activityfilter), which is open to
> > > developers to commit. Please ensure that you read the README contained
> > > in the repository before doing so.
> > >
> > > Please let us know if you have any questions on the above!
> >
> > Can i do stuff like this?
> >
> > - name: "Commits"
> >   subscribes: "aa...@kde.org"
> >   to: commits
> >   where:
> > project: 'bla'
> > project: 'bla1'
> > project: 'bla2'
> > project: 'bla3'
> > project: 'bla4'
> > project: 'bla5'
> > project: 'bla6'
> > project: 'bla7'
> > project: 'bla8'
> >
> > ?
>
> I'm afraid rules like that aren't supported, however you can specify a
> regex so something like:
>
> where:
> project: 'foo1|foo2|foo3'
>
> should work fine.
>
> >
> > Cheers,
> >   Albert
> >
>
> Cheers,
> Ben
>
> >
> > >
> > > Thanks,
> > > Ben Cooksley
> > > KDE Sysadmin
> > >
> >
> >
> >
> >
>