Re: Review of KGeoTag

2020-12-01 Thread Tobias Leupold
Wasn't too much effort ;-)

Am Dienstag, 1. Dezember 2020, 23:13:46 CET schrieb Albert Astals Cid:
> El dilluns, 30 de novembre de 2020, a les 0:01:26 CET, Tobias Leupold va
escriure:
> > Hi Albert :-)
> >
> > > > I can of course move to an KXmlGuiWindow if you think I really should.
> > > > Please tell me!
> > >
> > > I'm a bit biased, but i think it's better to have, like what if i'm an
> > > avid
> > > user and want to set a shortcut to the add file or to Save images
> > > actions?
> > >
> > > I can't because you're not using kxmlgui that gives me that for free.
> > >
> > > As said, it's not mandatory, but it gives niceties that makes apps "more
> > > consistent" amongst eachother.
> >
> > Fair enough ;-) With 523fd1e4f0cf4853bb9a06ceea598e3d2b63ef33, I switched
> > to a KXmlGuiWindow, and with 37bd97c9fc022ec2d6501d77049277833a87f927, I
> > removed saving the window's geometry manually, as this is now handled
> > automagically by the XML gui.
> >
> > > Also, you may want to add a KCrash::initialize call in your main to
> > > initialize kcrash and get the nice "this thing crashed report a bug"
> > > dialog.
> >
> > Added with cb2f3c4575872b95897ccff94d666a81484ea9c9
> >
> > Cheers, Tobias
>
> Awesome, thanks a lot for accommodating me :)
>
> Cheers,
>   Albert






Re: Review of KGeoTag

2020-12-01 Thread Albert Astals Cid
El dilluns, 30 de novembre de 2020, a les 0:01:26 CET, Tobias Leupold va 
escriure:
> Hi Albert :-)
> 
> > > I can of course move to an KXmlGuiWindow if you think I really should.
> > > Please tell me!
> >
> > I'm a bit biased, but i think it's better to have, like what if i'm an avid
> > user and want to set a shortcut to the add file or to Save images actions?
> >
> > I can't because you're not using kxmlgui that gives me that for free.
> >
> > As said, it's not mandatory, but it gives niceties that makes apps "more
> > consistent" amongst eachother.
> 
> Fair enough ;-) With 523fd1e4f0cf4853bb9a06ceea598e3d2b63ef33, I switched to a
> KXmlGuiWindow, and with 37bd97c9fc022ec2d6501d77049277833a87f927, I removed
> saving the window's geometry manually, as this is now handled automagically by
> the XML gui.
> 
> > Also, you may want to add a KCrash::initialize call in your main to
> > initialize kcrash and get the nice "this thing crashed report a bug"
> > dialog.
> 
> Added with cb2f3c4575872b95897ccff94d666a81484ea9c9
> 
> Cheers, Tobias

Awesome, thanks a lot for accommodating me :)

Cheers,
  Albert

> 
> 
> 
> 






Re: MauiKit and Index review

2020-12-01 Thread Carl Schwan


Le lundi, septembre 28, 2020 9:02 AM, Camilo Higuita Rodriguez 
 a écrit :

Hi, some feedback:

Index looks visually really nice, great job on that front :)

In term of technical review:

* There are tons of clazy warning in your codebase: I fixed some of them in [1] 
but
  there are more of them. I would encourage you to look into setting up clazy, 
it
  provides tons of helpful advice.
* 
https://invent.kde.org/maui/mauikit/-/blob/v1.2/src/platforms/linux/kdeconnect.cpp#L41
  This won't work if I set LANGUAGE=fr_FR as my environment variable. Also I 
don't think
  it is a good idea to parse the command line output like this. You should 
probably
  ask the kdeconnect team if they can add machine-readable interface or a dbus 
API for your
  usecase.
* 
https://invent.kde.org/maui/mauikit/-/blob/v1.2/src/utils/syncing/syncing.cpp#L198
  This strings should be translated if they are visible to the user.
* You are using qDebug in mauikit, you should probably use QLoggingCategory 
instead.

Cheers,
Carl


[1]: https://invent.kde.org/maui/mauikit/-/merge_requests/25/diffs
> Hi,
> For the next stable release, we would like to go through KDE review first.
>
> To start I want to submit MauiKit and Index for review, and later on the 
> other apps.
> https://invent.kde.org/maui/mauikit
> https://invent.kde.org/maui/index
>
> The changes we have made to get to this review are all in the development 
> branch.
>
> I will be available to perform any needed fixes and answer any questions 
> since I'm the main developer and maintainer.
>
> Greetings,
> Camilo Higuita
>