Re: AudioTube in KDEReview
That would be an option. Alternatively what might make sense is show a placeholdermessage [1] instead of the album cover and/or possibly an icon as generic placeholder artwork. Not sure which makes more sense. With a placeholder it'd certainly be more consistent from a visual POV. https://api.kde.org/frameworks/kirigami/html/classorg_1_1kde_1_1kirigami_1_1PlaceholderMessage.html I have now changed it to use the full space if there is no cover, and I'm quite happy with how it looks. Ah sorry. It was the Thomas Bangalter entry. Curiously the search is different today ^^. If you search for 'Bangalter' it happens with the artist entry still. Thanks, I'll have a look. OpenPGP_0xA81E075ABEC80A7E.asc Description: OpenPGP public key OpenPGP_signature Description: OpenPGP digital signature
Re: AudioTube in KDEReview
On 16.06.21 21:27, Jonah Brüchert wrote: >> - something is also wonky with the playlist. it doesn't cover the width >> (when data fails to load). it is overlapped by the scrollbar. clear and >> shuffle don't seem to have labels though there would be enough space >> https://i.imgur.com/Q3IoaBj.png > The left side should display the album cover, do you think the playlist > should fill the whole page if there is none? That would be an option. Alternatively what might make sense is show a placeholdermessage [1] instead of the album cover and/or possibly an icon as generic placeholder artwork. Not sure which makes more sense. With a placeholder it'd certainly be more consistent from a visual POV. https://api.kde.org/frameworks/kirigami/html/classorg_1_1kde_1_1kirigami_1_1PlaceholderMessage.html >> - on some artists I get `TypeError: 'NoneType' object is not iterable ` >> https://i.imgur.com/U8BKHbQ.png > Which exactly? I can't reproduce it with Daft Punk. Ah sorry. It was the Thomas Bangalter entry. Curiously the search is different today ^^. If you search for 'Bangalter' it happens with the artist entry still. HS
