Re: KDEReview for kio-s3
El dimarts, 20 de setembre de 2022, a les 0:17:52 (CEST), Elvis Angelaccio va escriure: > Hi all, > I think kio-s3 [1] is now ready to go through the KDEReview process and > get a first release. > > dfaure and sitter did a first code review in the original MR against > kio-extras [1]. The code hasn't changed much since then, mostly the port > to the new WorkerBase interface. > > Please have a look. Thanks :) Small enough, i didn't find anything to mention :) Cheers, Albert > > P.S. > You might notice that the gitlab CI is currently broken, I have already > filed a sysadmin ticket trying to sort it out. > > [1]: https://invent.kde.org/network/kio-s3 > [2]: https://invent.kde.org/network/kio-extras/-/merge_requests/35 > > > Cheers, > Elvis
Re: Plasma Welcome Center on KDEReview
plasma-disks is a fairly exhaustive example code base On Tue, Sep 20, 2022 at 2:19 AM Nate Graham wrote: > > On 9/18/22 11:03, Harald Sitter wrote: > > Not all code is licensing policy compliant (e.g. appdata is missing > > spdx tags). I'd suggest enabling the reuse linter pipeline. > > How do I do this? Is there an example I can copy from elsewhere (which > in case people haven't noticed, is basically how I do everything)? > > Nate
Re: Plasma Welcome Center on KDEReview
On Tue, Sep 20, 2022 at 12:19 PM Nate Graham wrote: > On 9/18/22 11:03, Harald Sitter wrote: > > Not all code is licensing policy compliant (e.g. appdata is missing > > spdx tags). I'd suggest enabling the reuse linter pipeline. > > How do I do this? Is there an example I can copy from elsewhere (which > in case people haven't noticed, is basically how I do everything)? > Please see https://invent.kde.org/sysadmin/ci-utilities/-/tree/master/gitlab-templates for a list of available templates for use on invent.kde.org. Cheers, Ben > > Nate >
