Re: kio-admin in kdereview

2022-10-12 Thread Harald Sitter 
On Thu, Oct 13, 2022 at 12:46 AM Albert Astals Cid  wrote:
> Did I misunderstood the code? It looks like this run all of kio with root
> powers?

That is correct

Re: kio-admin in kdereview

2022-10-12 Thread Albert Astals Cid 
El dimecres, 12 d’octubre de 2022, a les 10:40:45 (CEST), Harald Sitter va 
escriure:
> Hola
> 
> kio-admin implements an admin worker that gives root level access to
> the file system
> 
> https://invent.kde.org/system/kio-admin

qDebug() << "actions!!!";
qDebug() << "urly!!!" << url;
probably needs to go away or be a qCDebug?

Did I misunderstood the code? It looks like this run all of kio with root 
powers?

Cheers,
  Albert 

> 
> HS

kio-admin in kdereview

2022-10-12 Thread Harald Sitter 
Hola

kio-admin implements an admin worker that gives root level access to
the file system

https://invent.kde.org/system/kio-admin

HS

Re: KJournald in KDE-Review

2022-10-12 Thread Andreas Cord-Landwehr 
On Mittwoch, 12. Oktober 2022 03:56:03 CEST Aleix Pol wrote:
[...]
> Then I'd recommend to only make it public API when the time comes. :)
> 
> +1 to making it optional instead, if it makes your life any better.
> That said, when we've needed this kind of flexibility in the past, we
> have often ended up splitting the repository into a separate one, not
> sure it would make sense here.
> 
> Also it would be useful to know what your plans are. :D

Hi, just added such an option.

My goal is to eventually split the library part out from the application as 
soon as it makes sense. At the moment there are still sometimes changes to the 
library API/moving parts that are not fully polished yet.
The full story is that I started with the library, then noticed that  my 
reference app to show how the API can be used has a lot of value as its own. 
So the focus right now is to make something for end users and later on to look 
at finalizing the library abstraction.

Cheers,
Andreas