Re: libqaccessibilityclient now in kdereview

[Frederik Gladhorn]

On torsdag 7. mars 2019 14:45:50 CET Jonathan Riddell wrote:
> On Thu, 7 Mar 2019 at 05:20, Friedrich W. H. Kossebau  
wrote:
> > Soon it will be 2 years that libqaccessibilityclient entered kdereview,
> > and I just found it seems to be still in that state, at least by what
> > repo-metadata claims and given no emails to the thread which sonud like
> > review done I came across it when compiling kmag myself, where the
> > optional dep on this exists.
> 
> Thanks for your fixes.  I just spoke to Frederik on IRC who says I can
> the beaurocracy forward so I've filed a sysadmin ticket to move to
> extragear/libs and I guess I'll make a 0.4.0 change once that happens
> and try to get it onto build.kde.org.
> 

Thanks to all of you! I'm sorry for being so negligent here, I just don't find 
the time these days.

Cheers,
Frederik


> Jonathan

Re: libqaccessibilityclient now in kdereview

[Frederik Gladhorn]

Hi all,

On onsdag 26. juli 2017 08.11.18 CEST Ben Cooksley wrote:
> On Wed, Jul 26, 2017 at 9:18 AM, Mario Fux  wrote:
> > Am Dienstag, 25. Juli 2017, 14:55:42 CEST schrieb Albert Astals Cid:
> > 
> > Morning Albert
> 
> Hi Mario,
> 
> >> El dimarts, 25 de juliol de 2017, a les 13:25:39 CEST, Jonathan Riddell
> >> va
> >> 
> >> escriure:
> >> > libqaccessibilityclient is now in kdereview.  It's in a git repo
> >> > called libkdeaccessibilityclient but we filed a sysadmin request to
> >> > rename it.
> >> > 
> >> > We just released 0.2.0 in unstable (for some reason 0.1.1 was released
> >> > in stable some years ago).
> >> 
> >> Do we really have to keep the Qt4 compatibility or can we kill it?
> > 
> > Please keep it for now as the next Simon release (0.5.0 which is on its
> > way) is still Qt4 based.
> 
> Simon is (for the moment at least) prohibited from depending on
> libqaccessibilityclient, because Extragear (as well as Plasma and
> Applications module) applications are not allowed to depend on code
> which is in Playground or KDE Review.

It's indeed completely optional and I'm not sure if the code in Simon is ready 
for prime time. Peter wrote it as an experiment (and it seems to more or less 
work), but I'm not sure how stable it actually is.

Cheers,
Frederik


> 
> > Thx
> > Mario
> 
> Cheers,
> Ben
> 
> >> Cheers,
> >> 
> >>   Albert
> >>   
> >> > What is it?
> >> > 
> >> > Since it's hard to grasp all the bits related to accessibility, I'll
> >> > try
> >> > to
> >> > explain what the lib is for.
> >> > Most of the stack is part of Qt 5, so nothing to worry about, that's
> >> > the
> >> > part that lets applications expose their UI over DBus for AT-SPI, so
> >> > they
> >> > work nicely with assisitve tools (e.g. Orca). In accessibility
> >> > language,
> >> > the applications act as "servers" and the screen reader for example is
> >> > a
> >> > client.
> >> > 
> >> > This library is for writing clients, so applications that are
> >> > assistive,
> >> > such as screen readers. It currently has two users: KMag and Simon.
> >> > KMag can use it to follow the focus (e.g. when editing text, it can
> >> > automatically magnify the part of the document where the cursor is.
> >> > 
> >> > For Simon Listens, the use is to be able to let the user trigger menus
> >> > and
> >> > buttons by voice input.

Re: libqaccessibilityclient now in kdereview

[Frederik Gladhorn]

On tirsdag 25. juli 2017 14.47.44 CEST Albert Astals Cid wrote:
> El dimarts, 25 de juliol de 2017, a les 13:25:39 CEST, Jonathan Riddell va
> 
> escriure:
> > libqaccessibilityclient is now in kdereview.  It's in a git repo
> > called libkdeaccessibilityclient but we filed a sysadmin request to
> > rename it.
> > 
> > We just released 0.2.0 in unstable (for some reason 0.1.1 was released
> > in stable some years ago).
> 
> What's your target? Frameworks? KDE Applications? Independent release?

It's closest to being a framework, considering that it's a tiny helper lib.

> 
> 
> It seems to have autotests but they are not run by either of these
>   ctest
>   make check
>   make test

Will look into that, thanks for the feedback!

Cheers,
Frederik

> 
> 
> 
> 
> AccessibleObject seems like a dumping group, having functions like
>   double maximumValue() const;
> and
> QString imageDescription() const;
> that if you read the description seems to me like they apply to "different
> types" of objects. Is it because it is mimic-ing the ATSPI API? Is there a
> way to have these things more split so they are grouped together more
> logically?
> 
> 
> 
> Interfaces supportedInterfaces() const;
> documentation is wrong, it says "return QStringList"
> 
> 
> Can we remove the commented functions, i.e. managesDescendants, isRequired,
> etc.?
> 
> 
> Thanks for pushing this forward :)
> 
> 
> Cheers,
>   Albert
> 
> > What is it?
> > 
> > Since it's hard to grasp all the bits related to accessibility, I'll try
> > to
> > explain what the lib is for.
> > Most of the stack is part of Qt 5, so nothing to worry about, that's the
> > part that lets applications expose their UI over DBus for AT-SPI, so they
> > work nicely with assisitve tools (e.g. Orca). In accessibility language,
> > the applications act as "servers" and the screen reader for example is a
> > client.
> > 
> > This library is for writing clients, so applications that are assistive,
> > such as screen readers. It currently has two users: KMag and Simon.
> > KMag can use it to follow the focus (e.g. when editing text, it can
> > automatically magnify the part of the document where the cursor is.
> > 
> > For Simon Listens, the use is to be able to let the user trigger menus and
> > buttons by voice input.

Re: Product versions on bugs.kde.org

[Frederik Gladhorn]

On Saturday, March 26, 2016 12:05:55 PM David Faure wrote:
> On Sunday 20 March 2016 18:43:04 Alexander Potashev wrote:
> > 2016-03-09 1:09 GMT+03:00 Kevin Funk <kf...@kde.org>:
> > > Added all versions from 5.5.0 to 5.19.0.
> > 
> > 5.20.0 is out, could you please add it to Bugzilla as well?
> 
> I have now integrated Jonathan's script into release-tools, and I ran it for
> 5.20.0. Works well.
> 
> There's just one issue: the bugzilla product for attica is called attica and
> not frameworks-attica, unlike all other frameworks.
> Should we rename the product in bugzilla, or adjust the script?

I think it's fine to rename the product.
 
> PS: we still have no official attica maintainer in metainfo.yaml,
> but the bugzilla component is assigned to Frederik Gladhorn.
> Frederik, can I write you down in metainfo.yaml as well?

I have been really inactive, if anyone else would be up for taking it, I'd be 
happy. I won't manage to work on attica realistically.

Cheers,
Frederik

Fwd: [Development] Qt Contributors' Summit 2014 in Berlin 10-11th June

[Frederik Gladhorn]

Hello,

we will have a Qt Contributors' Summit again.

The event is invite only, but I think many people on these lists qualify for 
the event. Especially if you have lately been submitting patches through 
gerrit or otherwise been involved with Qt developement consider joining.

This is a great chance to influence many things in Qt directly with great 
discussions. Also a great start to getting deeper involved of course ;)

See the forwarded mail for details.

-- 
Best regards,
Frederik Gladhorn
Senior Software Engineer - Digia, Qt
Visit us on: http://qt.digia.com
---BeginMessage---
Hello,

Qt Contributors' Summit is coming!
This year the summit will be organized in the Estrel Convention center in 
Berlin on 10-11th June.

Please see the event wiki for details: 
http://qt-project.org/groups/qt-contributors-summit-2014/wiki

Participation to the event is limited and based on merit in the Qt project. 
Priority is given to Maintainers and Approvers, but everyone who has 
contributed to the success of the project in any way can apply for an 
invitation.

To request an invitation to the event, please use the following form:  
https://www.webropolsurveys.com/S/7CB14527039843C9.par
Be sure to fill in why you should be invited. The request page will be open 
through April and after closing the form, we will send out invitations as soon 
as possible.

Best regards,
Tero Kojo
Qt Online Community Manager, Digia
QtCS 2014 event coordinator

P.S. If your company would like to help make the event even better by 
sponsoring, see the wiki sponsoring page 
http://qt-project.org/groups/qt-contributors-summit-2014/wiki/Sponsorship and 
contact me (Tero Kojo) for details.
___
Development mailing list
developm...@qt-project.org
http://lists.qt-project.org/mailman/listinfo/development
---End Message---

Re: Please review QAccessibilityClient

[Frederik Gladhorn]

Mandag 13. januar 2014 02.24.30 skrev Albert Astals Cid:
 El Divendres, 3 de gener de 2014, a les 22:09:04, Frederik Gladhorn va
 
 escriure:
  Hi,
  
  Mario Fux asked if I could make a release of libqaccessibilityclient. When
  I started this little lib it was seemingly KDE only but with a bit of
  help, mostly from Sebastian Sauer it became a nice little Qt only lib.
 
 FWIW I gave it a look last week and from my I know nothing about the
 domain, it looks good.

Thanks, I'll make a release the next days, we can always bump the major 
version number later.

If someone feels like helping out rolling tarballs or testing them that would 
be appreciated.

Greetings
Frederik


 
 Cheers,
   Albert
 
  It makes writing accessibility tools easy by providing a convenient API
  over the rather tedious DBus AT-SPI standard. That means it works with
  Gnome, KDE/Qt apps and potentially others. Simon started to depend on it
  and the KWin focus tracking works with it as well.
  
  There is a fun example app that comes with the lib, it demonstrates a bit
  what the library provides. There are two classes Registry to provide the
  subscription to changes and AccessibleObject which represents one
  widget.
  Together they give a lot of information about running apps and are a nice
  basis for further helpful technology.
  
  The code can be found here:
  git://anongit.kde.org/libkdeaccessibilityclient
  
  I haven't had much time to work on it, but spent a bit of time cleaning it
  up today. The functions are generally documented and I'd be very happy
  about feedback/reviews.
  
  If there are no major blockers/improvement suggestions I'd like to make a
  release soon. If someone is looking for a fun and interesting new task, I
  would be happy with some help to get this baby out.
  
  Greetings,
  Frederik

Please review QAccessibilityClient

[Frederik Gladhorn]

Hi,

Mario Fux asked if I could make a release of libqaccessibilityclient. When I 
started this 
little lib it was seemingly KDE only but with a bit of help, mostly from 
Sebastian 
Sauer it became a nice little Qt only lib.

It makes writing accessibility tools easy by providing a convenient API over 
the rather 
tedious DBus AT-SPI standard. That means it works with Gnome, KDE/Qt apps and 
potentially others. Simon started to depend on it and the KWin focus tracking 
works 
with it as well.

There is a fun example app that comes with the lib, it demonstrates a bit what 
the 
library provides. There are two classes Registry to provide the subscription 
to 
changes and AccessibleObject which represents one widget.
Together they give a lot of information about running apps and are a nice basis 
for 
further helpful technology.

The code can be found here:
git://anongit.kde.org/libkdeaccessibilityclient

I haven't had much time to work on it, but spent a bit of time cleaning it up 
today. 
The functions are generally documented and I'd be very happy about 
feedback/reviews.

If there are no major blockers/improvement suggestions I'd like to make a 
release 
soon. If someone is looking for a fun and interesting new task, I would be 
happy with 
some help to get this baby out.

Greetings,
Frederik

Re: Review Request 110042: Find Qt5 version of DBusMenuQt

[Frederik Gladhorn]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110042/
---

(Updated Oct. 27, 2013, 6:46 p.m.)


Status
--

This change has been discarded.


Review request for kdelibs.


Repository: kdelibs


Description
---

Build fix for dbusmenu qt5 changes.
This appends the 5 to include path and lib dir in the find module.
Also rename the whole thing to not conflict with the Qt 4 version.


Diffs
-

  CMakeLists.txt 00402d4 
  cmake/modules/FindDBusMenuQt.cmake 5af70ef 
  cmake/modules/FindDBusMenuQt5.cmake PRE-CREATION 

Diff: http://git.reviewboard.kde.org/r/110042/diff/


Testing
---


Thanks,

Frederik Gladhorn

Review Request 110042: Find Qt5 version of DBusMenuQt

[Frederik Gladhorn]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110042/
---

Review request for kdelibs.


Description
---

Build fix for dbusmenu qt5 changes.
This appends the 5 to include path and lib dir in the find module.
Also rename the whole thing to not conflict with the Qt 4 version.


Diffs
-

  CMakeLists.txt 00402d4 
  cmake/modules/FindDBusMenuQt.cmake 5af70ef 
  cmake/modules/FindDBusMenuQt5.cmake PRE-CREATION 

Diff: http://git.reviewboard.kde.org/r/110042/diff/


Testing
---


Thanks,

Frederik Gladhorn

Re: Review Request 110042: Find Qt5 version of DBusMenuQt

[Frederik Gladhorn]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110042/
---

(Updated April 16, 2013, 1:26 p.m.)


Review request for kdelibs.


Description
---

Build fix for dbusmenu qt5 changes.
This appends the 5 to include path and lib dir in the find module.
Also rename the whole thing to not conflict with the Qt 4 version.


Diffs
-

  CMakeLists.txt 00402d4 
  cmake/modules/FindDBusMenuQt.cmake 5af70ef 
  cmake/modules/FindDBusMenuQt5.cmake PRE-CREATION 

Diff: http://git.reviewboard.kde.org/r/110042/diff/


Testing
---


Thanks,

Frederik Gladhorn

Re: Review Request 110042: Find Qt5 version of DBusMenuQt

[Frederik Gladhorn]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110042/
---

(Updated April 16, 2013, 1:26 p.m.)


Review request for kdelibs.


Description
---

Build fix for dbusmenu qt5 changes.
This appends the 5 to include path and lib dir in the find module.
Also rename the whole thing to not conflict with the Qt 4 version.


Diffs
-

  CMakeLists.txt 00402d4 
  cmake/modules/FindDBusMenuQt.cmake 5af70ef 
  cmake/modules/FindDBusMenuQt5.cmake PRE-CREATION 

Diff: http://git.reviewboard.kde.org/r/110042/diff/


Testing
---


Thanks,

Frederik Gladhorn

Re: Review Request 110042: Find Qt5 version of DBusMenuQt

[Frederik Gladhorn]

On Tuesday 16. April 2013 16.30.15 Rolf Eike Beer wrote:
 Am Dienstag 16 April 2013, 13:26:23 schrieb Frederik Gladhorn:
  ---
  This is an automatically generated e-mail. To reply, visit:
  http://git.reviewboard.kde.org/r/110042/
  ---
  
  Review request for kdelibs.
  
  
  Description
  ---
  
  Build fix for dbusmenu qt5 changes.
  This appends the 5 to include path and lib dir in the find module.
  Also rename the whole thing to not conflict with the Qt 4 version.
 
 Since DBusMenuQt5 is obviously a rather new thing I would vote for putting a
 DBusMenuQt5Config.cmake into that project itself and install that. That
 would allow everyone to use it with CMake once the module itself is
 installed, without any need for a Find*.cmake module.

I agree, that would make sense. If anyone is up for doing that (the code is in 
launchpad) feel free to do so, I will not get around to doing that. I can 
abandon this patch in favor of the Config.cmake file.

I mostly wanted to build kdelibs-frameworks and this patch is actually pretty 
small (I just renamed the .cmake file for clarity's sake).

Greetings
Frederik

 
 Eike

Re: Review LibKdeAccessibilityClient

[Frederik Gladhorn]

Søndag 7. oktober 2012 21.45.17 skrev Alexander Neundorf:
 On Thursday 04 October 2012, Frederik Gladhorn wrote:
  Hi,
  
  so after we took the time to hack a bit more on the library in Randa,
  I would be happy about more comments.
 
 Why does it use KDEPIMLIBS_INSTALL_DIR ?
 
 macro(MAKE_INSTALL_PATH_ABSOLUTE out in)
if (IS_ABSOLUTE ${in})# IS_ABSOLUTE is new since cmake 2.4.8
   set(${out} ${in})
else()
   set(${out} \${KDEPIMLIBS_INSTALL_DIR}/${in})
endif()
 endmacro(MAKE_INSTALL_PATH_ABSOLUTE out in)
 
 
 I would have expected ${CMAKE_INSTALL_PREFIX}.
Thanks, fixed.

Greetings
Frederik

 
 Alex

Re: Review LibKdeAccessibilityClient

[Frederik Gladhorn]

Hi,

so after we took the time to hack a bit more on the library in Randa,
I would be happy about more comments.

The plan is to use it for our tools (currently Simon and Magnifier),
so the only thing I didn't do is to change it to depend on ECM.

I find the CMake part is quite nice now, it doesn't even require the tedious 
FindFoo.cmake files, instead it uses the target-exporting feature of cmake 
that Alex suggested (good stuff indeed).

After realizing it was Qt only, we were bold enough to rename it to 
QAccessibilityClient.

Especially Peter reviewing and using it for Simon makes me feel relatively 
good about the lib, since it confirms its usefullness. The manual test in 
there is turning into a full accessibility debugging tool, another thing 
turning out better than I initially expected :) Give it a look when bored, 
it's fun to play with and works with Gnome and KDE apps (assuming you have qt-
at-spi and libatspi2).

Greetings
Frederik

On Thursday 23. August 2012 22.41.46 Kevin Ottens wrote:
 Hello,
 
 On Thursday 16 August 2012 09:29:27 Frederik Gladhorn wrote:
  Feedback is much appreciated.
 
 If you aim at releasing with KDE Frameworks, I would like to see the
 following happening:
  * Stick to the new CMake ways we use in KDE Frameworks (means depending
 on CMake 2.8.9 and ECM 0.0.5 for now);
  * Fix the issues raised by Alex (obviously);
  * Change the name to kaccessibilityclient to be more aligned with how we're
 naming the other frameworks.
 
 The first point could be a problem I guess if you aim at releasing before
 KDE Frameworks 5.0 as ECM is not widespread in distros yet.
 
 My 0.02€
 
 Regards.

Re: Review Request: Adding Accessibility Interfaces for Dolphin Views Widgets

[Frederik Gladhorn]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105972/#review19320
---

Ship it!


We just discussed and Aman will push the change now. It is working for several 
people and should not incur any penalty for users not using accessibility. 
Further work will happen as incremental changes.

- Frederik Gladhorn


On Aug. 17, 2012, 11:20 a.m., Amandeep Singh wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 http://git.reviewboard.kde.org/r/105972/
 ---
 
 (Updated Aug. 17, 2012, 11:20 a.m.)
 
 
 Review request for Dolphin, KDE Base Apps and KDE Accessibility.
 
 
 Description
 ---
 
 Added Accessibility Interfaces for Dolphin Views  Widgets, to make it 
 accessible.
 2 New files added in dolphin/ src/ kitemviews/ kitemlistviewaccessible.* that 
 contain the three new classes.
 
 
 Diffs
 -
 
   dolphin/src/CMakeLists.txt afc190f 
   dolphin/src/kitemviews/kitemlistcontroller.cpp 88f5d9f 
   dolphin/src/kitemviews/kitemlistview.h 5723b9a 
   dolphin/src/kitemviews/kitemlistview.cpp 72b3fd8 
   dolphin/src/kitemviews/kitemlistviewaccessible.h PRE-CREATION 
   dolphin/src/kitemviews/kitemlistviewaccessible.cpp PRE-CREATION 
   dolphin/src/kitemviews/private/kitemlistviewlayouter.h da5bd1d 
   dolphin/src/tests/CMakeLists.txt 3f906d1 
 
 Diff: http://git.reviewboard.kde.org/r/105972/diff/
 
 
 Testing
 ---
 
 Focus-tracking tested with KMag / KWin. 
 
 
 Thanks,
 
 Amandeep Singh
 

Re: Review Request: Adding Accessibility Interfaces for Dolphin Views Widgets

[Frederik Gladhorn]

Hello Frank,

On Sunday 23. September 2012 00.10.38 Frank Reininghaus wrote:
 Hi everyone,
 
 2012/9/22 Frederik Gladhorn:
  This is an automatically generated e-mail. To reply, visit:
  http://git.reviewboard.kde.org/r/105972/
  
  Ship it!
 
 in my opinion, the Ship It! button should be pressed only by the
 maintainer or another core developer of the application. I have
 clearly stated in my review that some parts of the request are not
 acceptable in the current form, in particular adding the public
 function KItemListView::layouter().
I forgot this was an open point. We will look into this tomorrow, maybe we can 
find a solution that you will find acceptable.

 I have offered to test the new
 feature and then change the public API of the affected classes in a
 better way, but nobody bothered to comment on my statement that the
 build system of KMag, which is required to test the feature, is broken
 and that I can't build it. Maybe you expected me to fix KMag myself. I
 could have done this, of course, but I really don't have much time for
 working on Dolphin, and I prefer to spend it working on the items on
 my own (very long) TODO-list.
 
 What I find even more unfortunate than the unacceptable unautorised
 push is the way the changes show up in the history now. I actually
 like tools like git log, git blame, and qgit a lot, I like it when
 the history looks clean, and I always thought that the main point of
 review requests is to bring the proposed change in a form that can be
 included in one, or maybe a few, logically structured commits. But the
 history is now a big ugly mess. Having commits like, e.g.,
 
 https://projects.kde.org/projects/kde/kde-baseapps/repository/revisions/e6d4
 a935c8d03dcfda65e0b2f92d243b18a411e3/diff
 
 in the repository is really pointless. I know that this commit has
 been done after comments from me, but the version of the files that
 did not respect the coding style should not have been pushed to the
 public repository in the first place. The space that these dozens of
 pointless commits take up in the repository is maybe not a big concern
 nowadays, but they make examining the history (which I sometimes do to
 find the cause of a regression) very, very painful.

I completely agree. Sorry for the big mess, we'll be more careful to rebase 
and squash the next time.

 
 Well, the damage has been done, and there is no way to fix it now. But
 I kindly ask you not to do any major changes in Dolphin code, in
 particular changes in header files, ever again without discussing this
 with the Dolphin core maintainers and getting approval. Thanks for
 your understanding.
Sorry again.

 
 Another point that we have not discussed yet is who will maintain the
 accessibility classes in the future. If this code is included in
 Dolphin, I want to know who will take care of any bugs that users will
 find.
I assume Amandeep will keep an eye on this area. I will try to fix bugs when it 
comes to accessibility myself as much as I can, so please ask me to fix 
regressions in the code.

Greetings
Frederik


 
 Frank

Review Request: Only show the screen config changed message once.

[Frederik Gladhorn]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106212/
---

Review request for KDE Base Apps and Alex Fiestas.


Description
---

The dialog from the kded would show up once for each event (eg unpluggin and 
pluggin in again) related to monitor changes.
I wonder what the #warning Modal dialog, stupid, fix. was supposed to fix.
The dialog was redone since it's actually not very easy to re-use KMessageBox 
in a non-modal way.


Diffs
-

  kcontrol/randr/module/randrmonitor.h 057c991 
  kcontrol/randr/module/randrmonitor.cpp 32d0d0a 

Diff: http://git.reviewboard.kde.org/r/106212/diff/


Testing
---


Thanks,

Frederik Gladhorn

Re: Review Request: Adding Accessibility Interfaces for Dolphin Views Widgets

[Frederik Gladhorn]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105972/#review17923
---



dolphin/src/kitemviews/kitemlistviewaccessible.cpp
http://git.reviewboard.kde.org/r/105972/#comment14142

You are right.


- Frederik Gladhorn


On Aug. 17, 2012, 11:20 a.m., Amandeep Singh wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 http://git.reviewboard.kde.org/r/105972/
 ---
 
 (Updated Aug. 17, 2012, 11:20 a.m.)
 
 
 Review request for Dolphin, KDE Base Apps and KDE Accessibility.
 
 
 Description
 ---
 
 Added Accessibility Interfaces for Dolphin Views  Widgets, to make it 
 accessible.
 2 New files added in dolphin/ src/ kitemviews/ kitemlistviewaccessible.* that 
 contain the three new classes.
 
 
 Diffs
 -
 
   dolphin/src/CMakeLists.txt afc190f 
   dolphin/src/kitemviews/kitemlistcontroller.cpp 88f5d9f 
   dolphin/src/kitemviews/kitemlistview.h 5723b9a 
   dolphin/src/kitemviews/kitemlistview.cpp 72b3fd8 
   dolphin/src/kitemviews/kitemlistviewaccessible.h PRE-CREATION 
   dolphin/src/kitemviews/kitemlistviewaccessible.cpp PRE-CREATION 
   dolphin/src/kitemviews/private/kitemlistviewlayouter.h da5bd1d 
   dolphin/src/tests/CMakeLists.txt 3f906d1 
 
 Diff: http://git.reviewboard.kde.org/r/105972/diff/
 
 
 Testing
 ---
 
 Focus-tracking tested with KMag / KWin. 
 
 
 Thanks,
 
 Amandeep Singh
 

Re: Review Request: Adding Accessibility Interfaces for Dolphin Views Widgets

[Frederik Gladhorn]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105972/#review17795
---



dolphin/src/kitemviews/kitemlistviewaccessible.cpp
http://git.reviewboard.kde.org/r/105972/#comment14034

The spaces are weird in this line.



dolphin/src/kitemviews/kitemlistviewaccessible.cpp
http://git.reviewboard.kde.org/r/105972/#comment14035

I think increasing by one is wrong here.
eg 9 items in 3 rows and 3 columns would return 4 here.



dolphin/src/kitemviews/kitemlistviewaccessible.cpp
http://git.reviewboard.kde.org/r/105972/#comment14036

Sibling is not very important. It will be removed in Qt 5 and can be 
ignored. But you can leave it for now.


- Frederik Gladhorn


On Aug. 17, 2012, 11:20 a.m., Amandeep Singh wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 http://git.reviewboard.kde.org/r/105972/
 ---
 
 (Updated Aug. 17, 2012, 11:20 a.m.)
 
 
 Review request for Dolphin, KDE Base Apps and KDE Accessibility.
 
 
 Description
 ---
 
 Added Accessibility Interfaces for Dolphin Views  Widgets, to make it 
 accessible.
 2 New files added in dolphin/ src/ kitemviews/ kitemlistviewaccessible.* that 
 contain the three new classes.
 
 
 Diffs
 -
 
   dolphin/src/CMakeLists.txt afc190f 
   dolphin/src/kitemviews/kitemlistcontroller.cpp 88f5d9f 
   dolphin/src/kitemviews/kitemlistview.h 5723b9a 
   dolphin/src/kitemviews/kitemlistview.cpp 72b3fd8 
   dolphin/src/kitemviews/kitemlistviewaccessible.h PRE-CREATION 
   dolphin/src/kitemviews/kitemlistviewaccessible.cpp PRE-CREATION 
   dolphin/src/kitemviews/private/kitemlistviewlayouter.h da5bd1d 
   dolphin/src/tests/CMakeLists.txt 3f906d1 
 
 Diff: http://git.reviewboard.kde.org/r/105972/diff/
 
 
 Testing
 ---
 
 Focus-tracking tested with KMag / KWin. 
 
 
 Thanks,
 
 Amandeep Singh
 

Re: Review Request: Adding Accessibility Interfaces for Dolphin Views Widgets

[Frederik Gladhorn]

 On Aug. 14, 2012, 3:44 p.m., Frank Reininghaus wrote:
  dolphin/src/kitemviews/kitemlistviewaccessible.h, line 143
  http://git.reviewboard.kde.org/r/105972/diff/3/?file=77712#file77712line143
 
  This class isn't needed any more, is it?
 
 Amandeep Singh wrote:
 This class is needed since the accessibility interface tree, as is shown 
 by Accerciser in dolphin will then never expand upto the Table Interface we 
 wrote. Basically QAI is present for the QWidgets and a11y clients can 
 navigate their children. 
 
 Since the KItemListView is a QGraphicsWidget, so accerciser is unable to 
 reach it directly. The class in question, KItemListContainerA11y provides 
 this connection to KItemListView.
 
 Frank Reininghaus wrote:
 OK, but then I wonder if my previous statement that the changes you had 
 proposed in KItemListContainer in the first version of your patch are not 
 needed is correct. I'm not familiar with QAccessible, but I can't see how any 
 code is supposed to construct or call methods of a 
 KItemListContainerAccessible (which is required if I understand you correctly 
 because the QAccessible framwork cannot reach KItemListViewAccessible 
 directly) in the current version of your patch. But maybe I got something 
 wrong.
 
 In other words: have you checked that the current version of the patch is 
 still working correctly?

The way the accessible objects are constructed is in 
QAccessible::queryAccessibleInterface. There are factories (and this patch adds 
a new one for the KItemListContainerA11y and KItemListViewAccessible) that get 
queried. It works by using QObject introspection and comparing the class name 
to what the factories support.


- Frederik


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105972/#review17396
---


On Aug. 17, 2012, 11:20 a.m., Amandeep Singh wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 http://git.reviewboard.kde.org/r/105972/
 ---
 
 (Updated Aug. 17, 2012, 11:20 a.m.)
 
 
 Review request for Dolphin, KDE Base Apps and KDE Accessibility.
 
 
 Description
 ---
 
 Added Accessibility Interfaces for Dolphin Views  Widgets, to make it 
 accessible.
 2 New files added in dolphin/ src/ kitemviews/ kitemlistviewaccessible.* that 
 contain the three new classes.
 
 
 Diffs
 -
 
   dolphin/src/CMakeLists.txt afc190f 
   dolphin/src/kitemviews/kitemlistcontroller.cpp 88f5d9f 
   dolphin/src/kitemviews/kitemlistview.h 5723b9a 
   dolphin/src/kitemviews/kitemlistview.cpp 72b3fd8 
   dolphin/src/kitemviews/kitemlistviewaccessible.h PRE-CREATION 
   dolphin/src/kitemviews/kitemlistviewaccessible.cpp PRE-CREATION 
   dolphin/src/kitemviews/private/kitemlistviewlayouter.h da5bd1d 
   dolphin/src/tests/CMakeLists.txt 3f906d1 
 
 Diff: http://git.reviewboard.kde.org/r/105972/diff/
 
 
 Testing
 ---
 
 Focus-tracking tested with KMag / KWin. 
 
 
 Thanks,
 
 Amandeep Singh
 

Re: Review Request: Adding Accessibility Interfaces for Dolphin Views Widgets

[Frederik Gladhorn]

 On Aug. 13, 2012, 2:50 p.m., Frank Reininghaus wrote:
  dolphin/src/kitemviews/kitemlistviewaccessible.h, line 16
  http://git.reviewboard.kde.org/r/105972/diff/2/?file=77302#file77302line16
 
  On the other hand, I see lots of QModelIndex and friends here, which is 
  something I don't particularly like. After all, the basic idea of the new 
  view engine is to get rid of Qt's itemviews.
  
  Is there an easy way to do it without Qt's itemviews?
 
 Frederik Gladhorn wrote:
 This is a very good point. For Qt 4 there is no way to avoid QModelIndex 
 since it's in the public API. I will look into this for Qt 5 since it's 
 definitively something we don't want to rely on.
 
 Frank Reininghaus wrote:
 It would be nice if the Qt itemviews dependency could be dropped with Qt 
 5.
 
 Concerning the public API: the Qt docs don't seem to contain anything 
 about QAccessibleTable2Interface and QAccessibleObjectEx, or am I missing 
 something?

I just checked, Qt 5 doesn't have QModelIndex in the API any more, we actually 
cleaned that up.
Regarding documentation: We never officially committed to the IAccessible2 like 
interfaces for Qt 4, so they are marked as internal, you can find some 
documentation in src/gui/qaccessible2.cpp (a little in Qt 4 and some more up to 
date one in Qt 5). Currently our plan is to make it official in Qt 5.1. This 
implementation is actually very good to validate what is problematic with the 
APIs, thus I'm happy for the feedback.


 On Aug. 13, 2012, 2:50 p.m., Frank Reininghaus wrote:
  dolphin/src/kitemviews/kitemlistviewaccessible.cpp, line 67
  http://git.reviewboard.kde.org/r/105972/diff/2/?file=77303#file77303line67
 
  I think this will fail when grouping is enabled.
 
 Frederik Gladhorn wrote:
 Frank, maybe you can give some guidance here. I didn't have time to 
 carefully read the KItemListView etc code, but for me the row/column 
 count/positions etc were a bit off. I wonder if there is a general problem in 
 the code or maybe just an off-by-one somewhere.
 
 Frank Reininghaus wrote:
 You're right, the rowCount issue is more tricky than it looks at first 
 sight, at least when grouping is enabled. Just leave it as it is at the 
 moment, I will look into that.
 
 About the row/column positions that are a bit off: the 
 QAccessible::updateAccessibility() calls always add 1 to the current index, 
 that looks strange and might be the cause of an off-by-one error. Or is there 
 a reason why 1 has to be added?

Yes, the +1 is one of the really ugly sides in Qt 4 accessibility. It's 
required, because we index children 1-based (0 is the item itself, 1 the first 
child). In Qt 5 this has been removed and the API is a lot more intuitive. For 
the time being this will have to stay this way though. I will happily do the Qt 
5 port in the near future.


- Frederik


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105972/#review17313
---


On Aug. 13, 2012, 5:50 a.m., Amandeep Singh wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 http://git.reviewboard.kde.org/r/105972/
 ---
 
 (Updated Aug. 13, 2012, 5:50 a.m.)
 
 
 Review request for Dolphin, KDE Base Apps and KDE Accessibility.
 
 
 Description
 ---
 
 Added Accessibility Interfaces for Dolphin Views  Widgets, to make it 
 accessible.
 2 New files added in dolphin/ src/ kitemviews/ kitemlistviewaccessible.* that 
 contain the three new classes.
 
 
 Diffs
 -
 
   dolphin/src/CMakeLists.txt 5c1a6da 
   dolphin/src/kitemviews/kitemlistcontainer.cpp 5500851 
   dolphin/src/kitemviews/kitemlistcontroller.cpp 88f5d9f 
   dolphin/src/kitemviews/kitemlistselectionmanager.cpp 383914d 
   dolphin/src/kitemviews/kitemlistview.h 5723b9a 
   dolphin/src/kitemviews/kitemlistview.cpp 72b3fd8 
   dolphin/src/kitemviews/kitemlistviewaccessible.h PRE-CREATION 
   dolphin/src/kitemviews/kitemlistviewaccessible.cpp PRE-CREATION 
   dolphin/src/kitemviews/private/kitemlistviewlayouter.h da5bd1d 
   dolphin/src/tests/CMakeLists.txt 3f906d1 
 
 Diff: http://git.reviewboard.kde.org/r/105972/diff/
 
 
 Testing
 ---
 
 Focus-tracking tested with KMag / KWin. 
 
 
 Thanks,
 
 Amandeep Singh
 

Re: Review Request: Adding Accessibility Interfaces for Dolphin Views Widgets

[Frederik Gladhorn]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105972/#review17304
---



dolphin/src/kitemviews/kitemlistcontainer.cpp
http://git.reviewboard.kde.org/r/105972/#comment13465

missing #ifndef QT_NO_ACCESSIBIILTY



dolphin/src/kitemviews/kitemlistcontainer.cpp
http://git.reviewboard.kde.org/r/105972/#comment13464

I agree with Jose, remove the removeFactory.



dolphin/src/kitemviews/kitemlistcontainer.cpp
http://git.reviewboard.kde.org/r/105972/#comment13468

#ifndef QT_NO_ACCESSIBIILTY



dolphin/src/kitemviews/kitemlistcontainer.cpp
http://git.reviewboard.kde.org/r/105972/#comment13466

Why do you send LocationChanged here? I don't think it's right or relevant. 
We generally don't send geometry updates.



dolphin/src/kitemviews/kitemlistcontainer.cpp
http://git.reviewboard.kde.org/r/105972/#comment13469

#ifndef QT_NO_ACCESSIBIILTY



dolphin/src/kitemviews/kitemlistcontainer.cpp
http://git.reviewboard.kde.org/r/105972/#comment13467

Remove LocationChanged



dolphin/src/kitemviews/kitemlistcontainer.cpp
http://git.reviewboard.kde.org/r/105972/#comment13470

#ifndef QT_NO_ACCESSIBIILTY and remove LocationChanged everywhere.



dolphin/src/kitemviews/kitemlistselectionmanager.cpp
http://git.reviewboard.kde.org/r/105972/#comment13471

not needed, revert the whole file.



dolphin/src/kitemviews/kitemlistview.cpp
http://git.reviewboard.kde.org/r/105972/#comment13472

I agree, you should only have one factory for all classes. Missing #ifndef 
QT_NO_ACCESSIBIILTY here again.



dolphin/src/kitemviews/kitemlistviewaccessible.h
http://git.reviewboard.kde.org/r/105972/#comment13474

Qt itemview headers should not be needed here.



dolphin/src/kitemviews/kitemlistviewaccessible.h
http://git.reviewboard.kde.org/r/105972/#comment13477

Doesn't make sense, you could have itemviews ng without the traditional 
itemviews.



dolphin/src/kitemviews/kitemlistviewaccessible.h
http://git.reviewboard.kde.org/r/105972/#comment13475

use the same style of comment everywhere (either capitalize or not, either 
space after // or not)



dolphin/src/kitemviews/kitemlistviewaccessible.h
http://git.reviewboard.kde.org/r/105972/#comment13476

Having the protected keyword twice doesn't make much sense.



dolphin/src/kitemviews/kitemlistviewaccessible.h
http://git.reviewboard.kde.org/r/105972/#comment13478

Weird style (two spaces), parenthesis with extra spaces etc, see kde libs 
coding style.



dolphin/src/kitemviews/kitemlistviewaccessible.cpp
http://git.reviewboard.kde.org/r/105972/#comment13473

dtor not needed, I'd prefer to remove it.



dolphin/src/kitemviews/kitemlistviewaccessible.cpp
http://git.reviewboard.kde.org/r/105972/#comment13479

Never use  for an empty string. You want QString().



dolphin/src/kitemviews/kitemlistviewaccessible.cpp
http://git.reviewboard.kde.org/r/105972/#comment13480

Actually I don't think there is much to fix. The model change can be 
ignored, it's a broken concept that got into QAccessible from IAccessible2. 
Rather add a comment that it's ignored on purpose (and will be gone in Qt 5).


- Frederik Gladhorn


On Aug. 13, 2012, 5:50 a.m., Amandeep Singh wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 http://git.reviewboard.kde.org/r/105972/
 ---
 
 (Updated Aug. 13, 2012, 5:50 a.m.)
 
 
 Review request for Dolphin, KDE Base Apps and KDE Accessibility.
 
 
 Description
 ---
 
 Added Accessibility Interfaces for Dolphin Views  Widgets, to make it 
 accessible.
 2 New files added in dolphin/ src/ kitemviews/ kitemlistviewaccessible.* that 
 contain the three new classes.
 
 
 Diffs
 -
 
   dolphin/src/CMakeLists.txt 5c1a6da 
   dolphin/src/kitemviews/kitemlistcontainer.cpp 5500851 
   dolphin/src/kitemviews/kitemlistcontroller.cpp 88f5d9f 
   dolphin/src/kitemviews/kitemlistselectionmanager.cpp 383914d 
   dolphin/src/kitemviews/kitemlistview.h 5723b9a 
   dolphin/src/kitemviews/kitemlistview.cpp 72b3fd8 
   dolphin/src/kitemviews/kitemlistviewaccessible.h PRE-CREATION 
   dolphin/src/kitemviews/kitemlistviewaccessible.cpp PRE-CREATION 
   dolphin/src/kitemviews/private/kitemlistviewlayouter.h da5bd1d 
   dolphin/src/tests/CMakeLists.txt 3f906d1 
 
 Diff: http://git.reviewboard.kde.org/r/105972/diff/
 
 
 Testing
 ---
 
 Focus-tracking tested with KMag / KWin. 
 
 
 Thanks,
 
 Amandeep Singh
 

KDE Accessibility Docmentation

[Frederik Gladhorn]

Hi,

after a few requests, I spent some time today trying to provide a some 
documentation for KDE accessibility.
Keep in mind that this is such a broad topic that I can only hope to see the 
tip of the iceberg.
I am currently in A Coruña at the Gnome accessibility hackfest in order to 
learn and cooperate.

I put the documentation in two places, trying to give it some structure but I 
know it needs some help and polish.
If you spot errors or think that it can be improved, please do so.

The user documentation can be found here:
http://userbase.kde.org/Accessibility

My request to people testing kde applications with screen readers would be to 
record your experiences. Especially when an application is almost useable, send 
a mail to the kde-accessibil...@kde.org list and maybe put a few notes in the 
list of applications 
(http://userbase.kde.org/Accessibility/Application_Overview).
Yes, I think it is about time to start testing. I know there are a few open 
bugs, we put a first round into Qt 4.8.1 today.

For developers, I tried to summarize some things here:
http://techbase.kde.org/Development/Tutorials/Accessibility

It would be great if people with actual knowledge of what needs to be done for 
good experiences with screen readers and other accessibility needs could add to 
the checklist.

If you would like to help with this effort, please let me know.
I'm looking for help with moving the good contents that may lurk on 
accessibility.kde.org over to the wikis.
If you can generally check/proofread/improve the documentation, that would be 
fabulous.

I have some work for applications started, an unfinished Kate patch for 
example, but we need feedback, which appliations you would like to be 
accessible.
On the other hand, I'm more than happy for every developer that is interested 
in fixing their application or doing some general work in this area.
And finally we need people to help test all this, best if you want an 
application to be usefull to you. Feedback appreciated!

Join #kde-accessibility on freenode.

Cheers
Frederik

Accessibility and KDE Sessions

[Frederik Gladhorn]

Hi,
currently there is good stuff happening when it comes to Accessibility and KDE.

I have lately spend some time improving the qt-at-spi bridge and it is getting 
a lot better, I hope we will have something sensibly working with Qt 4.8 and 
correspondingly one of the next KDE releases.

On thing that came up with the Gnome accessibility people is how we enable 
accessibility in a cross-desktop way. There are two sides to this: 1) when 
should Qt load the accessibility plugins on Linux and 2) how to make a KDE 
session accessible on log in.

1) Making Qt load accessibility plugins:
One possible solution is to query a X-Atom to check if the accessibility dbus 
is running. The downside is that this only works for newly started 
applications. It requires no changes to the existing infra structure and can 
be handled inside Qt with no changes in other places.
(for comparison, on Windows we get a system call NotifyWinEvent which signifies 
that now the accessibility should be activated... the current reality is that 
you need to have QT_ACCESSIBILITY=1 set in your environment when starting a Qt 
app)

2) Activating accessibility for a KDE Session
I have no idea about how to handle this in KDM.
For KDE in general, we could again persue a similar way to what Gnome does.
There is the at-spi-dbus-bus.desktop file included in at-spi-2-core which takes 
care of starting a dbus registry and setting up the session as needed 
(starting Orca for example)
The desktop file checks for a gconf setting. [1] I guess there is some 
equivalent way to do this in KDE and the maintainers are happy to extend this 
for us.

I would be interested to get feedback how to tackle these issues and making 
them a cross desktop standard. I bet there are nicer solutions than what I 
posted above.

Cheers,
Frederik


[1]
[Desktop Entry]
Type=Application
Name=AT SPI D-Bus Bus
Exec=/usr/libexec/at-spi-bus-launcher --launch-immediately
OnlyShowIn=GNOME;
NoDisplay=true
AutostartCondition=GSETTINGS org.gnome.desktop.interface toolkit-accessibility
X-GNOME-AutoRestart=true

Re: Review Request: KNewStuff3: allow uninstalling an entry via DownloadManager

[Frederik Gladhorn]

---
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6410/#review9696
---

Ship it!


Looks good to me, please commit.

- Frederik


On Jan. 23, 2011, 6:06 p.m., Martin Blumenstingl wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 http://svn.reviewboard.kde.org/r/6410/
 ---
 
 (Updated Jan. 23, 2011, 6:06 p.m.)
 
 
 Review request for kdelibs, Frederik Gladhorn and Jeremy Whiting.
 
 
 Summary
 ---
 
 Currently it is not possible to uninstall entries via some self-written code.
 
 This patch simply adds an uninstall method to the DownloadManager - which is 
 used like the install method.
 
 
 Diffs
 -
 
   /trunk/KDE/kdelibs/knewstuff/knewstuff3/downloadmanager.h 1216491 
   /trunk/KDE/kdelibs/knewstuff/knewstuff3/downloadmanager.cpp 1216491 
 
 Diff: http://svn.reviewboard.kde.org/r/6410/diff
 
 
 Testing
 ---
 
 -
 
 
 Thanks,
 
 Martin
 

Re: Review Request: KNewStuff3: allow uninstalling an entry via DownloadManager

[Frederik Gladhorn]

---
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6410/#review9697
---


Please add the @since tag for the right version (4.6 if you backport it).

- Frederik


On Jan. 23, 2011, 6:06 p.m., Martin Blumenstingl wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 http://svn.reviewboard.kde.org/r/6410/
 ---
 
 (Updated Jan. 23, 2011, 6:06 p.m.)
 
 
 Review request for kdelibs, Frederik Gladhorn and Jeremy Whiting.
 
 
 Summary
 ---
 
 Currently it is not possible to uninstall entries via some self-written code.
 
 This patch simply adds an uninstall method to the DownloadManager - which is 
 used like the install method.
 
 
 Diffs
 -
 
   /trunk/KDE/kdelibs/knewstuff/knewstuff3/downloadmanager.h 1216491 
   /trunk/KDE/kdelibs/knewstuff/knewstuff3/downloadmanager.cpp 1216491 
 
 Diff: http://svn.reviewboard.kde.org/r/6410/diff
 
 
 Testing
 ---
 
 -
 
 
 Thanks,
 
 Martin