Re: Review of special packager access

2016-07-19 Thread José Manuel Santamaría Lema
Hello,

El viernes, 8 de julio de 2016 23:39:41 (CEST) Ben Cooksley escribió:
> Hi all,
> 
> My apologies if you're not a packager or someone associated with a
> distribution - you can ignore this email. Packagers, please read on as
> this contains important details.
> 
> First: If you're a packager, please ensure you are subscribed to
> kde-distro-packag...@kde.org, which is our usual list for
> communicating with packagers. It would seem a number of you are
> missing from there :)

Subscribed

> [snip]
> 
> The list of accounts, which should approximately correspond to
> distributions, is as follows:
>
> [snip]
> - Siduction
> [snip]

Back in the days I was contributing both to siduction and kubuntu. Today I'm 
not working for siduction anymore but I'm still doing some contributions to 
kubuntu and I need access to the tarballs.

So it would be great if I could get my key into the kubuntu account so you can 
remove the siduction one.

Regards.




Re: Review Request 123881: Add KONSOLEPRIVATE_EXPORT to HistoryScroll since it's hasScroll method is needed.

2015-08-07 Thread José Manuel Santamaría Lema

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123881/#review83538
---

Ship it!


Ship It!

- José Manuel  Santamaría Lema


On Mayo 22, 2015, 7:49 p.m., Jeremy Whiting wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://git.reviewboard.kde.org/r/123881/
 ---
 
 (Updated Mayo 22, 2015, 7:49 p.m.)
 
 
 Review request for KDE Base Apps and Konsole.
 
 
 Repository: konsole
 
 
 Description
 ---
 
 Without this HistoryTest fails to link here.
 
 
 Diffs
 -
 
   src/History.h 6314ef993a329b3a7b52b5e43aeacafaf4d896de 
 
 Diff: https://git.reviewboard.kde.org/r/123881/diff/
 
 
 Testing
 ---
 
 
 Thanks,
 
 Jeremy Whiting
 




Re: Review Request 123881: Add KONSOLEPRIVATE_EXPORT to HistoryScroll since it's hasScroll method is needed.

2015-08-07 Thread José Manuel Santamaría Lema


 On Mayo 23, 2015, 12:23 a.m., Aleix Pol Gonzalez wrote:
  Hm..
  Builds here.
  Also builds in build.kde.org... 
  https://build.kde.org/job/konsole%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/2/
  
  :/
 
 Jeremy Whiting wrote:
 I'm not sure why, but I did test a few times before making this change. 
 Could it be because I'm building with gcc 5.1 again?
 
 Aleix Pol Gonzalez wrote:
 It could be, yes. Maybe we should also get CI with gcc 5... .

Hi,

the build failure fixed by this patch happens only with recent gcc 5 versions, 
hence why you cannot allways reproduce the failure.

I can assure you that you can reproduce the build failure right now with the 
gcc 5.2 provided in wily/proposed and debian unstable, for instance, failing 
build log for unpatched konsole built in wily:
http://gpul.grupos.udc.es/logs/konsole_15.04.2-0ubuntu1+santa1.1_amd64.build

The patch in question looks right from a theorical point of view and I can also 
say that it fixes the build failure mentioned above, so please ship it


- José Manuel


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123881/#review80746
---


On Mayo 22, 2015, 7:49 p.m., Jeremy Whiting wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://git.reviewboard.kde.org/r/123881/
 ---
 
 (Updated Mayo 22, 2015, 7:49 p.m.)
 
 
 Review request for KDE Base Apps and Konsole.
 
 
 Repository: konsole
 
 
 Description
 ---
 
 Without this HistoryTest fails to link here.
 
 
 Diffs
 -
 
   src/History.h 6314ef993a329b3a7b52b5e43aeacafaf4d896de 
 
 Diff: https://git.reviewboard.kde.org/r/123881/diff/
 
 
 Testing
 ---
 
 
 Thanks,
 
 Jeremy Whiting
 




Re: ABI break -- kdepimlims 4.9.3

2012-11-22 Thread José Manuel Santamaría Lema
Allen Winter win...@kde.org
 On Wednesday 21 November 2012 12:32:45 PM José Manuel Santamaría Lema wrote:
  Hello,
  
  while packaging kdepimlibs 4.9.3 I found what I think it's an ABI break
  in libkabc; looks like the ABI break was introduced in this commit:
  https://projects.kde.org/projects/kde/kdepimlibs/repository/revisions/da
  16f7d5
  
  The attached patch applies to 4.9.3 and solves the problem. If the patch
  is acceptable for you I can commit and push it to git.
  
  Thank you for your time.
 
 Yep.  Thanks for finding and fixing.
 -Allen

Ok, pushed to the KDE/4.9 branch.


signature.asc
Description: This is a digitally signed message part.


ABI break -- kdepimlims 4.9.3

2012-11-21 Thread José Manuel Santamaría Lema
Hello,

while packaging kdepimlibs 4.9.3 I found what I think it's an ABI break in 
libkabc; looks like the ABI break was introduced in this commit:
https://projects.kde.org/projects/kde/kdepimlibs/repository/revisions/da16f7d5

The attached patch applies to 4.9.3 and solves the problem. If the patch is 
acceptable for you I can commit and push it to git.

Thank you for your time.
--- a/kabc/scripts/addressee.src.cpp
+++ b/kabc/scripts/addressee.src.cpp
@@ -544,7 +544,7 @@ void Addressee::removeKey( const Key ke
   }
 }
 
-Key Addressee::key( Key::Type type, const QString customTypeString ) const
+Key Addressee::key( Key::Type type, QString customTypeString ) const
 {
   Key::List::ConstIterator it;
   Key::List::ConstIterator end(d-mKeys.constEnd());
@@ -575,7 +575,7 @@ Key::List Addressee::keys() const
   return d-mKeys;
 }
 
-Key::List Addressee::keys( Key::Type type, const QString customTypeString ) const
+Key::List Addressee::keys( Key::Type type, QString customTypeString ) const
 {
   Key::List list;
 
--- a/kabc/scripts/addressee.src.h
+++ b/kabc/scripts/addressee.src.h
@@ -276,7 +276,7 @@ class KABC_EXPORT Addressee
   @param customTypeString A string to match custom keys against when
  @p type is @c Key::Custom
  */
-Key key( Key::Type type, const QString customTypeString = QString() ) const;
+Key key( Key::Type type, QString customTypeString = QString() ) const;
 
 /**
   Return list of all keys.
@@ -299,7 +299,7 @@ class KABC_EXPORT Addressee
   @param customTypeString A string to match custom keys against when
  @p type is @c Key::Custom
  */
-Key::List keys( Key::Type type, const QString customTypeString = QString()  ) const;
+Key::List keys( Key::Type type, QString customTypeString = QString()  ) const;
 
 /**
   Return key with the given id.


signature.asc
Description: This is a digitally signed message part.


Re: KDE SC 4.8.4 important problems

2012-06-12 Thread José Manuel Santamaría Lema

 Therefore, I tend to think the kdelibs commit mentioned in that bug report
 (3d66d429cb48781881af3e735f2a80af2114ab25) shouldn't have been done for
 4.8.4. A confirmation from a Nepomuk developer would be highly
 appreciated.

Just in case it isn't obvious enough, actually I meant this one shouldn't have 
been done for 4.8.4:
http://quickgit.kde.org/index.php?p=kdelibs.gita=commith=a43824a200ed76cef48a90bd3aee8547698b7c91
which is the kdelibs one. I just pasted the wrong hash.


signature.asc
Description: This is a digitally signed message part.


Re: KDE SC 4.8.4 important problems

2012-06-11 Thread José Manuel Santamaría Lema
Hi,

Peter Penz peter.pen...@gmail.com
 The issue has been tracked at
 https://bugs.kde.org/show_bug.cgi?id=268064 - updating Soprano to the
 latest master resolves the crash. But I don't know more about the
 root-cause of this. Probably a Nepomuk-related update missed a proper
 versioning-check of Soprano?

There is also another bug report about all these crashes in general 
https://bugs.kde.org/show_bug.cgi?id=301453

Also, according to Manu Tortosa, indeed kde 4.8.4 works without crashes with 
the newer, beta soprano..

I inspected the soprano git repository and I found this commit:
http://quickgit.kde.org/index.php?p=soprano.gita=commith=3d66d429cb48781881af3e735f2a80af2114ab25

which was done the same day than the commit mentioned in the above bug report
https://bugs.kde.org/show_bug.cgi?id=301453#c2

So I built and install kdelibs reverting the commit mentioned in the comment 
#2, this hacked version of kdelibs has been making the crashes gone so far for 
me.

I have checked the debug output for gwenview with a system with the official 
4.8.4 kdelibs, I'm attaching it  as gwenview_stdout_crashing.txt. I did the 
same with a system with the hacked kdelibs, I'm attaching that output as 
gwenview_stdout_working.txt

Note that the working gwenview produces just one line like this:
gwenview(3899)/nepomuk (library) {anonymous}::GlobalModelContainer::init: 
Connecting to local socket /tmp/ksocket-santa/nepomuk-socket
while the crashing gwenview tries to connect to that socket various times.

Also note that if I remove /tmp/ksocket-santa/nepomuk-socket the crashes are 
gone.

So I also built a hacked soprano; this hacked soprano is 2.7.6 patched with 
these couple of commits:
http://quickgit.kde.org/index.php?p=kdelibs.gita=commith=a43824a200ed76cef48a90bd3aee8547698b7c91
http://quickgit.kde.org/index.php?p=soprano.gita=commith=5dde64227186d405f86bf66256705fbceabcf1e2
Installing it in an affected system makes the crashes vanish.

Therefore, I tend to think the kdelibs commit mentioned in that bug report 
(3d66d429cb48781881af3e735f2a80af2114ab25) shouldn't have been done for 4.8.4. 
A confirmation from a Nepomuk developer would be highly appreciated.
$ gwenview
gwenview(326)/nepomuk (library) {anonymous}::GlobalModelContainer::init: 
Connecting to local socket /tmp/ksocket-santa/nepomuk-socket
gwenview(326)/nepomuk (library) {anonymous}::GlobalModelContainer::init: 
Connecting to local socket /tmp/ksocket-santa/nepomuk-socket
gwenview(326)/nepomuk (library) {anonymous}::GlobalModelContainer::init: 
Connecting to local socket /tmp/ksocket-santa/nepomuk-socket
gwenview(326)/kio (bookmarks) KBookmarkManager::KBookmarkManager: starting 
KDirWatch for  /home/santa/.local/share/user-places.xbel
gwenview(326)/kdecore (KSycoca) KSycocaPrivate::openDatabase: Trying to open 
ksycoca from /var/tmp/kdecache-santa/ksycoca4
gwenview(326)/kio (KDirListerCache) KDirListerCache::listDir: Listing 
directory: KUrl(trash:/)
gwenview(326)/kio (Scheduler) KIO::SchedulerPrivate::doJob: 
KIO::SimpleJob(0x1b36470)
gwenview(326)/kio (Scheduler) KIO::SchedulerPrivate::protoQ: creating 
ProtoQueue instance for trash
gwenview(326)/kio (Scheduler) KIO::ProtoQueue::ProtoQueue: 
m_maxConnectionsTotal: 2 m_maxConnectionsPerHost: 2
gwenview(326)/kdecore (KLocale) KuitSemanticsPrivate::formatFromContextMarker: 
Unknown semantic role '@addaction' in context marker for message {Name}.
gwenview(326)/kdecore (KLocale) KuitSemanticsPrivate::formatFromContextMarker: 
Unknown semantic role '@addaction' in context marker for message {Date}.
gwenview(326)/kdecore (KLocale) KuitSemanticsPrivate::formatFromContextMarker: 
Unknown semantic role '@addaction' in context marker for message {Size}.
gwenview(326)/nepomuk (library) {anonymous}::GlobalModelContainer::init: 
Connecting to local socket /tmp/ksocket-santa/nepomuk-socket
gwenview(326)/kio (KDirListerCache) KDirListerCache::listDir: Entry currently 
being listed: KUrl(trash:/) by (KDirLister(0x1b36780) )
gwenview(326)/nepomuk (library) {anonymous}::GlobalModelContainer::init: 
Connecting to local socket /tmp/ksocket-santa/nepomuk-socket
gwenview(326)/kdeui (kdelibs): Attempt to use QAction edit_redo with 
KXMLGUIFactory! 
gwenview(326)/kdeui (kdelibs): Attempt to use QAction edit_undo with 
KXMLGUIFactory! 
gwenview(326)/kdecore (K*TimeZone*) KSystemTimeZonesPrivate::instance: 
instance(): ... initialised
gwenview(326)/kdecore (K*TimeZone*) KSystemTimeZonesPrivate::readConfig: 
readConfig(): local zone= Europe/Madrid
gwenview(326)/kdecore (K*TimeZone*) KSystemTimeZonesPrivate::readZoneTab: 
readZoneTab( /usr/share/zoneinfo/zone.tab )
gwenview(326)/nepomuk (library) {anonymous}::GlobalModelContainer::init: 
Connecting to local socket /tmp/ksocket-santa/nepomuk-socket
gwenview(326)/kio (KDirListerCache) KDirListerCache::listDir: Entry currently 
being listed: KUrl(trash:/) by (KDirLister(0x1b36780) ,  
KDirLister(0x1de3c40) )
gwenview(326)/kio (KDirListerCache) KDirListerCache::stopListingUrl: 

KDE SC 4.8.4 important problems

2012-06-10 Thread José Manuel Santamaría Lema
Hello,

firstly, to be honest, let me say I'm doing huge effort to write this mail in a 
way that I don't look like a clueless cretin who reports bugs to the mailing 
lists instead of the proper place (bugs.kde.org) just to cheat and get my 
bugs fixed. I promise I'm not that kind of person, I have a git/svn KDE account 
and I'm already doing a very modest contribution. In my honest opinion I know 
a bit how things work in KDE with regarding to the bug reporting stuff.

Also I'm packaging KDE for Debian in a team collaborating with other people 
since some time ago (I've been involved in 4.5.x, 4.6.x, 4.7.x and 4.8.x) and 
that's why I am writing here: when testing the latest point release of KDE SC 
(4.8.4), we are getting several crashes, and most of them are the kind of bugs 
(called release-critical in Debian) which would prevent us to release packages 
in the next stable release or migrate them to the testing branch. 

Most of these crashes follow this pattern (sorry for the vagueness, I 
hope to gather more information this night or so, I'll try to keep you posted 
but I can't promise anything):
1. Can't be reproduced with Nepomuk disabled.
2. Can't be reproduced with kdelibs 4.8.3
3. Can't be reproduced with KDE SC 4.9.
4. Could also be reproduced by various users and developers from other 
distributions.
5. They are not 100% reproducible; however they happen everytime in some 
computers, on others just very often; so often that make certain KDE programs 
unusuable.
6. I _feel_ backtraces might be invalid.

Since I have been packaging KDE (more or less since 4.5 as said above) I never 
got 7 potential RC bugs in a release (not even a .0 one) after just ~2 days of 
use. Read again the characteristics 2. 3. and .4; that in conjunction with the 
fact that some people just discovered today how you are managing git 
branches/freeze for kdelibs (myself included) is why I think we are getting 
some people in other thread questioning -with or without reason- the kdelibs 
development model. I don't want to discuss the kdelibs development model in 
this thread (I would really prefer to keep any possible omfg kdelibs 
developers are using the same branch for 4.9 and 4.8 messages in the other 
thread) I'm just explaining the situation, I hope you get now why you are 
reading the things you are reading in the other thread.

That being said, in this thread I want to focus on the actual grave problem(s) 
of 4.8.4, this is the list of crashes I have been experiencing:

#1 dolphin:
I can reproduce it right now in one of my computers just opening it, in other 
sometimes it crashes just clicking a file or folder. Eshat Cakar -a fellow 
Debian packager- also got other crash just clicking a folder, however he can't 
reproduce it anymore after he rebooted his computer.
Backtraces:
http://alioth.debian.org/~santa-guest/4.8.4_crashes/bug_dolphin_santa.kcrash.
http://alioth.debian.org/~santa-guest/4.8.4_crashes/bug_dolphin_eshat.txt

#2 gwenview 
I can reproduce it just clicking an image and sometimes even just starting the 
application.
Backtrace:
http://alioth.debian.org/~santa-guest/4.8.4_crashes/bug_gwenview_santa.kcrash

#3 kontact executing the kaddressbook component
I can reproduce it very oftenly just clicking the kaddressbok component in 
kontact.
Backtrace:
http://alioth.debian.org/~santa-guest/4.8.4_crashes/bug_kontact_santa.kcrash

#4 kmail executed outside kontact
I can reproduce it just executing kmail outside kontact
Backtrace:
http://alioth.debian.org/~santa-guest/4.8.4_crashes/bug_kmail_santa.kcrash

#5 kmail marking messages as read
I think this one got fixed by a commit in kdepimlibs, which I included in the 
debian packaging. Please ignore for now.

#6 kontact executing various components: calendar, to-do list, journal
When clicking on various kontact component I'm getting a segmentation fault, 
always with the same backtrace:
http://alioth.debian.org/~santa-guest/4.8.4_crashes/bug2_kontact_santa.kcrash

#7 kmail links
I can reproduce this one just opening a message with an url. Just clicking 
that url, which would it open it in konqueror given my local configuration 
crashes kmail:
Backtrace:
http://alioth.debian.org/~santa-guest/4.8.4_crashes/kmail_links.kcrash


signature.asc
Description: This is a digitally signed message part.


Re: Suggestions for some KDE default options

2011-12-17 Thread José Manuel Santamaría Lema
In first place, sorry for posting in this kind of thread, I'm doing it only in 
hope that you find this message useful when dealing with trolls. I don't want 
to offend anybody.

Anders Lund and...@alweb.dk
 On the other hand, being rude and patronizing towards a frustrated user
 trying to fix things does not help anyone either. Even if the suggestions
 are not well thought out, they are not posted here in a desire to be
 harmful, rather in a desire to use KDE software.

I found a couple of messages in a famous spanish forum posted by the user who 
started this thread:
http://www.forocoches.com/foro/showthread.php?p=98261515#post98261515
http://www.forocoches.com/foro/showthread.php?p=98377764#post98377764

The first one could be translated as:
I have put a slightly trolling message in the kde mailing list, I whish they 
accept it.

In the second one, in my opinion, he's just being proud of his trolling 
message.

For the record, in that thread there are several messages of this and other 
rude users indirectly insulting me and my fellow developers. As my name 
suggests, Spanish is my native language, I've read a bit that thread of that 
forum and I can assure you that there isn't any good intention behind the 
trolling message in this list, nor in any of the various offensive messages in 
that thread of that forum.

Thomas Lübking thomas.luebk...@gmail.com
 please google up the name of that user - best alongside his title
 some spanish fellows can likely tell for sure but to my findings it's
 a character from a famous spanish tv show

Yes. If I recall correctly even the adress he wrote is right for that 
character.


Review Request: Clearing scrollback and resetting does not present a new prompt

2011-02-08 Thread José Manuel Santamaría Lema

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100611/
---

Review request for Konsole.


Summary
---

Hi,

I can reproduce bug #242110 here, so I fixed it. Note that commit 
5d61b69e3e6a0348b04a0848a7080f748b36eb6e re-added Clear ScrollBack and Reset. 
This commit introduced _session-refresh(); commented out. I have checked the 
previous, different implementation from 4.4 branch and that implementation 
called _session-refresh() so I guess it must be commented out by accident.


This addresses bug 242110.
http://bugs.kde.org/show_bug.cgi?id=242110


Diffs
-

  src/SessionController.cpp a5d4019 

Diff: http://git.reviewboard.kde.org/r/100611/diff


Testing
---

I reproduced the bug and tested the patch installing from not-yet-released 
debian packages for KDE SC 4.6 (I'm working on them among other people).


Thanks,

José Manuel