Re: ABI break -- kdepimlims 4.9.3

2012-11-22 Thread José Manuel Santamaría Lema 
Allen Winter win...@kde.org
 On Wednesday 21 November 2012 12:32:45 PM José Manuel Santamaría Lema wrote:
  Hello,
  
  while packaging kdepimlibs 4.9.3 I found what I think it's an ABI break
  in libkabc; looks like the ABI break was introduced in this commit:
  https://projects.kde.org/projects/kde/kdepimlibs/repository/revisions/da
  16f7d5
  
  The attached patch applies to 4.9.3 and solves the problem. If the patch
  is acceptable for you I can commit and push it to git.
  
  Thank you for your time.
 
 Yep.  Thanks for finding and fixing.
 -Allen

Ok, pushed to the KDE/4.9 branch.


signature.asc
Description: This is a digitally signed message part.

ABI break -- kdepimlims 4.9.3

2012-11-21 Thread José Manuel Santamaría Lema 
Hello,

while packaging kdepimlibs 4.9.3 I found what I think it's an ABI break in 
libkabc; looks like the ABI break was introduced in this commit:
https://projects.kde.org/projects/kde/kdepimlibs/repository/revisions/da16f7d5

The attached patch applies to 4.9.3 and solves the problem. If the patch is 
acceptable for you I can commit and push it to git.

Thank you for your time.
--- a/kabc/scripts/addressee.src.cpp
+++ b/kabc/scripts/addressee.src.cpp
@@ -544,7 +544,7 @@ void Addressee::removeKey( const Key ke
   }
 }
 
-Key Addressee::key( Key::Type type, const QString customTypeString ) const
+Key Addressee::key( Key::Type type, QString customTypeString ) const
 {
   Key::List::ConstIterator it;
   Key::List::ConstIterator end(d-mKeys.constEnd());
@@ -575,7 +575,7 @@ Key::List Addressee::keys() const
   return d-mKeys;
 }
 
-Key::List Addressee::keys( Key::Type type, const QString customTypeString ) const
+Key::List Addressee::keys( Key::Type type, QString customTypeString ) const
 {
   Key::List list;
 
--- a/kabc/scripts/addressee.src.h
+++ b/kabc/scripts/addressee.src.h
@@ -276,7 +276,7 @@ class KABC_EXPORT Addressee
   @param customTypeString A string to match custom keys against when
  @p type is @c Key::Custom
  */
-Key key( Key::Type type, const QString customTypeString = QString() ) const;
+Key key( Key::Type type, QString customTypeString = QString() ) const;
 
 /**
   Return list of all keys.
@@ -299,7 +299,7 @@ class KABC_EXPORT Addressee
   @param customTypeString A string to match custom keys against when
  @p type is @c Key::Custom
  */
-Key::List keys( Key::Type type, const QString customTypeString = QString()  ) const;
+Key::List keys( Key::Type type, QString customTypeString = QString()  ) const;
 
 /**
   Return key with the given id.


signature.asc
Description: This is a digitally signed message part.

Re: ABI break -- kdepimlims 4.9.3

2012-11-21 Thread Allen Winter 
On Wednesday 21 November 2012 12:32:45 PM José Manuel Santamaría Lema wrote:
 Hello,
 
 while packaging kdepimlibs 4.9.3 I found what I think it's an ABI break in 
 libkabc; looks like the ABI break was introduced in this commit:
 https://projects.kde.org/projects/kde/kdepimlibs/repository/revisions/da16f7d5
 
 The attached patch applies to 4.9.3 and solves the problem. If the patch is 
 acceptable for you I can commit and push it to git.
 
 Thank you for your time.

Yep.  Thanks for finding and fixing.
-Allen