Re: Eloquens now on KDEREVIEW
I opened an issue in line with the new process https://invent.kde.org/sdk/eloquens/-/issues/1 Jonathan On Mon, 20 Jun 2022 at 21:30, Felipe Kinoshita wrote: > For those who don't know, Eloquens is a simple application targeted at > developers/designers, it generates the lorem ipsum text and allows you to > customize it a little bit like adding heading, bullet lists, etc... > > I would also like to ask if it would be possible for it to be released > along with KDE Gear. > > Thanks, > Felipe >
Re: Eloquens now on KDEREVIEW)
Hi Felipe, there doesn't seem to have been any movement on this for some months, are you still interested in working on it? If it's a useful app it can be added to KDE gear to get releases done for example. Jonathan On Sat, 3 Sept 2022 at 10:40, Tomaz Canabrava wrote: > Hello All, > > All discussion was resolved by Felipe in the past few weeks, > I Assume this is done, and should be moved out of KDE Review? > > Best. > > > On Tue, Jun 28, 2022 at 4:54 PM Felipe Kinoshita > wrote: > >> friendly ping! :) >> >> On Wed, Jun 22, 2022 at 5:44 PM Felipe Kinoshita >> wrote: >> > >> > > Ah! I would suggest moving the conversion into the Controller then. As >> > > far as kcfg, your Config object and your Settings.qml are concerned >> > > they can be proper bools, it's only in the Controller that you have >> > > the presentation requirement that bools must be 0/1. This saves you >> > > the two-way conversion, in the Controller you only need to convert >> > > bool=>int and the rest of the app can treat them as proper bools. >> > >> > Indeed, this makes much more sense. >> > >> > Fixed it now! >> > >> > Thanks, >> > Felipe >> > >> > On Wed, Jun 22, 2022 at 10:10 AM Harald Sitter wrote: >> > > >> > > On Wed, Jun 22, 2022 at 12:07 AM Felipe Kinoshita >> wrote: >> > > > >> > > > > Could you elaborate why your config.kcfg uses Ints for everything >> when >> > > > > you clearly want booleans (e.g. `Config.code == 1 ? true : false`) >> > > > >> > > > The API expects ones and zeros for its params, I chose to convert >> them to >> > > > booleans to make the API call easier to write and change. >> > > >> > > Ah! I would suggest moving the conversion into the Controller then. As >> > > far as kcfg, your Config object and your Settings.qml are concerned >> > > they can be proper bools, it's only in the Controller that you have >> > > the presentation requirement that bools must be 0/1. This saves you >> > > the two-way conversion, in the Controller you only need to convert >> > > bool=>int and the rest of the app can treat them as proper bools. >> > > >> > > HS >> >
Re: Eloquens now on KDEREVIEW)
Hello All, All discussion was resolved by Felipe in the past few weeks, I Assume this is done, and should be moved out of KDE Review? Best. On Tue, Jun 28, 2022 at 4:54 PM Felipe Kinoshita wrote: > friendly ping! :) > > On Wed, Jun 22, 2022 at 5:44 PM Felipe Kinoshita > wrote: > > > > > Ah! I would suggest moving the conversion into the Controller then. As > > > far as kcfg, your Config object and your Settings.qml are concerned > > > they can be proper bools, it's only in the Controller that you have > > > the presentation requirement that bools must be 0/1. This saves you > > > the two-way conversion, in the Controller you only need to convert > > > bool=>int and the rest of the app can treat them as proper bools. > > > > Indeed, this makes much more sense. > > > > Fixed it now! > > > > Thanks, > > Felipe > > > > On Wed, Jun 22, 2022 at 10:10 AM Harald Sitter wrote: > > > > > > On Wed, Jun 22, 2022 at 12:07 AM Felipe Kinoshita > wrote: > > > > > > > > > Could you elaborate why your config.kcfg uses Ints for everything > when > > > > > you clearly want booleans (e.g. `Config.code == 1 ? true : false`) > > > > > > > > The API expects ones and zeros for its params, I chose to convert > them to > > > > booleans to make the API call easier to write and change. > > > > > > Ah! I would suggest moving the conversion into the Controller then. As > > > far as kcfg, your Config object and your Settings.qml are concerned > > > they can be proper bools, it's only in the Controller that you have > > > the presentation requirement that bools must be 0/1. This saves you > > > the two-way conversion, in the Controller you only need to convert > > > bool=>int and the rest of the app can treat them as proper bools. > > > > > > HS >
Re: Eloquens now on KDEREVIEW)
friendly ping! :) On Wed, Jun 22, 2022 at 5:44 PM Felipe Kinoshita wrote: > > > Ah! I would suggest moving the conversion into the Controller then. As > > far as kcfg, your Config object and your Settings.qml are concerned > > they can be proper bools, it's only in the Controller that you have > > the presentation requirement that bools must be 0/1. This saves you > > the two-way conversion, in the Controller you only need to convert > > bool=>int and the rest of the app can treat them as proper bools. > > Indeed, this makes much more sense. > > Fixed it now! > > Thanks, > Felipe > > On Wed, Jun 22, 2022 at 10:10 AM Harald Sitter wrote: > > > > On Wed, Jun 22, 2022 at 12:07 AM Felipe Kinoshita > > wrote: > > > > > > > Could you elaborate why your config.kcfg uses Ints for everything when > > > > you clearly want booleans (e.g. `Config.code == 1 ? true : false`) > > > > > > The API expects ones and zeros for its params, I chose to convert them to > > > booleans to make the API call easier to write and change. > > > > Ah! I would suggest moving the conversion into the Controller then. As > > far as kcfg, your Config object and your Settings.qml are concerned > > they can be proper bools, it's only in the Controller that you have > > the presentation requirement that bools must be 0/1. This saves you > > the two-way conversion, in the Controller you only need to convert > > bool=>int and the rest of the app can treat them as proper bools. > > > > HS
Re: Eloquens now on KDEREVIEW)
> Ah! I would suggest moving the conversion into the Controller then. As > far as kcfg, your Config object and your Settings.qml are concerned > they can be proper bools, it's only in the Controller that you have > the presentation requirement that bools must be 0/1. This saves you > the two-way conversion, in the Controller you only need to convert > bool=>int and the rest of the app can treat them as proper bools. Indeed, this makes much more sense. Fixed it now! Thanks, Felipe On Wed, Jun 22, 2022 at 10:10 AM Harald Sitter wrote: > > On Wed, Jun 22, 2022 at 12:07 AM Felipe Kinoshita wrote: > > > > > Could you elaborate why your config.kcfg uses Ints for everything when > > > you clearly want booleans (e.g. `Config.code == 1 ? true : false`) > > > > The API expects ones and zeros for its params, I chose to convert them to > > booleans to make the API call easier to write and change. > > Ah! I would suggest moving the conversion into the Controller then. As > far as kcfg, your Config object and your Settings.qml are concerned > they can be proper bools, it's only in the Controller that you have > the presentation requirement that bools must be 0/1. This saves you > the two-way conversion, in the Controller you only need to convert > bool=>int and the rest of the app can treat them as proper bools. > > HS
Re: Eloquens now on KDEREVIEW)
On Wed, Jun 22, 2022 at 12:07 AM Felipe Kinoshita wrote: > > > Could you elaborate why your config.kcfg uses Ints for everything when > > you clearly want booleans (e.g. `Config.code == 1 ? true : false`) > > The API expects ones and zeros for its params, I chose to convert them to > booleans to make the API call easier to write and change. Ah! I would suggest moving the conversion into the Controller then. As far as kcfg, your Config object and your Settings.qml are concerned they can be proper bools, it's only in the Controller that you have the presentation requirement that bools must be 0/1. This saves you the two-way conversion, in the Controller you only need to convert bool=>int and the rest of the app can treat them as proper bools. HS
Re: Eloquens now on KDEREVIEW
> Could you elaborate why your config.kcfg uses Ints for everything when > you clearly want booleans (e.g. `Config.code == 1 ? true : false`) The API expects ones and zeros for its params, I chose to convert them to booleans to make the API call easier to write and change. I've fixed all the other issues you pointed out! Thanks, Felipe
Re: Eloquens now on KDEREVIEW)
> Could you elaborate why your config.kcfg uses Ints for everything when > you clearly want booleans (e.g. `Config.code == 1 ? true : false`) The API expects ones and zeros for its params, I chose to convert them to booleans to make the API call easier to write and change. I've fixed all the other issues you pointed out! Thanks, Felipe
Re: Eloquens now on KDEREVIEW
On 6/21/22 13:24, Harald Sitter wrote: some desktop file validation: (the last point is because SingleMainWindow isn't actually a valid key, you should remove it I guess) org.kde.eloquens.desktop: hint: value "Qt;KDE;Development;Utility;" for key "Categories" in group "Desktop Entry" contains more than one ma in category; application might appear more than once in the application menu org.kde.eloquens.desktop: error: file contains key "SingleMainWindow" in group "Desktop Entry", but keys extending the format should start with "X-" SingleMainWindow is a valid key, but handling it property requires a version of desktop-file-utils that was updated recently enough to notice. Nate
Re: Eloquens now on KDEREVIEW
On Mon, Jun 20, 2022 at 10:30 PM Felipe Kinoshita wrote: > > For those who don't know, Eloquens is a simple application targeted at > developers/designers, it generates the lorem ipsum text and allows you to > customize it a little bit like adding heading, bullet lists, etc... > > I would also like to ask if it would be possible for it to be released along > with KDE Gear. Neat! Link for would be reviewers https://invent.kde.org/sdk/eloquens I mostly have some nit picks: Your saveWindowGeometryTimer seems like a huge hack. Why not simply disable the Connections object when the window is not visible (or only turn it enabled when the window is fully initialized). There is absolutely no guarantee that the window will be in a good state after 1 second. It may be 5 it may be 10 it may be 30. In main.qml you really shouldn't hardcode font.family: "Liberation Serif";. If you want a serif font then simply use `serif`. Could you elaborate why your config.kcfg uses Ints for everything when you clearly want booleans (e.g. `Config.code == 1 ? true : false`) In Controller::fetch() you can declare and initialize `reply` in the same line. For the connect in there should pass `this` as third argument (not passing a context object is usually bad practice cause the lambda may get called past the captured variable's life) In App your destructor is unnecessary. You can remove it entirely - it violates the rule of five. There's also a dangling private: in the header. You might want to consider using the reuse-lint template to assert that reuse compliance doesn't regress https://invent.kde.org/plasma/plasma-disks/-/blob/master/.gitlab-ci.yml some desktop file validation: (the last point is because SingleMainWindow isn't actually a valid key, you should remove it I guess) org.kde.eloquens.desktop: hint: value "Qt;KDE;Development;Utility;" for key "Categories" in group "Desktop Entry" contains more than one ma in category; application might appear more than once in the application menu org.kde.eloquens.desktop: error: file contains key "SingleMainWindow" in group "Desktop Entry", but keys extending the format should start with "X-"
Re: Eloquens now on KDEREVIEW
Everything should be fixed now! Thanks, Felipe
Re: Eloquens now on KDEREVIEW
El dilluns, 20 de juny de 2022, a les 22:30:06 (CEST), Felipe Kinoshita va
escriure:
> For those who don't know, Eloquens is a simple application targeted at
> developers/designers, it generates the lorem ipsum text and allows you to
> customize it a little bit like adding heading, bullet lists, etc...
You need to load the translation catalog, aka
KLocalizedString::setApplicationDomain
You're using invent for bug reporting which is "not allowed"
You don't need
QCoreApplication::setApplicationName(QStringLiteral("eloquens"));
KAboutData::setApplicationData will do it for you
>
> I would also like to ask if it would be possible for it to be released
> along with KDE Gear.
Personally I always recommend new apps to release a few times on their own
because it allows them to do a much more direct feedback look with users,
otherwise your first release is in 2 months and if users think "this is cool
but would be much cooler with X feature" (which is relatively common on new
apps), they have to wait 4 months more.
On the other hand this application is super simple, so I may be convinced
that's not gonna happen.
Cheers,
Albert
>
> Thanks,
> Felipe
Eloquens now on KDEREVIEW
For those who don't know, Eloquens is a simple application targeted at developers/designers, it generates the lorem ipsum text and allows you to customize it a little bit like adding heading, bullet lists, etc... I would also like to ask if it would be possible for it to be released along with KDE Gear. Thanks, Felipe
