Re: Interesting issue for kde-baseapps, Jenkins kdesrc-build, proposed solution

2013-03-12 Thread Ben Cooksley
Hi all,

On Mon, Mar 11, 2013 at 8:16 PM, Christoph Cullmann cullm...@absint.com wrote:
 Other alternatives include splitting kate up in the various
 library/runtime-
 support/application components but that's a lot of extra work for
 what is
 really just a kde-projects problem.

Just a note that we now have a policy against any future modules being
in a similar situation such as this one.
Only historical modules will have this issue.


 Does anyone have objections to the sysadmins realigning the 3 git
 modules in
 question? (And if so, I'd appreciate ideas for better ways to fix).
 Hi,

 I would have no problem with moving kate.git around, splitting is IMHO
 a pain for later developing on it, as all parts are tightly coupled anyway.

Please note that the actual location of kate.git (on git.kde.org) will
not be affected in any way by this.
It only affects the module structure.


 Greetings
 Christoph

Regards,
Ben


 --
 - Dr.-Ing. Christoph Cullmann -
 AbsInt Angewandte Informatik GmbH  Email: cullm...@absint.com
 Science Park 1 Tel:   +49-681-38360-22
 66123 Saarbrücken  Fax:   +49-681-38360-20
 GERMANYWWW:   http://www.AbsInt.com
 
 Geschäftsführung: Dr.-Ing. Christian Ferdinand
 Eingetragen im Handelsregister des Amtsgerichts Saarbrücken, HRB 11234


Re: Interesting issue for kde-baseapps, Jenkins kdesrc-build, proposed solution

2013-03-12 Thread Michael Pyne
On Tuesday, March 12, 2013 20:38:30 Ben Cooksley wrote:
  Does anyone have objections to the sysadmins realigning the 3 git
  modules in
  question? (And if so, I'd appreciate ideas for better ways to fix).
  
  Hi,
  
  I would have no problem with moving kate.git around, splitting is IMHO
  a pain for later developing on it, as all parts are tightly coupled
  anyway.
 
 Please note that the actual location of kate.git (on git.kde.org) will
 not be affected in any way by this.
 It only affects the module structure.

Given the lack of opposition I have submitted a KDE Sysadmin bug [1] to 
request the move.

I will update dependency-data and kdesrc-build after the move is complete. 
Thanks!

[1] https://bugs.kde.org/show_bug.cgi?id=316629

Regards,
 - Michael Pyne


Re: Interesting issue for kde-baseapps, Jenkins kdesrc-build, proposed solution

2013-03-12 Thread Ben Cooksley
On Wed, Mar 13, 2013 at 1:08 PM, Michael Pyne mp...@kde.org wrote:
 On Tuesday, March 12, 2013 20:38:30 Ben Cooksley wrote:
  Does anyone have objections to the sysadmins realigning the 3 git
  modules in
  question? (And if so, I'd appreciate ideas for better ways to fix).
 
  Hi,
 
  I would have no problem with moving kate.git around, splitting is IMHO
  a pain for later developing on it, as all parts are tightly coupled
  anyway.

 Please note that the actual location of kate.git (on git.kde.org) will
 not be affected in any way by this.
 It only affects the module structure.

 Given the lack of opposition I have submitted a KDE Sysadmin bug [1] to
 request the move.

 I will update dependency-data and kdesrc-build after the move is complete.
 Thanks!

This has now been completed. The dependency data and build.kde.org
have both been updated for this change.


 [1] https://bugs.kde.org/show_bug.cgi?id=316629

 Regards,
  - Michael Pyne

Regards,
Ben


Re: Interesting issue for kde-baseapps, Jenkins kdesrc-build, proposed solution

2013-03-11 Thread Christoph Cullmann
 Other alternatives include splitting kate up in the various
 library/runtime-
 support/application components but that's a lot of extra work for
 what is
 really just a kde-projects problem.
 
 Does anyone have objections to the sysadmins realigning the 3 git
 modules in
 question? (And if so, I'd appreciate ideas for better ways to fix).
Hi,

I would have no problem with moving kate.git around, splitting is IMHO
a pain for later developing on it, as all parts are tightly coupled anyway.

Greetings
Christoph

-- 
- Dr.-Ing. Christoph Cullmann -
AbsInt Angewandte Informatik GmbH  Email: cullm...@absint.com
Science Park 1 Tel:   +49-681-38360-22
66123 Saarbrücken  Fax:   +49-681-38360-20
GERMANYWWW:   http://www.AbsInt.com

Geschäftsführung: Dr.-Ing. Christian Ferdinand
Eingetragen im Handelsregister des Amtsgerichts Saarbrücken, HRB 11234


Interesting issue for kde-baseapps, Jenkins kdesrc-build, proposed solution

2013-03-10 Thread Michael Pyne
Hi all,

I would like to propose moving the kde-baseapps, kate, and konsole git modules 
to an alternative layout within the kde-projects repository, due to circular 
dependency issues.

For some background, the aforementioned modules have the following names and 
virtual layouts in kde-projects (the database):

kde-baseapps = kde/kde-baseapps
kate = kde/kde-baseapps/kate
konsole  = kde/kde-baseapps/konsole

Logically speaking, you can see that it might seem that both kate and konsole 
depend on the kde-baseapps module.

As it turns out, the opposite is true, at least for kate: kate provides the 
text/plain KPart required to exercise the test suite for konqueror in kde-
baseapps, so recently Albert Astals Cid made the proper update to the 
dependency-data information used for Jenkins on build.kde.org, to make kde-
baseapps depend on kate.

The change is actually correct, but kdesrc-build has an implicit dependency in 
the opposite direction (kate depending on kde-baseapps) since kdesrc-build 
uses the same on-disk layout as it presented in the kde-projects database [1] 
(otherwise there would likely be 100+ directories in the source directory). 
Without this implicit dependency kdesrc-build would try to run git-clone of 
kde-baseapps into a non-empty source directory (since it would already contain 
kate), which git-clone treats as a fatal error.

Even without kdesrc-build adding this dependency, it is very strange for a 
parent module to depend on its child in general.

The easiest fix, as proposed by the sysadmins is to move the affected modules 
to a different virtual layout within kde-projects. Something like:

kde-baseapps = kde/$foo/kde-baseapps
kate = kde/$foo/kate
konsole  = kde/$foo/konsole

where $foo == applications (as my proposal). This would be a new grouping 
and make it possible to fix the dependency issue cleanly, since there would 
only be sibling dependencies (which are far better IMHO than modules that are 
simultaneously git modules and logical parents of other git modules, like 
kdelibs is).

Other alternatives include splitting kate up in the various library/runtime-
support/application components but that's a lot of extra work for what is 
really just a kde-projects problem.

Does anyone have objections to the sysadmins realigning the 3 git modules in 
question? (And if so, I'd appreciate ideas for better ways to fix).

Regards,
 - Michael Pyne

[1] See kdesrc-build commit b48b7ed0db219f1d9e2b9cbb80b1be10fa238410;  
http://quickgit.kde.org/?p=kdesrc-build.gita=commith=b48b7ed0db219f1d9e2b9cbb80b1be10fa238410

signature.asc
Description: This is a digitally signed message part.