Moving KDiagram to extragear/graphics/libs (was: Re: KDiagram libs (KChart, KGantt) in KDE Review)
Hi, 2 weeks have passed, seems there are no stoppers for KDiagram to move on into extragear/graphics/libs :) So filing now a ticket to sysadmin to do the move. Thanks Albert, Aleix, Adriaan for having given KDiagram a check and (helping on) solving the issues you found (so KDiagram is Triple A rated? ;) ) Thanks also to whoever silently gave KDiagram some testing but did not report anything (hopefully a good sign). Status: * KDiagram builds on CI without warnings, all tests pass: http://build.kde.org/job/kdiagram_master_qt5/ * bugs.kde.org: added Product kdiagram, components KChart KGantt * reviewboard: kdiagram (first review request handled) * i18n.kde.org: integrated, first translations done: http://i18n.kde.org/stats/gui/trunk-kf5/po/kgantt_qt.po/ http://i18n.kde.org/stats/gui/trunk-kf5/po/kchart_qt.po/ * KMyMoney frameworks branch ported to KChart (and found first bugs :P) * Massif-Visualizer frameworks branch has review request for port to KChart (maintainer on vacation currently) * Calligra will start the Qt5/KF5 port the next days, so nothing yet to do Currently known unsolved issues (which I consider no showstoppers): * lupdate/Scripty fails on some files, but no deal right now, as no strings are in code affected. Will look into once I have more time. * code is build with different flag if unit tests are build, not perfect actually only enables unit tests embedded directly in the source files, so not changing actual library code (marked as TODO for now, no regression against currently used old snapshots of KDChart) First release: Other than initially planned I will not do an immediate release of KDiagram now, but first collect some more feedback by the projects porting to it, especially Calligra. First release will still happen before or at time the first release of any project known that ported to it of course (so tell if yours does :) ). Cheers Friedrich
Re: KDiagram libs (KChart, KGantt) in KDE Review
Am Dienstag, 17. Februar 2015, 23:07:07 schrieb Albert Astals Cid: El Diumenge, 8 de febrer de 2015, a les 00:29:26, Friedrich W. H. Kossebau va escriure: Hi, Calligra, Massif-Visualizer, KMyMoney (and perhaps more) make use of KDAB's nice offer of their KDChart in the GPLv2 licensing variant. But as there are no real public releases of KDChart, all the projects have copied a dump of KDChart into their code repositories, updating now and then to newer versions of KDChart. Which is anything but perfect. To improve things, after some talk with KDABians it was decided to create a KDE repo with a KDE-fied fork of KDChart, based on their latest Qt5ied version. So all FLOSS Qt5-based projects have a single place to-go-to for nice charting. Which would be centrally updated now and then. Still not perfect, but an improvement over the current situation. To meet the KDE repo requirements, KDAB has also extended the license to GPLv2+ for this dump :) That repo is named kdiagram and has just been moved into kdereview. Final destination is extragear/graphics, as other charting/diagram software also is located there. Scripty says (not sure if correct or not, lupdate is sometimes a bit weird) So seems lupdate complained over nested classes (e.g. A::Private) being defined without the nesting class (A) being declared before, at least all the complains where on lines after class A::B. For most of these cases I could see that nesting classes where not included before. Just, in some cases they are. Seems lupdate has problems with the macro used which declares the nested class in the nesting class (KCHART_DECLARE_PRIVATE_BASE_POLYMORPHIC). Pushed a commit fixing those cases where the include for the nesting class would have been missing. But not sure what to do about the rest. Replacing the preprocessor macro with explicit code, just to make lupdate happy? Any other, better idea? (Fix lupdate? well, out of my scope sadly) Cheers Friedrich
Re: KDiagram libs (KChart, KGantt) in KDE Review
El Diumenge, 8 de febrer de 2015, a les 00:29:26, Friedrich W. H. Kossebau va escriure: Hi, Calligra, Massif-Visualizer, KMyMoney (and perhaps more) make use of KDAB's nice offer of their KDChart in the GPLv2 licensing variant. But as there are no real public releases of KDChart, all the projects have copied a dump of KDChart into their code repositories, updating now and then to newer versions of KDChart. Which is anything but perfect. To improve things, after some talk with KDABians it was decided to create a KDE repo with a KDE-fied fork of KDChart, based on their latest Qt5ied version. So all FLOSS Qt5-based projects have a single place to-go-to for nice charting. Which would be centrally updated now and then. Still not perfect, but an improvement over the current situation. To meet the KDE repo requirements, KDAB has also extended the license to GPLv2+ for this dump :) That repo is named kdiagram and has just been moved into kdereview. Final destination is extragear/graphics, as other charting/diagram software also is located there. Scripty says (not sure if correct or not, lupdate is sometimes a bit weird) ./src/KChart /home/scripty/prod/git-unstable-kf5/kdereview_kdiagram/src/KChart/KChartAbstractCoordinatePlane_p.h:54: Ignoring definition of undeclared qualified class /home/scripty/prod/git-unstable-kf5/kdereview_kdiagram/src/KChart/Cartesian/KChartThreeDBarAttributes_p.h:45: Ignoring definition of undeclared qualified class /home/scripty/prod/git-unstable-kf5/kdereview_kdiagram/src/KChart/Cartesian/KChartLeveyJenningsDiagram_p.h:52: Ignoring definition of undeclared qualified class /home/scripty/prod/git-unstable-kf5/kdereview_kdiagram/src/KChart/Cartesian/KChartLeveyJenningsCoordinatePlane_p.h:49: Ignoring definition of undeclared qualified class /home/scripty/prod/git-unstable-kf5/kdereview_kdiagram/src/KChart/KChartAbstractThreeDAttributes_p.h:45: Ignoring definition of undeclared qualified class /home/scripty/prod/git-unstable-kf5/kdereview_kdiagram/src/KChart/KChartAbstractAxis_p.h:51: Ignoring definition of undeclared qualified class /home/scripty/prod/git-unstable-kf5/kdereview_kdiagram/src/KChart/Polar/KChartAbstractPolarDiagram_p.h:47: Ignoring definition of undeclared qualified class /home/scripty/prod/git-unstable-kf5/kdereview_kdiagram/src/KChart/Polar/KChartPieAttributes_p.h:44: Ignoring definition of undeclared qualified class /home/scripty/prod/git-unstable-kf5/kdereview_kdiagram/src/KChart/Polar/KChartAbstractPieDiagram_p.h:47: Ignoring definition of undeclared qualified class /home/scripty/prod/git-unstable-kf5/kdereview_kdiagram/src/KChart/Polar/KChartPieDiagram_p.h:44: Ignoring definition of undeclared qualified class /home/scripty/prod/git-unstable-kf5/kdereview_kdiagram/src/KChart/Polar/KChartRingDiagram_p.h:44: Ignoring definition of undeclared qualified class /home/scripty/prod/git-unstable-kf5/kdereview_kdiagram/src/KChart/Polar/KChartPolarDiagram_p.h:45: Ignoring definition of undeclared qualified class /home/scripty/prod/git-unstable-kf5/kdereview_kdiagram/src/KChart/Polar/KChartThreeDPieAttributes_p.h:44: Ignoring definition of undeclared qualified class /home/scripty/prod/git-unstable-kf5/kdereview_kdiagram/src/KChart/KChartAbstractDiagram_p.h:98: Ignoring definition of undeclared qualified class /home/scripty/prod/git-unstable-kf5/kdereview_kdiagram/src/KChart/KChartThreeDLineAttributes_p.h:44: Ignoring definition of undeclared qualified class /home/scripty/prod/git-unstable-kf5/kdereview_kdiagram/src/KChart/KChartWidget_p.h:47: Ignoring definition of undeclared qualified class /home/scripty/prod/git-unstable-kf5/kdereview_kdiagram/src/KChart/Ternary/KChartTernaryPointDiagram_p.h:43: Ignoring definition of undeclared qualified class /home/scripty/prod/git-unstable-kf5/kdereview_kdiagram/src/KChart/Ternary/KChartTernaryLineDiagram_p.h:43: Ignoring definition of undeclared qualified class /home/scripty/prod/git-unstable-kf5/kdereview_kdiagram/src/KChart/Ternary/KChartTernaryCoordinatePlane_p.h:49: Ignoring definition of undeclared qualified class /home/scripty/prod/git-unstable-kf5/kdereview_kdiagram/src/KChart/KChartAbstractCoordinatePlane_p.h:54: Ignoring definition of undeclared qualified class /home/scripty/prod/git-unstable-kf5/kdereview_kdiagram/src/KChart/Cartesian/KChartThreeDBarAttributes_p.h:45: Ignoring definition of undeclared qualified class /home/scripty/prod/git-unstable-kf5/kdereview_kdiagram/src/KChart/Cartesian/KChartLeveyJenningsDiagram_p.h:52: Ignoring definition of undeclared qualified class /home/scripty/prod/git-unstable-kf5/kdereview_kdiagram/src/KChart/Cartesian/KChartLeveyJenningsCoordinatePlane_p.h:49: Ignoring definition of undeclared qualified class /home/scripty/prod/git-unstable-kf5/kdereview_kdiagram/src/KChart/KChartAbstractThreeDAttributes_p.h:45: Ignoring definition of undeclared qualified class /home/scripty/prod/git-unstable-kf5/kdereview_kdiagram/src/KChart/KChartAbstractAxis_p.h:51:
Re: KDiagram libs (KChart, KGantt) in KDE Review
Am Mittwoch, 11. Februar 2015, 16:30:39 schrieb Andreas Hartmetz: On Wednesday 11 February 2015 14:59:50 Adriaan de Groot wrote: On Monday 09 February 2015 01:50:03 Friedrich W. H. Kossebau wrote: Yes, nearly copypaste: the copies of KDChart in Calligra KMyMoney are older (2.4.1, based on Qt4) versions, while the copy of KDChart in Massif-Visualizer matches the version of the KChart lib in KDiagram. I've tried compiling the code on FreeBSD 10.1-RELEASE with Clang 3.4.1 (I'm assuming that's a supported compiler -- on techbase, searching for supported compiler doesn't give me much compatibility information newer than KDE 4.2). - I need to add /usr/local/include to the include search path; this is not kdiagram specific, but seems to be a general Qt5 issue on FreeBSD. - TestDrawIntoPainter seems to hang; after 2 min at 100% CPU I killed it. I ran it separately by hand and get output about missing OpenGL drivers (which is true, I'm building kdiagram in a restricted environment; I didn't originally expect to need to have DBUS running to be able to do the tests either) and debug output like: QDEBUG : TestDrawIntoPainter::testTest() Time for drawing pixmap : :/test: 53682 ms : Is that test supposed to take so much longer (minutes) than the other tests (deciseconds)? I guess so. The test is commented out in the .pro file in the KDAB version - the reason is probably that it takes so long. Yes, this test is also aborted on CI, see http://build.kde.org/job/kdiagram_master_qt5/lastCompletedBuild/testReport/ And locally also ran forever=until I cancelled. Will disable then as well in KDiagram. And perhaps investigate for a possible error in the code, if I feel more curious later :) So from a it-compiles-and-the-tests-pass point of view on my platform, it looks good. Thanks again for that testing, Ade, should have helped by that one fix for clean builds with clang in general :) Cheers Friedrich
Re: KDiagram libs (KChart, KGantt) in KDE Review
tcanabra:/data/ $ git clone kde:diagram [13:41:14] Cloning into 'diagram'... fatal: remote error: access denied or repository not exported: /diagram Is this expected?
Re: KDiagram libs (KChart, KGantt) in KDE Review
On Thu, Feb 12, 2015 at 1:52 PM, Tomaz Canabrava tcanabr...@kde.org wrote: tcanabra:/data/ $ git clone kde:diagram [13:41:14] ugh - just realized I forgot a 'k' Cloning into 'diagram'... fatal: remote error: access denied or repository not exported: /diagram Is this expected?
Re: KDiagram libs (KChart, KGantt) in KDE Review
On Monday 09 February 2015 01:50:03 Friedrich W. H. Kossebau wrote: Yes, nearly copypaste: the copies of KDChart in Calligra KMyMoney are older (2.4.1, based on Qt4) versions, while the copy of KDChart in Massif-Visualizer matches the version of the KChart lib in KDiagram. I've tried compiling the code on FreeBSD 10.1-RELEASE with Clang 3.4.1 (I'm assuming that's a supported compiler -- on techbase, searching for supported compiler doesn't give me much compatibility information newer than KDE 4.2). - I need to add /usr/local/include to the include search path; this is not kdiagram specific, but seems to be a general Qt5 issue on FreeBSD. - TestDrawIntoPainter seems to hang; after 2 min at 100% CPU I killed it. I ran it separately by hand and get output about missing OpenGL drivers (which is true, I'm building kdiagram in a restricted environment; I didn't originally expect to need to have DBUS running to be able to do the tests either) and debug output like: QDEBUG : TestDrawIntoPainter::testTest() Time for drawing pixmap :/test: 53682 ms Is that test supposed to take so much longer (minutes) than the other tests (deciseconds)? So from a it-compiles-and-the-tests-pass point of view on my platform, it looks good. [ade]
Re: KDiagram libs (KChart, KGantt) in KDE Review
On Wednesday 11 February 2015 14:59:50 Adriaan de Groot wrote: On Monday 09 February 2015 01:50:03 Friedrich W. H. Kossebau wrote: Yes, nearly copypaste: the copies of KDChart in Calligra KMyMoney are older (2.4.1, based on Qt4) versions, while the copy of KDChart in Massif-Visualizer matches the version of the KChart lib in KDiagram. I've tried compiling the code on FreeBSD 10.1-RELEASE with Clang 3.4.1 (I'm assuming that's a supported compiler -- on techbase, searching for supported compiler doesn't give me much compatibility information newer than KDE 4.2). - I need to add /usr/local/include to the include search path; this is not kdiagram specific, but seems to be a general Qt5 issue on FreeBSD. - TestDrawIntoPainter seems to hang; after 2 min at 100% CPU I killed it. I ran it separately by hand and get output about missing OpenGL drivers (which is true, I'm building kdiagram in a restricted environment; I didn't originally expect to need to have DBUS running to be able to do the tests either) and debug output like: QDEBUG : TestDrawIntoPainter::testTest() Time for drawing pixmap :/test: 53682 ms Is that test supposed to take so much longer (minutes) than the other tests (deciseconds)? I guess so. The test is commented out in the .pro file in the KDAB version - the reason is probably that it takes so long. So from a it-compiles-and-the-tests-pass point of view on my platform, it looks good. [ade]
Re: KDiagram libs (KChart, KGantt) in KDE Review
Am Montag, 9. Februar 2015, 04:09:59 schrieb Aleix Pol: Hi, I just went through the cmake code. Thanks, Aleix. Let's see: - I see this, what does need to be fixed? # TODO: fix ecm_generate_headers to support camelcase .h files See https://git.reviewboard.kde.org/r/122317/ , and for related discussion also https://git.reviewboard.kde.org/r/122193 By current feddback in the other RR 122317 seems okay principally, just noone has yet ship-it-ed. Looking forward to someone doing so, so KDiagram can soon make use of the macro also for KChart (yes, could have also worked-around by lowercasing all filenames in the sources, but did not want to change even more things than just the namespace). - Library targets are usually called KF5*, see KF5Parts or KF5Gantt Even if not part of KF5 itself? So should any libraries in KDE repos prefix their targets like that, because the related ECM macros are used? I would rather think KF5 prefix should be reserved to libs from KF5, but if what you propose is already standard, I will follow. - Is this really needed? add_definitions(-DKDAB_NO_UNIT_TESTS). It's not very good to compile differently things if there's unit tests and not. Not perfect, agreed. Okay if I add a TODO for now? (given this is also in existing released code, and fixing might need some discussions) - some of the definitions in the root CMakeLists.txt files are already being defined by KDEFrameworkCompilerSettings. You might want to clean them up. Fixed, - misses a .reviewboardrc file. Fixed. I created a small review request you also want to look into: https://git.reviewboard.kde.org/r/122495/ Thanks for that, going to comment on tonight. Cheers Friedrich
Re: KDiagram libs (KChart, KGantt) in KDE Review
On Mon, Feb 9, 2015 at 11:35 AM, Inge Wallin i...@lysator.liu.se wrote: On Monday, February 09, 2015 04:09:59 Aleix Pol wrote: On Mon, Feb 9, 2015 at 1:50 AM, Friedrich W. H. Kossebau kosse...@kde.org wrote: Am Montag, 9. Februar 2015, 00:23:58 schrieb Albert Astals Cid: El Diumenge, 8 de febrer de 2015, a les 00:29:26, Friedrich W. H. Kossebau va escriure: Hi, Calligra, Massif-Visualizer, KMyMoney (and perhaps more) make use of KDAB's nice offer of their KDChart in the GPLv2 licensing variant. But as there are no real public releases of KDChart, all the projects have copied a dump of KDChart into their code repositories, updating now and then to newer versions of KDChart. Which is anything but perfect. To improve things, after some talk with KDABians it was decided to create a KDE repo with a KDE-fied fork of KDChart, based on their latest Qt5ied version. So all FLOSS Qt5-based projects have a single place to-go-to for nice charting. Which would be centrally updated now and then. Still not perfect, but an improvement over the current situation. To meet the KDE repo requirements, KDAB has also extended the license to GPLv2+ for this dump :) Thanks KDABians for this. If this is basically a copypaste from the existing code we're already shipping i have no objection, Yes, nearly copypaste: the copies of KDChart in Calligra KMyMoney are older (2.4.1, based on Qt4) versions, while the copy of KDChart in Massif-Visualizer matches the version of the KChart lib in KDiagram. though you should probably get someone with CMake knowledge to review (and kill that autogen.py and g++.pri?) Yes, any volunteers here for reviewing the CMake parts? :) Code should be similar to that of a KF5 tier1 lib. Cheers Friedrich Hi, I just went through the cmake code. Let's see: - I see this, what does need to be fixed? # TODO: fix ecm_generate_headers to support camelcase .h files - Library targets are usually called KF5*, see KF5Parts or KF5Gantt KDiagram is not a framework and cannot become one until the library is release under the LGPL license (right?). So a name starting with KF5 sounds strange to me at this point. - Is this really needed? add_definitions(-DKDAB_NO_UNIT_TESTS). It's not very good to compile differently things if there's unit tests and not. - some of the definitions in the root CMakeLists.txt files are already being defined by KDEFrameworkCompilerSettings. You might want to clean them up. - misses a .reviewboardrc file. I created a small review request you also want to look into: https://git.reviewboard.kde.org/r/122495/ Aleix Correct, my apologies, I was thinking it might become a framework. Aleix
Re: KDiagram libs (KChart, KGantt) in KDE Review
On Monday, February 09, 2015 04:09:59 Aleix Pol wrote: On Mon, Feb 9, 2015 at 1:50 AM, Friedrich W. H. Kossebau kosse...@kde.org wrote: Am Montag, 9. Februar 2015, 00:23:58 schrieb Albert Astals Cid: El Diumenge, 8 de febrer de 2015, a les 00:29:26, Friedrich W. H. Kossebau va escriure: Hi, Calligra, Massif-Visualizer, KMyMoney (and perhaps more) make use of KDAB's nice offer of their KDChart in the GPLv2 licensing variant. But as there are no real public releases of KDChart, all the projects have copied a dump of KDChart into their code repositories, updating now and then to newer versions of KDChart. Which is anything but perfect. To improve things, after some talk with KDABians it was decided to create a KDE repo with a KDE-fied fork of KDChart, based on their latest Qt5ied version. So all FLOSS Qt5-based projects have a single place to-go-to for nice charting. Which would be centrally updated now and then. Still not perfect, but an improvement over the current situation. To meet the KDE repo requirements, KDAB has also extended the license to GPLv2+ for this dump :) Thanks KDABians for this. If this is basically a copypaste from the existing code we're already shipping i have no objection, Yes, nearly copypaste: the copies of KDChart in Calligra KMyMoney are older (2.4.1, based on Qt4) versions, while the copy of KDChart in Massif-Visualizer matches the version of the KChart lib in KDiagram. though you should probably get someone with CMake knowledge to review (and kill that autogen.py and g++.pri?) Yes, any volunteers here for reviewing the CMake parts? :) Code should be similar to that of a KF5 tier1 lib. Cheers Friedrich Hi, I just went through the cmake code. Let's see: - I see this, what does need to be fixed? # TODO: fix ecm_generate_headers to support camelcase .h files - Library targets are usually called KF5*, see KF5Parts or KF5Gantt KDiagram is not a framework and cannot become one until the library is release under the LGPL license (right?). So a name starting with KF5 sounds strange to me at this point. - Is this really needed? add_definitions(-DKDAB_NO_UNIT_TESTS). It's not very good to compile differently things if there's unit tests and not. - some of the definitions in the root CMakeLists.txt files are already being defined by KDEFrameworkCompilerSettings. You might want to clean them up. - misses a .reviewboardrc file. I created a small review request you also want to look into: https://git.reviewboard.kde.org/r/122495/ Aleix
Re: KDiagram libs (KChart, KGantt) in KDE Review
Am Montag, 9. Februar 2015, 00:23:58 schrieb Albert Astals Cid: El Diumenge, 8 de febrer de 2015, a les 00:29:26, Friedrich W. H. Kossebau va escriure: Hi, Calligra, Massif-Visualizer, KMyMoney (and perhaps more) make use of KDAB's nice offer of their KDChart in the GPLv2 licensing variant. But as there are no real public releases of KDChart, all the projects have copied a dump of KDChart into their code repositories, updating now and then to newer versions of KDChart. Which is anything but perfect. To improve things, after some talk with KDABians it was decided to create a KDE repo with a KDE-fied fork of KDChart, based on their latest Qt5ied version. So all FLOSS Qt5-based projects have a single place to-go-to for nice charting. Which would be centrally updated now and then. Still not perfect, but an improvement over the current situation. To meet the KDE repo requirements, KDAB has also extended the license to GPLv2+ for this dump :) Thanks KDABians for this. If this is basically a copypaste from the existing code we're already shipping i have no objection, Yes, nearly copypaste: the copies of KDChart in Calligra KMyMoney are older (2.4.1, based on Qt4) versions, while the copy of KDChart in Massif-Visualizer matches the version of the KChart lib in KDiagram. though you should probably get someone with CMake knowledge to review (and kill that autogen.py and g++.pri?) Yes, any volunteers here for reviewing the CMake parts? :) Code should be similar to that of a KF5 tier1 lib. Cheers Friedrich
Re: KDiagram libs (KChart, KGantt) in KDE Review
On Mon, Feb 9, 2015 at 1:50 AM, Friedrich W. H. Kossebau kosse...@kde.org wrote: Am Montag, 9. Februar 2015, 00:23:58 schrieb Albert Astals Cid: El Diumenge, 8 de febrer de 2015, a les 00:29:26, Friedrich W. H. Kossebau va escriure: Hi, Calligra, Massif-Visualizer, KMyMoney (and perhaps more) make use of KDAB's nice offer of their KDChart in the GPLv2 licensing variant. But as there are no real public releases of KDChart, all the projects have copied a dump of KDChart into their code repositories, updating now and then to newer versions of KDChart. Which is anything but perfect. To improve things, after some talk with KDABians it was decided to create a KDE repo with a KDE-fied fork of KDChart, based on their latest Qt5ied version. So all FLOSS Qt5-based projects have a single place to-go-to for nice charting. Which would be centrally updated now and then. Still not perfect, but an improvement over the current situation. To meet the KDE repo requirements, KDAB has also extended the license to GPLv2+ for this dump :) Thanks KDABians for this. If this is basically a copypaste from the existing code we're already shipping i have no objection, Yes, nearly copypaste: the copies of KDChart in Calligra KMyMoney are older (2.4.1, based on Qt4) versions, while the copy of KDChart in Massif-Visualizer matches the version of the KChart lib in KDiagram. though you should probably get someone with CMake knowledge to review (and kill that autogen.py and g++.pri?) Yes, any volunteers here for reviewing the CMake parts? :) Code should be similar to that of a KF5 tier1 lib. Cheers Friedrich Hi, I just went through the cmake code. Let's see: - I see this, what does need to be fixed? # TODO: fix ecm_generate_headers to support camelcase .h files - Library targets are usually called KF5*, see KF5Parts or KF5Gantt - Is this really needed? add_definitions(-DKDAB_NO_UNIT_TESTS). It's not very good to compile differently things if there's unit tests and not. - some of the definitions in the root CMakeLists.txt files are already being defined by KDEFrameworkCompilerSettings. You might want to clean them up. - misses a .reviewboardrc file. I created a small review request you also want to look into: https://git.reviewboard.kde.org/r/122495/ Aleix
Re: KDiagram libs (KChart, KGantt) in KDE Review
El Diumenge, 8 de febrer de 2015, a les 00:29:26, Friedrich W. H. Kossebau va escriure: Hi, Calligra, Massif-Visualizer, KMyMoney (and perhaps more) make use of KDAB's nice offer of their KDChart in the GPLv2 licensing variant. But as there are no real public releases of KDChart, all the projects have copied a dump of KDChart into their code repositories, updating now and then to newer versions of KDChart. Which is anything but perfect. To improve things, after some talk with KDABians it was decided to create a KDE repo with a KDE-fied fork of KDChart, based on their latest Qt5ied version. So all FLOSS Qt5-based projects have a single place to-go-to for nice charting. Which would be centrally updated now and then. Still not perfect, but an improvement over the current situation. To meet the KDE repo requirements, KDAB has also extended the license to GPLv2+ for this dump :) Thanks KDABians for this. If this is basically a copypaste from the existing code we're already shipping i have no objection, though you should probably get someone with CMake knowledge to review (and kill that autogen.py and g++.pri?) Cheers, Albert That repo is named kdiagram and has just been moved into kdereview. Final destination is extragear/graphics, as other charting/diagram software also is located there. After the initial code dump in the repo, work has been done to convert the buildsystem from qmake to cmake/ECM and KDE-fy the code in general. But no real changes besides renaming/rebranding have been done to the codebase, so this should be quickly usable by all FLOSS programs with their own copy of KDChart so far, and just need a few s/KDChart/KChart/ etc. for adaption. KDChart actually consists of two libraries, kdchart and kdgantt, which have been made explicitly separate libs in KDiagram, and named kchart and kgantt there (and thus the repo kdiagram instead of kchart, to not hide the gantt lib). Not yet clear if those libs would be merged more one day, so for now staying with a single repo, like the original, instead of splitting up into two repos by the two libs. Ideally a first release of kdiagram (libs kchart, kgantt) is done before the porting work of Calligra to Qt5 starts somewhen end of February, so that port can rely on the then external libs from the start. For that the schedule now is: tagging first release: February 16th moving to Extragear/Graphics: February 22th release first release: February 22th Please do a git clone kde:kdiagram and give the libs some build testing (also go for all the compiled example and test apps) and review, especially the buildsystem. And perhaps prepare your FLOSS apps to use it already. This should give you KChart resp. KGantt in your CMakeLists.txt file: find_package(KChart 2.6.0 REQUIRED) target_link_libraries(myflossapp KChart) find_package(KGantt 2.6.0 REQUIRED) target_link_libraries(myflossapp KGantt) Cheers Friedrich
KDiagram libs (KChart, KGantt) in KDE Review
Hi, Calligra, Massif-Visualizer, KMyMoney (and perhaps more) make use of KDAB's nice offer of their KDChart in the GPLv2 licensing variant. But as there are no real public releases of KDChart, all the projects have copied a dump of KDChart into their code repositories, updating now and then to newer versions of KDChart. Which is anything but perfect. To improve things, after some talk with KDABians it was decided to create a KDE repo with a KDE-fied fork of KDChart, based on their latest Qt5ied version. So all FLOSS Qt5-based projects have a single place to-go-to for nice charting. Which would be centrally updated now and then. Still not perfect, but an improvement over the current situation. To meet the KDE repo requirements, KDAB has also extended the license to GPLv2+ for this dump :) That repo is named kdiagram and has just been moved into kdereview. Final destination is extragear/graphics, as other charting/diagram software also is located there. After the initial code dump in the repo, work has been done to convert the buildsystem from qmake to cmake/ECM and KDE-fy the code in general. But no real changes besides renaming/rebranding have been done to the codebase, so this should be quickly usable by all FLOSS programs with their own copy of KDChart so far, and just need a few s/KDChart/KChart/ etc. for adaption. KDChart actually consists of two libraries, kdchart and kdgantt, which have been made explicitly separate libs in KDiagram, and named kchart and kgantt there (and thus the repo kdiagram instead of kchart, to not hide the gantt lib). Not yet clear if those libs would be merged more one day, so for now staying with a single repo, like the original, instead of splitting up into two repos by the two libs. Ideally a first release of kdiagram (libs kchart, kgantt) is done before the porting work of Calligra to Qt5 starts somewhen end of February, so that port can rely on the then external libs from the start. For that the schedule now is: tagging first release: February 16th moving to Extragear/Graphics: February 22th release first release: February 22th Please do a git clone kde:kdiagram and give the libs some build testing (also go for all the compiled example and test apps) and review, especially the buildsystem. And perhaps prepare your FLOSS apps to use it already. This should give you KChart resp. KGantt in your CMakeLists.txt file: find_package(KChart 2.6.0 REQUIRED) target_link_libraries(myflossapp KChart) find_package(KGantt 2.6.0 REQUIRED) target_link_libraries(myflossapp KGantt) Cheers Friedrich
