Moving KMarkdownWebView to extragear/utils (was: Re: KMarkdownWebView (kpart) in KDE Review)
Hi, Am Dienstag, 22. August 2017, 00:18:19 CEST schrieb Friedrich W. H. Kossebau: > KMarkdownWebView today entered KDE Review. This repo contains a kpart for > rendered display of Markdown files, using web technologies (webpage with > JavaScript library which creates HTML from the plaintext handed in). Thanks Elvis, Albert, Allen for your replies, also anyone who gave feedback on irc (and those possibly who tested and stayed silent as no issues were hit). So 14 days will have passed upcoming Tuesday, and seems no showstoppers are left for leaving kdereview to become a "normal" repo. Besides the fixing commits for the things commented on no other bigger changes happened since it entered kdereview, cmp. https://cgit.kde.org/ kmarkdownwebview.git/log/ , but you might want to give it a final check. > I consider it rather a hack and would favour something done natively in Qt > (e.g. like the Markdown Okular generator in https://phabricator.kde.org/ > D7382). But for now it serves the use-case of providing a webpage-like > rendered display of markdown documents. Especially for the live preview > plugin for Kate & KDevelop currently worked on*. > > * https://frinring.wordpress.com/2017/08/21/look-what-you-have-donewwdo > > See also https://cgit.kde.org/kmarkdownwebview.git/about/ > > The separate library libKMarkdownWebView is done for sharing code with a > thumbnailer plugin, whose code yet is to be committed to this repo, as it > resists to work right now. > > Initial build on CI looks good: > https://build.kde.org/job/Extragear%20kmarkdownwebview%20kf5-qt5%20SUSEQt5.9 > / > https://build.kde.org/job/Extragear%20kmarkdownwebview%20kf5-qt5%20FreeBSDQ > t5.7/ > > Target would be extragear/$SOMETHING, with $SOMETHING possibly "utils". So unless anyone objects, I will ask to have the repo in extragear, in repo hierarchy path extragear/utils. Once it's moved and I pinged the translators, a week later should see first release then. Cheers Friedrich
Re: KMarkdownWebView (kpart) in KDE Review
Hi Elvis, (seems my reply I started last week was somehow lost, pardon for late reply) Am Dienstag, 22. August 2017, 11:31:00 CEST schrieb Elvis Angelaccio: > On martedì 22 agosto 2017 00:18:19 CEST, Friedrich W. H. Kossebau wrote: > > Hi, > > > > KMarkdownWebView today entered KDE Review. This repo contains a kpart for > > rendered display of Markdown files, using web technologies (webpage with > > JavaScript library which creates HTML from the plaintext handed in). > > > > I consider it rather a hack and would favour something done natively in Qt > > (e.g. like the Markdown Okular generator in https://phabricator.kde.org/ > > D7382). But for now it serves the use-case of providing a webpage-like > > rendered display of markdown documents. Especially for the live preview > > plugin for Kate & KDevelop currently worked on*. > > > > * https://frinring.wordpress.com/2017/08/21/look-what-you-have-donewwdo > > > > See also https://cgit.kde.org/kmarkdownwebview.git/about/ > > > > The separate library libKMarkdownWebView is done for sharing code with a > > thumbnailer plugin, whose code yet is to be committed to this repo, as it > > resists to work right now. > > > > Initial build on CI looks good: > > https://build.kde.org/job/Extragear%20kmarkdownwebview%20kf5-qt5%20SUSEQt5 > > .9/ > > https://build.kde.org/job/Extragear%20kmarkdownwebview%20kf5-qt5%20FreeBS > > DQt5.7/ > > > > And people on #kde-devel & #kdevelop also reported successful builds and > > usage. > > > > > > Target would be extragear/$SOMETHING, with $SOMETHING possibly "utils". > > > > Initial release planned right after leaving kdereview. > > > > Question: is there any appstream metadata possible for plugins? > > Yes, have a look at kio-gdrive or kio-stash as example. Took that as template, thanks for pointer. > From a quick look, everything works fine. > > One minor issue I spotted: if I preview a markdown file in some archive, > the ark preview window has a menu named "No text" instead of "Edit" (with > the "Select All" action). This could be fixed by adding the > Edit element in kmarkdownwebviewpartui.rc (not sure if > there is another fix). Perhaps the Ark preview window does not load the std xmlgui config, so those toplevel menu entry names are missing? I remember I have seen that also with other parts. Fixed for now by the workaround you proposed, an explicit Edit. Cheers Friedrich
Re: KMarkdownWebView (kpart) in KDE Review
On martedì 22 agosto 2017 00:18:19 CEST, Friedrich W. H. Kossebau wrote: Hi, KMarkdownWebView today entered KDE Review. This repo contains a kpart for rendered display of Markdown files, using web technologies (webpage with JavaScript library which creates HTML from the plaintext handed in). I consider it rather a hack and would favour something done natively in Qt (e.g. like the Markdown Okular generator in https://phabricator.kde.org/ D7382). But for now it serves the use-case of providing a webpage-like rendered display of markdown documents. Especially for the live preview plugin for Kate & KDevelop currently worked on*. * https://frinring.wordpress.com/2017/08/21/look-what-you-have-donewwdo See also https://cgit.kde.org/kmarkdownwebview.git/about/ The separate library libKMarkdownWebView is done for sharing code with a thumbnailer plugin, whose code yet is to be committed to this repo, as it resists to work right now. Initial build on CI looks good: https://build.kde.org/job/Extragear%20kmarkdownwebview%20kf5-qt5%20SUSEQt5.9/ https://build.kde.org/job/Extragear%20kmarkdownwebview%20kf5-qt5%20FreeBSDQt5.7/ And people on #kde-devel & #kdevelop also reported successful builds and usage. Target would be extragear/$SOMETHING, with $SOMETHING possibly "utils". Initial release planned right after leaving kdereview. Question: is there any appstream metadata possible for plugins? Yes, have a look at kio-gdrive or kio-stash as example. From a quick look, everything works fine. One minor issue I spotted: if I preview a markdown file in some archive, the ark preview window has a menu named "No text" instead of "Edit" (with the "Select All" action). This could be fixed by adding the Edit element in kmarkdownwebviewpartui.rc (not sure if there is another fix). Cheers Friedrich Cheers, Elvis
Re: KMarkdownWebView (kpart) in KDE Review
Am Dienstag, 22. August 2017, 23:38:06 CEST schrieb Friedrich W. H. Kossebau: > Am Dienstag, 22. August 2017, 22:41:28 CEST schrieb Albert Astals Cid: > > You don't have a Messages.sh > > Thanks for taking a look, though... there is one, in src/: > https://cgit.kde.org/kmarkdownwebview.git/tree/src/Message.sh Seems I am blind to some trailing "s" :) My bad, fixed. Cheers Friedrich
Re: KMarkdownWebView (kpart) in KDE Review
Am Dienstag, 22. August 2017, 23:09:18 CEST schrieb Allen Winter: > One Krazy issue about making an explicit ctor, see > http://ebn.kde.org/krazy/reports/kdereview/kmarkdownwebview/src/index.html Fixed. > I ran clazy too and it found no issues. Happy to read. Thanks for having had a look, Allen :) Cheers Friedrich
Re: KMarkdownWebView (kpart) in KDE Review
Am Dienstag, 22. August 2017, 22:41:28 CEST schrieb Albert Astals Cid: > You don't have a Messages.sh Thanks for taking a look, though... there is one, in src/: https://cgit.kde.org/kmarkdownwebview.git/tree/src/Message.sh Placement missing to follow some pattern? For completeness I just pushed added extraction from rc file, though the current one has no strings. But a wrong domain still, and will not hurt to be prepared for possibly future additions there. Cheers Friedrich
Re: KMarkdownWebView (kpart) in KDE Review
One Krazy issue about making an explicit ctor, see http://ebn.kde.org/krazy/reports/kdereview/kmarkdownwebview/src/index.html I ran clazy too and it found no issues. On Monday, August 21, 2017 6:18:19 PM EDT Friedrich W. H. Kossebau wrote: > Hi, > > KMarkdownWebView today entered KDE Review. This repo contains a kpart for > rendered display of Markdown files, using web technologies (webpage with > JavaScript library which creates HTML from the plaintext handed in). > > I consider it rather a hack and would favour something done natively in Qt > (e.g. like the Markdown Okular generator in https://phabricator.kde.org/ > D7382). But for now it serves the use-case of providing a webpage-like > rendered display of markdown documents. Especially for the live preview > plugin for Kate & KDevelop currently worked on*. > > * https://frinring.wordpress.com/2017/08/21/look-what-you-have-donewwdo > > See also https://cgit.kde.org/kmarkdownwebview.git/about/ > > The separate library libKMarkdownWebView is done for sharing code with a > thumbnailer plugin, whose code yet is to be committed to this repo, as it > resists to work right now. > > Initial build on CI looks good: > https://build.kde.org/job/Extragear%20kmarkdownwebview%20kf5-qt5%20SUSEQt5.9/ > https://build.kde.org/job/Extragear%20kmarkdownwebview%20kf5-qt5%20FreeBSDQt5.7/ > > And people on #kde-devel & #kdevelop also reported successful builds and > usage. > > > Target would be extragear/$SOMETHING, with $SOMETHING possibly "utils". > > Initial release planned right after leaving kdereview. > > Question: is there any appstream metadata possible for plugins? > > Cheers > Friedrich >
Re: KMarkdownWebView (kpart) in KDE Review
El dimarts, 22 d’agost de 2017, a les 0:18:19 CEST, Friedrich W. H. Kossebau va escriure: > Hi, > > KMarkdownWebView today entered KDE Review. This repo contains a kpart for > rendered display of Markdown files, using web technologies (webpage with > JavaScript library which creates HTML from the plaintext handed in). > > I consider it rather a hack and would favour something done natively in Qt > (e.g. like the Markdown Okular generator in https://phabricator.kde.org/ > D7382). But for now it serves the use-case of providing a webpage-like > rendered display of markdown documents. Especially for the live preview > plugin for Kate & KDevelop currently worked on*. > > * https://frinring.wordpress.com/2017/08/21/look-what-you-have-donewwdo > > See also https://cgit.kde.org/kmarkdownwebview.git/about/ > > The separate library libKMarkdownWebView is done for sharing code with a > thumbnailer plugin, whose code yet is to be committed to this repo, as it > resists to work right now. > > Initial build on CI looks good: > https://build.kde.org/job/Extragear%20kmarkdownwebview%20kf5-qt5%20SUSEQt5.9 > / > https://build.kde.org/job/Extragear%20kmarkdownwebview%20kf5-qt5%20FreeBSDQ > t5.7/ > > And people on #kde-devel & #kdevelop also reported successful builds and > usage. > > > Target would be extragear/$SOMETHING, with $SOMETHING possibly "utils". > > Initial release planned right after leaving kdereview. You don't have a Messages.sh Cheers, Albert > > Question: is there any appstream metadata possible for plugins? > > Cheers > Friedrich
KMarkdownWebView (kpart) in KDE Review
Hi, KMarkdownWebView today entered KDE Review. This repo contains a kpart for rendered display of Markdown files, using web technologies (webpage with JavaScript library which creates HTML from the plaintext handed in). I consider it rather a hack and would favour something done natively in Qt (e.g. like the Markdown Okular generator in https://phabricator.kde.org/ D7382). But for now it serves the use-case of providing a webpage-like rendered display of markdown documents. Especially for the live preview plugin for Kate & KDevelop currently worked on*. * https://frinring.wordpress.com/2017/08/21/look-what-you-have-donewwdo See also https://cgit.kde.org/kmarkdownwebview.git/about/ The separate library libKMarkdownWebView is done for sharing code with a thumbnailer plugin, whose code yet is to be committed to this repo, as it resists to work right now. Initial build on CI looks good: https://build.kde.org/job/Extragear%20kmarkdownwebview%20kf5-qt5%20SUSEQt5.9/ https://build.kde.org/job/Extragear%20kmarkdownwebview%20kf5-qt5%20FreeBSDQt5.7/ And people on #kde-devel & #kdevelop also reported successful builds and usage. Target would be extragear/$SOMETHING, with $SOMETHING possibly "utils". Initial release planned right after leaving kdereview. Question: is there any appstream metadata possible for plugins? Cheers Friedrich
