Re: Plasma Remote Controllers in KDE Review

2022-08-29 Thread Alexander Volkov

Hi,

Whether it can be used for mapping extra mouse buttons?
https://bugs.kde.org/show_bug.cgi?id=171295

Probably the name "remote controllers" is not perfect for this project...

26.08.2022 13:21, Aditya Mehra пишет:

Hi,

Plasma remote controllers is in KDE Review and would like to release 
it along with Plasma Bigscreen


Plasma remote controllers allows translating various input device 
events into keyboard and pointer events send from remote control type 
devices like CEC and Gamepads to provide key navigation support in 
applications. It also allows re mapping of keys to specific events.


You can find the repository here: 
https://invent.kde.org/plasma-bigscreen/plasma-remotecontrollers


Request to please review Plasma remote controllers.

Regards,
Aditya


Re: Plasma Remote Controllers in KDE Review

2022-08-26 Thread Albert Astals Cid
El divendres, 26 d’agost de 2022, a les 12:21:40 (CEST), Aditya Mehra va 
escriure:
> Hi,
> 
> Plasma remote controllers is in KDE Review and would like to release it
> along with Plasma Bigscreen
> 
> Plasma remote controllers allows translating various input device events
> into keyboard and pointer events send from remote control type devices like
> CEC and Gamepads to provide key navigation support in applications. It also
> allows re mapping of keys to specific events.
> 
> You can find the repository here:
> https://invent.kde.org/plasma-bigscreen/plasma-remotecontrollers
> 
> Request to please review Plasma remote controllers.

There's a few "can be marked override" that i think that you should.

You need to call KLocalizedString::setApplicationDomain in the main of the 
app.

Cheers,
  Albert

> 
> Regards,
> Aditya






Re: Plasma Remote Controllers in KDE Review

2022-08-26 Thread Aditya Mehra
Hi,

Thanks for the review, I have fixed most of the issues mentioned in this list. 
Please review again.

Regards,
Aditya

From: Harald Sitter 
Sent: Friday, August 26, 2022 10:43 PM
To: Aditya Mehra 
Cc: kde-core-devel 
Subject: Re: Plasma Remote Controllers in KDE Review

- src dir is missing i18n setup (messages.sh and define in cmakelists)
- not reuse covered
- metainfo.xml missing (appstream)
- doesn't have gitlab ci builds apparently?
- doesn't have bugzilla product
- clazy is not happy

On Fri, Aug 26, 2022 at 12:21 PM Aditya Mehra  wrote:
>
> Hi,
>
> Plasma remote controllers is in KDE Review and would like to release it along 
> with Plasma Bigscreen
>
> Plasma remote controllers allows translating various input device events into 
> keyboard and pointer events send from remote control type devices like CEC 
> and Gamepads to provide key navigation support in applications. It also 
> allows re mapping of keys to specific events.
>
> You can find the repository here: 
> https://invent.kde.org/plasma-bigscreen/plasma-remotecontrollers
>
> Request to please review Plasma remote controllers.
>
> Regards,
> Aditya


Re: Plasma Remote Controllers in KDE Review

2022-08-26 Thread Harald Sitter
- src dir is missing i18n setup (messages.sh and define in cmakelists)
- not reuse covered
- metainfo.xml missing (appstream)
- doesn't have gitlab ci builds apparently?
- doesn't have bugzilla product
- clazy is not happy

On Fri, Aug 26, 2022 at 12:21 PM Aditya Mehra  wrote:
>
> Hi,
>
> Plasma remote controllers is in KDE Review and would like to release it along 
> with Plasma Bigscreen
>
> Plasma remote controllers allows translating various input device events into 
> keyboard and pointer events send from remote control type devices like CEC 
> and Gamepads to provide key navigation support in applications. It also 
> allows re mapping of keys to specific events.
>
> You can find the repository here: 
> https://invent.kde.org/plasma-bigscreen/plasma-remotecontrollers
>
> Request to please review Plasma remote controllers.
>
> Regards,
> Aditya


Plasma Remote Controllers in KDE Review

2022-08-26 Thread Aditya Mehra
Hi,

Plasma remote controllers is in KDE Review and would like to release it along 
with Plasma Bigscreen

Plasma remote controllers allows translating various input device events into 
keyboard and pointer events send from remote control type devices like CEC and 
Gamepads to provide key navigation support in applications. It also allows re 
mapping of keys to specific events.

You can find the repository here: 
https://invent.kde.org/plasma-bigscreen/plasma-remotecontrollers

Request to please review Plasma remote controllers.

Regards,
Aditya