Re: Qt5PatchCollection versions (broken QWE)
El dijous, 27 de maig de 2021, a les 6:10:47 (CEST), Harald Sitter va escriure: > On Wed, May 26, 2021 at 7:39 PM Antonio Rojas wrote: > > > > El miércoles, 26 de mayo de 2021 13:19:34 (CEST), Harald Sitter escribió: > > > Hola > > > > > > QWE and QtScript in our kde/5.15 branches currently have unaligned > > > versions. > > > > > > QWE 5.15.4: > > > https://invent.kde.org/qt/qt/qtwebengine/-/blob/kde/5.15/.qmake.conf > > > > > > QtBase 5.15.3: > > > https://invent.kde.org/qt/qt/qtbase/-/blob/kde/5.15/.qmake.conf > > > > > > This then breaks version alignment expectations. For example QWECore > > > requires QtWebChannel at the same version but since the versions are > > > misaligned the requirement check changes. > > > > This is because the upstream QWE and QtScripts 5.15 branches are public, > > unlike the other Qt repos. The versioning issue is discussed here: > > > > https://www.qt.io/blog/building-qt-webengine-against-other-qt-versions > > > > Lowering the version number would be misleading since this is the real, > > upstream 5.15 code, which is post-5.15.4 already. > > I suppose then we need to fix the cmake check? That would be one of the patches that would make some sense even if not coming from upstream i guess. Cheers, Albert > > Right now building the lot of our patch collection branches leads to > skrooge not being able to build because of that defect. That seems > silly at the best of times. > > HS >
Re: Qt5PatchCollection versions (broken QWE)
On Wed, May 26, 2021 at 7:39 PM Antonio Rojas wrote: > > El miércoles, 26 de mayo de 2021 13:19:34 (CEST), Harald Sitter escribió: > > Hola > > > > QWE and QtScript in our kde/5.15 branches currently have unaligned versions. > > > > QWE 5.15.4: > > https://invent.kde.org/qt/qt/qtwebengine/-/blob/kde/5.15/.qmake.conf > > > > QtBase 5.15.3: > > https://invent.kde.org/qt/qt/qtbase/-/blob/kde/5.15/.qmake.conf > > > > This then breaks version alignment expectations. For example QWECore > > requires QtWebChannel at the same version but since the versions are > > misaligned the requirement check changes. > > This is because the upstream QWE and QtScripts 5.15 branches are public, > unlike the other Qt repos. The versioning issue is discussed here: > > https://www.qt.io/blog/building-qt-webengine-against-other-qt-versions > > Lowering the version number would be misleading since this is the real, > upstream 5.15 code, which is post-5.15.4 already. I suppose then we need to fix the cmake check? Right now building the lot of our patch collection branches leads to skrooge not being able to build because of that defect. That seems silly at the best of times. HS
Re: Qt5PatchCollection versions (broken QWE)
El miércoles, 26 de mayo de 2021 13:19:34 (CEST), Harald Sitter escribió: Hola QWE and QtScript in our kde/5.15 branches currently have unaligned versions. QWE 5.15.4: https://invent.kde.org/qt/qt/qtwebengine/-/blob/kde/5.15/.qmake.conf QtBase 5.15.3: https://invent.kde.org/qt/qt/qtbase/-/blob/kde/5.15/.qmake.conf This then breaks version alignment expectations. For example QWECore requires QtWebChannel at the same version but since the versions are misaligned the requirement check changes. This is because the upstream QWE and QtScripts 5.15 branches are public, unlike the other Qt repos. The versioning issue is discussed here: https://www.qt.io/blog/building-qt-webengine-against-other-qt-versions Lowering the version number would be misleading since this is the real, upstream 5.15 code, which is post-5.15.4 already.
Re: Qt5PatchCollection versions (broken QWE)
On Wed, May 26, 2021 at 1:19 PM Harald Sitter wrote: > > Hola > > QWE and QtScript in our kde/5.15 branches currently have unaligned versions. > > QWE 5.15.4: > https://invent.kde.org/qt/qt/qtwebengine/-/blob/kde/5.15/.qmake.conf > > QtBase 5.15.3: > https://invent.kde.org/qt/qt/qtbase/-/blob/kde/5.15/.qmake.conf > > This then breaks version alignment expectations. For example QWECore > requires QtWebChannel at the same version but since the versions are > misaligned the requirement check changes. > > CMake Error at > /usr/lib/x86_64-linux-gnu/cmake/Qt5WebEngineCore/Qt5WebEngineCoreConfig.cmake:111 > (find_package): > Could not find a configuration file for package "Qt5WebChannel" that is > compatible with requested version "5.15.4". > The following configuration files were considered but not accepted: > /usr/lib/x86_64-linux-gnu/cmake/Qt5WebChannel/Qt5WebChannelConfig.cmake, > version: 5.15.3 > > I would think that we should simply align the versions at whatever > version seems appropriate. To that end I would propose that we lower > the versions of QWE and QtScript to .3. > > Thoughts? Should I start an MR? > > (Also, kinda unrelated but I couldn't find a good venue to discuss > things with all curators as gitlab issues are disabled for everything > but the backport tracker :-( similarly I'm not sure where one would > file a regression bug report if there were one - might need sorting > out TBH) > > HS Discussing here probably makes sense. Does this maybe mean that we started from the wrong commit? I'd say your recommendations are sound. +1 Aleix
Qt5PatchCollection versions (broken QWE)
Hola QWE and QtScript in our kde/5.15 branches currently have unaligned versions. QWE 5.15.4: https://invent.kde.org/qt/qt/qtwebengine/-/blob/kde/5.15/.qmake.conf QtBase 5.15.3: https://invent.kde.org/qt/qt/qtbase/-/blob/kde/5.15/.qmake.conf This then breaks version alignment expectations. For example QWECore requires QtWebChannel at the same version but since the versions are misaligned the requirement check changes. CMake Error at /usr/lib/x86_64-linux-gnu/cmake/Qt5WebEngineCore/Qt5WebEngineCoreConfig.cmake:111 (find_package): Could not find a configuration file for package "Qt5WebChannel" that is compatible with requested version "5.15.4". The following configuration files were considered but not accepted: /usr/lib/x86_64-linux-gnu/cmake/Qt5WebChannel/Qt5WebChannelConfig.cmake, version: 5.15.3 I would think that we should simply align the versions at whatever version seems appropriate. To that end I would propose that we lower the versions of QWE and QtScript to .3. Thoughts? Should I start an MR? (Also, kinda unrelated but I couldn't find a good venue to discuss things with all curators as gitlab issues are disabled for everything but the backport tracker :-( similarly I'm not sure where one would file a regression bug report if there were one - might need sorting out TBH) HS
